)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31357,"name":"LEDUC Florian","display_name":"Florian LEDUC","email":"florian.leduc@socgen.com","username":"leducflorian","status":"Société Générale"},"change_message_id":"9edf220b9ca663b9ca628586f5749d2f2afc703f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e0fceeec_691ff4bc","updated":"2021-12-13 19:24:55.000000000","message":"Loan Harrouin can you please fix the failing tests, please :)? ","commit_id":"9406179cfc49462cc95fb60636162cf0b79d0814"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b29d281240b91a27ca1e406eed65d4796d23aa6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fa9bd928_919c26e2","updated":"2023-05-16 10:18:48.000000000","message":"This looks to have stalled out, unfortunately","commit_id":"9406179cfc49462cc95fb60636162cf0b79d0814"}],"openstack/compute/v2/server.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1125e8d5d39265d8da2528618acb39fe74207e45","unresolved":false,"context_lines":[{"line_number":457,"context_line":"    def get_actions(self, session, limit\u003dNone, marker\u003dNone, changes_since\u003dNone,"},{"line_number":458,"context_line":"                    changes_before\u003dNone):"},{"line_number":459,"context_line":"        \"\"\"Get the lists of executed actions on a server.\"\"\""},{"line_number":460,"context_line":"        params \u003d {\u0027limit\u0027: limit, \u0027marker\u0027: marker,"},{"line_number":461,"context_line":"                  \u0027changes-since\u0027: changes_since,"},{"line_number":462,"context_line":"                  \u0027changes-before\u0027: changes_before}"},{"line_number":463,"context_line":"        url \u003d utils.urljoin(Server.base_path, self.id, \u0027os-instance-actions\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_a0734db4","line":460,"updated":"2019-08-08 13:57:09.000000000","message":"limit, chances-since and marker require microversion 2.58, let\u0027s try to ensure it","commit_id":"bb9d9c177db09bcf1f4244931d2bd63740bc0a8b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1125e8d5d39265d8da2528618acb39fe74207e45","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        \"\"\"Get the lists of executed actions on a server.\"\"\""},{"line_number":460,"context_line":"        params \u003d {\u0027limit\u0027: limit, \u0027marker\u0027: marker,"},{"line_number":461,"context_line":"                  \u0027changes-since\u0027: changes_since,"},{"line_number":462,"context_line":"                  \u0027changes-before\u0027: changes_before}"},{"line_number":463,"context_line":"        url \u003d utils.urljoin(Server.base_path, self.id, \u0027os-instance-actions\u0027)"},{"line_number":464,"context_line":"        return session.get(url, params\u003dparams).json()"},{"line_number":465,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_c078c990","line":462,"updated":"2019-08-08 13:57:09.000000000","message":"and this requires 2.66","commit_id":"bb9d9c177db09bcf1f4244931d2bd63740bc0a8b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1125e8d5d39265d8da2528618acb39fe74207e45","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        params \u003d {\u0027limit\u0027: limit, \u0027marker\u0027: marker,"},{"line_number":461,"context_line":"                  \u0027changes-since\u0027: changes_since,"},{"line_number":462,"context_line":"                  \u0027changes-before\u0027: changes_before}"},{"line_number":463,"context_line":"        url \u003d utils.urljoin(Server.base_path, self.id, \u0027os-instance-actions\u0027)"},{"line_number":464,"context_line":"        return session.get(url, params\u003dparams).json()"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def live_migrate(self, session, host, force, block_migration,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_606d55cb","line":463,"updated":"2019-08-08 13:57:09.000000000","message":"and the call itself requires 2.21. we should try to pick a suitable version based on the request.","commit_id":"bb9d9c177db09bcf1f4244931d2bd63740bc0a8b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"293cc64af012482c6091e7c910a0848483860d66","unresolved":false,"context_lines":[{"line_number":457,"context_line":"    def get_actions(self, session, limit\u003dNone, marker\u003dNone, changes_since\u003dNone,"},{"line_number":458,"context_line":"                    changes_before\u003dNone):"},{"line_number":459,"context_line":"        \"\"\"Get the lists of executed actions on a server.\"\"\""},{"line_number":460,"context_line":"        if utils.supports_microversion(session, \u00272.66\u0027):"},{"line_number":461,"context_line":"            params \u003d {\u0027limit\u0027: limit, \u0027marker\u0027: marker,"},{"line_number":462,"context_line":"                      \u0027changes-since\u0027: changes_since,"},{"line_number":463,"context_line":"                      \u0027changes-before\u0027: changes_before}"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_78d89f1d","line":460,"updated":"2019-08-09 08:57:26.000000000","message":"This would be the correct approach when you receive information from the server. But given that we have specific instructions from a caller, it has to be different. We cannot just silently ignore the limit argument if the version is not met. I suggest you take approach similar to this https://github.com/openstack/openstacksdk/blob/master/openstack/baremetal/v1/node.py#L334-L342","commit_id":"444d45cbab742ea28619a5ecef600b8d12791854"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"293cc64af012482c6091e7c910a0848483860d66","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            params \u003d None"},{"line_number":469,"context_line":"        else:"},{"line_number":470,"context_line":"            message \u003d (\"API version %s is required to get actions, but \""},{"line_number":471,"context_line":"                       \"it is not available.\") % 2.21"},{"line_number":472,"context_line":"            raise exceptions.NotSupported(message)"},{"line_number":473,"context_line":"        url \u003d utils.urljoin(Server.base_path, self.id, \u0027os-instance-actions\u0027)"},{"line_number":474,"context_line":"        return session.get(url, params\u003dparams).json()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_98d55be8","line":471,"updated":"2019-08-09 08:57:26.000000000","message":"You can embed 2.21 in the message, it\u0027s a constant.","commit_id":"444d45cbab742ea28619a5ecef600b8d12791854"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8a13aa5b002c98e3d7e7ede859d0eb42e5e0f488","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                       \"it is not available.\")"},{"line_number":482,"context_line":"            raise exceptions.NotSupported(message)"},{"line_number":483,"context_line":"        url \u003d utils.urljoin(Server.base_path, self.id, \u0027os-instance-actions\u0027)"},{"line_number":484,"context_line":"        return session.get(url, params\u003dparams).json()"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def live_migrate(self, session, host, force, block_migration,"},{"line_number":487,"context_line":"                     disk_over_commit\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_3b96aef1","line":484,"updated":"2020-03-31 15:08:12.000000000","message":"1) you need to actually pass the microversion you detected, otherwise the default will be used\n\n2) please use exceptions.raise_from_response to handle any errors","commit_id":"ec96ee2928472f4e06e4b70b0497bbc34dae597b"}]}