)]}'
{"openstack/cloud/openstackcloud.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"897e48800be51f9f39fdc747fdc2fddb4ee6525c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        cloud_config \u003d config.get_one(**params)"},{"line_number":230,"context_line":"        # Attach the discovery cache from the old session so we won\u0027t"},{"line_number":231,"context_line":"        # double discover."},{"line_number":232,"context_line":"        cloud_config._discovery_cache \u003d self.session._discovery_cache"},{"line_number":233,"context_line":"        # Override the cloud name so that logging/location work right"},{"line_number":234,"context_line":"        cloud_config._name \u003d self.name"},{"line_number":235,"context_line":"        cloud_config.config[\u0027profile\u0027] \u003d self.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_b83cd730","line":232,"updated":"2019-08-09 09:00:49.000000000","message":"So, is discovery_cache attached to cloud_config or a session?","commit_id":"4092be2612955f9ba6ab83fee43415b5fd780945"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"0a305078b12ab920228d30700042432483ab9049","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        cloud_config \u003d config.get_one(**params)"},{"line_number":230,"context_line":"        # Attach the discovery cache from the old session so we won\u0027t"},{"line_number":231,"context_line":"        # double discover."},{"line_number":232,"context_line":"        cloud_config._discovery_cache \u003d self.session._discovery_cache"},{"line_number":233,"context_line":"        # Override the cloud name so that logging/location work right"},{"line_number":234,"context_line":"        cloud_config._name \u003d self.name"},{"line_number":235,"context_line":"        cloud_config.config[\u0027profile\u0027] \u003d self.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_61f30675","line":232,"in_reply_to":"7faddb67_b83cd730","updated":"2019-08-09 11:46:30.000000000","message":"Yes!\n\nThere can be a discovery cache on the auth plugin, on the session, and there can be one passed directly to the discovery function. Any that exist are consulted, and results are saved to any that exist.\n\nThe thing is - we really want to be super aggressive with discovery cache, because it\u0027s completely unauthenticated data that isn\u0027t related to scope - so it doesn\u0027t change per user or project. So we make a discovery cache dict in CloudRegion and pass it to Session - so that we can make sure we have one.\n\nThere\u0027s two potential issues (one I just thought of writing this, so thanks!)\n\nFirst - we should probably make discovery_cache in loader.OpenStackConfig so that it\u0027s shared more globally - and so that it can naturally get passed to the new CloudRegion created from it.\n\nSecond - most of the service projects (nova, ironic) likely won\u0027t have a loader.OpenStackConfig, as they\u0027ll likely just be creating a CloudRegion directly - like if they used cloud_region.from_conf. In that case, in this method when we create a new CloudRegion, there\u0027s no where to pull it from except the old one - or from the old session, like we\u0027re doing here.\n\nSo for completeness we should probably get around to doing the First thinng... but the Second thing handles both cases from a connect_as perspective, and we need to do it for the second case anyway... so I\u0027m inclined to ignore the first one for now.\n\nThat said - I should rename these vars to cloud_region because it\u0027s otherwise somewhat confusing to remember what they are ...","commit_id":"4092be2612955f9ba6ab83fee43415b5fd780945"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6142155f0d937209b7e6b600235cf8fade41fb5a","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        # Override the cloud name so that logging/location work right"},{"line_number":234,"context_line":"        cloud_config._name \u003d self.name"},{"line_number":235,"context_line":"        cloud_config.config[\u0027profile\u0027] \u003d self.name"},{"line_number":236,"context_line":"        # Use self.__class__ so that we return whatever this if, like if it\u0027s"},{"line_number":237,"context_line":"        # a subclass in the case of shade wrapping sdk."},{"line_number":238,"context_line":"        return self.__class__(config\u003dcloud_config)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_19ab861e","line":236,"range":{"start_line":236,"start_character":61,"end_line":236,"end_character":63},"updated":"2019-08-12 21:11:16.000000000","message":"is","commit_id":"0ca426146d248934c1de0751f23f8bad5441e6a6"}],"openstack/tests/unit/base.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6142155f0d937209b7e6b600235cf8fade41fb5a","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                 urllib.parse.parse_qs(history_uri_parts.query)),"},{"line_number":696,"context_line":"                (\u0027REST mismatch on call %(index)d. Expected %(call)r. \u0027"},{"line_number":697,"context_line":"                 \u0027Got %(history)r). \u0027"},{"line_number":698,"context_line":"                 \u0027NOTE: query string order differences wont cause mismatch\u0027 %"},{"line_number":699,"context_line":"                 {"},{"line_number":700,"context_line":"                     \u0027index\u0027: x,"},{"line_number":701,"context_line":"                     \u0027call\u0027: \u0027{method} {url}\u0027.format(method\u003dcall[\u0027method\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_5947be78","line":698,"range":{"start_line":698,"start_character":55,"end_line":698,"end_character":59},"updated":"2019-08-12 21:11:16.000000000","message":"won\u0027t","commit_id":"0ca426146d248934c1de0751f23f8bad5441e6a6"}]}