)]}'
{"openstack/cloud/_compute.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"92563d7fc2854e449f9ea0d25bb973b34fc650ce","unresolved":false,"context_lines":[{"line_number":896,"context_line":"                else:"},{"line_number":897,"context_line":"                    raise exc.OpenStackCloudException("},{"line_number":898,"context_line":"                        \"The \u0027tag\u0027 attribute for the interface \""},{"line_number":899,"context_line":"                        \"supported in microversion 2.32-2.36 or \u003e\u003d 2.42\")"},{"line_number":900,"context_line":"            if nic:"},{"line_number":901,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":902,"context_line":"                    \"Additional unsupported keys given for server network\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_0502730c","line":899,"updated":"2019-08-08 13:54:25.000000000","message":"You shouldn\u0027t rely on default_microversion, but rather try to bump it. See baremetal node resource for some examples","commit_id":"be40ef4afb5f57d5fc59ea6af3380a87e278cea4"},{"author":{"_account_id":28094,"name":"Maxim Babushkin","email":"babushkin.max@gmail.com","username":"mbabushk"},"change_message_id":"ced35941f2ad03cc99771fb2053c4285fba68312","unresolved":false,"context_lines":[{"line_number":896,"context_line":"                else:"},{"line_number":897,"context_line":"                    raise exc.OpenStackCloudException("},{"line_number":898,"context_line":"                        \"The \u0027tag\u0027 attribute for the interface \""},{"line_number":899,"context_line":"                        \"supported in microversion 2.32-2.36 or \u003e\u003d 2.42\")"},{"line_number":900,"context_line":"            if nic:"},{"line_number":901,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":902,"context_line":"                    \"Additional unsupported keys given for server network\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_fd6f8b25","line":899,"in_reply_to":"7faddb67_0502730c","updated":"2019-08-11 09:31:59.000000000","message":"Could you give a more specific example, please?\n\nAs far as I understand, you mean that in case of \u0027tag\u0027 is used, I should pass specific microversion to the kwargs.\nAm I right?\n\nTo what version should I bump to?\nWhat happens if I need to pass a specific microversion?","commit_id":"be40ef4afb5f57d5fc59ea6af3380a87e278cea4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09ed6156a48a9979229bc6e28a30c8b5562f76ee","unresolved":false,"context_lines":[{"line_number":896,"context_line":"                else:"},{"line_number":897,"context_line":"                    raise exc.OpenStackCloudException("},{"line_number":898,"context_line":"                        \"The \u0027tag\u0027 attribute for the interface \""},{"line_number":899,"context_line":"                        \"supported in microversion 2.32-2.36 or \u003e\u003d 2.42\")"},{"line_number":900,"context_line":"            if nic:"},{"line_number":901,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":902,"context_line":"                    \"Additional unsupported keys given for server network\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_ee7eecad","line":899,"in_reply_to":"7faddb67_fd6f8b25","updated":"2019-08-12 09:03:47.000000000","message":"You can see a similar logic in https://github.com/openstack/openstacksdk/blob/master/openstack/baremetal/v1/node.py#L333-L342. Essentially, you shouldn\u0027t expect the caller to provide the correct microversion, it goes against the openstacksdk philosophy (which I cannot find a link to).","commit_id":"be40ef4afb5f57d5fc59ea6af3380a87e278cea4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ae5a14d77dffe64b69543e44d93e61777c08858e","unresolved":false,"context_lines":[{"line_number":890,"context_line":"            # A tag supported only in server microversion 2.32-2.36 or \u003e\u003d 2.42"},{"line_number":891,"context_line":"            # Bumping the version to 2.42 to support the \u0027tag\u0027 implementation"},{"line_number":892,"context_line":"            if \u0027tag\u0027 in nic:"},{"line_number":893,"context_line":"                microversion \u003d \u00272.42\u0027"},{"line_number":894,"context_line":"                net[\u0027tag\u0027] \u003d nic.pop(\u0027tag\u0027)"},{"line_number":895,"context_line":"            if nic:"},{"line_number":896,"context_line":"                raise exc.OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_2960e200","line":893,"updated":"2019-08-21 10:08:41.000000000","message":"nit:\n\n microversion \u003d utils.pick_microversions(self.compute, \u00272.42\u0027)\n\nwill be more user-friendly, since it will allow them to override it with a higher version.","commit_id":"545cce8f2f960d39551dcf8ff65ee59eafcc8d86"},{"author":{"_account_id":28094,"name":"Maxim Babushkin","email":"babushkin.max@gmail.com","username":"mbabushk"},"change_message_id":"c88132c748d0ce5165baa7b88c3de5a971002df7","unresolved":false,"context_lines":[{"line_number":890,"context_line":"            # A tag supported only in server microversion 2.32-2.36 or \u003e\u003d 2.42"},{"line_number":891,"context_line":"            # Bumping the version to 2.42 to support the \u0027tag\u0027 implementation"},{"line_number":892,"context_line":"            if \u0027tag\u0027 in nic:"},{"line_number":893,"context_line":"                microversion \u003d \u00272.42\u0027"},{"line_number":894,"context_line":"                net[\u0027tag\u0027] \u003d nic.pop(\u0027tag\u0027)"},{"line_number":895,"context_line":"            if nic:"},{"line_number":896,"context_line":"                raise exc.OpenStackCloudException("}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_4c79ac2c","line":893,"in_reply_to":"7faddb67_2960e200","updated":"2019-08-21 10:48:16.000000000","message":"Thanks for the suggestion.\nUpdated the patch.","commit_id":"545cce8f2f960d39551dcf8ff65ee59eafcc8d86"}]}