)]}'
{"id":"openstack%2Fopenstacksdk~676009","triplet_id":"openstack%2Fopenstacksdk~master~If65d7c23e07d9f232410a562e47f183d003a7dc0","project":"openstack/openstacksdk","branch":"master","topic":"DRY-test_connection","hashtags":[],"change_id":"If65d7c23e07d9f232410a562e47f183d003a7dc0","subject":"DRY test_connection","status":"MERGED","created":"2019-08-12 19:15:24.000000000","updated":"2019-08-13 14:08:51.000000000","submitted":"2019-08-13 14:08:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676009-1565705331423-c9b5ff1c","meta_rev_id":"31a70d20ad95e526f23312951dedb85bfc8950d9","_number":676009,"virtual_id_number":676009,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2019-08-13 14:08:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":2,"date":"2019-08-13 12:36:20.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-13 09:23:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":1,"date":"2019-08-13 12:36:20.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-13 09:23:12.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-08-13 12:36:20.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2019-08-13 14:08:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"20182c1be7ee673394f6b4ac58a8f09e4287a93b","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-12 19:15:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b18fdb7b72c3bd9e2ef6584fe8a1cc1b75aa7c60","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-12 20:46:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c124aae1302c4095b90ebc0efb87b293 : SUCCESS in 3m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ddeb123b40a543f9bc6d5f427f9ba8cc : SUCCESS in 3m 44s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b68e9a2e4c944974b48fbd131a56e6ad : SUCCESS in 3m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2884e6ff5ef74eb9bc63fe656379ef46 : SUCCESS in 3m 35s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2f6bf5992158473cbd6c035edc9cebc0 : SUCCESS in 3m 43s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/d8a573137fca40ef8f629a5d799793e9 : SUCCESS in 59m 44s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/799b2b6c106e45ee904df525a038867f : SUCCESS in 1h 08m 25s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/1af26c6ea5cc4957990fd927bf5f5c90 : SUCCESS in 5m 36s\n- os-client-config-tox-py27-tips https://zuul.opendev.org/t/openstack/build/f0d8cf2891ca467eb947c1be1bbe478b : SUCCESS in 3m 27s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/512b372689e2414280290c52af91c94f : SUCCESS in 5m 35s\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/4634dee8e9fc4daa94bb0e6c84d83114 : SUCCESS in 4m 19s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/b62909e4b6124e19b486ebd4d2852ae8 : SUCCESS in 4m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/49115e64d6004b279290aa8520d8824f : SUCCESS in 4m 02s\n- openstacksdk-ansible-devel-functional-devstack https://zuul.opendev.org/t/openstack/build/cea85f6a9b194f578749a57f3361cf76 : SUCCESS in 46m 33s (non-voting)\n- openstacksdk-ansible-stable-2.6-functional-devstack https://zuul.opendev.org/t/openstack/build/a8027cae794c4cf58060f369908b2d43 : SUCCESS in 43m 33s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ffdc45c23c0f4fcea4d11b1d9ffae484 : SUCCESS in 55m 38s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/44e215db3e0740558fe765f711b71592 : SUCCESS in 1h 19m 48s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/3bf3238cb266493aa485000d35c3544c : SUCCESS in 56m 23s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/8578c584f5bd4cb28482243cad6154c6 : FAILURE in 58m 50s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/008ae301edc54178b542d8e7821d154b : SUCCESS in 36m 05s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/cfb447c870fd4e33943c863d5b9238d7 : SUCCESS in 35m 41s (non-voting)\n- openstacksdk-functional-devstack-python2 https://zuul.opendev.org/t/openstack/build/ec24baf6c8fc4feebd0406de4b7f6b4c : SUCCESS in 58m 25s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/76440cb86b354fbda633f453a0ea0b6f : SUCCESS in 52m 02s (non-voting)\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/88bfc84f49094d34b9222f1356ee69c2 : SUCCESS in 54m 41s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/d47e29c3e27e4d16a9d6409021a2d73f : SUCCESS in 21m 31s\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/7ea2d2f1124345538a661a2b1994c6e9 : SUCCESS in 50m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8507bffc9aa9c722ee00152e8fa23c63c8ecea59","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-08-13 09:23:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"95fdaae7c1ee74972d8501852cf80c22db075843","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-08-13 12:36:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"093e6644f730e1bdb7dbeb66fb6b29bf24d9c698","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-13 12:36:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"75baad3c3504e2ee161735800248a1797d6f08b7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-13 14:08:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ec1fb6f77c243a305287188600752788ec90f6cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-13 14:08:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/158e6096bf7b4ccb8b9d1bd0b99bcd57 : SUCCESS in 3m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1a25a10d2f4441cfb6021b68a82a37f8 : SUCCESS in 3m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/87775100c11b45cb8f27b5ba72e7993c : SUCCESS in 4m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/58ae1467d8b04a7182f9b850695e4856 : SUCCESS in 3m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bd4fc05d0919418fa5bac55943f5bb35 : SUCCESS in 4m 08s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/e97e7fb4101d4fe1a418efd2a8e5b735 : SUCCESS in 57m 08s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/5435cf6b35854478a2ceb2d52d28004b : SUCCESS in 1h 03m 27s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/65eba3962c764651a3f3205bea381cf5 : SUCCESS in 4m 14s\n- os-client-config-tox-py27-tips https://zuul.opendev.org/t/openstack/build/ac20949aab3940338b3fb7fdbe968769 : SUCCESS in 3m 23s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/ab26ec67651d4c13b4703b60e25a72c2 : SUCCESS in 3m 38s\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/38d063fed8b9461c82fe3e31295474bd : SUCCESS in 3m 57s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/a5cf5bd78f9242aaaa0ca89ac402f48e : SUCCESS in 4m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ca2e8994031147f693b5af30b4db4fdd : SUCCESS in 3m 35s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/34c3d7c310db49e1a1d4ba8a3e44367e : SUCCESS in 59m 35s\n- openstacksdk-functional-devstack-python2 https://zuul.opendev.org/t/openstack/build/1ed848cb570348a383b08412b2fcfa13 : SUCCESS in 56m 41s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/674279532d544c9bbdd8f8ae17bdfd55 : SUCCESS in 1h 20m 49s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/cde87f973ff544048e108a1939af67d1 : SUCCESS in 57m 28s\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/7ddf71f02bca4bb68c2f181745b0bab0 : SUCCESS in 43m 21s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/e9e6f4c97c8c4a409d975f508a9b3c3c : SUCCESS in 19m 53s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ad0a52033ccb031db5a90c127af8aa3e5046bbc6","revisions":{"ad0a52033ccb031db5a90c127af8aa3e5046bbc6":{"kind":"REWORK","_number":1,"created":"2019-08-12 19:15:24.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/09/676009/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/09/676009/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/09/676009/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/09/676009/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/09/676009/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/09/676009/1"}}},"commit":{"parents":[{"commit":"8a81f8dd7b1f3c203e2b79749f90a1a608837822","subject":"Merge \"Retry large object manifest upload\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/8a81f8dd7b1f3c203e2b79749f90a1a608837822"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-12 19:13:13.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-12 19:13:13.000000000","tz":-300},"subject":"DRY test_connection","message":"DRY test_connection\n\nAn earlier change [1] wastefully subclassed TestConnection when all it\nneeded was the setUp(). The subclass was redundantly running all the\nsuperclass\u0027s tests again.\n\nThis commit factors out the setUp into a local base class and subclasses\nthat base class from TestConnection and TestOsloConfig, cutting out 14\nredundant tests.\n\n[1] I3d16d17caa2e8a58b7064c54e930468288aa6ff1\n\nChange-Id: If65d7c23e07d9f232410a562e47f183d003a7dc0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/ad0a52033ccb031db5a90c127af8aa3e5046bbc6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/ad0a52033ccb031db5a90c127af8aa3e5046bbc6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}