)]}'
{"id":"openstack%2Fopenstacksdk~676015","triplet_id":"openstack%2Fopenstacksdk~master~Ie5067a331b6f52d3e0480433c02199e2dd923ae6","project":"openstack/openstacksdk","branch":"master","topic":"cleanup-_make_proxy","hashtags":[],"change_id":"Ie5067a331b6f52d3e0480433c02199e2dd923ae6","subject":"Minor refactor cleanup of _make_proxy","status":"MERGED","created":"2019-08-12 20:12:11.000000000","updated":"2019-08-13 22:50:29.000000000","submitted":"2019-08-13 22:50:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676015-1565736629485-28760403","meta_rev_id":"4e26fab2f1d3dc0d5a675d997359ce9a61d50063","_number":676015,"virtual_id_number":676015,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":2,"date":"2019-08-13 22:50:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":2,"date":"2019-08-13 12:17:32.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2019-08-13 22:34:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"value":2,"date":"2019-08-13 14:59:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":1,"date":"2019-08-13 21:04:32.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-13 14:59:26.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2019-08-13 21:04:32.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2019-08-13 22:34:27.000000000","updated_by":{"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},"reviewer":{"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},"state":"REVIEWER"},{"updated":"2019-08-13 22:50:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e973f97d63d335e8a47fc607df4e760b9fbe1ce3","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-12 20:12:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"62bfb26a3b9624644d049e9f109d6f12857629f9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-12 21:44:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d1edd22e9c7240a6b3c989671b03971f : SUCCESS in 5m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/56d8cc42f44343fc83c805fe39e31d66 : SUCCESS in 3m 47s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f5d95a926218439fb2150ff54f9a2765 : SUCCESS in 3m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0cd1a99f09aa4494953c06440b5b2732 : SUCCESS in 3m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/db78bc98f16f427e9298a3ff078494a4 : SUCCESS in 4m 41s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/69592ebf161e4ecd8a8c01911b442d0a : SUCCESS in 1h 00m 50s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/de22f43a71614540a6868d74d30946b9 : SUCCESS in 1h 02m 55s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/e21db039a1254db18614a28704f5deb2 : SUCCESS in 4m 29s\n- os-client-config-tox-py27-tips https://zuul.opendev.org/t/openstack/build/6e95bf2be39b4c6bb78c9c3755269105 : SUCCESS in 4m 04s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/edeabb42fab64db4b3d5532549a561b7 : SUCCESS in 3m 31s\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/79fb0ec06a4e44b7aee69b217cd6110d : SUCCESS in 4m 26s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/a88d81968a394ccea79c90bdb6d13bbb : SUCCESS in 4m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2179c3e664884176a66060b582f99d96 : SUCCESS in 3m 50s\n- openstacksdk-ansible-devel-functional-devstack https://zuul.opendev.org/t/openstack/build/cc8b56d44daf46ff90cda5da7fcc02a4 : SUCCESS in 45m 01s (non-voting)\n- openstacksdk-ansible-stable-2.6-functional-devstack https://zuul.opendev.org/t/openstack/build/07cbadb8f111420a97f6ea0204358681 : SUCCESS in 44m 17s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c2eda41ed6cc4c4ca6f4a4755a609b93 : SUCCESS in 1h 00m 14s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/dc4ac6090fb24b3daa0db791cbf42192 : SUCCESS in 1h 21m 49s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/ae92d742f2724cd88d6cb3dc16048446 : SUCCESS in 54m 14s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/83d587ad3f3240669b7677e31eb582f7 : FAILURE in 55m 32s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/3c42efe51d1946a59ad7989776c80f02 : SUCCESS in 35m 37s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/ad723ffcb26b4c53876acba27e478226 : SUCCESS in 37m 20s (non-voting)\n- openstacksdk-functional-devstack-python2 https://zuul.opendev.org/t/openstack/build/5c2a7ffa4b274961b852ba4448f280f8 : SUCCESS in 1h 07m 44s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/eb515784969a4b4e83e28e1097cbc9c7 : SUCCESS in 1h 05m 32s (non-voting)\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/6097f432b510460bb22261feff159876 : SUCCESS in 51m 58s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/b7b00a5735a649bf8043ce41747a1f41 : SUCCESS in 21m 03s\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/f0ae7b4d5cc5484e9d387ea009b37743 : SUCCESS in 50m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c14959ba6741b2c4ccf19d2d2246327a43967959","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-08-13 12:17:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"084ce1deeb23790d135c7e4c585e099950ee87ae","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2019-08-13 14:59:26.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"65182b1256bd56e2c895e0857f90e9734ff1d7e5","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-08-13 21:04:32.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"bf8b2618277d286fe81497aaceab44fca4eb194f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-13 21:04:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5522e6c0bb78dc89f673acbe88eeee990f896e22","author":{"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},"date":"2019-08-13 22:34:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"89698e07e3c3e324037c48d9fa41581af1429c56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-13 22:50:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/20ae78d3a0ca498593d51b929cda177f : SUCCESS in 4m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f3e4579f97014f1392c121c150a1c914 : SUCCESS in 3m 09s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/aea92daa1bef4583b4bf93110a7a22ca : SUCCESS in 2m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/23779cff0253405f88fb61a402bb55f6 : SUCCESS in 2m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/14168afe1a124ba49895e7f45ff00b95 : SUCCESS in 3m 50s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/5f0a6011b5634e93956f31330a582db6 : SUCCESS in 56m 42s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/3a6b390c986049129d46f6172d3542e9 : SUCCESS in 1h 18m 04s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/2c1e39a6179e4e05afe519ca260f66e2 : SUCCESS in 3m 45s\n- os-client-config-tox-py27-tips https://zuul.opendev.org/t/openstack/build/a0cc79f0b4024629b2fb2a6eee56c28c : SUCCESS in 2m 48s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/e077dee0475f418ea7cd4e4f3e756692 : SUCCESS in 3m 19s\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/117e36465c454aea8d8c0c69ab7b7071 : SUCCESS in 6m 14s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/18d3c1352ed54434abe265954475b4d9 : SUCCESS in 6m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7e43bfd08a46415f8dc1b42c273358bb : SUCCESS in 3m 42s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c76ecfb1730943b1bca9f29361919b70 : SUCCESS in 1h 06m 12s\n- openstacksdk-functional-devstack-python2 https://zuul.opendev.org/t/openstack/build/b32580bc86574a11a43c1fbb927003df : SUCCESS in 1h 04m 46s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/3d1b832058cc4390accb0f0bfa60d843 : SUCCESS in 1h 40m 07s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/ee257f1f4d7a440ca277b9ee537310b4 : SUCCESS in 55m 07s\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/c102131451a2402493696d0958db0e31 : SUCCESS in 28m 49s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/d9cef17a82e8431bb3258b4db6c32fa8 : SUCCESS in 19m 00s","accounts_in_message":[],"_revision_number":1},{"id":"3212932154bfc3c7b1261148c53b80ac18599f32","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-13 22:50:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b30132030bf3fd403ded77d42f78c85711a1f944","revisions":{"b30132030bf3fd403ded77d42f78c85711a1f944":{"kind":"REWORK","_number":1,"created":"2019-08-12 20:12:11.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/15/676015/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/15/676015/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/15/676015/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/15/676015/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/15/676015/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/15/676015/1"}}},"commit":{"parents":[{"commit":"8a81f8dd7b1f3c203e2b79749f90a1a608837822","subject":"Merge \"Retry large object manifest upload\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/8a81f8dd7b1f3c203e2b79749f90a1a608837822"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-12 20:11:12.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-12 20:11:12.000000000","tz":-300},"subject":"Minor refactor cleanup of _make_proxy","message":"Minor refactor cleanup of _make_proxy\n\nNoticed we were doing a redundant lookup and conditional. Straight\nrefactor for readability, no functional change.\n\nChange-Id: Ie5067a331b6f52d3e0480433c02199e2dd923ae6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/b30132030bf3fd403ded77d42f78c85711a1f944"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/b30132030bf3fd403ded77d42f78c85711a1f944"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}