)]}'
{"openstack/tests/functional/base.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"72bf232d494e36ebed65d8ff9f031fcaebb387ba","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        :returns: True if the service exists, otherwise False."},{"line_number":127,"context_line":"        \"\"\""},{"line_number":128,"context_line":"        if not self.conn.has_service(service_type):"},{"line_number":129,"context_line":"            self.skipTest(\u0027Service {service_type} not found in cloud\u0027.format("},{"line_number":130,"context_line":"                service_type\u003dservice_type))"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a60ee92f","line":128,"updated":"2019-10-04 15:01:55.000000000","message":"hm.\n\nhas_service runs get_endpoint, which winds up running a lot of the same code as get_endpoint_data (L135).\n\nSo based on this change, the \"good path\" now picks up that extra call, which seems inefficient.\n\nAre we doing this just to resolve the TODO, or are we solving an actual problem?\n\n[Later] Oh, I just picked up on the fact that this is test only. I\u0027m going to stop making a big deal out of it.","commit_id":"5e927dce69b1db750bc346c366fd31c97e1e6fbf"}]}