)]}'
{"openstack/cloud/meta.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3e2cd95f1fb0b13bc833f487fa70fb3088b42235","unresolved":false,"context_lines":[{"line_number":474,"context_line":"    server[\u0027security_groups\u0027] \u003d groups or []"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"def get_hostvars_from_server(cloud, server, mounts\u003dNone):"},{"line_number":478,"context_line":"    \"\"\"Expand additional server information useful for ansible inventory."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    Variables in this function may make additional cloud queries to flesh out"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_c6ca05a0","line":477,"updated":"2019-10-04 15:57:01.000000000","message":"it (still) bugs me that this is in meta rather than a compute-specific module.","commit_id":"cd6c3f2c9e1d022021e43258d5794838c104a25b"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ed917e6c2521c033a96b589e5cf1d53c7a629e7e","unresolved":false,"context_lines":[{"line_number":474,"context_line":"    server[\u0027security_groups\u0027] \u003d groups or []"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"def get_hostvars_from_server(cloud, server, mounts\u003dNone):"},{"line_number":478,"context_line":"    \"\"\"Expand additional server information useful for ansible inventory."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    Variables in this function may make additional cloud queries to flesh out"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_ac7b2bf2","line":477,"in_reply_to":"3fa7e38b_c6ca05a0","updated":"2019-10-04 16:11:54.000000000","message":"Yes, you are absolutely right.","commit_id":"cd6c3f2c9e1d022021e43258d5794838c104a25b"}],"openstack/tests/functional/cloud/test_inventory.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3e2cd95f1fb0b13bc833f487fa70fb3088b42235","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _test_host_content(self, host):"},{"line_number":50,"context_line":"        self.assertEqual(host[\u0027image\u0027][\u0027id\u0027], self.image.id)"},{"line_number":51,"context_line":"        self.assertNotIn(\u0027links\u0027, host[\u0027image\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(host[\u0027flavor\u0027][\u0027id\u0027], self.flavor.id)"},{"line_number":53,"context_line":"        self.assertNotIn(\u0027links\u0027, host[\u0027flavor\u0027])"},{"line_number":54,"context_line":"        self.assertNotIn(\u0027links\u0027, host)"},{"line_number":55,"context_line":"        self.assertIsInstance(host[\u0027volumes\u0027], list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_6c37734f","side":"PARENT","line":52,"updated":"2019-10-04 15:57:01.000000000","message":"If we were actually testing the fix, would we maybe want to add something like\n\n # The server\u0027s flavor is a \"cached\" one, so it doesn\u0027t have an \u0027id\u0027\n self.assertNotIn(\u0027id\u0027, host[\u0027flavor\u0027])\n\nhere and below?","commit_id":"5e927dce69b1db750bc346c366fd31c97e1e6fbf"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ed917e6c2521c033a96b589e5cf1d53c7a629e7e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _test_host_content(self, host):"},{"line_number":50,"context_line":"        self.assertEqual(host[\u0027image\u0027][\u0027id\u0027], self.image.id)"},{"line_number":51,"context_line":"        self.assertNotIn(\u0027links\u0027, host[\u0027image\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(host[\u0027flavor\u0027][\u0027id\u0027], self.flavor.id)"},{"line_number":53,"context_line":"        self.assertNotIn(\u0027links\u0027, host[\u0027flavor\u0027])"},{"line_number":54,"context_line":"        self.assertNotIn(\u0027links\u0027, host)"},{"line_number":55,"context_line":"        self.assertIsInstance(host[\u0027volumes\u0027], list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_6c8533cf","side":"PARENT","line":52,"in_reply_to":"3fa7e38b_6c37734f","updated":"2019-10-04 16:11:54.000000000","message":"Yes, I agree.","commit_id":"5e927dce69b1db750bc346c366fd31c97e1e6fbf"}],"releasenotes/notes/fix-for-microversion-70cd686b6d6e3fd0.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3e2cd95f1fb0b13bc833f487fa70fb3088b42235","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    this increase never actually became effective. A fix is coming in `3.17.1` of"},{"line_number":7,"context_line":"    `keystoneauth` which will unbreak version discovery and cause the microversion"},{"line_number":8,"context_line":"    support to start working, which means previous SDK code that assumed the"},{"line_number":9,"context_line":"    existence of a flavor.id field in the Server record no longer works."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_86496d33","line":9,"updated":"2019-10-04 15:57:01.000000000","message":"...and we\u0027ve fixed it now.","commit_id":"cd6c3f2c9e1d022021e43258d5794838c104a25b"}]}
