)]}'
{"openstack/connection.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2a2f08aa31149f58a5bd180c000e001709fd8a2e","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            # Hide a reference to the connection on the session to help with"},{"line_number":434,"context_line":"            # backwards compatibility for folks trying to just pass"},{"line_number":435,"context_line":"            # conn.session to a Resource method\u0027s session argument."},{"line_number":436,"context_line":"            self.session._sdk_connection \u003d weakref.proxy(self)"},{"line_number":437,"context_line":"        return self._session"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def add_service(self, service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_dba6a954","line":436,"updated":"2019-11-25 15:50:16.000000000","message":"this one is a clear win","commit_id":"757f78c1538c9e462dee89aafcefd7ecb0c6a7a5"}],"openstack/service_description.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2a2f08aa31149f58a5bd180c000e001709fd8a2e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                endpoint \u003d proxy_mod.Proxy.get_endpoint(proxy)"},{"line_number":94,"context_line":"                if instance._strict_proxies:"},{"line_number":95,"context_line":"                    self._validate_proxy(proxy, endpoint)"},{"line_number":96,"context_line":"                proxy._connection \u003d weakref.proxy(instance)"},{"line_number":97,"context_line":"            instance._proxies[self.service_type] \u003d proxy"},{"line_number":98,"context_line":"        return instance._proxies[self.service_type]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a6a394b0","line":96,"updated":"2019-11-25 15:50:16.000000000","message":"This one I\u0027m not so sure about. Why would it be okay to gc a Connection while ProxyZ are still around expecting to use it? Is it because we\u0027re counting on always accessing the Proxy through a Connection, so we can rely on the Connection not being cleaned up?\n\nI\u0027m not sure we can do that. For example, in nova\u0027s usage, we pull out the Proxy and throw away the Connection [1]. So IIUC this part of the change could get us in trouble there.\n\nI\u0027m going to try running a couple of nova tempest jobs against this. (Unfortunately, it only confirms my suspicions if they *do* break; if they don\u0027t, it still doesn\u0027t necessarily mean this is okay.)\n\n[1] https://opendev.org/openstack/nova/src/branch/master/nova/utils.py#L1038","commit_id":"757f78c1538c9e462dee89aafcefd7ecb0c6a7a5"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"1ccad1a7b00aaadb2860db45338d7b750a773f2b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                endpoint \u003d proxy_mod.Proxy.get_endpoint(proxy)"},{"line_number":94,"context_line":"                if instance._strict_proxies:"},{"line_number":95,"context_line":"                    self._validate_proxy(proxy, endpoint)"},{"line_number":96,"context_line":"                proxy._connection \u003d weakref.proxy(instance)"},{"line_number":97,"context_line":"            instance._proxies[self.service_type] \u003d proxy"},{"line_number":98,"context_line":"        return instance._proxies[self.service_type]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_fed6e852","line":96,"in_reply_to":"3fa7e38b_a6a394b0","updated":"2019-11-26 05:51:02.000000000","message":"I think it\u0027s fine to drop this change, at least for the Senlin fix. After a few hours of testing the memory is still stable with only the connection change.","commit_id":"757f78c1538c9e462dee89aafcefd7ecb0c6a7a5"}]}