)]}'
{"id":"openstack%2Fopenstacksdk~701729","triplet_id":"openstack%2Fopenstacksdk~master~I9488135957934da0f3fc7a57b36ec58c269665bf","project":"openstack/openstacksdk","branch":"master","hashtags":[],"change_id":"I9488135957934da0f3fc7a57b36ec58c269665bf","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2020-01-09 13:50:44.000000000","updated":"2020-01-09 18:01:33.000000000","submitted":"2020-01-09 17:58:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"701729-1578592717944-af565c7f","meta_rev_id":"fab7141712686002d18f6fbde0fea26d0b30fb8f","_number":701729,"virtual_id_number":701729,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-09 17:58:37.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-01-09 13:59:48.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-01-09 16:44:12.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-09 16:44:12.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2020-01-09 17:58:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b8bca336ad3944059562a4f5f44149d93a1e5114","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-01-09 13:50:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff6e47c5829e49a80f8ee5ff5da145924be4a217","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-01-09 13:59:48.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)\n\nEasy win.","accounts_in_message":[],"_revision_number":1},{"id":"b4df72398582bb4cc11eb2e0b81c3bc94da4b0bd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 15:59:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/845d3d2a0a654997b066bd10d70a4bf3 : SUCCESS in 4m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1c3ee619b7c549a8a8f4f05f9e76451e : SUCCESS in 3m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bc4cb099c83a4ba4b5c845c3fc2330d7 : SUCCESS in 6m 12s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/167eaba85c9c407f9f8b5a72633a6841 : SUCCESS in 5m 31s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/e967ecd89f4740789fccefb97b254938 : SUCCESS in 1h 07m 01s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/9c47aea7035c499787cc4d9c4f77197a : SUCCESS in 4m 59s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/4f4e745969334cefb71e2251fa7fd9a9 : SUCCESS in 6m 15s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/622eba66b86c4415b35990ecef5d7165 : SUCCESS in 4m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2b4994800a704e7488b486c210eff34c : SUCCESS in 10m 59s\n- openstacksdk-ansible-devel-functional-devstack https://zuul.opendev.org/t/openstack/build/a31b04421f3845259cee54617de31433 : SUCCESS in 38m 43s (non-voting)\n- openstacksdk-ansible-stable-2.8-functional-devstack https://zuul.opendev.org/t/openstack/build/ad73433cae134a9791eb5c6b0299de83 : SUCCESS in 43m 44s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/bea80957277749b7afd108c8fce94f97 : SUCCESS in 1h 19m 47s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/1cedd2148d124366b38e88ae4724057c : SUCCESS in 2h 05m 04s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/dca85d048a6542b985716df179ed14f9 : SUCCESS in 1h 21m 41s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/0d6637aeee614ebdabe40117afe80019 : FAILURE in 1h 36m 42s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/205e50858b634154a4df5dc160f24f54 : SUCCESS in 41m 16s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/b738e4af9f644d1c877df3c41b6f15f7 : SUCCESS in 51m 54s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/236d26714b7446ca9e99626356eb8388 : SUCCESS in 1h 36m 31s (non-voting)\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/f886b4f6bfb34c98bcf85321a577be89 : SUCCESS in 55m 32s\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/b809ebc9af094c54809c6d61d405ea00 : SUCCESS in 1h 35m 49s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/0cd75ecb40d04f8daea7f666a8778912 : FAILURE in 13m 47s (non-voting)\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/3928f642dd0b49f1b505b3153a7b237b : SUCCESS in 1h 35m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b755a308abdfd20addd29130c695dc0a313d525e","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-01-09 16:44:12.000000000","message":"Patch Set 1: Workflow+1\n\nI think this is trivial enough to fast approve.","accounts_in_message":[],"_revision_number":1},{"id":"db155b2432d2fff4165af48fc2c1e5707ce056ae","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 16:44:24.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9c5f606d7cece4d0ed7dbdb6083dd59609ca753b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 17:58:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"72fafdb50d062e6cd8b2af88dc039019896ed7a6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 17:58:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7d513dc0375548628813eae98070000f : SUCCESS in 8m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c249e93b01544148b79468c3bd562b64 : SUCCESS in 5m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9288d6cfc5414e90afce559c5086f1f6 : SUCCESS in 5m 08s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/43c5b14d82cc42c6ad4c86c81505f9b5 : SUCCESS in 4m 12s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/ed54f619f57c4222b64cc334e0ec02ce : SUCCESS in 56m 39s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/b53fc3cd96d5445883ed91eb5f8ca6e5 : SUCCESS in 5m 45s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/fd0a7f2dea094b529b1522ff193dc6d0 : SUCCESS in 5m 07s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/3c66a1aa71ca413a82b0ca2e35b51e5b : SUCCESS in 5m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/891ace115dcd4e38a10c8fda0df195f0 : SUCCESS in 9m 21s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3bd3cc39ede144eba1b321c9e1eaf6ef : SUCCESS in 56m 05s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/75e9aa1277f348baaba68e6737919623 : SUCCESS in 1h 12m 13s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/36d509daa9224dfa8656367879ba4962 : SUCCESS in 56m 18s\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/79ddb5fb5c4b4ae69c1e7f847fc34857 : SUCCESS in 34m 15s","accounts_in_message":[],"_revision_number":1},{"id":"fab7141712686002d18f6fbde0fea26d0b30fb8f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-09 18:01:33.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7582f62c3f904d3e9f555b039f3b1bfb : SUCCESS in 2m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4d0d078e5e613a745f700867b8a08bf56eba28df","revisions":{"4d0d078e5e613a745f700867b8a08bf56eba28df":{"kind":"REWORK","_number":1,"created":"2020-01-09 13:50:44.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/29/701729/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/29/701729/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/29/701729/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/29/701729/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/29/701729/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/29/701729/1"}}},"commit":{"parents":[{"commit":"fcef46e5d3d14d8247bf30ee498156b03c83eee2","subject":"Merge \"Fix bug in object storage container creation setting metadata\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/fcef46e5d3d14d8247bf30ee498156b03c83eee2"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2020-01-09 13:50:09.000000000","tz":-360},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2020-01-09 13:50:09.000000000","tz":-360},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1. As mentioned in [1], we should avoid using six.iteritems to achieve\n   iterators. We can use dict.items instead, as it will return iterators\n   in PY3 as well. And dict.items/keys will more readable.\n\n2. In py2, the performance about list should be negligible,\n   see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I9488135957934da0f3fc7a57b36ec58c269665bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/4d0d078e5e613a745f700867b8a08bf56eba28df"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/4d0d078e5e613a745f700867b8a08bf56eba28df"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}