)]}'
{"id":"openstack%2Fopenstacksdk~705073","triplet_id":"openstack%2Fopenstacksdk~master~Ia2f469690023e1d7e1c1e7935d6681a87f9433cd","project":"openstack/openstacksdk","branch":"master","topic":"fix-trunk-error-handling","hashtags":[],"change_id":"Ia2f469690023e1d7e1c1e7935d6681a87f9433cd","subject":"Fix error handling in network trunks operations","status":"MERGED","created":"2020-01-30 17:38:19.000000000","updated":"2020-03-03 13:10:42.000000000","submitted":"2020-02-05 18:08:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"705073-1580926120856-5f1f21a0","meta_rev_id":"6480a8f3d3ca850f613c18d1c6048e7a6ea81e69","_number":705073,"virtual_id_number":705073,"owner":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},{"value":0,"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-05 18:08:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"recommended":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"all":[{"value":1,"date":"2020-01-31 09:16:55.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":2,"date":"2020-02-05 16:28:37.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2020-01-31 08:52:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":1,"date":"2020-02-02 18:31:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},{"value":1,"date":"2020-01-31 08:47:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":1,"date":"2020-02-05 16:28:37.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},{"value":0,"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},{"value":0,"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-31 08:47:45.000000000","updated_by":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"reviewer":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"state":"REVIEWER"},{"updated":"2020-01-31 08:52:51.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"state":"REVIEWER"},{"updated":"2020-01-31 09:16:55.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2020-02-02 18:31:59.000000000","updated_by":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"reviewer":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"state":"REVIEWER"},{"updated":"2020-02-05 16:28:37.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-02-05 18:08:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"122f1ca73913e62eac3ffa09b2993d173a8ad3ff","author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"date":"2020-01-30 17:38:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e76a9e478fc0f599a863c745df5a36df76268995","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-30 19:00:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fcf931a0dd4e46b6a2a9130596aaef75 : SUCCESS in 5m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/02772dad59f94f5890daf83bc1a79d43 : SUCCESS in 7m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b2be1b31b5f045d89db2a2d2a42b6394 : SUCCESS in 6m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a6f8740af4be46419e56ee6b33761faa : SUCCESS in 5m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/28fce62bf52646ce99aac8aa33fca84c : SUCCESS in 4m 36s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/f530cb0e4f27455699daacca0e38fa40 : SUCCESS in 1h 00m 41s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/069b1dfe144d4e709a4da966e4f315c4 : SUCCESS in 5m 37s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/acd5813fdd8a4822858ea4f8516fed2f : SUCCESS in 6m 20s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/37476d438b3f4b9288db66868d0258b6 : SUCCESS in 4m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ee41c0fbac543459ac9079f0cc9e202 : SUCCESS in 8m 42s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/37112ff0fadb40d49684319ecbb32cbf : SUCCESS in 1h 00m 43s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/206687bdd1684f5f9d52f2b535ff5fe5 : SUCCESS in 1h 10m 21s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/01e7d4ed7cd64e22b8015a9380e51701 : SUCCESS in 51m 30s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/916c8d88dd694eca97139ad70a8a3816 : FAILURE in 59m 46s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/1eb89b4a9ac14badb122f0e0705a4889 : SUCCESS in 35m 08s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/2ff8b9a96c5a4e319c989533b425f4e6 : SUCCESS in 35m 59s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/2bc0035acabc41f5a9a59ee0c989aa6a : FAILURE in 51m 53s (non-voting)\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/07358d30f871497e947ad4a028cca1e2 : SUCCESS in 34m 44s\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/fb44fefe4ad64cb8b21ee84def91e1bc : SUCCESS in 1h 09m 25s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6e968505da754459b4d68c22aac61a00 : SUCCESS in 18m 52s (non-voting)\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/d6601def155f4e45b060b295c474f154 : SUCCESS in 1h 15m 34s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/640724ecd7ac4e6299e311f3d681cd61 : SUCCESS in 1h 00m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3456858f90aec6a103231385e10c7552783ce5e5","author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"date":"2020-01-31 08:47:45.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6d1ad473786fdd07245f82d27c0a7bdbb7ae9cde","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2020-01-31 08:52:51.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"36e8ff2cdae1d9af511807a80f43263d34c94d98","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-01-31 09:16:55.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ab2c1af280f4abd5310e7ff5abb7d205436330fc","author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"date":"2020-02-02 18:31:59.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2699f6e809a3ababdb78934af5e91152a65715de","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-02-05 16:28:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c511629350d3357cd44c911d254925c039e21df1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-05 16:28:51.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2abaded5d83e6dc5dd7ffbe220ce80dd9b4a9883","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-05 18:08:40.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b5e38a1df72c4a24a14588fb220f8796 : SUCCESS in 5m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a4478ea6609e441bb878420be33cf55f : SUCCESS in 5m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/037771c29b2948a2a199c0172bcb2cf2 : SUCCESS in 3m 59s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/350f033cd52d49a8b8af0bbcd671d416 : SUCCESS in 5m 17s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/cb5d8d0f6ae444bb9b8485e6d9a9cf5a : SUCCESS in 1h 11m 06s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/f1e75c1d57424cc7b86a5861e62c003f : SUCCESS in 5m 39s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/9bb99382a46c4ab78b47e18b49874a55 : SUCCESS in 5m 24s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/1d2cd532044741dfa2f11662d434bf39 : SUCCESS in 6m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0c04e419393a47e0a3a198b015fdc161 : SUCCESS in 7m 23s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0938974f59e749beb1b130cd5e4bb8aa : SUCCESS in 57m 11s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/e65ade224ea44f03a16c7ccccf7a7f38 : SUCCESS in 1h 36m 18s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/aa5574ef084940e7b0d14f888d804942 : SUCCESS in 59m 58s\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/b7b571e2321545c3b7bec26188eef51c : SUCCESS in 33m 43s","accounts_in_message":[],"_revision_number":1},{"id":"ba552962cce2617f15d8303a595eb40863d3a2ed","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-05 18:08:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"d2e526b095335ad44025c858920a4afaf3011a6c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-05 18:10:47.000000000","message":"Patch Set 1:\n\nBuild failed (promote pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3cc2c478fe3345b39b57ddc1b314e482 : FAILURE in 1m 24s","accounts_in_message":[],"_revision_number":1},{"id":"f12c893de6de3c1ba9dbd1e2955e5de791f8ffc4","author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"date":"2020-03-03 13:10:42.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit a16e508489ca8e83db0fc5d68496e6eb499d65c0","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9b7e02bebcb27cb916d6b46eed48a8e1edeadea8","revisions":{"9b7e02bebcb27cb916d6b46eed48a8e1edeadea8":{"kind":"REWORK","_number":1,"created":"2020-01-30 17:38:19.000000000","uploader":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"ref":"refs/changes/73/705073/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/73/705073/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/73/705073/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/73/705073/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/73/705073/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/73/705073/1"}}},"commit":{"parents":[{"commit":"7c19b166de345b4c7413282dfbb56cc07526fc64","subject":"Merge \"Fail a job for ansible modules with message\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/7c19b166de345b4c7413282dfbb56cc07526fc64"}]}],"author":{"name":"Michał Dulko","email":"mdulko@redhat.com","date":"2020-01-30 17:26:16.000000000","tz":60},"committer":{"name":"Michał Dulko","email":"mdulko@redhat.com","date":"2020-01-30 17:26:16.000000000","tz":60},"subject":"Fix error handling in network trunks operations","message":"Fix error handling in network trunks operations\n\nIt seems like operations defined in network.v2.trunk had no error\nhandling or even ignored results from Neutron altogether. This meant\nthat user was not able to say if his requests were successful or not.\n\nThis commit fixes the issues by adding error handling through\nexceptions.raise_from_response and making sure that Trunk\u0027s body is\nupdated with the actual result from Neutron instead of the info passed\nfrom user (seems like delete_subports() even updated the Trunk object\nactually *adding* the removed subports).\n\nChange-Id: Ia2f469690023e1d7e1c1e7935d6681a87f9433cd\nStory: #2007239\nTask: #38579\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/9b7e02bebcb27cb916d6b46eed48a8e1edeadea8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/9b7e02bebcb27cb916d6b46eed48a8e1edeadea8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}