)]}'
{"id":"openstack%2Fopenstacksdk~708111","triplet_id":"openstack%2Fopenstacksdk~master~If3ed7211763044af88a3b6bf16d8c1c70b61664f","project":"openstack/openstacksdk","branch":"master","topic":"bulk-resource","hashtags":[],"change_id":"If3ed7211763044af88a3b6bf16d8c1c70b61664f","subject":"Make _get_microversion_for a class method.","status":"ABANDONED","created":"2020-02-17 12:15:23.000000000","updated":"2020-02-21 14:04:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2de27ceeb2a8ccc2a07ed12fc0ebc04a3dd114ef","_number":708111,"virtual_id_number":708111,"owner":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},{"date":"2020-02-21 13:57:27.000000000","_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-02-17 13:39:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},{"value":2,"date":"2020-02-18 09:11:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":1,"date":"2020-02-18 09:55:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-02-19 15:43:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2020-02-17 13:38:37.000000000","_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-17 13:38:37.000000000","updated_by":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"reviewer":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"state":"REVIEWER"},{"updated":"2020-02-17 13:39:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-02-18 09:11:04.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"state":"REVIEWER"},{"updated":"2020-02-18 09:55:00.000000000","updated_by":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"reviewer":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"state":"REVIEWER"},{"updated":"2020-02-19 15:43:23.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"96df307ccda2a51b787e311494f7ff4882d72084","author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"date":"2020-02-17 12:15:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b48c4b63f26479bc798b8cb771cb120039ce5e7e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-17 13:39:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7e9cc2815b9143fc9ed8888416c549dd : SUCCESS in 6m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/747c2c28007f40f3b6bfe2b56b960e10 : SUCCESS in 5m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e08781dec541459da355208a75df1ad8 : SUCCESS in 5m 35s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2bcf61865f744b4695cd98f33c81f8f7 : SUCCESS in 6m 08s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1ff1b16f31d04052aea312429a09d38b : SUCCESS in 4m 59s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/9c86658043ff487eb218623b4629dd7f : SUCCESS in 1h 13m 59s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/2a4fe918d7bc4360ab6d8cbcd68d1060 : SUCCESS in 6m 15s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/88ccb3b2bc05413ab4a698a5ca68a9ae : SUCCESS in 8m 40s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/d77e57167702439b9971d0b50f25af5a : SUCCESS in 6m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1fec36bd89cd45588c7e60525aba3939 : SUCCESS in 9m 47s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7f8e695cbb9c41639ee0e5f9a9783238 : SUCCESS in 57m 04s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/e56e2d32521e4282be9359fe9c160f04 : SUCCESS in 1h 13m 36s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/78eec8fdf259415ea393c37a50dc71c6 : SUCCESS in 59m 41s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/4f6b5c3fdcb440e2b639ba5063841376 : FAILURE in 1h 00m 15s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/e2e35d043e424f80999c5e278862327e : SUCCESS in 39m 29s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/8184a2ab880040daab7f8bf067d915fb : SUCCESS in 45m 02s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/956c0025bfb34ed99755a8a0066028a1 : SUCCESS in 1h 00m 13s (non-voting)\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/44de7dbd81e54a559f784755f9a605c9 : SUCCESS in 35m 50s\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/b83286c4b9014141ae2edcc591ef0c47 : SUCCESS in 54m 53s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c344fcccac79473eb09085e632d92d06 : SUCCESS in 18m 23s (non-voting)\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/4439a933340d4df9b43427ea6a934170 : SUCCESS in 1h 16m 37s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/04f86b5dc9054daea2e3b490cbf102d8 : SUCCESS in 37m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2d4ab74f3e116db264c9bc0238430e71c28e9006","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2020-02-18 09:11:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"95d42b3d69d566aeb40e21035a0be9d4c93e8577","author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"date":"2020-02-18 09:55:00.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"700f041ea82996e6cb258f2acd1b5174a7d52b3b","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-02-19 15:43:23.000000000","message":"Patch Set 1: Code-Review-1\n\nYou need to fix server_group.py, it\u0027s still has an instance method.","accounts_in_message":[],"_revision_number":1},{"id":"06825836609020772b09a6300f37eadad74dc80e","author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"date":"2020-02-21 13:57:27.000000000","message":"Patch Set 1:\n\nDmitry, I cannot simply make the ServerGroup._get_microversion_for class method, since here https://opendev.org/openstack/openstacksdk/src/commit/36cda6086ca1c5cc5515bba9001a26285ca1e15c/openstack/compute/v2/server_group.py#L73 it changes instance _body attribute. So I\u0027ll abandon the change in favor of different solution.","accounts_in_message":[],"_revision_number":1},{"id":"a2378dfec98de48c55b59764f945f0a0b71b478f","author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"date":"2020-02-21 14:04:35.000000000","message":"Abandoned\n\nCannot simply change method to class method  for ServerGroup subclass.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f1bbd155166fdbee3aa61782a2b1e79f3483eb36","revisions":{"f1bbd155166fdbee3aa61782a2b1e79f3483eb36":{"kind":"REWORK","_number":1,"created":"2020-02-17 12:15:23.000000000","uploader":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"ref":"refs/changes/11/708111/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/11/708111/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/11/708111/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/11/708111/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/11/708111/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/11/708111/1"}}},"commit":{"parents":[{"commit":"36cda6086ca1c5cc5515bba9001a26285ca1e15c","subject":"Change of auth url and regions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/36cda6086ca1c5cc5515bba9001a26285ca1e15c"}]}],"author":{"name":"gryf","email":"gryf73@gmail.com","date":"2020-02-13 15:17:36.000000000","tz":60},"committer":{"name":"gryf","email":"gryf73@gmail.com","date":"2020-02-17 12:15:06.000000000","tz":60},"subject":"Make _get_microversion_for a class method.","message":"Make _get_microversion_for a class method.\n\nWe\u0027re going to need this method for calculating microversion in bulk\ncreate process. While we don\u0027t changing microversions between the\nobjects it should be safe to make it calculated for all a resource.\n\nChange-Id: If3ed7211763044af88a3b6bf16d8c1c70b61664f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f1bbd155166fdbee3aa61782a2b1e79f3483eb36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f1bbd155166fdbee3aa61782a2b1e79f3483eb36"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}