)]}'
{"id":"openstack%2Fopenstacksdk~710995","triplet_id":"openstack%2Fopenstacksdk~stable%2Ftrain~I76b33e6c870971cdf50938d1328445702c83b64a","project":"openstack/openstacksdk","branch":"stable/train","topic":"story/2006679","hashtags":[],"change_id":"I76b33e6c870971cdf50938d1328445702c83b64a","subject":"Fix error handling on add/remove router iface calls","status":"MERGED","created":"2020-03-03 12:41:32.000000000","updated":"2020-03-04 23:23:55.000000000","submitted":"2020-03-04 23:19:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"710995-1583363996539-74ea99eb","meta_rev_id":"3d48c9c0eb78be38ce6ed4135b2f2a1dd638a0e2","_number":710995,"virtual_id_number":710995,"owner":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-04 23:19:56.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"recommended":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"all":[{"value":1,"date":"2020-03-03 13:09:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":1,"date":"2020-03-03 13:15:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"value":2,"date":"2020-03-04 21:38:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"value":1,"date":"2020-03-04 21:38:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"value":0,"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-03 13:09:28.000000000","updated_by":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"reviewer":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"state":"REVIEWER"},{"updated":"2020-03-03 13:15:23.000000000","updated_by":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"reviewer":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"state":"REVIEWER"},{"updated":"2020-03-04 21:38:59.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-03-04 23:19:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"69027e01150e30ae9d494535646237215c1cba24","author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"date":"2020-03-03 12:41:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a201c0cbd200ad192252cfcf845466bf452775ff","author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"date":"2020-03-03 13:09:28.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a47ca4396f2484694c2eb224bba0b335ab37b753","author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"date":"2020-03-03 13:11:03.000000000","message":"Patch Set 1:\n\nI assume this is worth cherry-picking too then: https://review.opendev.org/#/c/711001/.","accounts_in_message":[],"_revision_number":1},{"id":"228e70edfb2ad594e0a239c67cf67b3855c0c859","author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"date":"2020-03-03 13:15:23.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"942d4bbebfb4a595bdc1cf18bd341c2e31397923","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-03 14:35:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/077e550e47c74234a627ed906d5ab4bd : SUCCESS in 7m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8e8a9ec81fc5417db8a5bc831aba60eb : SUCCESS in 7m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4283bbdfa51845f99529868b08431e6e : SUCCESS in 6m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/82bbebd20c604cb799a6ae8dbab918e5 : SUCCESS in 6m 11s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ee9311e87373458ca990b03824f64e71 : SUCCESS in 7m 41s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/1bec91531c6947059bcf4ea04df2f3d7 : SUCCESS in 1h 21m 12s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/f4d2f4ffc26e468fa350cbf40d95f6b2 : SUCCESS in 1h 09m 22s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/d88bf3185f884e69b26d9c5e7bbe58b4 : SUCCESS in 6m 37s\n- os-client-config-tox-py27-tips https://zuul.opendev.org/t/openstack/build/a405a526ae914d10946d96e2a0094383 : SUCCESS in 6m 43s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/2198d36289ef4336a770d3229b329ebf : SUCCESS in 6m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/92c9463691b54ceab11dca5fc444c7e8 : SUCCESS in 7m 17s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/cb42e6c548ec488585e278f1859098ae : SUCCESS in 59m 47s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/0778f001be1949e3b9c1bac728851578 : SUCCESS in 1h 46m 41s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/9291106ae8234fc1a4403baa88ba67e5 : SUCCESS in 1h 00m 54s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/cbe002c466754fb5bd6da0629b8d5faa : FAILURE in 1h 01m 52s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/aaf30ba14bd44b628e142f8a4bd3f49f : SUCCESS in 44m 36s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/4a8b331bb6454066966b91d0ba09fdba : SUCCESS in 38m 25s (non-voting)\n- openstacksdk-functional-devstack-python2 https://zuul.opendev.org/t/openstack/build/b0edf4236a074e59a8bbb8d093daa4b4 : SUCCESS in 1h 01m 37s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/8f3ff0a7293a4054ba3cf0937145868c : SUCCESS in 53m 44s (non-voting)\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/f4831a7635da45c19acef1bcc087bb3e : SUCCESS in 52m 55s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/7875cf6bfe824c15a664a1b11bd0d176 : SUCCESS in 24m 18s\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/89a427f22d5d417a8885bf92b6f76e29 : SUCCESS in 57m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c0930546e82dd7574c4992d94d7171df3e5173be","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-03-04 21:38:59.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"838328236d78f889972d76bf57b3c7751905b4b4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-04 21:39:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7eb9d7c67641ea75a06b6c9bf293f902a3210b64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-04 23:19:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1de09f07080419ae7166b692dfa2d27a93753284","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-04 23:19:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/16921fa835834db5b7243f6814d5b6ba : SUCCESS in 6m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a41ec7d5615b4fddabdcb1bea48c90b3 : SUCCESS in 5m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5cec7ceb2d50461f815ddeefc4b78a2a : SUCCESS in 4m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/98c98112b99e43d3ad16505ff3885934 : SUCCESS in 6m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0f7f7021511948a98d7d2037d84bc184 : SUCCESS in 6m 47s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/15d4bc223d874e889401a98b809e2775 : SUCCESS in 1h 02m 33s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/adf8a21280f548f887e9dd5ab6020fd2 : SUCCESS in 1h 00m 28s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/cfdcd5826ca34bd3a3ba38e3081e6d1f : SUCCESS in 5m 54s\n- os-client-config-tox-py27-tips https://zuul.opendev.org/t/openstack/build/21bc9b4611944f4d871a54c2552ba6f4 : SUCCESS in 6m 19s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/428ba2caf69c4266988d8f7038b6d49c : SUCCESS in 4m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0ec23857a5d1441c8bbd59a5e3ea08a6 : SUCCESS in 6m 07s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/5d470cc2d9f7465598404e650e5dfb52 : SUCCESS in 1h 09m 23s\n- openstacksdk-functional-devstack-python2 https://zuul.opendev.org/t/openstack/build/e69d33ce3cc4498b8cfd36fdda5f517d : SUCCESS in 1h 07m 14s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/bdf273d0668b4ec3b456c9fd7d3f9767 : SUCCESS in 1h 31m 35s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/85e560d5454a43b99e3eb45a84727a1a : SUCCESS in 1h 09m 09s\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/75a854e1c74f4849b425477e0e9d20b7 : SUCCESS in 36m 45s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/dc493009f3f84e00bc6b01e598d33be6 : SUCCESS in 19m 11s","accounts_in_message":[],"_revision_number":1},{"id":"e3d52628051ee619c00b82b9ac2df8888f301cde","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-04 23:23:55.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c2588366243b49ca9f6c72812c19976b : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dc65d5fd302c7fe3d252871afb5f190c979a2185","revisions":{"dc65d5fd302c7fe3d252871afb5f190c979a2185":{"kind":"REWORK","_number":1,"created":"2020-03-03 12:41:32.000000000","uploader":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"ref":"refs/changes/95/710995/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/95/710995/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/95/710995/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/95/710995/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/95/710995/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/95/710995/1"}}},"commit":{"parents":[{"commit":"3aa053e7b938920991da6e5d9b31cd48ca9f9e43","subject":"Handle HTTP errors in add/remove router interface calls","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/3aa053e7b938920991da6e5d9b31cd48ca9f9e43"}]}],"author":{"name":"Michał Dulko","email":"mdulko@redhat.com","date":"2020-01-30 12:15:28.000000000","tz":60},"committer":{"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","date":"2020-03-03 12:39:08.000000000","tz":60},"subject":"Fix error handling on add/remove router iface calls","message":"Fix error handling on add/remove router iface calls\n\nIb1f880f75e511faaf8c798da22b9ca54dd441166 was manually processing call\nresults to raise SDKException. Instead of that\nexception.raise_from_response() should be used to make sure a correct\nexception class is thrown (e.g. NotFoundException on 404 results) and\nthis commit fixes this.\n\nChange-Id: I76b33e6c870971cdf50938d1328445702c83b64a\nStory: #2006679\nTask: #38575\n(cherry picked from commit 8afbfc7cd15a4bd8470cdcf41ee15a2a1d8e840a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/dc65d5fd302c7fe3d252871afb5f190c979a2185"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/dc65d5fd302c7fe3d252871afb5f190c979a2185"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}