)]}'
{"id":"openstack%2Fopenstacksdk~711001","triplet_id":"openstack%2Fopenstacksdk~stable%2Ftrain~Ia2f469690023e1d7e1c1e7935d6681a87f9433cd","project":"openstack/openstacksdk","branch":"stable/train","topic":"fix-trunk-error-handling-stable/train","hashtags":[],"change_id":"Ia2f469690023e1d7e1c1e7935d6681a87f9433cd","subject":"Fix error handling in network trunks operations","status":"MERGED","created":"2020-03-03 13:10:42.000000000","updated":"2020-03-03 18:12:40.000000000","submitted":"2020-03-03 18:08:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"711001-1583258938770-77b288b9","meta_rev_id":"fe365050e7a43494e9d307d70bc51deb9a78ad2f","_number":711001,"virtual_id_number":711001,"owner":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-03 18:08:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":2,"date":"2020-03-03 15:30:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2020-03-03 14:40:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-03-03 14:34:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":1,"date":"2020-03-03 15:30:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-03 14:34:09.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-03-03 14:40:48.000000000","updated_by":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"reviewer":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"state":"REVIEWER"},{"updated":"2020-03-03 15:30:25.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-03-03 18:08:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9fc61680a359593d440fa0082d30c1d4fb54f436","author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"date":"2020-03-03 13:10:42.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"51ad3d9a2c9c8b9c5fd200d20e90aa90e6ee7dfd","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-03 14:34:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5d9c65437bcd2a029546f8b4aab0a586856edcbf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-03 14:35:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3eb3cf5a4e9b41918c102e54c9a034c7 : SUCCESS in 6m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a1597b496aba4045a352986c00077d32 : SUCCESS in 6m 07s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1609ee3a949c4c4987994f7f0c4224be : SUCCESS in 5m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3ae4108dc209490aa7bf3e18d139261f : SUCCESS in 5m 30s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f79050f1b6e147c3bb07282c9dbf3d5d : SUCCESS in 7m 09s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/5d8b81464a1646cea2bc495beabc13f6 : SUCCESS in 1h 01m 09s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/b3af1329eb7f415d81284aef994db87b : SUCCESS in 1h 14m 59s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/fbf4f3c86f654761bc9a2ceca153ed2e : SUCCESS in 7m 36s\n- os-client-config-tox-py27-tips https://zuul.opendev.org/t/openstack/build/a3625bf9dd8f4610ae8b72072f8cb890 : SUCCESS in 5m 15s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/15dea3db5948412daccca1b243a6df4d : SUCCESS in 7m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/492512931721415c9f46df4d723cb6e9 : SUCCESS in 6m 39s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/d5bc58fe7ee740489d460eb9c436767f : SUCCESS in 1h 00m 20s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/2dc243b052574fcb8c3868e10aafc738 : SUCCESS in 1h 21m 17s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/a5d0ae920cc845f9b21be6b1e604aa4b : SUCCESS in 56m 03s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/9637ef9503254e47a2ccdc20ab2e9449 : FAILURE in 57m 34s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/58296faa24124ebba12b5dc161e8b80a : SUCCESS in 34m 15s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/d8025c2b3ff9450a804537c46c553336 : SUCCESS in 38m 53s (non-voting)\n- openstacksdk-functional-devstack-python2 https://zuul.opendev.org/t/openstack/build/7848485043434dfd95dd64e74dbe9b8e : SUCCESS in 1h 08m 23s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/93a461beb16a4ac7b783051e5b3a77b6 : SUCCESS in 1h 00m 45s (non-voting)\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/34467ee8ccbc402599c9a4ea1341a0e2 : SUCCESS in 51m 10s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/d2755900daa0425cafddfcc7d66258a0 : SUCCESS in 25m 30s\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/0168d59888874313bebb8dc86b05ba8c : SUCCESS in 54m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3bf4daa25f91b302e2866de69fc4cd598660a707","author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"date":"2020-03-03 14:40:48.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks, I somehow managed to miss it when comparing master and stable/train. Another nice one to have for user-friendliness","accounts_in_message":[],"_revision_number":1},{"id":"06377e4f239c9ddd8128246203fc65b35ee0160f","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-03-03 15:30:25.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"08005c02a4472f34bda0f5674a79a75210434242","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-03 15:30:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"304d4f58c6abec356d0ac74503afef074317c9b3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-03 18:08:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"cc9b45423d1aed9b1e5d2c378315a60d490aba88","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-03 18:08:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5580b31d0b754e29815854fa8a37286b : SUCCESS in 7m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a6b4b979f4724ffdb956f3e81b08146f : SUCCESS in 6m 12s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f36bd2658d4c4765883f74c53956b2c2 : SUCCESS in 7m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c4983ed9bd9b4d0195f348e16fb8c574 : SUCCESS in 7m 20s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/13f4d425a3b04edaa58c9160ec206502 : SUCCESS in 7m 33s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/a5fecbe017b646b588c03a34098a19b0 : SUCCESS in 1h 04m 43s\n- openstacksdk-functional-devstack-tips-python2 https://zuul.opendev.org/t/openstack/build/13b81c5fa2f347a38405c18d3a58d90e : SUCCESS in 1h 02m 38s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/6ce902c14c9d4068a0096368427897a6 : SUCCESS in 6m 45s\n- os-client-config-tox-py27-tips https://zuul.opendev.org/t/openstack/build/c19d34a4b1eb41d9a53a80d031b4ded8 : SUCCESS in 7m 25s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/9cde84d434154ea2994565224f62cbef : SUCCESS in 8m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b385275ec25d4371abcfc58af7a16e61 : SUCCESS in 7m 54s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/1e1d0508b8194bcf8f6982da109cf69d : SUCCESS in 1h 00m 28s\n- openstacksdk-functional-devstack-python2 https://zuul.opendev.org/t/openstack/build/bd4aad8ab961478d8550d6b7dfe7fdef : SUCCESS in 1h 05m 56s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/83e3ce7f350d49d58c762795692b1786 : SUCCESS in 1h 38m 40s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/0c7e4945f6c74015a62959945eaf9af6 : SUCCESS in 56m 24s\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/5bfed260b36d49008813890cace7c7a2 : SUCCESS in 36m 09s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/83443a616809410caf289bf310beb2f7 : SUCCESS in 22m 44s","accounts_in_message":[],"_revision_number":1},{"id":"597d920d203460e5b3b5b196738f0cc73a22505d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-03 18:12:40.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dd846872da11407f8e64936b3f49a797 : SUCCESS in 2m 56s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a16e508489ca8e83db0fc5d68496e6eb499d65c0","revisions":{"a16e508489ca8e83db0fc5d68496e6eb499d65c0":{"kind":"REWORK","_number":1,"created":"2020-03-03 13:10:42.000000000","uploader":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"ref":"refs/changes/01/711001/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/01/711001/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/01/711001/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/01/711001/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/01/711001/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/01/711001/1"}}},"commit":{"parents":[{"commit":"50c989891e5e6f9d92cc84619ba237182bd1d14a","subject":"Merge \"baremetal node: \u0027error\u0027 is a failed state\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/50c989891e5e6f9d92cc84619ba237182bd1d14a"}]}],"author":{"name":"Michał Dulko","email":"mdulko@redhat.com","date":"2020-01-30 17:26:16.000000000","tz":60},"committer":{"name":"Michał Dulko","email":"mdulko@redhat.com","date":"2020-03-03 13:10:42.000000000","tz":0},"subject":"Fix error handling in network trunks operations","message":"Fix error handling in network trunks operations\n\nIt seems like operations defined in network.v2.trunk had no error\nhandling or even ignored results from Neutron altogether. This meant\nthat user was not able to say if his requests were successful or not.\n\nThis commit fixes the issues by adding error handling through\nexceptions.raise_from_response and making sure that Trunk\u0027s body is\nupdated with the actual result from Neutron instead of the info passed\nfrom user (seems like delete_subports() even updated the Trunk object\nactually *adding* the removed subports).\n\nChange-Id: Ia2f469690023e1d7e1c1e7935d6681a87f9433cd\nStory: #2007239\nTask: #38579\n(cherry picked from commit 9b7e02bebcb27cb916d6b46eed48a8e1edeadea8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/a16e508489ca8e83db0fc5d68496e6eb499d65c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/a16e508489ca8e83db0fc5d68496e6eb499d65c0"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}