)]}'
{"id":"openstack%2Fopenstacksdk~712336","triplet_id":"openstack%2Fopenstacksdk~master~Ia81d8a39ca1c8407c689e7d128ace82071b52a01","project":"openstack/openstacksdk","branch":"master","topic":"provision-state-negotiation","hashtags":[],"change_id":"Ia81d8a39ca1c8407c689e7d128ace82071b52a01","subject":"Fix microversion negotiation in some bare metal node call","status":"MERGED","created":"2020-03-11 10:32:51.000000000","updated":"2020-03-11 15:59:18.000000000","submitted":"2020-03-11 15:57:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"712336-1583942231378-eb552905","meta_rev_id":"2eccff1f1c7052fd03718764662e4f7a84c3a21d","_number":712336,"virtual_id_number":712336,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-11 15:57:11.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-11 14:32:40.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"recommended":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2020-03-11 14:28:54.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2020-03-11 14:24:10.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2020-03-11 14:24:10.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-11 14:24:10.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-03-11 14:28:54.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-03-11 15:57:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5a5a565ec0a9f9823cefd25f4cfe3bb570f9f189","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-11 10:32:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c92ab274efe8e413841588df06a7e3785a633b19","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-11 11:50:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ff1d5457c9bd3abfe33f9ae1a0a7726f5c1c5933","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 13:15:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6e69e5eb92ff491584f050d938c10d7a : SUCCESS in 5m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/826cb9680c7f4194ab3757ed2bcac11d : SUCCESS in 4m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d57d0c2abd3f4ac99b9d95fdb2f0756c : SUCCESS in 5m 32s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a60aa475fd764144b72312aaf18273f7 : SUCCESS in 6m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/89113af77dff4bac93d04e53d4e0e0b2 : SUCCESS in 5m 22s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/a48485d50e8544df9792ff0a54bdea57 : SUCCESS in 54m 08s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/d832d7477ee343da9ea87f407ec55542 : SUCCESS in 5m 18s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/799055d296fe49b9b14ea0be453513c9 : SUCCESS in 4m 56s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/ba62165fcd334f06b6a6521ed69ecc92 : SUCCESS in 6m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8b6ea5803ce44300af4247b4e824926d : SUCCESS in 8m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/dca4b24760924ddf9d2ff8a145feabeb : SUCCESS in 5m 15s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/2130af5ca18646c993c531d26a3a53c2 : SUCCESS in 1h 06m 28s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/fff31dfb71fe4b0da79abc571c909c4d : SUCCESS in 1h 13m 34s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/c5b6e6c72c8b4d57adf59ae47f4be0b3 : SUCCESS in 57m 03s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/68b6a3f719d04879bcdf30e7b07a333c : SUCCESS in 1h 00m 44s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/1bf536f34c434cd49fabca3e970a57d1 : SUCCESS in 39m 02s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/dc27789572e04a2b961f9521bd3d2db9 : SUCCESS in 43m 55s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/4eb007d03487438792a850fdd45ea3a8 : SUCCESS in 55m 35s (non-voting)\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/27a6b082e4db418e8d714251ba91921f : SUCCESS in 35m 40s\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/a85f9d69fded4ebbb0e9ff8947a9b395 : SUCCESS in 58m 58s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b52331e214054856b0ddad4c424ecb91 : SUCCESS in 17m 53s (non-voting)\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/b42dea2442d14bcdac57b6d20992a3ba : SUCCESS in 1h 18m 55s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/c5ff3813e93b4d05b36b9b9495aacd5a : SUCCESS in 37m 56s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c771e652099a988f176fb5fd88fdffd1e3483d79","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-03-11 14:24:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"01ad89a09e04acb659b191c5b2d378ed2047862c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 14:24:22.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b5186f7ef196e954e67075d3bfefda9746a876b7","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-03-11 14:28:54.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c6ff3fc5aaf0a260b81532fbc8deee5e43108a92","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-11 14:32:40.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"531473188e84082a144c705023986c828db6fce1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 15:57:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d6652f9531d177949a20424d5de163b7ffcad41f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 15:57:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/43954037cd494aa9ab901b172bf42d49 : SUCCESS in 7m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5df37415d8f44b9caf5c79fd8d98ff19 : SUCCESS in 7m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/58003447362c428db52595b9008b9d51 : SUCCESS in 8m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bd0d16a46d174c478fcd0d00fb8be92e : SUCCESS in 8m 40s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/e4fa01f6d01047ee99ed7254f3c7feec : SUCCESS in 1h 01m 19s\n- openstacksdk-tox-py36-tips https://zuul.opendev.org/t/openstack/build/bacdbaf533b043a69177e51d1f6c01dd : SUCCESS in 7m 44s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/46b68a8fe3064d90a1c58de54a9517ab : SUCCESS in 5m 58s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/e7a271deac4b498b972ac391e685d2cf : SUCCESS in 7m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b254bd8f90c3433cbaf292ce2a229e4b : SUCCESS in 11m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1f71a55a604c44a2ab35b4dabce1352e : SUCCESS in 7m 21s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/6ff6dfc5b0904ded881fe67cc3119b82 : SUCCESS in 1h 03m 20s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/e9c0423c50dc4d689a97a94b3f6bc247 : SUCCESS in 1h 28m 20s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/1970655a471f4ba584396db1cf08fc72 : SUCCESS in 1h 00m 40s\n- nodepool-functional-openstack-src https://zuul.opendev.org/t/openstack/build/54a368b415a04475a33146a80aed0e4f : SUCCESS in 36m 44s","accounts_in_message":[],"_revision_number":2},{"id":"42d57bc7dbbbc34aa7cb8be54e78b3b4477cc5c0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 15:59:18.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/52b0bf25b0c348e2974d0b76290e38ae : SUCCESS in 1m 36s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ab0dba67e23c46e7ac7df5188eb5e3ef : SUCCESS in 1m 22s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2d844d775a722bf15243214a3c406f37a35e23c4","revisions":{"337c23d3d98b6198839a4fb9a0b827a032c37300":{"kind":"REWORK","_number":1,"created":"2020-03-11 10:32:51.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/36/712336/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/36/712336/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/36/712336/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/36/712336/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/36/712336/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/36/712336/1"}}},"commit":{"parents":[{"commit":"1ad44c8fa1f535e550b98f9927afdfe6cf7227d9","subject":"Merge \"Add retired and retired_reason fields to baremetal node\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/1ad44c8fa1f535e550b98f9927afdfe6cf7227d9"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-03-11 10:29:26.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-03-11 10:32:26.000000000","tz":60},"subject":"Fix microversion negotiation in some bare metal node call","message":"Fix microversion negotiation in some bare metal node call\n\nUsing utils.pick_microversion means that the result may be None,\nwhich is likely lower than a version negotiated for the resource.\n\nFor example, when calling set_node_provision_state(\u003cnode name\u003e, \"provide\"),\nit is determined that \"provide\" does not require a non-default microversion,\nso None is used, breaking using node name.\n\nThis change switches set_node_provision_state, set_node_power_state and\npatch_node to _assert_microversion_for that takes into account the\nmicroversion negotiated for the resource.\n\nChange-Id: Ia81d8a39ca1c8407c689e7d128ace82071b52a01\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/337c23d3d98b6198839a4fb9a0b827a032c37300"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/337c23d3d98b6198839a4fb9a0b827a032c37300"}]},"branch":"refs/heads/master"},"2d844d775a722bf15243214a3c406f37a35e23c4":{"kind":"REWORK","_number":2,"created":"2020-03-11 11:50:26.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/36/712336/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/36/712336/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/36/712336/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/36/712336/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/36/712336/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/36/712336/2"}}},"commit":{"parents":[{"commit":"1ad44c8fa1f535e550b98f9927afdfe6cf7227d9","subject":"Merge \"Add retired and retired_reason fields to baremetal node\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/1ad44c8fa1f535e550b98f9927afdfe6cf7227d9"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-03-11 10:29:26.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-03-11 11:50:16.000000000","tz":60},"subject":"Fix microversion negotiation in some bare metal node call","message":"Fix microversion negotiation in some bare metal node call\n\nUsing utils.pick_microversion means that the result may be None,\nwhich is likely lower than a version negotiated for the resource.\n\nFor example, when calling set_node_provision_state(\u003cnode name\u003e, \"provide\"),\nit is determined that \"provide\" does not require a non-default microversion,\nso None is used, breaking using node name.\n\nThis change switches set_node_provision_state, set_node_power_state and\npatch_node to _assert_microversion_for that takes into account the\nmicroversion negotiated for the resource.\n\nChange-Id: Ia81d8a39ca1c8407c689e7d128ace82071b52a01\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/2d844d775a722bf15243214a3c406f37a35e23c4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/2d844d775a722bf15243214a3c406f37a35e23c4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}