)]}'
{"doc/source/user/proxies/baremetal.rst":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.allocations"},{"line_number":95,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.wait_for_allocation"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"volume connectors Operations"},{"line_number":98,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":99,"context_line":".. autoclass:: openstack.baremetal.v1._proxy.Proxy"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_4d9d0558","line":97,"range":{"start_line":97,"start_character":16,"end_line":97,"end_character":17},"updated":"2020-04-17 09:23:51.000000000","message":"remove the s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.allocations"},{"line_number":95,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.wait_for_allocation"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"volume connectors Operations"},{"line_number":98,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":99,"context_line":".. autoclass:: openstack.baremetal.v1._proxy.Proxy"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_ed78512b","line":97,"range":{"start_line":97,"start_character":7,"end_line":97,"end_character":8},"updated":"2020-04-17 09:23:51.000000000","message":"use a capital C","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.allocations"},{"line_number":95,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.wait_for_allocation"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"volume connectors Operations"},{"line_number":98,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":99,"context_line":".. autoclass:: openstack.baremetal.v1._proxy.Proxy"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_4d88651e","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":1},"updated":"2020-04-17 09:23:51.000000000","message":"use a capital V","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":99,"context_line":".. autoclass:: openstack.baremetal.v1._proxy.Proxy"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.create_volume_connectors"},{"line_number":102,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.update_volume_connectors"},{"line_number":103,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.patch_volume_connectors"},{"line_number":104,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.delete_allocation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_ada3e99d","line":101,"range":{"start_line":101,"start_character":78,"end_line":101,"end_character":79},"updated":"2020-04-17 09:23:51.000000000","message":"remove s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":99,"context_line":".. autoclass:: openstack.baremetal.v1._proxy.Proxy"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.create_volume_connectors"},{"line_number":102,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.update_volume_connectors"},{"line_number":103,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.patch_volume_connectors"},{"line_number":104,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.delete_allocation"},{"line_number":105,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.get_volume_connectors"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_8d9eed51","line":102,"range":{"start_line":102,"start_character":78,"end_line":102,"end_character":79},"updated":"2020-04-17 09:23:51.000000000","message":"remove s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.create_volume_connectors"},{"line_number":102,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.update_volume_connectors"},{"line_number":103,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.patch_volume_connectors"},{"line_number":104,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.delete_allocation"},{"line_number":105,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.get_volume_connectors"},{"line_number":106,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.volume_connectors"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_edadf188","line":103,"range":{"start_line":103,"start_character":77,"end_line":103,"end_character":78},"updated":"2020-04-17 09:23:51.000000000","message":"remove s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.create_volume_connectors"},{"line_number":102,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.update_volume_connectors"},{"line_number":103,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.patch_volume_connectors"},{"line_number":104,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.delete_allocation"},{"line_number":105,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.get_volume_connectors"},{"line_number":106,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.volume_connectors"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_cda8f578","line":104,"range":{"start_line":104,"start_character":55,"end_line":104,"end_character":72},"updated":"2020-04-17 09:23:51.000000000","message":"delete_volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.update_volume_connectors"},{"line_number":103,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.patch_volume_connectors"},{"line_number":104,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.delete_allocation"},{"line_number":105,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.get_volume_connectors"},{"line_number":106,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.volume_connectors"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Utilities"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_0dbc9db9","line":105,"range":{"start_line":105,"start_character":75,"end_line":105,"end_character":76},"updated":"2020-04-17 09:23:51.000000000","message":"remove s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3128bd6acab0cfa3974ced751e1ef4cc307d4cbd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Volume Connector Operations"},{"line_number":65,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":66,"context_line":".. autoclass:: openstack.baremetal.v1._proxy.Proxy"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.create_volume_connector"},{"line_number":69,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.update_volume_connector"},{"line_number":70,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.patch_volume_connector"},{"line_number":71,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.delete_volume_connector"},{"line_number":72,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.get_volume_connector"},{"line_number":73,"context_line":"   .. automethod:: openstack.baremetal.v1._proxy.Proxy.volume_connectors"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Utilities"},{"line_number":76,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f493fa4_c45c06ef","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":72},"updated":"2020-04-28 17:19:24.000000000","message":"need to use the new format to avoid problem in the docs.\n :noindex:\n :members: create_volume_connector, ...","commit_id":"ad32284755f5898c55960b285c2e3dfbc5aa5a4d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":65,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":66,"context_line":".. autoclass:: openstack.baremetal.v1._proxy.Proxy"},{"line_number":67,"context_line":"  :noindex:"},{"line_number":68,"context_line":"  :members: volume_connector, get_volume_connector, create_volume_connector,"},{"line_number":69,"context_line":"            update_volume_connector, patch_volume_connector,"},{"line_number":70,"context_line":"            delete_volume_connector"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_b92ff8a5","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":28},"updated":"2020-05-04 17:14:59.000000000","message":"typo, here should be volume_connectors (that\u0027s why the job is failing)","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"}],"doc/source/user/resources/baremetal/index.rst":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"   v1/port"},{"line_number":11,"context_line":"   v1/port_group"},{"line_number":12,"context_line":"   v1/allocation"},{"line_number":13,"context_line":"   v1/volume_connectors"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_6db3a1eb","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":23},"updated":"2020-04-17 09:23:51.000000000","message":"remove the s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"}],"doc/source/user/resources/baremetal/v1/volume_connectors.rst":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack.baremetal.v1.volume_connectors"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.baremetal.v1.volume_connectors"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_adcc896a","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":40},"updated":"2020-04-17 09:23:51.000000000","message":"remove the s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack.baremetal.v1.volume_connectors"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.baremetal.v1.volume_connectors"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The VolumeConnectors Class"},{"line_number":7,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_edc69148","line":4,"range":{"start_line":4,"start_character":55,"end_line":4,"end_character":56},"updated":"2020-04-17 09:23:51.000000000","message":"remove the s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.baremetal.v1.volume_connectors"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The VolumeConnectors Class"},{"line_number":7,"context_line":"--------------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``VolumeConnectors`` class inherits from :"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_2ddeb910","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":20},"updated":"2020-04-17 09:23:51.000000000","message":"remove the s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"The VolumeConnectors Class"},{"line_number":7,"context_line":"--------------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``VolumeConnectors`` class inherits from :"},{"line_number":10,"context_line":"class:`~openstack.resource.Resource`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. autoclass:: openstack.baremetal.v1.volume_connectors.VolumeConnectors"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_0de13dd1","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":22},"updated":"2020-04-17 09:23:51.000000000","message":"remove the s","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The ``VolumeConnectors`` class inherits from :"},{"line_number":10,"context_line":"class:`~openstack.resource.Resource`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. autoclass:: openstack.baremetal.v1.volume_connectors.VolumeConnectors"},{"line_number":13,"context_line":"   :members:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_add129fe","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":72},"updated":"2020-04-17 09:23:51.000000000","message":"VolumeConnector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The ``VolumeConnectors`` class inherits from :"},{"line_number":10,"context_line":"class:`~openstack.resource.Resource`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. autoclass:: openstack.baremetal.v1.volume_connectors.VolumeConnectors"},{"line_number":13,"context_line":"   :members:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4c43b2_6de8c1b3","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":55},"updated":"2020-04-17 09:23:51.000000000","message":"volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f4c43b2_eddb3118","line":14,"updated":"2020-04-17 09:23:51.000000000","message":"Rename this file to volume_connector.rst","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"}],"openstack/baremetal/v1/_proxy.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7305266f02d16c42c98815ea66f22373dba4dc0c","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        res \u003d self._get_resource(_node.Node, node)"},{"line_number":1006,"context_line":"        return res.set_traits(self, traits)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    def volume_connector(self, details\u003dFalse, **query):"},{"line_number":1009,"context_line":"        \"\"\"Retrieve a generator of volume_connectors."},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        :param details: A boolean indicating whether the detailed information"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_cb0dcc38","line":1008,"range":{"start_line":1008,"start_character":23,"end_line":1008,"end_character":24},"updated":"2020-04-13 22:10:02.000000000","message":"type: should be connectors","commit_id":"2fc3bcb681251280e9e243dac2d7c3773a623552"},{"author":{"_account_id":31674,"name":"subham rai","email":"subham.k.rai@gmail.com","username":"subhamkrai"},"change_message_id":"d12f2f8d5093e648f4f20a7f554d170d8d4b3dcf","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        res \u003d self._get_resource(_node.Node, node)"},{"line_number":1006,"context_line":"        return res.set_traits(self, traits)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    def volume_connector(self, details\u003dFalse, **query):"},{"line_number":1009,"context_line":"        \"\"\"Retrieve a generator of volume_connectors."},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        :param details: A boolean indicating whether the detailed information"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_c775b19a","line":1008,"range":{"start_line":1008,"start_character":23,"end_line":1008,"end_character":24},"in_reply_to":"3f4c43b2_cb0dcc38","updated":"2020-04-14 12:03:08.000000000","message":"so I\u0027ll have to change volume_connector to volume_connectors everywhere I have used this.?","commit_id":"2fc3bcb681251280e9e243dac2d7c3773a623552"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8b75b7931f9a43691939c65fc4913ff997cfc706","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        :param details: A boolean indicating whether the detailed information"},{"line_number":1012,"context_line":"                        for every volume_connector should be returned."},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"            * ``detail``: To show detailed information about the resource.This"},{"line_number":1015,"context_line":"              cannot be set to True if ``fields`` parameter is specified."},{"line_number":1016,"context_line":"            * ``fields``: A list containing one or more fields to be returned"},{"line_number":1017,"context_line":"              in the response. This may lead to some performance gain"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_2670dea5","line":1014,"range":{"start_line":1014,"start_character":74,"end_line":1014,"end_character":75},"updated":"2020-04-14 09:22:44.000000000","message":"nit: missing blank space","commit_id":"2fc3bcb681251280e9e243dac2d7c3773a623552"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from openstack.baremetal.v1 import node as _node"},{"line_number":18,"context_line":"from openstack.baremetal.v1 import port as _port"},{"line_number":19,"context_line":"from openstack.baremetal.v1 import port_group as _portgroup"},{"line_number":20,"context_line":"from openstack.baremetal.v1 import volume_connectors as _volumeconnectors"},{"line_number":21,"context_line":"from openstack import exceptions"},{"line_number":22,"context_line":"from openstack import proxy"},{"line_number":23,"context_line":"from openstack import utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_cdd635f2","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":73},"updated":"2020-04-17 09:23:51.000000000","message":"this should be changed to \nfrom openstack.baremetal.v1 import volume_connector as _volumeconnector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"        :returns: A generator of volume_connectors instances."},{"line_number":1042,"context_line":"        \"\"\""},{"line_number":1043,"context_line":"        return _volumeconnectors.VolumeConnectors.list(self,"},{"line_number":1044,"context_line":"                                                       details\u003ddetails,"},{"line_number":1045,"context_line":"                                                       **query)"},{"line_number":1046,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_0d665d52","line":1043,"range":{"start_line":1043,"start_character":16,"end_line":1043,"end_character":49},"updated":"2020-04-17 09:23:51.000000000","message":"change to _volumeconnector.VolumeConnector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"                                                       details\u003ddetails,"},{"line_number":1045,"context_line":"                                                       **query)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    def create_volume_connectors(self, **attrs):"},{"line_number":1048,"context_line":"        \"\"\"Create a new volume_connectors from attributes."},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        :param dict attrs: Keyword arguments that will be used to create a"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_2d2cf900","line":1047,"range":{"start_line":1047,"start_character":8,"end_line":1047,"end_character":32},"updated":"2020-04-17 09:23:51.000000000","message":"create_volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"        :rtype::class:"},{"line_number":1056,"context_line":"            `~openstack.baremetal.v1.volume_connectors.VolumeConnectors`."},{"line_number":1057,"context_line":"        \"\"\""},{"line_number":1058,"context_line":"        return self._create(_volumeconnectors.VolumeConnectors, **attrs)"},{"line_number":1059,"context_line":""},{"line_number":1060,"context_line":"    def get_volume_connectors(self, volume_connectors, fields\u003dNone):"},{"line_number":1061,"context_line":"        \"\"\"Get a specific volume_connectors."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_ad3f6923","line":1058,"range":{"start_line":1058,"start_character":28,"end_line":1058,"end_character":62},"updated":"2020-04-17 09:23:51.000000000","message":"change to match the changes","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"        \"\"\""},{"line_number":1058,"context_line":"        return self._create(_volumeconnectors.VolumeConnectors, **attrs)"},{"line_number":1059,"context_line":""},{"line_number":1060,"context_line":"    def get_volume_connectors(self, volume_connectors, fields\u003dNone):"},{"line_number":1061,"context_line":"        \"\"\"Get a specific volume_connectors."},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"        :param volume_connectors: The value can be the ID of a"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_adfac971","line":1060,"range":{"start_line":1060,"start_character":8,"end_line":1060,"end_character":29},"updated":"2020-04-17 09:23:51.000000000","message":"get_volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"        \"\"\""},{"line_number":1058,"context_line":"        return self._create(_volumeconnectors.VolumeConnectors, **attrs)"},{"line_number":1059,"context_line":""},{"line_number":1060,"context_line":"    def get_volume_connectors(self, volume_connectors, fields\u003dNone):"},{"line_number":1061,"context_line":"        \"\"\"Get a specific volume_connectors."},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"        :param volume_connectors: The value can be the ID of a"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_edf4d188","line":1060,"range":{"start_line":1060,"start_character":36,"end_line":1060,"end_character":53},"updated":"2020-04-17 09:23:51.000000000","message":"volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound` when no"},{"line_number":1073,"context_line":"            volume_connectors matching the name or ID could be found.`"},{"line_number":1074,"context_line":"        \"\"\""},{"line_number":1075,"context_line":"        return self._get_with_fields(_volumeconnectors.VolumeConnectors,"},{"line_number":1076,"context_line":"                                     volume_connectors,"},{"line_number":1077,"context_line":"                                     fields\u003dfields)"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def update_volume_connectors(self, volume_connectors, **attrs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_6d15614a","line":1076,"range":{"start_line":1075,"start_character":38,"end_line":1076,"end_character":54},"updated":"2020-04-17 09:23:51.000000000","message":"this you will need to change to match the import and the parameter","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                                     volume_connectors,"},{"line_number":1077,"context_line":"                                     fields\u003dfields)"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def update_volume_connectors(self, volume_connectors, **attrs):"},{"line_number":1080,"context_line":"        \"\"\"Update a volume_connectors."},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        :param volume_connectors:Either the ID of a volume_connectors"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_3f237caa","line":1079,"range":{"start_line":1079,"start_character":8,"end_line":1079,"end_character":32},"updated":"2020-04-17 09:23:51.000000000","message":"update_volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                                     volume_connectors,"},{"line_number":1077,"context_line":"                                     fields\u003dfields)"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"    def update_volume_connectors(self, volume_connectors, **attrs):"},{"line_number":1080,"context_line":"        \"\"\"Update a volume_connectors."},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        :param volume_connectors:Either the ID of a volume_connectors"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_bf366ce5","line":1079,"range":{"start_line":1079,"start_character":39,"end_line":1079,"end_character":56},"updated":"2020-04-17 09:23:51.000000000","message":"volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"        :rtype::class:"},{"line_number":1090,"context_line":"            `~openstack.baremetal.v1.volume_connectors.VolumeConnectors.`"},{"line_number":1091,"context_line":"        \"\"\""},{"line_number":1092,"context_line":"        return self._update(_volumeconnectors.VolumeConnectors,"},{"line_number":1093,"context_line":"                            volume_connectors, **attrs)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    def patch_volume_connectors(self, volume_connectors, patch):"},{"line_number":1096,"context_line":"        \"\"\"Apply a JSON patch to the volume_connectors."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_df2b787f","line":1093,"range":{"start_line":1092,"start_character":28,"end_line":1093,"end_character":45},"updated":"2020-04-17 09:23:51.000000000","message":"change to match the changes","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        return self._update(_volumeconnectors.VolumeConnectors,"},{"line_number":1093,"context_line":"                            volume_connectors, **attrs)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    def patch_volume_connectors(self, volume_connectors, patch):"},{"line_number":1096,"context_line":"        \"\"\"Apply a JSON patch to the volume_connectors."},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        :param volume_connectors: The value can be the ID of a"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_7f13445d","line":1095,"range":{"start_line":1095,"start_character":8,"end_line":1095,"end_character":31},"updated":"2020-04-17 09:23:51.000000000","message":"patch_volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        return self._update(_volumeconnectors.VolumeConnectors,"},{"line_number":1093,"context_line":"                            volume_connectors, **attrs)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    def patch_volume_connectors(self, volume_connectors, patch):"},{"line_number":1096,"context_line":"        \"\"\"Apply a JSON patch to the volume_connectors."},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        :param volume_connectors: The value can be the ID of a"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_5f0e4832","line":1095,"range":{"start_line":1095,"start_character":38,"end_line":1095,"end_character":55},"updated":"2020-04-17 09:23:51.000000000","message":"volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"        :rtype::class:"},{"line_number":1106,"context_line":"            `~openstack.baremetal.v1.volume_connectors.VolumeConnectors.`"},{"line_number":1107,"context_line":"        \"\"\""},{"line_number":1108,"context_line":"        return self._get_resource(_volumeconnectors.VolumeConnectors,"},{"line_number":1109,"context_line":"                                  volume_connectors).patch(self, patch)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def delete_volume_connectors(self, volume_connectors,"},{"line_number":1112,"context_line":"                                 ignore_missing\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_9f18d075","line":1109,"range":{"start_line":1108,"start_character":34,"end_line":1109,"end_character":51},"updated":"2020-04-17 09:23:51.000000000","message":"change to match the changes","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"        return self._get_resource(_volumeconnectors.VolumeConnectors,"},{"line_number":1109,"context_line":"                                  volume_connectors).patch(self, patch)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def delete_volume_connectors(self, volume_connectors,"},{"line_number":1112,"context_line":"                                 ignore_missing\u003dTrue):"},{"line_number":1113,"context_line":"        \"\"\"Delete a volume_connectors."},{"line_number":1114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_cd03d50e","line":1111,"range":{"start_line":1111,"start_character":8,"end_line":1111,"end_character":32},"updated":"2020-04-17 09:23:51.000000000","message":"delete_volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"        return self._get_resource(_volumeconnectors.VolumeConnectors,"},{"line_number":1109,"context_line":"                                  volume_connectors).patch(self, patch)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def delete_volume_connectors(self, volume_connectors,"},{"line_number":1112,"context_line":"                                 ignore_missing\u003dTrue):"},{"line_number":1113,"context_line":"        \"\"\"Delete a volume_connectors."},{"line_number":1114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_df025809","line":1111,"range":{"start_line":1111,"start_character":39,"end_line":1111,"end_character":56},"updated":"2020-04-17 09:23:51.000000000","message":"volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"            :class:"},{"line_number":1129,"context_line":"            `~openstack.baremetal.v1.volume_connectors.VolumeConnectors`."},{"line_number":1130,"context_line":"        \"\"\""},{"line_number":1131,"context_line":"        return self._delete(_volumeconnectors.VolumeConnectors,"},{"line_number":1132,"context_line":"                            volume_connectors, ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_1f0de036","line":1132,"range":{"start_line":1131,"start_character":28,"end_line":1132,"end_character":46},"updated":"2020-04-17 09:23:51.000000000","message":"change to match the new changes","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f4c43b2_9f46104f","line":1133,"updated":"2020-04-17 09:23:51.000000000","message":"The docs for each volume_connector function you will need to update removing the s and using the correct class since the s is not required \u003d)","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"            `~openstack.baremetal.v1.volume_connector.VolumeConnector`."},{"line_number":1129,"context_line":"        \"\"\""},{"line_number":1130,"context_line":"        return self._delete(_volumeconnector.VolumeConnector,"},{"line_number":1131,"context_line":"                            volume_connector, ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_af4b2a5d","line":1131,"updated":"2020-05-04 17:14:59.000000000","message":"You are missing a find_volume_connector function here \u003d)","commit_id":"ad32284755f5898c55960b285c2e3dfbc5aa5a4d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1669e64747095c6b58abbc90b6dc4f11bbb48789","unresolved":false,"context_lines":[{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        :param details: A boolean indicating whether the detailed information"},{"line_number":1012,"context_line":"                        for every volume_connector should be returned."},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"            * ``detail``: To show detailed information about the resource."},{"line_number":1015,"context_line":"              This cannot be set to True if ``fields`` parameter is specified."},{"line_number":1016,"context_line":"            * ``fields``: A list containing one or more fields to be returned"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_8d0d8337","line":1013,"updated":"2020-06-10 09:30:03.000000000","message":"The list below is not attached to anything, did you mean to document \u0027query\u0027?","commit_id":"3e305779833a4beec1c328f14b5e8ea5b5731066"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1669e64747095c6b58abbc90b6dc4f11bbb48789","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        :param details: A boolean indicating whether the detailed information"},{"line_number":1012,"context_line":"                        for every volume_connector should be returned."},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"            * ``detail``: To show detailed information about the resource."},{"line_number":1015,"context_line":"              This cannot be set to True if ``fields`` parameter is specified."},{"line_number":1016,"context_line":"            * ``fields``: A list containing one or more fields to be returned"},{"line_number":1017,"context_line":"              in the response. This may lead to some performance gain"},{"line_number":1018,"context_line":"              because other fields of the resource are not refreshed."}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_6d074f1a","line":1015,"range":{"start_line":1014,"start_character":14,"end_line":1015,"end_character":78},"updated":"2020-06-10 09:30:03.000000000","message":"This should be removed","commit_id":"3e305779833a4beec1c328f14b5e8ea5b5731066"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1669e64747095c6b58abbc90b6dc4f11bbb48789","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"    def find_volume_connector(self, name_or_id, ignore_missing\u003dTrue):"},{"line_number":1061,"context_line":"        \"\"\"Find a single volume connector."},{"line_number":1062,"context_line":""},{"line_number":1063,"context_line":"        :param str name_or_id: The name or ID of a volume connector."},{"line_number":1064,"context_line":"        :param bool ignore_missing: When set to ``False``, an exception of"},{"line_number":1065,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound` will be raised"},{"line_number":1066,"context_line":"            when the volume connector does not exist.  When set to `True``,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_4d252bab","line":1063,"updated":"2020-06-10 09:30:03.000000000","message":"Volume connectors don\u0027t have names","commit_id":"3e305779833a4beec1c328f14b5e8ea5b5731066"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7a36f4189d4b93bd7ef0ffd4d28558cc20724007","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"        :param details: A boolean indicating whether the detailed information"},{"line_number":1011,"context_line":"                        for every volume_connector should be returned."},{"line_number":1012,"context_line":"        :param dict query: Optional query parameters to be sent to restrict"},{"line_number":1013,"context_line":"            the ports returned. Available parameters include:"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"            * ``fields``: A list containing one or more fields to be returned"},{"line_number":1016,"context_line":"              in the response. This may lead to some performance gain"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_edad4332","line":1013,"range":{"start_line":1013,"start_character":16,"end_line":1013,"end_character":21},"updated":"2020-06-15 15:53:33.000000000","message":"This is wrong.","commit_id":"cd16d5e2f1c3300d19eddb6ddbd0258352fc889d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7a36f4189d4b93bd7ef0ffd4d28558cc20724007","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"        \"\"\""},{"line_number":1057,"context_line":"        return self._create(_volumeconnector.VolumeConnector, **attrs)"},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"    def find_volume_connector(self, name_or_id, ignore_missing\u003dTrue):"},{"line_number":1060,"context_line":"        \"\"\"Find a single volume connector."},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"        :param bool ignore_missing: When set to ``False``, an exception of"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_0db19790","line":1059,"range":{"start_line":1059,"start_character":36,"end_line":1059,"end_character":46},"updated":"2020-06-15 15:53:33.000000000","message":"You need to rename the variable since they don\u0027t have names, and re add the documentation for the parameter.","commit_id":"cd16d5e2f1c3300d19eddb6ddbd0258352fc889d"}],"openstack/baremetal/v1/volume_connector.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8b75b7931f9a43691939c65fc4913ff997cfc706","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # The physical_network field introduced in 1.32"},{"line_number":38,"context_line":"    _max_microversion \u003d \u00271.32\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    #: The identifier of Volume connector and this field depends on the \"type\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_a6022eb3","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":32},"updated":"2020-04-14 09:22:44.000000000","message":"not sure this reference is correct, should refer to volume connectors introduced in 1.32","commit_id":"2fc3bcb681251280e9e243dac2d7c3773a623552"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class VolumeConnector(_common.ListMixin, resource.Resource):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    resources_key \u003d \u0027volumeconnectors\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/volume/connectors\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_c93c21ca","line":19,"range":{"start_line":19,"start_character":21,"end_line":19,"end_character":37},"updated":"2020-05-18 09:48:25.000000000","message":"change this to connectors","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b1eb3b2db196ae6fd220a5f4c745b3add79834d0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    commit_jsonpatch \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":33,"context_line":"        \u0027volume_connector_id\u0027,"},{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_34f7b45b","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":28},"updated":"2020-05-20 17:27:26.000000000","message":"change to node, make sure the unit tests will be ok after you change here \u003d)","commit_id":"0e330fc45cc4209ab446dc397c1906b5143f8914"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ffb261c1fa09212a8ee483d94a865a8e260fe5a8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    commit_jsonpatch \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":33,"context_line":"        \u0027node\u0027,"},{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ff570b3c_b5d9a523","line":33,"updated":"2020-05-26 18:52:33.000000000","message":"need to add \u0027detail\u0027 here since it failed with  Invalid query params: detail","commit_id":"0c719e72e00f4385fbf4c2a65510f64e4bdbd230"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4787e8f803adaa7f46772517078ea23aa5c6186c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    commit_jsonpatch \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":33,"context_line":"        \u0027node\u0027,"},{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ff570b3c_77a040f5","line":33,"updated":"2020-06-02 18:05:18.000000000","message":"You haven\u0027t add detail here, the test is going to fail again.","commit_id":"aef80c16f8a49ea8bc06b279757762772322ee7f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1669e64747095c6b58abbc90b6dc4f11bbb48789","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    id \u003d resource.Body(\u0027uuid\u0027, alternate_id\u003dTrue)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"VolumeConnectorDetail \u003d VolumeConnector"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_0d50530a","line":59,"updated":"2020-06-10 09:30:03.000000000","message":"not needed here, it\u0027s used for backward compatibility in other palces","commit_id":"3e305779833a4beec1c328f14b5e8ea5b5731066"}],"openstack/baremetal/v1/volume_connectors.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack import resource"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class VolumeConnectors(_common.ListMixin, resource.Resource):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    resources_key \u003d \u0027connectors\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/volume/connectors\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_7f6a24b3","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":22},"updated":"2020-04-17 09:23:51.000000000","message":"VolumeConnector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    commit_jsonpatch \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":33,"context_line":"        \u0027volume_connectors_id\u0027,"},{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_d28d307c","line":33,"updated":"2020-04-17 09:23:51.000000000","message":"the parameter here should be volume_connector_id following the api documentation","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # The volume connectors introduced in 1.32"},{"line_number":38,"context_line":"    _max_microversion \u003d \u00271.32\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    #: The identifier of Volume connectors and this field depends on the \"type\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_9fb45037","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":46},"updated":"2020-04-17 09:23:51.000000000","message":"maybe use \" Volume Connectors is available since 1.32 \"","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # The volume connectors introduced in 1.32"},{"line_number":38,"context_line":"    _max_microversion \u003d \u00271.32\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    #: The identifier of Volume connectors and this field depends on the \"type\""},{"line_number":41,"context_line":"    # of the volume_connectors"},{"line_number":42,"context_line":"    connector_id \u003d resource.Body(\u0027connector_id\u0027)"},{"line_number":43,"context_line":"    #: Timestamp at which the port was created."},{"line_number":44,"context_line":"    created_at \u003d resource.Body(\u0027created_at\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_32ea940e","line":41,"range":{"start_line":40,"start_character":4,"end_line":41,"end_character":30},"updated":"2020-04-17 09:23:51.000000000","message":"you can keep the singular form here","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    links \u003d resource.Body(\u0027links\u0027, type\u003dlist)"},{"line_number":49,"context_line":"    #: The UUID of node this port belongs to"},{"line_number":50,"context_line":"    node_id \u003d resource.Body(\u0027node_uuid\u0027)"},{"line_number":51,"context_line":"    #: The types of Volume connectors"},{"line_number":52,"context_line":"    type \u003d resource.Body(\u0027type\u0027)"},{"line_number":53,"context_line":"    #: Timestamp at which the port was last updated."},{"line_number":54,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_d2b41038","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":37},"updated":"2020-04-17 09:23:51.000000000","message":"The class only take care of 1 Volume Connector at time so this should be \"The type of the Volume Connector\"","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    id \u003d resource.Body(\u0027uuid\u0027, alternate_id\u003dTrue)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"VolumeConnectorsDetail \u003d VolumeConnectors"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_ff847460","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":22},"updated":"2020-04-17 09:23:51.000000000","message":"VolumeConnectorDetail \u003d VolumeConnector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"}],"openstack/tests/functional/baremetal/base.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                                          ignore_missing\u003dTrue))"},{"line_number":64,"context_line":"        return port_group"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def create_volume_connectors(self, node_id\u003dNone, **kwargs):"},{"line_number":67,"context_line":"        node_id \u003d node_id or self.node_id"},{"line_number":68,"context_line":"        volume_connectors \u003d self.conn.baremetal.create_volumes_connector("},{"line_number":69,"context_line":"            node_uuid\u003dnode_id, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_df87f860","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":32},"updated":"2020-04-17 09:23:51.000000000","message":"keep the singular here","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def create_volume_connectors(self, node_id\u003dNone, **kwargs):"},{"line_number":67,"context_line":"        node_id \u003d node_id or self.node_id"},{"line_number":68,"context_line":"        volume_connectors \u003d self.conn.baremetal.create_volumes_connector("},{"line_number":69,"context_line":"            node_uuid\u003dnode_id, **kwargs)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_7f9864bf","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":25},"updated":"2020-04-17 09:23:51.000000000","message":"volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.addCleanup("},{"line_number":72,"context_line":"            lambda:"},{"line_number":73,"context_line":"            self.conn.baremetal.delete_volume_connectors(volume_connectors.id,"},{"line_number":74,"context_line":"                                                         ignore_missing\u003dTrue))"},{"line_number":75,"context_line":"        return volume_connectors"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_ffe9141a","line":73,"range":{"start_line":73,"start_character":57,"end_line":73,"end_character":74},"updated":"2020-04-17 09:23:51.000000000","message":"volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa5e763bf5154c4e1fd09898534395234ffe52c4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            lambda:"},{"line_number":73,"context_line":"            self.conn.baremetal.delete_volume_connectors(volume_connectors.id,"},{"line_number":74,"context_line":"                                                         ignore_missing\u003dTrue))"},{"line_number":75,"context_line":"        return volume_connectors"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_9f8d707d","line":75,"range":{"start_line":75,"start_character":15,"end_line":75,"end_character":32},"updated":"2020-04-17 09:23:51.000000000","message":"volume_connector","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a1e82f51d34298d5e4e5a230510ff28dea56b6ed","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def create_volume_connector(self, node_id\u003dNone, **kwargs):"},{"line_number":67,"context_line":"        node_id \u003d node_id or self.node_id"},{"line_number":68,"context_line":"        volume_connector \u003d self.conn.baremetal.create_volumes_connector("},{"line_number":69,"context_line":"            node_uuid\u003dnode_id, **kwargs)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_304b04b1","line":68,"range":{"start_line":68,"start_character":47,"end_line":68,"end_character":71},"updated":"2020-05-04 09:17:00.000000000","message":"the name of the function here should be create_volume_connector, since it was declared like that in the openstack/baremetal/v1/_proxy.py","commit_id":"ad32284755f5898c55960b285c2e3dfbc5aa5a4d"}],"openstack/tests/functional/baremetal/test_baremetal_volume_connector.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def test_volume_connector_create_get_delete(self):"},{"line_number":27,"context_line":"        volume_connector \u003d self.create_volume_connector("},{"line_number":28,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":29,"context_line":"            node_uuid\u003d\u00276d85703a-565d-469a-96ce-30b6de53079d\u0027,"},{"line_number":30,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        loaded \u003d self.conn.baremetal.get_volume_connector("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_ac605837","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":59},"updated":"2020-05-04 17:14:59.000000000","message":"use self.node.id","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_volume_connector_list(self):"},{"line_number":49,"context_line":"        node2 \u003d self.create_node(name\u003d\u0027test-node\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        vc1 \u003d self.create_volume_connector("},{"line_number":52,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":53,"context_line":"            node_id\u003dnode2.id)"},{"line_number":54,"context_line":"        vc2 \u003d self.create_volume_connector("},{"line_number":55,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4g\u0027,"},{"line_number":56,"context_line":"            node_id\u003dself.node.id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        vcs \u003d self.conn.baremetal.volume_connector("},{"line_number":59,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c5h\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_6cc81074","line":56,"range":{"start_line":51,"start_character":0,"end_line":56,"end_character":33},"updated":"2020-05-04 17:14:59.000000000","message":"you are missing a required parameter to create a volume connector (type, node_id, connector_id)","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            node_id\u003dself.node.id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        vcs \u003d self.conn.baremetal.volume_connector("},{"line_number":59,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c5h\u0027)"},{"line_number":60,"context_line":"        self.assertEqual([v.id for v in vcs], [vc2.id])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        vcs \u003d self.conn.baremetal.volume_connector(node\u003dnode2.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_4c73944e","line":59,"range":{"start_line":59,"start_character":26,"end_line":59,"end_character":67},"updated":"2020-05-04 17:14:59.000000000","message":"This connector_id doesn\u0027t exist in any of the volume connectors you created (vc1 or vc2) so the assertEqual below will fail you need to use \"iqn.2017-07.org.openstack:01:d9a51732c4g\"","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEqual([v.id for v in vcs], [vc1.id])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_volume_connector_list_update_delete(self):"},{"line_number":69,"context_line":"        self.create_volume_connector("},{"line_number":70,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":71,"context_line":"            extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":72,"context_line":"        volume_connector \u003d next(self.conn.baremetal.volume_connector("},{"line_number":73,"context_line":"            details\u003dTrue,"},{"line_number":74,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4h\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_acdb381f","line":71,"range":{"start_line":69,"start_character":8,"end_line":71,"end_character":33},"updated":"2020-05-04 17:14:59.000000000","message":"missing required parameters for the creation (type and node_uuid)","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":72,"context_line":"        volume_connector \u003d next(self.conn.baremetal.volume_connector("},{"line_number":73,"context_line":"            details\u003dTrue,"},{"line_number":74,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4h\u0027))"},{"line_number":75,"context_line":"        self.assertEqual(volume_connector.extra, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # This test checks that resources returned from listing are usable"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_0cf50c84","line":74,"range":{"start_line":74,"start_character":26,"end_line":74,"end_character":66},"updated":"2020-05-04 17:14:59.000000000","message":"here you need to use the use connector_id you used in the create_volume_connector before, since you are trying to find the same volume connector","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                    ignore_missing\u003dFalse)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_volume_connector_update(self):"},{"line_number":84,"context_line":"        volume_connector \u003d self.create_volume_connector("},{"line_number":85,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027)"},{"line_number":86,"context_line":"        volume_connector.extra \u003d {\u0027answer\u0027: 42}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_cf5dd6ea","line":84,"range":{"start_line":84,"start_character":32,"end_line":84,"end_character":55},"updated":"2020-05-04 17:14:59.000000000","message":"missing some required paramaters","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_volume_connector_patch(self):"},{"line_number":97,"context_line":"        volume_connector \u003d self.create_volume_connector()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        volume_connector \u003d self.conn.baremetal.patch_volume_connector("},{"line_number":100,"context_line":"            volume_connector, dict(path\u003d\u0027/extra/answer\u0027, op\u003d\u0027add\u0027, value\u003d42))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_cf7316b1","line":97,"range":{"start_line":97,"start_character":32,"end_line":97,"end_character":57},"updated":"2020-05-04 17:14:59.000000000","message":"You need to pass the required parameters.","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_volume_connector_patch(self):"},{"line_number":97,"context_line":"        volume_connector \u003d self.create_volume_connector()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        volume_connector \u003d self.conn.baremetal.patch_volume_connector("},{"line_number":100,"context_line":"            volume_connector, dict(path\u003d\u0027/extra/answer\u0027, op\u003d\u0027add\u0027, value\u003d42))"},{"line_number":101,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_efca529f","line":98,"updated":"2020-05-04 17:14:59.000000000","message":"You also need to override an attribute (I would do with connector_id)","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        volume_connector \u003d self.conn.baremetal.patch_volume_connector("},{"line_number":100,"context_line":"            volume_connector, dict(path\u003d\u0027/extra/answer\u0027, op\u003d\u0027add\u0027, value\u003d42))"},{"line_number":101,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        volume_connector \u003d self.conn.baremetal.get_volume_connector("},{"line_number":104,"context_line":"            volume_connector.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_6fbe4200","line":101,"updated":"2020-05-04 17:14:59.000000000","message":"add a new assertEqual to ensure that the connector_id was updated.","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f4fe1adfec560ec688a1dac85eaf764d935d144","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            volume_connector.id)"},{"line_number":105,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_volume_connector_negative_non_existing(self):"},{"line_number":108,"context_line":"        uuid \u003d \"5c9dcd04-2073-49bc-9618-99ae634d8971\""},{"line_number":109,"context_line":"        self.assertRaises(exceptions.ResourceNotFound,"},{"line_number":110,"context_line":"                          self.conn.baremetal.get_volume_connector, uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_6f53e2e3","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":51},"updated":"2020-05-04 17:14:59.000000000","message":"This should be ok after you add the missing find_volume_connector function.","commit_id":"1575c3ab3a5e5963702c866fd2a6f6aa4e5dce1d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def test_volume_connector_create_get_delete(self):"},{"line_number":27,"context_line":"        volume_connector \u003d self.create_volume_connector("},{"line_number":28,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":29,"context_line":"            node_uuid\u003dself.node.id,"},{"line_number":30,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        loaded \u003d self.conn.baremetal.get_volume_connector("}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_c46b6982","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":35},"updated":"2020-05-18 09:48:25.000000000","message":"node_uuid won\u0027t be required here, sorry. You can remove it.","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            node_id\u003dself.node.id,"},{"line_number":58,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        vcs \u003d self.conn.baremetal.volume_connector("},{"line_number":61,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4g\u0027)"},{"line_number":62,"context_line":"        self.assertEqual([v.id for v in vcs], [vc2.id])"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_8654d6ff","line":60,"range":{"start_line":60,"start_character":34,"end_line":60,"end_character":50},"updated":"2020-05-18 09:48:25.000000000","message":"should be volume_connectors","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4g\u0027)"},{"line_number":62,"context_line":"        self.assertEqual([v.id for v in vcs], [vc2.id])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        vcs \u003d self.conn.baremetal.volume_connector(node\u003dnode2.id)"},{"line_number":65,"context_line":"        self.assertEqual([v.id for v in vcs], [vc1.id])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        vcs \u003d self.conn.baremetal.volume_connector(node\u003d\u0027test-node\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_e62f9285","line":64,"range":{"start_line":64,"start_character":34,"end_line":64,"end_character":50},"updated":"2020-05-18 09:48:25.000000000","message":"should be volume_connectors","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        vcs \u003d self.conn.baremetal.volume_connector(node\u003dnode2.id)"},{"line_number":65,"context_line":"        self.assertEqual([v.id for v in vcs], [vc1.id])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        vcs \u003d self.conn.baremetal.volume_connector(node\u003d\u0027test-node\u0027)"},{"line_number":68,"context_line":"        self.assertEqual([v.id for v in vcs], [vc1.id])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_volume_connector_list_update_delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_c641ae3b","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":50},"updated":"2020-05-18 09:48:25.000000000","message":"should be volume_connectors","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            node_id\u003dself.node.id,"},{"line_number":74,"context_line":"            type\u003d\u0027iqn\u0027,"},{"line_number":75,"context_line":"            extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":76,"context_line":"        volume_connector \u003d next(self.conn.baremetal.volume_connector("},{"line_number":77,"context_line":"            details\u003dTrue,"},{"line_number":78,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027))"},{"line_number":79,"context_line":"        self.assertEqual(volume_connector.extra, {\u0027foo\u0027: \u0027bar\u0027})"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_a6675ae9","line":76,"range":{"start_line":76,"start_character":52,"end_line":76,"end_character":68},"updated":"2020-05-18 09:48:25.000000000","message":"should be volume_connectors","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            node_id\u003dself.node.id,"},{"line_number":91,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":92,"context_line":"        volume_connector.extra \u003d {\u0027answer\u0027: 42}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        volume_connector \u003d self.conn.baremetal.update_volume_connector("},{"line_number":95,"context_line":"            volume_connector)"},{"line_number":96,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_c9e70112","line":93,"updated":"2020-05-18 09:48:25.000000000","message":"It seems we will need to change the state of the node here so we can update.\nYou can try setting using \n\nself.conn.baremetal.set_node_provision_state(self.node,\u0027manage\u0027, wait\u003dTrue)","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4f\u0027,"},{"line_number":105,"context_line":"            node_id\u003dself.node.id,"},{"line_number":106,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        volume_connector \u003d self.conn.baremetal.patch_volume_connector("},{"line_number":109,"context_line":"            volume_connector, dict(path\u003d\u0027/extra/answer\u0027, op\u003d\u0027add\u0027, value\u003d42))"},{"line_number":110,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_e915a5e6","line":107,"updated":"2020-05-18 09:48:25.000000000","message":"It seems we will need to change the state of the node here so we can update.\nYou can try setting using \n\nself.conn.baremetal.set_node_provision_state(self.node,\u0027manage\u0027, wait\u003dTrue)","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e1d68bf262e1c2cbf6891fdeb04082cf25a3558f","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_volume_connector_fields(self):"},{"line_number":132,"context_line":"        self.create_node()"},{"line_number":133,"context_line":"        self.create_volume_connector("},{"line_number":134,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027)"},{"line_number":135,"context_line":"        result \u003d self.conn.baremetal.volume_connector("},{"line_number":136,"context_line":"            fields\u003d[\u0027uuid\u0027, \u0027node_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_a4fd95b2","line":133,"range":{"start_line":133,"start_character":13,"end_line":133,"end_character":36},"updated":"2020-05-18 09:48:25.000000000","message":"missing the type parameter in this test.","commit_id":"278381164f8497fd3586c3af1753b995aa9ba2a3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.assertIsNotNone(loaded.node_id)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        with_fields \u003d self.conn.baremetal.get_volume_connector("},{"line_number":37,"context_line":"            volume_connector.id, fields\u003d[\u0027uuid\u0027, \u0027extra\u0027, \u0027node_id\u0027])"},{"line_number":38,"context_line":"        self.assertEqual(volume_connector.id, with_fields.id)"},{"line_number":39,"context_line":"        self.assertIsNone(with_fields.node_id)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_d2a5dd48","line":37,"range":{"start_line":37,"start_character":58,"end_line":37,"end_character":67},"updated":"2020-05-18 20:15:04.000000000","message":"You can remove \u0027node_id\u0027 from the list since we are testing that we are not getting this value.","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        node2 \u003d self.create_node(name\u003d\u0027test-node\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        vc1 \u003d self.create_volume_connector("},{"line_number":51,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":52,"context_line":"            node_id\u003dnode2.id,"},{"line_number":53,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":54,"context_line":"        vc2 \u003d self.create_volume_connector("}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_d4066a1c","line":51,"range":{"start_line":51,"start_character":26,"end_line":51,"end_character":66},"updated":"2020-05-18 20:15:04.000000000","message":"Looking at the tests they are showing that the id is duplicated, so let\u0027s change here to \n\niqn.2018-07.org.openstack:01:d9a514g2c32","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_volume_connector_list_update_delete(self):"},{"line_number":70,"context_line":"        self.create_volume_connector("},{"line_number":71,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":72,"context_line":"            node_id\u003dself.node.id,"},{"line_number":73,"context_line":"            type\u003d\u0027iqn\u0027,"},{"line_number":74,"context_line":"            extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_541a5a6e","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":66},"updated":"2020-05-18 20:15:04.000000000","message":"Change to \niqn.2020-07.org.openstack:02:de451472ce2","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":75,"context_line":"        volume_connector \u003d next(self.conn.baremetal.volume_connectors("},{"line_number":76,"context_line":"            details\u003dTrue,"},{"line_number":77,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027))"},{"line_number":78,"context_line":"        self.assertEqual(volume_connector.extra, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # This test checks that resources returned from listing are usable"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_143d82c3","line":77,"range":{"start_line":77,"start_character":26,"end_line":77,"end_character":66},"updated":"2020-05-18 20:15:04.000000000","message":"Change to the same value \n\niqn.2020-07.org.openstack:02:de451472ce2\n\nSince this is for list.","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_volume_connector_update(self):"},{"line_number":87,"context_line":"        volume_connector \u003d self.create_volume_connector("},{"line_number":88,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":89,"context_line":"            node_id\u003dself.node.id,"},{"line_number":90,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":91,"context_line":"        volume_connector.extra \u003d {\u0027answer\u0027: 42}"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_b4593636","line":88,"range":{"start_line":88,"start_character":26,"end_line":88,"end_character":66},"updated":"2020-05-18 20:15:04.000000000","message":"Change to \n\niqn.2019-07.org.openstack:03:de45b472c40","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":91,"context_line":"        volume_connector.extra \u003d {\u0027answer\u0027: 42}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        volume_connector \u003d self.conn.baremetal.set_node_provision_state("},{"line_number":94,"context_line":"            self.node, \u0027manage\u0027, wait\u003dTrue)"},{"line_number":95,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        volume_connector \u003d self.conn.baremetal.get_volume_connector("}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_52854dce","line":94,"range":{"start_line":93,"start_character":8,"end_line":94,"end_character":43},"updated":"2020-05-18 20:15:04.000000000","message":"I should express myself better \u003d).\nWhen I said that we would need to change the state of the node I meant that we need to add a call for it, but you need to also keep the update_volume_connector call.\n\nself.conn.baremetal.set_node_provision_state(self.node,\u0027manage\u0027,wait\u003dTrue)\nvolume_connector \u003d self.conn.baremetal.update_volume_connector(\n            volume_connector)\n\nYou need both lines \u003d)","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_volume_connector_patch(self):"},{"line_number":102,"context_line":"        volume_connector \u003d self.create_volume_connector("},{"line_number":103,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4f\u0027,"},{"line_number":104,"context_line":"            node_id\u003dself.node.id,"},{"line_number":105,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_747cbe82","line":103,"range":{"start_line":103,"start_character":26,"end_line":103,"end_character":66},"updated":"2020-05-18 20:15:04.000000000","message":"Change to iqn.2020-07.org.openstack:04:de45b472c40","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            node_id\u003dself.node.id,"},{"line_number":105,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        volume_connector \u003d self.conn.baremetal.et_node_provision_state("},{"line_number":108,"context_line":"            self.node, \u0027manage\u0027, wait\u003dTrue)"},{"line_number":109,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":110,"context_line":"        self.assertEqual(\u0027iqn.2017-07.org.openstack:01:d9a51732c4f\u0027,"},{"line_number":111,"context_line":"                         volume_connector.connector_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_b256695b","line":108,"range":{"start_line":107,"start_character":7,"end_line":108,"end_character":43},"updated":"2020-05-18 20:15:04.000000000","message":"Here is the same case you need \n\nself.conn.baremetal.set_node_provision_state(self.node,\u0027manage\u0027,wait\u003dTrue)\nvolume_connector \u003d self.conn.baremetal.patch_volume_connector(\n            volume_connector, dict(path\u003d\u0027/extra/answer\u0027, op\u003d\u0027add\u0027, value\u003d42))","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        volume_connector \u003d self.conn.baremetal.et_node_provision_state("},{"line_number":108,"context_line":"            self.node, \u0027manage\u0027, wait\u003dTrue)"},{"line_number":109,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":110,"context_line":"        self.assertEqual(\u0027iqn.2017-07.org.openstack:01:d9a51732c4f\u0027,"},{"line_number":111,"context_line":"                         volume_connector.connector_id)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        volume_connector \u003d self.conn.baremetal.get_volume_connector("}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_b472d6ab","line":110,"range":{"start_line":110,"start_character":26,"end_line":110,"end_character":66},"updated":"2020-05-18 20:15:04.000000000","message":"Change to iqn.2020-07.org.openstack:04:de45b472c40","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            volume_connector.id)"},{"line_number":115,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_volume_connector_negative_non_existing(self):"},{"line_number":118,"context_line":"        uuid \u003d \"5c9dcd04-2073-49bc-9618-99ae634d8971\""},{"line_number":119,"context_line":"        self.assertRaises(exceptions.ResourceNotFound,"},{"line_number":120,"context_line":"                          self.conn.baremetal.get_volume_connector, uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_b23f8923","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":51},"updated":"2020-05-18 20:15:04.000000000","message":"This one is working \\o/ Awesome!","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def test_volume_connector_fields(self):"},{"line_number":131,"context_line":"        self.create_node()"},{"line_number":132,"context_line":"        self.create_volume_connector("},{"line_number":133,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":134,"context_line":"            node_id\u003dself.node.id,"},{"line_number":135,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":136,"context_line":"        result \u003d self.conn.baremetal.volume_connector("}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_5461bad2","line":133,"range":{"start_line":133,"start_character":26,"end_line":133,"end_character":66},"updated":"2020-05-18 20:15:04.000000000","message":"Change to iqn.2018-08.org.openstack:04:de45f372c48","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"961a09c3f76ea3bbf43f79753472985ba12dadf7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":134,"context_line":"            node_id\u003dself.node.id,"},{"line_number":135,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":136,"context_line":"        result \u003d self.conn.baremetal.volume_connector("},{"line_number":137,"context_line":"            fields\u003d[\u0027uuid\u0027, \u0027node_id\u0027])"},{"line_number":138,"context_line":"        for item in result:"},{"line_number":139,"context_line":"            self.assertIsNotNone(item.id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_d242fdaa","line":136,"range":{"start_line":136,"start_character":37,"end_line":136,"end_character":53},"updated":"2020-05-18 20:15:04.000000000","message":"volume_connectors","commit_id":"df2b193c72669e71881217f185339dd7774c1b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9b188c80c29dc2714350dd12cb0e535b2e94d384","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.node \u003d self.create_node()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_volume_connector_create_get_delete(self):"},{"line_number":27,"context_line":"        volume_connector \u003d self.create_volume_connector("},{"line_number":28,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c3f\u0027,"},{"line_number":29,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_1510cea7","line":27,"updated":"2020-05-19 14:47:20.000000000","message":"add \nself.conn.baremetal.set_node_provision_state(\n            self.node, \u0027manage\u0027, wait\u003dTrue)\nbefore creating the connector.","commit_id":"57aabc3c14b88b57b54935720452fdc08f2bb855"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9b188c80c29dc2714350dd12cb0e535b2e94d384","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":91,"context_line":"        volume_connector.extra \u003d {\u0027answer\u0027: 42}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self.conn.baremetal.set_node_provision_state("},{"line_number":94,"context_line":"            self.node, \u0027manage\u0027, wait\u003dTrue)"},{"line_number":95,"context_line":"        volume_connector \u003d self.conn.baremetal.update_volume_connector("},{"line_number":96,"context_line":"            volume_connector)"},{"line_number":97,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_55c9a656","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":43},"updated":"2020-05-19 14:47:20.000000000","message":"So, I was talking with the ironic-cores, seems that this need\u0027s to be the called before creating the volume connector \u003d)","commit_id":"57aabc3c14b88b57b54935720452fdc08f2bb855"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9b188c80c29dc2714350dd12cb0e535b2e94d384","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            node_id\u003dself.node.id,"},{"line_number":107,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        self.conn.baremetal.set_node_provision_state("},{"line_number":110,"context_line":"            self.node, \u0027manage\u0027, wait\u003dTrue)"},{"line_number":111,"context_line":"        volume_connector \u003d self.conn.baremetal.update_volume_connector("},{"line_number":112,"context_line":"            volume_connector)"},{"line_number":113,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_55cec659","line":110,"range":{"start_line":109,"start_character":6,"end_line":110,"end_character":43},"updated":"2020-05-19 14:47:20.000000000","message":"this needs to be called before creating the volume connector.","commit_id":"57aabc3c14b88b57b54935720452fdc08f2bb855"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9b188c80c29dc2714350dd12cb0e535b2e94d384","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertIsNone(self.conn.baremetal.delete_volume_connector(uuid))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_volume_connector_fields(self):"},{"line_number":135,"context_line":"        self.create_node()"},{"line_number":136,"context_line":"        self.create_volume_connector("},{"line_number":137,"context_line":"            connector_id\u003d\u0027iqn.2018-08.org.openstack:04:de45f37c48\u0027,"},{"line_number":138,"context_line":"            node_id\u003dself.node.id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_f5643a4c","line":135,"updated":"2020-05-19 14:47:20.000000000","message":"add \n\nself.conn.baremetal.set_node_provision_state(\n            self.node, \u0027manage\u0027, wait\u003dTrue)\n\n\nafter self.create_node()","commit_id":"57aabc3c14b88b57b54935720452fdc08f2bb855"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b1eb3b2db196ae6fd220a5f4c745b3add79834d0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          self.conn.baremetal.get_volume_connector,"},{"line_number":49,"context_line":"                          volume_connector.id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_volume_connector_list(self):"},{"line_number":52,"context_line":"        node2 \u003d self.create_node(name\u003d\u0027test-node\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        vc1 \u003d self.create_volume_connector("}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_77f5ae56","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":34},"updated":"2020-05-20 17:27:26.000000000","message":"please also add set_node_provision_state and set_node_power_state \n\nHere you need to do for self.node and for node2. you can add the lines after you do the creation of node2 and before the vc1","commit_id":"0e330fc45cc4209ab446dc397c1906b5143f8914"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b1eb3b2db196ae6fd220a5f4c745b3add79834d0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        vcs \u003d self.conn.baremetal.volume_connectors("},{"line_number":64,"context_line":"            connector_id\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4g\u0027)"},{"line_number":65,"context_line":"        self.assertEqual([v.id for v in vcs], [vc2.id])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        vcs \u003d self.conn.baremetal.volume_connectors(node\u003dnode2.id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_14dd50df","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":24},"updated":"2020-05-20 17:27:26.000000000","message":"change connector_id to node and the value you can use self.node.id","commit_id":"0e330fc45cc4209ab446dc397c1906b5143f8914"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b1eb3b2db196ae6fd220a5f4c745b3add79834d0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        vcs \u003d self.conn.baremetal.volume_connectors(node\u003d\u0027test-node\u0027)"},{"line_number":71,"context_line":"        self.assertEqual([v.id for v in vcs], [vc1.id])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_volume_connector_list_update_delete(self):"},{"line_number":74,"context_line":"        self.create_volume_connector("},{"line_number":75,"context_line":"            connector_id\u003d\u0027iqn.2020-07.org.openstack:02:d9451472ce2\u0027,"},{"line_number":76,"context_line":"            node_id\u003dself.node.id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_d75aba80","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":48},"updated":"2020-05-20 17:27:26.000000000","message":"please also add the set_node_provision_state and set_node_power_state in this test.","commit_id":"0e330fc45cc4209ab446dc397c1906b5143f8914"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b1eb3b2db196ae6fd220a5f4c745b3add79834d0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":79,"context_line":"        volume_connector \u003d next(self.conn.baremetal.volume_connectors("},{"line_number":80,"context_line":"            details\u003dTrue,"},{"line_number":81,"context_line":"            connector_id\u003d\u0027iqn.2020-07.org.openstack:02:d9451472ce2\u0027))"},{"line_number":82,"context_line":"        self.assertEqual(volume_connector.extra, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # This test checks that resources returned from listing are usable"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_94f2006f","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":24},"updated":"2020-05-20 17:27:26.000000000","message":"change to node and the value to self.node.id","commit_id":"0e330fc45cc4209ab446dc397c1906b5143f8914"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d782a12330d65817e3ca88857fbe4e80d534fd4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          volume_connector.id)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_volume_connector_list(self):"},{"line_number":51,"context_line":"        node2 \u003d self.node(name\u003d\u0027test-node\u0027)"},{"line_number":52,"context_line":"        self.conn.baremetal.set_node_provision_state("},{"line_number":53,"context_line":"            self.node, \u0027manage\u0027, wait\u003dTrue)"},{"line_number":54,"context_line":"        self.conn.baremetal.set_node_power_state(self.node, \u0027power off\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_cda5f0a0","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":43},"updated":"2020-05-21 18:30:51.000000000","message":"why you changed this? O.o\nit should be self.create_node(name\u003d\u0027test-node\u0027)\n\nPlease add the calls to move node2 to manage and to power off","commit_id":"d0f14144c86554da38f54407770ff21b54c4c932"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d782a12330d65817e3ca88857fbe4e80d534fd4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        vcs \u003d self.conn.baremetal.volume_connectors("},{"line_number":65,"context_line":"            node\u003d\u0027iqn.2017-07.org.openstack:01:d9a51732c4g\u0027)"},{"line_number":66,"context_line":"        self.assertEqual([v.id for v in vcs], [vc2.id])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        vcs \u003d self.conn.baremetal.volume_connectors(node\u003dnode2.id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_8dc81855","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":58},"updated":"2020-05-21 18:30:51.000000000","message":"You forgot to change the value here.","commit_id":"d0f14144c86554da38f54407770ff21b54c4c932"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d782a12330d65817e3ca88857fbe4e80d534fd4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":83,"context_line":"        volume_connector \u003d next(self.conn.baremetal.volume_connectors("},{"line_number":84,"context_line":"            details\u003dTrue,"},{"line_number":85,"context_line":"            node\u003d\u0027iqn.2020-07.org.openstack:02:d9451472ce2\u0027))"},{"line_number":86,"context_line":"        self.assertEqual(volume_connector.extra, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # This test checks that resources returned from listing are usable"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_0d8fe829","line":85,"range":{"start_line":85,"start_character":18,"end_line":85,"end_character":58},"updated":"2020-05-21 18:30:51.000000000","message":"you changed to node but you forgot to change the value (check my old comment)","commit_id":"d0f14144c86554da38f54407770ff21b54c4c932"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d782a12330d65817e3ca88857fbe4e80d534fd4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            node_id\u003dself.node.id,"},{"line_number":119,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        volume_connector \u003d self.conn.baremetal.update_volume_connector("},{"line_number":122,"context_line":"            volume_connector)"},{"line_number":123,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":124,"context_line":"        self.assertEqual(\u0027iqn.2020-07.org.openstack:04:de45b47c40\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_6ddb044e","line":121,"range":{"start_line":121,"start_character":47,"end_line":121,"end_character":70},"updated":"2020-05-21 18:30:51.000000000","message":"Here you should call patch_volume_connector, take a look at the functional test for patch port [1]\n\nIt\u0027s the same idea \n\n[1] https://github.com/openstack/openstacksdk/blob/master/openstack/tests/functional/baremetal/test_baremetal_port.py#L90-L91","commit_id":"d0f14144c86554da38f54407770ff21b54c4c932"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d782a12330d65817e3ca88857fbe4e80d534fd4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def test_volume_connector_fields(self):"},{"line_number":145,"context_line":"        self.create_node()"},{"line_number":146,"context_line":"        self.conn.baremetal.set_node_provision_state("},{"line_number":147,"context_line":"            self.node, \u0027manage\u0027, wait\u003dTrue)"},{"line_number":148,"context_line":"        self.create_volume_connector("},{"line_number":149,"context_line":"            connector_id\u003d\u0027iqn.2018-08.org.openstack:04:de45f37c48\u0027,"},{"line_number":150,"context_line":"            node_id\u003dself.node.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_8dc2d883","line":147,"updated":"2020-05-21 18:30:51.000000000","message":"Need to add a call to set the node to power of in this test.","commit_id":"d0f14144c86554da38f54407770ff21b54c4c932"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"08c5a36388f2714e74480802034d802d27eadecc","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            node_id\u003dself.node.id,"},{"line_number":84,"context_line":"            type\u003d\u0027iqn\u0027,"},{"line_number":85,"context_line":"            extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":86,"context_line":"        volume_connector \u003d next(self.conn.baremetal.volume_connectors("},{"line_number":87,"context_line":"            details\u003dTrue,"},{"line_number":88,"context_line":"            node\u003dself.node.id))"},{"line_number":89,"context_line":"        self.assertEqual(volume_connector.extra, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # This test checks that resources returned from listing are usable"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_64564c09","line":88,"range":{"start_line":86,"start_character":8,"end_line":88,"end_character":31},"updated":"2020-05-26 07:50:38.000000000","message":"I\u0027m trying to figure out why this tests fails with \"Invalid input for field/attribute connector_uuid. Value: \u0027detail\u0027. unable to convert to uuid. Error: Expected a UUID but received detail.\n\" \n\n@Riccardo, @Dmitry do you have any ideas?","commit_id":"8cbf7c4624d71a2738fa0673a2b6acbc146ddd43"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"08c5a36388f2714e74480802034d802d27eadecc","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            node_id\u003dself.node.id,"},{"line_number":122,"context_line":"            type\u003d\u0027iqn\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        volume_connector \u003d self.conn.baremetal.patch_volume_connector("},{"line_number":125,"context_line":"            volume_connector)"},{"line_number":126,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027iqn.2020-07.org.openstack:04:de45b47c40\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_a2c177e7","line":124,"range":{"start_line":124,"start_character":47,"end_line":124,"end_character":69},"updated":"2020-05-26 07:50:38.000000000","message":"For patch_volume_connector you need to provide two arguments, you only provided one.","commit_id":"8cbf7c4624d71a2738fa0673a2b6acbc146ddd43"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ffb261c1fa09212a8ee483d94a865a8e260fe5a8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        volume_connector \u003d self.conn.baremetal.patch_volume_connector("},{"line_number":125,"context_line":"            volume_connector, dict(path\u003d\u0027/extra/answer\u0027, op\u003d\u0027add\u0027, value\u003d42))"},{"line_number":126,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027iqn.2020-07.org.openstack:04:de45b47c40\u0027,"},{"line_number":128,"context_line":"                         volume_connector.connector_id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        volume_connector \u003d self.conn.baremetal.get_volume_connector("}],"source_content_type":"text/x-python","patch_set":12,"id":"ff570b3c_f5d15d31","line":127,"range":{"start_line":127,"start_character":26,"end_line":127,"end_character":65},"updated":"2020-05-26 18:52:33.000000000","message":"there is one missing character here so the assert failed","commit_id":"0c719e72e00f4385fbf4c2a65510f64e4bdbd230"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"4825281ad4d4888c6cf59068032334860cd48b34","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        volume_connector \u003d self.conn.baremetal.patch_volume_connector("},{"line_number":125,"context_line":"            volume_connector, dict(path\u003d\u0027/extra/answer\u0027, op\u003d\u0027add\u0027, value\u003d42))"},{"line_number":126,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, volume_connector.extra)"},{"line_number":127,"context_line":"        self.assertEqual(\u0027iqn.2020-07.org.openstack:04:de45b47c40\u0027,"},{"line_number":128,"context_line":"                         volume_connector.connector_id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        volume_connector \u003d self.conn.baremetal.get_volume_connector("}],"source_content_type":"text/x-python","patch_set":12,"id":"ff570b3c_161b261b","line":127,"range":{"start_line":127,"start_character":26,"end_line":127,"end_character":65},"in_reply_to":"ff570b3c_f5d15d31","updated":"2020-05-27 15:04:59.000000000","message":"It could be worth to store this kind of value into a var to avoid this kind of issue and to use it on creation and asserts. Same remark for the previous tests with the same logic of tests.","commit_id":"0c719e72e00f4385fbf4c2a65510f64e4bdbd230"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ceb3ce075a2eadf0528baf1944ba40edb9affc1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.assertEqual([v.id for v in vcs], [vc1.id])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        vcs \u003d self.conn.baremetal.volume_connectors(node\u003d\u0027test-node\u0027)"},{"line_number":75,"context_line":"        self.assertEqual([v.id for v in vcs], [vc1.id])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_volume_connector_list_update_delete(self):"},{"line_number":78,"context_line":"        self.conn.baremetal.set_node_provision_state("}],"source_content_type":"text/x-python","patch_set":17,"id":"bf51134e_66b517ee","line":75,"updated":"2020-06-25 12:23:09.000000000","message":"Let\u0027s also test the details argument.","commit_id":"0d691f78e12798f56ecad4588554e4da769b50e4"}],"openstack/tests/functional/baremetal/test_baremetal_volume_connectors.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.node \u003d self.create_node()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_volume_connectors_create_get_delete(self):"},{"line_number":27,"context_line":"        volume_connectors \u003d self.create_volume_connectors()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        loaded \u003d self.conn.baremetal.get_volume_connectors("},{"line_number":30,"context_line":"            volume_connectors.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_91ff4300","line":27,"updated":"2020-04-15 20:11:20.000000000","message":"you need to pass parameters to create a volume connector no?","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def test_port_list(self):"},{"line_number":46,"context_line":"        node2 \u003d self.create_node(name\u003d\u0027test-node\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        pg1 \u003d self.create_volume_connectors(address\u003d\u002711:22:33:44:55:66\u0027,"},{"line_number":49,"context_line":"                                            node_id\u003dnode2.id)"},{"line_number":50,"context_line":"        pg2 \u003d self.create_volume_connectors(address\u003d\u002711:22:33:44:55:77\u0027,"},{"line_number":51,"context_line":"                                            node_id\u003dself.node.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_719ef7b8","line":48,"range":{"start_line":48,"start_character":44,"end_line":48,"end_character":51},"updated":"2020-04-15 20:11:20.000000000","message":"Are you sure this is one of the parameters?","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        pg1 \u003d self.create_volume_connectors(address\u003d\u002711:22:33:44:55:66\u0027,"},{"line_number":49,"context_line":"                                            node_id\u003dnode2.id)"},{"line_number":50,"context_line":"        pg2 \u003d self.create_volume_connectors(address\u003d\u002711:22:33:44:55:77\u0027,"},{"line_number":51,"context_line":"                                            node_id\u003dself.node.id)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        pgs \u003d self.conn.baremetal.volume_connectors("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_51b93b2c","line":50,"range":{"start_line":50,"start_character":44,"end_line":50,"end_character":51},"updated":"2020-04-15 20:11:20.000000000","message":"same from above","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        pg2 \u003d self.create_volume_connectors(address\u003d\u002711:22:33:44:55:77\u0027,"},{"line_number":51,"context_line":"                                            node_id\u003dself.node.id)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        pgs \u003d self.conn.baremetal.volume_connectors("},{"line_number":54,"context_line":"            address\u003d\u002711:22:33:44:55:77\u0027)"},{"line_number":55,"context_line":"        self.assertEqual([p.id for p in pgs], [pg2.id])"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_71871763","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":11},"updated":"2020-04-15 20:11:20.000000000","message":"the name of the variable is a bit strange to me, what is the meaning of pgs?","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                            node_id\u003dself.node.id)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        pgs \u003d self.conn.baremetal.volume_connectors("},{"line_number":54,"context_line":"            address\u003d\u002711:22:33:44:55:77\u0027)"},{"line_number":55,"context_line":"        self.assertEqual([p.id for p in pgs], [pg2.id])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        pgs \u003d self.conn.baremetal.volume_connectors(node\u003dnode2.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_d17eeb69","line":54,"range":{"start_line":54,"start_character":12,"end_line":54,"end_character":19},"updated":"2020-04-15 20:11:20.000000000","message":"address?","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.assertEqual([p.id for p in pgs], [pg1.id])"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_port_list_update_delete(self):"},{"line_number":64,"context_line":"        self.create_volume_connectors(address\u003d\u002711:22:33:44:55:66\u0027,"},{"line_number":65,"context_line":"                                      extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":66,"context_line":"        volume_connectors \u003d next(self.conn.baremetal.volume_connectors("},{"line_number":67,"context_line":"            details\u003dTrue, address\u003d\u002711:22:33:44:55:66\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_f192079f","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":45},"updated":"2020-04-15 20:11:20.000000000","message":"address?","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.create_volume_connectors(address\u003d\u002711:22:33:44:55:66\u0027,"},{"line_number":65,"context_line":"                                      extra\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":66,"context_line":"        volume_connectors \u003d next(self.conn.baremetal.volume_connectors("},{"line_number":67,"context_line":"            details\u003dTrue, address\u003d\u002711:22:33:44:55:66\u0027))"},{"line_number":68,"context_line":"        self.assertEqual(volume_connectors.extra, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # This test checks that resources returned from listing are usable"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_5192db9f","line":67,"range":{"start_line":67,"start_character":26,"end_line":67,"end_character":33},"updated":"2020-04-15 20:11:20.000000000","message":"same","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                                     ignore_missing\u003dFalse)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_volume_connectors_update(self):"},{"line_number":77,"context_line":"        volume_connectors \u003d self.create_volume_connectors()"},{"line_number":78,"context_line":"        volume_connectors.extra \u003d {\u0027answer\u0027: 42}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        volume_connectors \u003d self.conn.baremetal.update_volume_connectors("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_51e77b41","line":77,"range":{"start_line":77,"start_character":57,"end_line":77,"end_character":59},"updated":"2020-04-15 20:11:20.000000000","message":"don\u0027t you need  some specific parameters to initialize a volume connector?","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff95d7d033179b9d3b8650d1ec9a9a7a5508ead0","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_volume_connectors_update(self):"},{"line_number":77,"context_line":"        volume_connectors \u003d self.create_volume_connectors()"},{"line_number":78,"context_line":"        volume_connectors.extra \u003d {\u0027answer\u0027: 42}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        volume_connectors \u003d self.conn.baremetal.update_volume_connectors("},{"line_number":81,"context_line":"            volume_connectors)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_71d55743","line":78,"updated":"2020-04-15 20:11:20.000000000","message":"I would expect an update of other parameters also \u003d)","commit_id":"027b1e81024bc5be112b986e0014c89a1184b85f"}]}