)]}'
{"openstack/cloud/_baremetal.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c004dbb3b6e498e28f850f3c58505f992482ce63","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        else:"},{"line_number":326,"context_line":"            return machine"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def unregister_machine(self, nics, uuid, wait\u003dNone, timeout\u003d600):"},{"line_number":329,"context_line":"        \"\"\"Unregister Baremetal from Ironic"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        Removes entries for Network Interfaces and baremetal nodes"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e45d1816","line":328,"range":{"start_line":328,"start_character":45,"end_line":328,"end_character":56},"updated":"2020-05-27 16:17:10.000000000","message":"What do you think about deprecate this one by using debtcollector by using something like:\n\n```\nfrom debtcollector import removals\n...\n@removals.removed_kwarg(\u0027wait\u0027, message\u003d\"Please stop to use this argument it will be removed blablabla\")\n```","commit_id":"b1ec4174e76d5876e17749a6dabb07cc4e919c32"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7f89170939a1c7ad2e271d52bc5688fa92cebf41","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        else:"},{"line_number":326,"context_line":"            return machine"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def unregister_machine(self, nics, uuid, wait\u003dNone, timeout\u003d600):"},{"line_number":329,"context_line":"        \"\"\"Unregister Baremetal from Ironic"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        Removes entries for Network Interfaces and baremetal nodes"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_b32d05ff","line":328,"range":{"start_line":328,"start_character":45,"end_line":328,"end_character":56},"in_reply_to":"ff570b3c_4d87b910","updated":"2020-05-29 08:37:42.000000000","message":"As you want, your current code LGTM anyway.","commit_id":"b1ec4174e76d5876e17749a6dabb07cc4e919c32"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"288fd43c7f970745bafa879de396a8a0aa39b218","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        else:"},{"line_number":326,"context_line":"            return machine"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def unregister_machine(self, nics, uuid, wait\u003dNone, timeout\u003d600):"},{"line_number":329,"context_line":"        \"\"\"Unregister Baremetal from Ironic"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        Removes entries for Network Interfaces and baremetal nodes"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_4d87b910","line":328,"range":{"start_line":328,"start_character":45,"end_line":328,"end_character":56},"in_reply_to":"ff570b3c_e45d1816","updated":"2020-05-28 11:42:02.000000000","message":"I\u0027m a bit uneasy about adding a new dependency for something that is a pretty basic Python snippet.","commit_id":"b1ec4174e76d5876e17749a6dabb07cc4e919c32"}],"openstack/tests/unit/cloud/test_baremetal_node.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c004dbb3b6e498e28f850f3c58505f992482ce63","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"                method\u003d\u0027GET\u0027,"},{"line_number":1495,"context_line":"                uri\u003dself.get_mock_url("},{"line_number":1496,"context_line":"                    resource\u003d\u0027ports\u0027,"},{"line_number":1497,"context_line":"                    qs_elements\u003d[\u0027address\u003d%s\u0027 % mac_address]),"},{"line_number":1498,"context_line":"                json\u003d{\u0027ports\u0027: [{\u0027address\u0027: mac_address,"},{"line_number":1499,"context_line":"                                 \u0027node_uuid\u0027: port_node_uuid,"},{"line_number":1500,"context_line":"                                 \u0027uuid\u0027: port_uuid}]}),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_64a7480d","line":1497,"range":{"start_line":1497,"start_character":20,"end_line":1497,"end_character":31},"updated":"2020-05-27 16:17:10.000000000","message":"Not sure to understand why you renamed this one.","commit_id":"b1ec4174e76d5876e17749a6dabb07cc4e919c32"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d3b35cf4c9abd036884c1fc2e29de45a0d2382e4","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"                method\u003d\u0027GET\u0027,"},{"line_number":1495,"context_line":"                uri\u003dself.get_mock_url("},{"line_number":1496,"context_line":"                    resource\u003d\u0027ports\u0027,"},{"line_number":1497,"context_line":"                    qs_elements\u003d[\u0027address\u003d%s\u0027 % mac_address]),"},{"line_number":1498,"context_line":"                json\u003d{\u0027ports\u0027: [{\u0027address\u0027: mac_address,"},{"line_number":1499,"context_line":"                                 \u0027node_uuid\u0027: port_node_uuid,"},{"line_number":1500,"context_line":"                                 \u0027uuid\u0027: port_uuid}]}),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a4c5e03f","line":1497,"range":{"start_line":1497,"start_character":20,"end_line":1497,"end_character":31},"in_reply_to":"ff570b3c_64a7480d","updated":"2020-05-27 16:34:54.000000000","message":"append doesn\u0027t work the way we need here now that \"detail\" is no longer used","commit_id":"b1ec4174e76d5876e17749a6dabb07cc4e919c32"}]}