)]}'
{"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a94a81f0b0b56b85a2fc2d41795e752445eb2ab0","unresolved":false,"context_lines":[{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"    def _service_cleanup(self, dry_run\u003dTrue, status_queue\u003dNone):"},{"line_number":1484,"context_line":"        for obj in self.servers():"},{"line_number":1485,"context_line":"            if status_queue:"},{"line_number":1486,"context_line":"                status_queue.put(obj)"},{"line_number":1487,"context_line":"            if not dry_run:"},{"line_number":1488,"context_line":"                self.delete_server(obj)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_b4e0c0fa","line":1488,"range":{"start_line":1485,"start_character":12,"end_line":1488,"end_character":39},"updated":"2020-06-08 11:40:39.000000000","message":"Why not continue to call `_service_cleanup_del_res` by passing `self.delete_server` as the function to call?\n\nExample:\n```\nself._service_cleanup_del_res(self.delete_server,\n                              obj,\n                              dry_run,\n                              status_queue)\n```\n\nI mean here you duplicate the logic and also you don\u0027t handle the SDKException so it will bubble up to caller of `_service_cleanup` and we don\u0027t get the related error log  that we write when something went wrong.\n\nI think we should keep the previous version and just remove the code related to keypairs removing there.","commit_id":"ff40b22aae165e036bf9b81f949179e8384168e4"}]}