)]}'
{"openstack/resource.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d8d15427b8d5601616ae4247f87a94e0700e132a","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"        :param session: The session to use for making this request."},{"line_number":1907,"context_line":"        :param list tags: List with tags to be set on the resource"},{"line_number":1908,"context_line":"        \"\"\""},{"line_number":1909,"context_line":"        tags \u003d tags or None"},{"line_number":1910,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027tags\u0027)"},{"line_number":1911,"context_line":"        session \u003d self._get_session(session)"},{"line_number":1912,"context_line":"        response \u003d session.put(url, json\u003d{\u0027tags\u0027: tags})"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_3154ad54","line":1909,"range":{"start_line":1909,"start_character":8,"end_line":1909,"end_character":27},"updated":"2020-07-01 10:08:39.000000000","message":"`tags` is already init by default with `None` so I don\u0027t think this line is needed.\n\nThoughts?","commit_id":"42d202493fec2a89df88c260ca02ea693db72b11"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c00e14362ed283cc324d57e877f273b4d493666","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"        :param session: The session to use for making this request."},{"line_number":1907,"context_line":"        :param list tags: List with tags to be set on the resource"},{"line_number":1908,"context_line":"        \"\"\""},{"line_number":1909,"context_line":"        tags \u003d tags or None"},{"line_number":1910,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027tags\u0027)"},{"line_number":1911,"context_line":"        session \u003d self._get_session(session)"},{"line_number":1912,"context_line":"        response \u003d session.put(url, json\u003d{\u0027tags\u0027: tags})"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_5c5b1453","line":1909,"range":{"start_line":1909,"start_character":8,"end_line":1909,"end_character":27},"in_reply_to":"bf51134e_3154ad54","updated":"2020-07-03 12:54:51.000000000","message":"This actually must be\n\ntags \u003d tags or []\n\nin order to match the previous behaviour. See also the test failures e.g. https://51c2eadcae50d4ed72de-5ad940f899c2efbeec7ada457cff5516.ssl.cf1.rackcdn.com/738041/3/check/openstacksdk-functional-devstack/45cc763/testr_results.html","commit_id":"42d202493fec2a89df88c260ca02ea693db72b11"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"5e28c2140a5b6155076986081b41affecb8cc972","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"        :param session: The session to use for making this request."},{"line_number":1907,"context_line":"        :param list tags: List with tags to be set on the resource"},{"line_number":1908,"context_line":"        \"\"\""},{"line_number":1909,"context_line":"        tags \u003d tags or None"},{"line_number":1910,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027tags\u0027)"},{"line_number":1911,"context_line":"        session \u003d self._get_session(session)"},{"line_number":1912,"context_line":"        response \u003d session.put(url, json\u003d{\u0027tags\u0027: tags})"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_b65fdde3","line":1909,"range":{"start_line":1909,"start_character":8,"end_line":1909,"end_character":27},"in_reply_to":"bf51134e_5c5b1453","updated":"2020-07-06 10:18:30.000000000","message":"You\u0027re right","commit_id":"42d202493fec2a89df88c260ca02ea693db72b11"}],"tox.ini":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c00e14362ed283cc324d57e877f273b4d493666","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    sphinx-build -a -E -W -d releasenotes/build/doctrees --keep-going -b html releasenotes/source releasenotes/build/html"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"[flake8]"},{"line_number":110,"context_line":"select \u003d E,F,W,H,O,B,B9"},{"line_number":111,"context_line":"# The following are ignored on purpose. It\u0027s not super worth it to fix them."},{"line_number":112,"context_line":"# However, if you feel strongly about it, patches will be accepted to fix them"},{"line_number":113,"context_line":"# if they fix ALL of the occurances of one and only one of them."}],"source_content_type":"text/x-properties","patch_set":3,"id":"bf51134e_5c2034b1","line":110,"range":{"start_line":110,"start_character":19,"end_line":110,"end_character":23},"updated":"2020-07-03 12:54:51.000000000","message":"Isn\u0027t that redundant?","commit_id":"42d202493fec2a89df88c260ca02ea693db72b11"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c00e14362ed283cc324d57e877f273b4d493666","unresolved":false,"context_lines":[{"line_number":111,"context_line":"# The following are ignored on purpose. It\u0027s not super worth it to fix them."},{"line_number":112,"context_line":"# However, if you feel strongly about it, patches will be accepted to fix them"},{"line_number":113,"context_line":"# if they fix ALL of the occurances of one and only one of them."},{"line_number":114,"context_line":"# H203,H210 Optional warnings turned on by the select line"},{"line_number":115,"context_line":"# H238 New Style Classes are the default in Python3"},{"line_number":116,"context_line":"# H306 Is about alphabetical imports - there\u0027s a lot to fix."},{"line_number":117,"context_line":"# H4 Are about docstrings and there\u0027s just a huge pile of pre-existing issues."}],"source_content_type":"text/x-properties","patch_set":3,"id":"bf51134e_fc182885","line":114,"updated":"2020-07-03 12:54:51.000000000","message":"I\u0027d rather like to see the specifics about these warnings here.","commit_id":"42d202493fec2a89df88c260ca02ea693db72b11"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c00e14362ed283cc324d57e877f273b4d493666","unresolved":false,"context_lines":[{"line_number":119,"context_line":"#      Also, both openstacksdk and Donald Knuth disagree with the rule. Line"},{"line_number":120,"context_line":"#      breaks should occur before the binary operator for readability."},{"line_number":121,"context_line":"# B950 Don\u0027t care about bugbear\u0027s line length check"},{"line_number":122,"context_line":"ignore \u003d H238,H203,H210,H306,H4,W503,B903,B950"},{"line_number":123,"context_line":"show-source \u003d True"},{"line_number":124,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,openstack/_services_mixin.py"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"bf51134e_f7fde108","line":122,"range":{"start_line":122,"start_character":14,"end_line":122,"end_character":23},"updated":"2020-07-03 12:54:51.000000000","message":"These should go in front of H238","commit_id":"42d202493fec2a89df88c260ca02ea693db72b11"}]}
