)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc490bbeaaf6db740923c7e32cc0237fc970226","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compute 2.6 added the ceate console API [1], and 2.8 added the \u0027mks\u0027"},{"line_number":10,"context_line":"and \u0027webmks\u0027 console types [2]. Since we don\u0027t do client-side"},{"line_number":11,"context_line":"parameter validation, we get 2.8 for free when implementing support"},{"line_number":12,"context_line":"for 2.6."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://docs.openstack.org/api-ref/compute/?expanded\u003dcreate-console-detail#server-consoles"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_ca43fa12","line":11,"updated":"2020-07-19 15:34:06.000000000","message":"How does it work if remote_console hardcodes 2.6? Won\u0027t 2.8 features be rejected on the server side?","commit_id":"19b0b4b02a93525d5659427ceea395100695dc21"}],"openstack/compute/v2/server.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc490bbeaaf6db740923c7e32cc0237fc970226","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        return self"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def remote_console(self, session, protocol, type):"},{"line_number":557,"context_line":"        microversion \u003d \u00272.6\u0027"},{"line_number":558,"context_line":"        if not utils.supports_microversion(session, microversion):"},{"line_number":559,"context_line":"            raise exceptions.NotSupported(\u0027Compute microversion 2.6 is not \u0027"},{"line_number":560,"context_line":"                                          \u0027supported by this cloud.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2a48b62c","line":557,"updated":"2020-07-19 15:34:06.000000000","message":"I think you need 2.8 depending on the type (at least that\u0027s how I read your commit message)","commit_id":"19b0b4b02a93525d5659427ceea395100695dc21"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9aed9d27e8ed7126b9638d95c3acfd5f07ebfa15","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        return self"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def remote_console(self, session, protocol, type):"},{"line_number":557,"context_line":"        microversion \u003d \u00272.6\u0027"},{"line_number":558,"context_line":"        if not utils.supports_microversion(session, microversion):"},{"line_number":559,"context_line":"            raise exceptions.NotSupported(\u0027Compute microversion 2.6 is not \u0027"},{"line_number":560,"context_line":"                                          \u0027supported by this cloud.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9c4f6c33","line":557,"in_reply_to":"bf51134e_2a48b62c","updated":"2020-07-21 19:37:17.000000000","message":"Yep, nice catch!","commit_id":"19b0b4b02a93525d5659427ceea395100695dc21"}]}