)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b72d93fcf032b6dd4d96fd8ebdad32db606e5f22","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compute microversion 2.9 added the `is_locked` parameter in the"},{"line_number":10,"context_line":"response of server detail, server update, and the server reduild"},{"line_number":11,"context_line":"action. This patch a functional test to verify this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: 2007929"},{"line_number":14,"context_line":"Change-Id: I66520cd85b19e9ef7a328d529bd4cdb0685dc77c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_56e84515","line":11,"updated":"2020-07-25 12:35:36.000000000","message":"The added tests only verify that is_locked evaluates to false, which is also the case when Nova does not return this field (bool(None) \u003d\u003d False). Maybe you need a test with min_microversion\u003d\u00272.9\u0027 and is_locked set to True?","commit_id":"a5a72ab567ce418e6bcb2976e5b899b32086c10c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"936e3a89fa7e4ceb468b00b456b61c2e233599c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compute microversion 2.9 added the `is_locked` parameter in the"},{"line_number":10,"context_line":"response of server detail, server update, and the server reduild"},{"line_number":11,"context_line":"action. This patch a functional test to verify this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: 2007929"},{"line_number":14,"context_line":"Change-Id: I66520cd85b19e9ef7a328d529bd4cdb0685dc77c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_395b9454","line":11,"in_reply_to":"9f560f44_56e84515","updated":"2020-07-31 19:43:58.000000000","message":"Yeah, thanks for calling me out on being lazy.","commit_id":"a5a72ab567ce418e6bcb2976e5b899b32086c10c"}],"openstack/tests/functional/compute/v2/test_server.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"34cbb302c4162dbfcd40fc0120bbfdf124b8310b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        newname \u003d self.getUniqueString()"},{"line_number":70,"context_line":"        sot \u003d self.conn.compute.rebuild_server(self.server, self.image,"},{"line_number":71,"context_line":"                                               name\u003dnewname)"},{"line_number":72,"context_line":"        self.conn.compute.wait_for_server(sot, wait\u003dself._wait_for_timeout)"},{"line_number":73,"context_line":"        self.assertEqual(newname, sot.name)"},{"line_number":74,"context_line":"        self.assertTrue(sot.is_locked)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ef0cae3c","line":72,"updated":"2020-07-31 19:57:28.000000000","message":"Weirdly, if I don\u0027t have this wait, the is_locked assertion on L74 fails. Which it shouldn\u0027t, because \u0027locked\u0027 should be in the response to the rebuild action request...","commit_id":"04b5296cd96c027b5851e066019a2b6fde58811d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"8056702dc91d330a7348ab25ce66942101707fdd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        newname \u003d self.getUniqueString()"},{"line_number":70,"context_line":"        sot \u003d self.conn.compute.rebuild_server(self.server, self.image,"},{"line_number":71,"context_line":"                                               name\u003dnewname)"},{"line_number":72,"context_line":"        self.conn.compute.wait_for_server(sot, wait\u003dself._wait_for_timeout)"},{"line_number":73,"context_line":"        self.assertEqual(newname, sot.name)"},{"line_number":74,"context_line":"        self.assertTrue(sot.is_locked)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ea877c0e","line":72,"in_reply_to":"9f560f44_afd59645","updated":"2020-07-31 21:40:53.000000000","message":"Fun: https://review.opendev.org/#/c/744258/","commit_id":"04b5296cd96c027b5851e066019a2b6fde58811d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c78fe88f2bd3bbad97e71b7e51dc18dcbc6f382b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        newname \u003d self.getUniqueString()"},{"line_number":70,"context_line":"        sot \u003d self.conn.compute.rebuild_server(self.server, self.image,"},{"line_number":71,"context_line":"                                               name\u003dnewname)"},{"line_number":72,"context_line":"        self.conn.compute.wait_for_server(sot, wait\u003dself._wait_for_timeout)"},{"line_number":73,"context_line":"        self.assertEqual(newname, sot.name)"},{"line_number":74,"context_line":"        self.assertTrue(sot.is_locked)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_afd59645","line":72,"in_reply_to":"9f560f44_ef0cae3c","updated":"2020-07-31 20:12:34.000000000","message":"I *think* that\u0027s because the rebuild request is made with microversion 2.1 (2.9 is needed for \u0027locked\u0027)...","commit_id":"04b5296cd96c027b5851e066019a2b6fde58811d"}]}