)]}'
{"openstack/compute/v2/server.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e04b517ad51f71b1fc65e6ed6b41fe70b81f193d","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    def get_console_url(self, session, console_type):"},{"line_number":488,"context_line":"        action \u003d CONSOLE_TYPE_ACTION_MAPPING.get(console_type)"},{"line_number":489,"context_line":"        if not action:"},{"line_number":490,"context_line":"            raise ValueError(\"Unsupported console type\")"},{"line_number":491,"context_line":"        body \u003d {action: {\u0027type\u0027: console_type}}"},{"line_number":492,"context_line":"        resp \u003d self._action(session, body)"},{"line_number":493,"context_line":"        return resp.json().get(\u0027console\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_82516d65","line":490,"updated":"2020-09-22 14:48:13.000000000","message":"nit: mention the type","commit_id":"ec8f810f050b96837a43c92349824617938332ce"}],"openstack/tests/unit/compute/v2/test_proxy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e04b517ad51f71b1fc65e6ed6b41fe70b81f193d","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            expected_args\u003d[\"console_type\"])"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    def test_create_console(self):"},{"line_number":584,"context_line":"        with \\"},{"line_number":585,"context_line":"            mock.patch(\u0027openstack.utils.supports_microversion\u0027) as smv, \\"},{"line_number":586,"context_line":"            mock.patch(\u0027openstack.compute.v2._proxy.Proxy._create\u0027) as rcc, \\"},{"line_number":587,"context_line":"            mock.patch(\u0027openstack.compute.v2.server.Server.get_console_url\u0027) \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_22c6a117","line":584,"updated":"2020-09-22 14:48:13.000000000","message":"ugh","commit_id":"ec8f810f050b96837a43c92349824617938332ce"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e04b517ad51f71b1fc65e6ed6b41fe70b81f193d","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        with \\"},{"line_number":585,"context_line":"            mock.patch(\u0027openstack.utils.supports_microversion\u0027) as smv, \\"},{"line_number":586,"context_line":"            mock.patch(\u0027openstack.compute.v2._proxy.Proxy._create\u0027) as rcc, \\"},{"line_number":587,"context_line":"            mock.patch(\u0027openstack.compute.v2.server.Server.get_console_url\u0027) \\"},{"line_number":588,"context_line":"                as sgc:"},{"line_number":589,"context_line":"            console_fake \u003d {"},{"line_number":590,"context_line":"                \u0027url\u0027: \u0027a\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_62cc1934","line":587,"updated":"2020-09-22 14:48:13.000000000","message":"please move these to decorators and use autospec\u003dTrue","commit_id":"ec8f810f050b96837a43c92349824617938332ce"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e04b517ad51f71b1fc65e6ed6b41fe70b81f193d","unresolved":false,"context_lines":[{"line_number":599,"context_line":"            sgc.assert_called_with(self.proxy, \u0027fake_type\u0027)"},{"line_number":600,"context_line":"            self.assertDictEqual(console_fake, ret)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"            smv.reset_mock()"},{"line_number":603,"context_line":"            sgc.reset_mock()"},{"line_number":604,"context_line":"            rcc.reset_mock()"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"            # Test server_remote_console is triggered when mv\u003e\u003d2.6"},{"line_number":607,"context_line":"            smv.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a2d911f5","line":604,"range":{"start_line":602,"start_character":0,"end_line":604,"end_character":28},"updated":"2020-09-22 14:48:13.000000000","message":"using reset_mock is a good sigh the test should be split in two","commit_id":"ec8f810f050b96837a43c92349824617938332ce"}],"releasenotes/notes/optimize-server-console-1d27c107b9a1cdc3.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e04b517ad51f71b1fc65e6ed6b41fe70b81f193d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Optimizes compute server console creation by addind older get_server_console method to the server and create_console proxy method calling appropriate method depending on the suported microversion."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_c2a36542","line":4,"updated":"2020-09-22 14:48:13.000000000","message":"Please wrap lines.\n\ns/addind/adding/, s/suported/supported/","commit_id":"ec8f810f050b96837a43c92349824617938332ce"}]}