)]}'
{"openstack/block_storage/v3/_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"019576d56458e751e6e5ef1612395e4494b8ce70","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":187,"context_line":"                 when no resource can be found."},{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        if isinstance(volume_type_id, _type.Type):"},{"line_number":190,"context_line":"            volume_type_id \u003d volume_type_id.id"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        return self._get(_type.TypeEncryption,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_e1399a3f","line":189,"updated":"2020-11-02 14:45:07.000000000","message":"you should use \u0027_get_resource\u0027 function here and in other functions (similarly to https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/block_storage/v3/_proxy.py#L386). This would be better","commit_id":"962b918d486605092d1868a6c1c9a71bcfb27fa7"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"69f4f65762ba6f3715b498993c4324ff22e191ef","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":187,"context_line":"                 when no resource can be found."},{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        if isinstance(volume_type_id, _type.Type):"},{"line_number":190,"context_line":"            volume_type_id \u003d volume_type_id.id"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        return self._get(_type.TypeEncryption,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_40089190","line":189,"in_reply_to":"1f621f24_e1399a3f","updated":"2020-11-17 15:00:03.000000000","message":"This can be like that:\n\n       val \u003d self._get_resource(_type.Type, volume_type_id)\n\n       return self._get(_type.TypeEncryption,\n                        volume_type_id\u003dval.id,\n                        requires_id\u003dFalse)\n\n\nthen the test could be:\n   def test_get_type_encryption(self):\n       self.verify_get(\n           self.proxy.get_type_encryption, type.TypeEncryption,\n           expected_args\u003d[type.TypeEncryption],\n           expected_kwargs\u003d{\n               \u0027volume_type_id\u0027: \u0027value\u0027,\n               \u0027requires_id\u0027: False}\n       )","commit_id":"962b918d486605092d1868a6c1c9a71bcfb27fa7"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"69f4f65762ba6f3715b498993c4324ff22e191ef","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        :returns: The updated type encryption"},{"line_number":264,"context_line":"        :rtype: :class:`~openstack.volume.v3.type.TypeEncryption`"},{"line_number":265,"context_line":"        \"\"\""},{"line_number":266,"context_line":"        if isinstance(encryption_id, _type.TypeEncryption):"},{"line_number":267,"context_line":"            type_encryption \u003d encryption_id"},{"line_number":268,"context_line":"        elif volume_type_id is None:"},{"line_number":269,"context_line":"            raise exceptions.SDKException("},{"line_number":270,"context_line":"                \u0027volume_type_id must be specified if encryption_id is not a\u0027"},{"line_number":271,"context_line":"                \u0027 TypeEncryption instance\u0027"},{"line_number":272,"context_line":"            )"},{"line_number":273,"context_line":"        else:"},{"line_number":274,"context_line":"            type_encryption \u003d self.get_type_encryption("},{"line_number":275,"context_line":"                volume_type_id\u003dvolume_type_id)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        return self._update(_type.TypeEncryption, type_encryption,"},{"line_number":278,"context_line":"                            **attrs)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def get_volume(self, volume):"},{"line_number":281,"context_line":"        \"\"\"Get a single volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_800c6994","line":278,"range":{"start_line":266,"start_character":1,"end_line":278,"end_character":36},"updated":"2020-11-17 15:00:03.000000000","message":"and if this is just:\n\n    return self._update(_type.TypeEncryption, encryption,\n                    **attrs)\n\nThe test would be:\n\n   def test_update_type_encryption(self):\n       self.verify_update(\n           self.proxy.update_type_encryption, type.TypeEncryption,\n       )","commit_id":"962b918d486605092d1868a6c1c9a71bcfb27fa7"}],"openstack/block_storage/v3/type.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8be72c4a85fc6193e387638314388c8aa51d09ff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    #: a private volume-type. *Type: bool*"},{"line_number":37,"context_line":"    is_public \u003d resource.Body(\u0027os-volume-type-access:is_public\u0027, type\u003dbool)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class TypeEncryption(resource.Resource):"},{"line_number":40,"context_line":"    resource_key \u003d \"encryption\""},{"line_number":41,"context_line":"    resources_key \u003d \"encryption\""},{"line_number":42,"context_line":"    base_path \u003d \"/types/%(volume_type_id)s/encryption\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_85e177ff","line":39,"updated":"2020-10-08 13:06:40.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"92c2e552f3235471d5c999557bbeaa0142dbd097"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a2f90e5f57e4ad1705f3f62d72ed946eb7d47d54","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    #: a private volume-type. *Type: bool*"},{"line_number":40,"context_line":"    is_public \u003d resource.Body(\u0027os-volume-type-access:is_public\u0027, type\u003dbool)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TypeEncryption(resource.Resource):"},{"line_number":43,"context_line":"    resource_key \u003d \"encryption\""},{"line_number":44,"context_line":"    resources_key \u003d \"encryption\""},{"line_number":45,"context_line":"    base_path \u003d \"/types/%(volume_type_id)s/encryption\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_76caaea1","line":42,"updated":"2020-11-17 22:03:46.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"70e19fdc034cb060ec646cff61eeb6d865fb3cf5"}]}