)]}'
{"id":"openstack%2Fopenstacksdk~761053","triplet_id":"openstack%2Fopenstacksdk~master~If3356acb8241198e028adfc2aecceee7dbadcc1e","project":"openstack/openstacksdk","branch":"master","topic":"assert","hashtags":[],"change_id":"If3356acb8241198e028adfc2aecceee7dbadcc1e","subject":"Fix invalid assertIsNotNone statement","status":"MERGED","created":"2020-11-03 05:47:15.000000000","updated":"2020-11-10 16:24:56.000000000","submitted":"2020-11-10 16:20:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"761053-1605025221350-40a8ff94","meta_rev_id":"bab8239f581943ef8be051ca2219458e469bdab4","_number":761053,"virtual_id_number":761053,"owner":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-10 16:20:21.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"date":"2020-11-10 01:58:17.000000000","_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"value":2,"date":"2020-11-10 10:35:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-11-10 10:36:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-10 10:35:39.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-11-10 10:36:48.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2020-11-10 16:20:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fa6e46152ad1022ce649cf8e076b3971570ee2b9","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2020-11-03 05:47:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"21cabf93306e0852559e5107319fddc72fc106f5","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-11-03 10:45:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"dfcc2832debcdabb85880a23da01e56c5d2f88e1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 11:57:36.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e9d883fa7f6141aaaf7bb70b033fd412 : SUCCESS in 4m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/90ce1cad284c43719f9a36cac137a5bd : SUCCESS in 3m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0daa37c960894c13bef019b4099f9b99 : SUCCESS in 4m 54s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3068d0533e0e4da68a2d79bd470be85f : SUCCESS in 4m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/605d4a8a6e324ef3bfda8de3e70511df : SUCCESS in 4m 26s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/08e9ec2974634e38bdda371d62af8faa : FAILURE in 1h 00m 54s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/cfa1e615d4c54902904c41a3f8b72a67 : SUCCESS in 5m 39s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/cbb60ed0f0a44db6a95eccf8b90a8653 : SUCCESS in 5m 14s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/6bda7b77fa684ab6b417ef8bc2f1024a : SUCCESS in 5m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1680a42288224f8b98c7b349fa82e365 : SUCCESS in 7m 42s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/ecb3c47f705b4d5ba17787c39481aa8b : SUCCESS in 1h 11m 28s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/fa602ad16485467dbcd2a80442610c9a : SUCCESS in 18m 02s\n- nodepool-functional-container-openstack-siblings https://zuul.opendev.org/t/openstack/build/db453b383eed4efd8fabb2fa00965233 : SUCCESS in 31m 57s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4b0afbd72c22495ea9331006ce589ae0 : FAILURE in 1h 00m 15s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/8158c4037ac64fa0a870946586303607 : FAILURE in 1h 20m 47s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/20c32f6f4be240d5acf3e6b5e5f7b368 : FAILURE in 53m 05s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/a9a4a0d4119246de8179ab1810216284 : POST_FAILURE in 38m 09s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/be99af013055433fa3e88b915a2239e2 : SUCCESS in 33m 06s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/4c4caea0c4074084b3836bfa94a360c0 : SUCCESS in 38m 43s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/dd0bb407395a49bebb59799c1875341f : SUCCESS in 54m 57s (non-voting)\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/c22c45375bfe4f4a88f2f2a92a548409 : SUCCESS in 58m 44s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8f98637f39b34bd7a2664b104ea6c961 : SUCCESS in 21m 25s (non-voting)\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/37798511842444989dce5a457f488c91 : SUCCESS in 49m 40s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/8816ea0da924482eabaa86346fb5ae0f : SUCCESS in 40m 33s (non-voting)\n- openstacksdk-ansible-stable-2.8-functional-devstack https://zuul.opendev.org/t/openstack/build/7131f6ea70de4e22bbb253d6a70ca286 : FAILURE in 37m 49s (non-voting)\n- openstacksdk-ansible-stable-2.9-functional-devstack https://zuul.opendev.org/t/openstack/build/bfcea2ee81164aeeab54814562bfa80d : FAILURE in 38m 54s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"951201d507bf67abf9f062596cf287d888d9c0d8","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2020-11-04 01:22:43.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"72d083c6ea452e4d3144c8dcbf01b6c23e1ec950","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-04 07:40:11.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/67004dd47dc8424eac156d74df6b30cc : SUCCESS in 4m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ea87f4a0dc4d42d6ab76a7f9f86de58d : SUCCESS in 3m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a51d8b9a697542eab070604783c07a8a : SUCCESS in 4m 09s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5e8cfe005b9545349bd88a4963195998 : SUCCESS in 4m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4a9407d5b85d4565844af0adb9f99adf : SUCCESS in 4m 18s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/9b6229b33e594866ac08ba5c6fadfe33 : POST_FAILURE in 26m 13s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/7aca4b6a39724099888940663db5ae77 : SUCCESS in 4m 10s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/a985ca7f83bc4307bbfdc2c22f97acf8 : SUCCESS in 3m 58s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/50073bd3f48749aeae558af42b3fa151 : SUCCESS in 5m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6d6d34ec76f74194b089fa92d91497e4 : SUCCESS in 11m 20s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/b184e0687c514fbd9259a6bce444d8d7 : SUCCESS in 58m 14s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/8df55bdb99cc445ca38fcdc22eb8aadd : SUCCESS in 24m 32s\n- nodepool-functional-container-openstack-siblings https://zuul.opendev.org/t/openstack/build/f86a7fde38994e49992029f85b543b31 : SUCCESS in 25m 06s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c99c127ca7824fbf9dc8fee73b340fda : FAILURE in 56m 29s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/73f8784ff9f64eb1868156a191b74f43 : FAILURE in 2h 04m 30s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/869607146ba84430bd6687f7850b264f : FAILURE in 52m 44s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/93f3f3bba8c140cba670d57ff4e7a744 : POST_FAILURE in 35m 34s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/7ce19099ff424c4aa795b9b0d52b7469 : SUCCESS in 30m 40s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/3ac5b8882fa144cfbb1445e082750112 : FAILURE in 49m 00s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/beee7f3922b44379a0005d17a642ffb5 : FAILURE in 1h 06m 51s (non-voting)\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/de4113640e384ac093f42a290e56951e : SUCCESS in 55m 16s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/08e1c0cdb4014bf7910b340c560798b7 : SUCCESS in 24m 11s (non-voting)\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/0b3b117035a04080a52f8df6f2c4e275 : SUCCESS in 59m 50s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/b5d5e7a0cde0461887b01b3ede70c2b0 : SUCCESS in 51m 11s (non-voting)\n- openstacksdk-ansible-stable-2.8-functional-devstack https://zuul.opendev.org/t/openstack/build/cb8df67353d04dfa9a392d7b466191e5 : FAILURE in 43m 10s (non-voting)\n- openstacksdk-ansible-stable-2.9-functional-devstack https://zuul.opendev.org/t/openstack/build/1e0e06536aaa424692a4199b15f248e3 : FAILURE in 53m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b0f8c120e8fd5c2de72583a3246b667281a679e8","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2020-11-05 05:47:59.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"edbcfe9b3cf6f00624560650dc31d9bb0bc126b2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-05 07:04:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a320e55276834369b17a5b0295a614dd : SUCCESS in 5m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/803ad3d0bf5343a384cd86a92a996c29 : SUCCESS in 3m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7390fb66a5d04680bd318ba3cea143c2 : SUCCESS in 3m 12s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/81fd4512c1bc47ecb5ed7be5fb3c3887 : SUCCESS in 3m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3c3d1752b3644c7fa88439cf0ae21c0b : SUCCESS in 3m 25s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/0c553fce67c442f7aa9f96d32b87f6fd : SUCCESS in 47m 26s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/6ddd05b967b04d0fbd927bbe27250bc7 : SUCCESS in 3m 27s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/c7f7c623c808401bb4eb449659bead14 : SUCCESS in 3m 03s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/c63971b0133843be96b2c5f0ec164ad6 : SUCCESS in 3m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/852b6c3226e54f75b54d037b3fa7c262 : SUCCESS in 8m 32s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/fde7f966b0ff4aa49c7cc893e3a013fe : SUCCESS in 1h 00m 31s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/a07dde0986144b1482c8e23fc87c5f08 : SUCCESS in 16m 55s\n- nodepool-functional-container-openstack-siblings https://zuul.opendev.org/t/openstack/build/0ad833d8f5eb4f5183ed63c1ff5c119d : SUCCESS in 37m 25s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/95209a2dda164856ba3fb3021c51c799 : SUCCESS in 56m 14s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/a4391674bab749d0b629896bd5a66f6e : SUCCESS in 1h 14m 25s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/0aaa6f05cd9d48a4a1b4e03c771069c8 : SUCCESS in 52m 46s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/2f6eecafb3bc45b782f1f05035cd3628 : POST_FAILURE in 32m 24s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/8e7bb7d81a8c43c082f6580a396beebe : SUCCESS in 35m 16s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/108ac1ec899f451abff78a40c581afc8 : FAILURE in 32m 59s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/562f672d33a44836b60d53907e06ef49 : SUCCESS in 57m 22s (non-voting)\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/529f1614c6ed427281aeb445c4c4bba7 : SUCCESS in 54m 24s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/bbeadf4ef163422f8217aa0a0cf922fa : SUCCESS in 24m 36s (non-voting)\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/f63a181f374b4c448046a45beca52c4b : SUCCESS in 51m 34s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/ed88f20a193b4dd7b9c4e3f469e9bb2d : SUCCESS in 44m 05s (non-voting)\n- openstacksdk-ansible-stable-2.8-functional-devstack https://zuul.opendev.org/t/openstack/build/5f7c8e9f418f42edbc324e170b0bd731 : FAILURE in 37m 06s (non-voting)\n- openstacksdk-ansible-stable-2.9-functional-devstack https://zuul.opendev.org/t/openstack/build/4cc978e1143249a19a3c63b8da3cd30a : FAILURE in 38m 03s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d30ca5fb26d815460cd0616254d36427f42b8c66","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2020-11-09 12:54:57.000000000","message":"Patch Set 2: Code-Review-1\n\nshouldn\u0027t it be assertEqual instead?","accounts_in_message":[],"_revision_number":2},{"id":"ee607db13fc73b0a4dd8ba7b15e994c75de958c4","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-11-09 14:38:47.000000000","message":"Patch Set 2:\n\nassertEqual(.., None) is an anti-pattern, assertIs(Not)None should be used instead.","accounts_in_message":[],"_revision_number":2},{"id":"232c409b3b29180161a99884992376d749eb252a","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2020-11-09 15:03:07.000000000","message":"Patch Set 2: -Code-Review\n\n\u003e assertEqual(.., None) is an anti-pattern, assertIs(Not)None should\n \u003e be used instead.\n\nI was not actually referring None in any case. I just thought that perhaps the test was implemented with mistake of using assertNone(nonNone,etc) instead of some real comparison.","accounts_in_message":[],"_revision_number":2},{"id":"8a32195bab77dc1d833c3a757b23b97f466c2ef2","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2020-11-10 01:58:17.000000000","message":"Patch Set 2:\n\nSeems we don\u0027t know exact values of them, so we can only check not-none?","accounts_in_message":[],"_revision_number":2},{"id":"87f9d6bb03d1a0bc8176c3330d75e9923a2c77e0","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-11-10 10:35:39.000000000","message":"Patch Set 2: Code-Review+2\n\nI think this is fine for a test","accounts_in_message":[],"_revision_number":2},{"id":"25394e01b2160a95a4308d93a0f9cce567915e22","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2020-11-10 10:36:48.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"8030a7f958e645e95dbffa565dfccbfcd4b94aa7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-10 10:37:47.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"2e46f54f8578e34234374c75f5214a8627ad711f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-10 16:20:21.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1c1f7376f3e04c8cb296927e234160d3 : SUCCESS in 4m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2ece80ca4bed4d46b05366c699cd5e2d : SUCCESS in 3m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b86d59e4bdd846a881210f11700601b2 : SUCCESS in 4m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0612fc2b132c4c718241e5d697909d78 : SUCCESS in 5m 07s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/6b1d3eaa13b645d5bdbe70c97baa1a69 : SUCCESS in 55m 54s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/840a9f712a78433ab9c70ea3da59bb82 : SUCCESS in 4m 21s\n- os-client-config-tox-py37-tips https://zuul.opendev.org/t/openstack/build/a46bcc90f6094da7bba17d64e647ac39 : SUCCESS in 4m 03s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/6d56293ba4294a86a069214c115c92f3 : SUCCESS in 4m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3b006fb37d6f4d6397cc2b14e3222017 : SUCCESS in 8m 27s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/43167d8a982b48b3aba384b42f285218 : SUCCESS in 58m 53s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/95f9bc364e7143b6bb304ac58b1b79a4 : SUCCESS in 16m 27s\n- nodepool-functional-container-openstack-siblings https://zuul.opendev.org/t/openstack/build/c69a5220c9214705845fc237ea2e824d : SUCCESS in 35m 23s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f46d432cce0a479f8fe388babd6a53ae : SUCCESS in 58m 32s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/16de25d67ca049ee8058f95864bab24c : SUCCESS in 1h 18m 30s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/367433d7b6884f84a703cbdc1a83cb39 : SUCCESS in 1h 02m 18s","accounts_in_message":[],"_revision_number":2},{"id":"6f212f3cae51884962e3c0cbbcf6351107b4a7da","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-10 16:20:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"9aef0724a2390de3ea792cd847af4c9c838f356e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-10 16:24:56.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aae1c34ee2e2444fa27e2421edf4a712 : SUCCESS in 1m 40s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"907634cc0a8350c786135fb8fe92a39832e0818f","revisions":{"dddb6e741ec7e307fae13fd1b029e946d4a893f0":{"kind":"REWORK","_number":1,"created":"2020-11-03 05:47:15.000000000","uploader":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"ref":"refs/changes/53/761053/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/53/761053/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/53/761053/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/53/761053/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/53/761053/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/53/761053/1"}}},"commit":{"parents":[{"commit":"34aa00bff571b52fd9bc107768132222b8285315","subject":"Merge \"Support waiting for bare metal power states\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/34aa00bff571b52fd9bc107768132222b8285315"}]}],"author":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2020-11-02 09:33:10.000000000","tz":480},"committer":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2020-11-03 05:46:45.000000000","tz":480},"subject":"Fix invalid assertIsNotNone statement","message":"Fix invalid assertIsNotNone statement\n\nThis is to fix the invalid assertIsNotNone statements like\n\"self.assertIsNotNone(\u0027maxTotalInstances\u0027, sot.absolute)\",\nwhich will always return True.\n\nChange-Id: If3356acb8241198e028adfc2aecceee7dbadcc1e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/dddb6e741ec7e307fae13fd1b029e946d4a893f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/dddb6e741ec7e307fae13fd1b029e946d4a893f0"}]},"branch":"refs/heads/master"},"907634cc0a8350c786135fb8fe92a39832e0818f":{"kind":"REWORK","_number":2,"created":"2020-11-05 05:47:59.000000000","uploader":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"ref":"refs/changes/53/761053/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/53/761053/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/53/761053/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/53/761053/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/53/761053/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/53/761053/2"}}},"commit":{"parents":[{"commit":"34aa00bff571b52fd9bc107768132222b8285315","subject":"Merge \"Support waiting for bare metal power states\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/34aa00bff571b52fd9bc107768132222b8285315"}]}],"author":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2020-11-02 09:33:10.000000000","tz":480},"committer":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2020-11-05 05:47:37.000000000","tz":0},"subject":"Fix invalid assertIsNotNone statement","message":"Fix invalid assertIsNotNone statement\n\nThis is to fix the invalid assertIsNotNone statements like\n\"self.assertIsNotNone(\u0027maxTotalInstances\u0027, sot.absolute)\",\nwhich will always return True.\n\nChange-Id: If3356acb8241198e028adfc2aecceee7dbadcc1e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/907634cc0a8350c786135fb8fe92a39832e0818f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/907634cc0a8350c786135fb8fe92a39832e0818f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}