)]}'
{"openstack/cloud/_compute.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d04ba2c8703cec3c4a4714dcfae9a7e1d683fd","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        \"\"\""},{"line_number":428,"context_line":"        if name_or_id:"},{"line_number":429,"context_line":"            flavor \u003d self.compute.find_flavor(name_or_id,"},{"line_number":430,"context_line":"                                              get_extra_specs\u003dget_extra)"},{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            flavors \u003d list(self.compute.flavors(filters))"},{"line_number":433,"context_line":"            if len(flavors) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_cdaf11e1","line":430,"updated":"2020-11-10 10:42:57.000000000","message":"This ignores filters, is it intended? If yes, update the docstring maybe?","commit_id":"77f04838f9fa6dd62f45aac5fe514acae586db98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d04ba2c8703cec3c4a4714dcfae9a7e1d683fd","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            flavor \u003d self.compute.find_flavor(name_or_id,"},{"line_number":430,"context_line":"                                              get_extra_specs\u003dget_extra)"},{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            flavors \u003d list(self.compute.flavors(filters))"},{"line_number":433,"context_line":"            if len(flavors) \u003e 1:"},{"line_number":434,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":435,"context_line":"                    \"Multiple matches found for %s\" % name_or_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_adac55ed","line":432,"updated":"2020-11-10 10:42:57.000000000","message":"nit: maybe add get_extra_specs argument to flavors() instead of implementing it below?","commit_id":"77f04838f9fa6dd62f45aac5fe514acae586db98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d04ba2c8703cec3c4a4714dcfae9a7e1d683fd","unresolved":false,"context_lines":[{"line_number":432,"context_line":"            flavors \u003d list(self.compute.flavors(filters))"},{"line_number":433,"context_line":"            if len(flavors) \u003e 1:"},{"line_number":434,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":435,"context_line":"                    \"Multiple matches found for %s\" % name_or_id)"},{"line_number":436,"context_line":"            flavor \u003d flavors[0]"},{"line_number":437,"context_line":"            if get_extra and not flavor.extra_specs:"},{"line_number":438,"context_line":"                flavor \u003d flavor.fetch_extra_specs(self.compute)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_0db6293f","line":435,"updated":"2020-11-10 10:42:57.000000000","message":"This branch is where name_or_id is None, I think you meant to use filters.","commit_id":"77f04838f9fa6dd62f45aac5fe514acae586db98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d04ba2c8703cec3c4a4714dcfae9a7e1d683fd","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            if len(flavors) \u003e 1:"},{"line_number":434,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":435,"context_line":"                    \"Multiple matches found for %s\" % name_or_id)"},{"line_number":436,"context_line":"            flavor \u003d flavors[0]"},{"line_number":437,"context_line":"            if get_extra and not flavor.extra_specs:"},{"line_number":438,"context_line":"                flavor \u003d flavor.fetch_extra_specs(self.compute)"},{"line_number":439,"context_line":"        if flavor:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_edb2cd48","line":436,"updated":"2020-11-10 10:42:57.000000000","message":"This may fail with IndexError?","commit_id":"77f04838f9fa6dd62f45aac5fe514acae586db98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d04ba2c8703cec3c4a4714dcfae9a7e1d683fd","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        :returns: A flavor ``munch.Munch``."},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        flavor \u003d self.compute.get_flavor(id, get_extra_specs\u003dget_extra)"},{"line_number":452,"context_line":"        if flavor:"},{"line_number":453,"context_line":"            return flavor._to_munch(original_names\u003dFalse)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def get_server_console(self, server, length\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_4d85c159","line":452,"updated":"2020-11-10 10:42:57.000000000","message":"I don\u0027t think get_* calls can return None","commit_id":"77f04838f9fa6dd62f45aac5fe514acae586db98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d04ba2c8703cec3c4a4714dcfae9a7e1d683fd","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":1479,"context_line":"        \"\"\""},{"line_number":1480,"context_line":"        access \u003d self.compute.get_flavor_access(flavor_id)"},{"line_number":1481,"context_line":"        if access:"},{"line_number":1482,"context_line":"            return _utils.normalize_flavor_accesses(access)"},{"line_number":1483,"context_line":""},{"line_number":1484,"context_line":"    def list_hypervisors(self, filters\u003d{}):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_2d8a0569","line":1481,"updated":"2020-11-10 10:42:57.000000000","message":"Can get_flavor_access really return None? If yes, needs documenting that this method can return None instead of a list.","commit_id":"77f04838f9fa6dd62f45aac5fe514acae586db98"}]}