)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"593206c1a52348ae67be08b952affc97c2d82c7a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"On update the network provider parameters were"},{"line_number":10,"context_line":"nested in the \"provider\". According to the"},{"line_number":11,"context_line":"Neutron API [0], update should follow the same"},{"line_number":12,"context_line":"semantics as create."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[0] https://docs.openstack.org/api-ref/network/v2/?expanded\u003dupdate-network-detail#update-network"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"b7e875b7_edfe25a0","line":12,"updated":"2022-01-24 14:22:23.000000000","message":"I\u0027m surprised unit tests don\u0027t need an update","commit_id":"ccc8d6e4b0691d8e9c10d3169dfd74ef0f7f96c8"}],"openstack/cloud/_network.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3680b5352df4acb66b77dfbfd5120d1947997396","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        :returns: The updated network object."},{"line_number":569,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":570,"context_line":"        \"\"\""},{"line_number":571,"context_line":"        if \u0027provider\u0027 in kwargs:"},{"line_number":572,"context_line":"            if not isinstance(kwargs[\u0027provider\u0027], dict):"},{"line_number":573,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":574,"context_line":"                    \"Parameter \u0027provider\u0027 must be a dict\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"13f5a4ce_5e2afb36","line":571,"updated":"2020-12-23 12:07:56.000000000","message":"To remove redundant accesses to kwargs this should be something like:\n\n provider \u003d kwargs.pop(\"provider\", None)\n if provider:","commit_id":"a5b680d9fae43e2fc18dc88e18f0278a64a89df4"},{"author":{"_account_id":32655,"name":"Ales Musil","email":"amusil@redhat.com","username":"amusil"},"change_message_id":"99012ce7c1b3221d17811e070d5a99d57ff80a65","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        :returns: The updated network object."},{"line_number":569,"context_line":"        :raises: OpenStackCloudException on operation error."},{"line_number":570,"context_line":"        \"\"\""},{"line_number":571,"context_line":"        if \u0027provider\u0027 in kwargs:"},{"line_number":572,"context_line":"            if not isinstance(kwargs[\u0027provider\u0027], dict):"},{"line_number":573,"context_line":"                raise exc.OpenStackCloudException("},{"line_number":574,"context_line":"                    \"Parameter \u0027provider\u0027 must be a dict\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a2669eb_d87231fd","line":571,"in_reply_to":"13f5a4ce_5e2afb36","updated":"2021-01-04 07:24:32.000000000","message":"Done","commit_id":"a5b680d9fae43e2fc18dc88e18f0278a64a89df4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3680b5352df4acb66b77dfbfd5120d1947997396","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                           \u0027segmentation_id\u0027):"},{"line_number":580,"context_line":"                    provider[\u0027provider:\u0027 + key] \u003d kwargs[\u0027provider\u0027][key]"},{"line_number":581,"context_line":"            kwargs.pop(\u0027provider\u0027)"},{"line_number":582,"context_line":"            kwargs.update(provider)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if \u0027external\u0027 in kwargs:"},{"line_number":585,"context_line":"            kwargs[\u0027router:external\u0027] \u003d kwargs.pop(\u0027external\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"023e1418_813848f7","line":582,"updated":"2020-12-23 12:07:56.000000000","message":"Could you add a unit test for the new behavior?","commit_id":"a5b680d9fae43e2fc18dc88e18f0278a64a89df4"},{"author":{"_account_id":32655,"name":"Ales Musil","email":"amusil@redhat.com","username":"amusil"},"change_message_id":"99012ce7c1b3221d17811e070d5a99d57ff80a65","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                           \u0027segmentation_id\u0027):"},{"line_number":580,"context_line":"                    provider[\u0027provider:\u0027 + key] \u003d kwargs[\u0027provider\u0027][key]"},{"line_number":581,"context_line":"            kwargs.pop(\u0027provider\u0027)"},{"line_number":582,"context_line":"            kwargs.update(provider)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if \u0027external\u0027 in kwargs:"},{"line_number":585,"context_line":"            kwargs[\u0027router:external\u0027] \u003d kwargs.pop(\u0027external\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bbf67ff9_d475dc50","line":582,"in_reply_to":"023e1418_813848f7","updated":"2021-01-04 07:24:32.000000000","message":"Can you please point me in which file I should search for those test?","commit_id":"a5b680d9fae43e2fc18dc88e18f0278a64a89df4"},{"author":{"_account_id":32655,"name":"Ales Musil","email":"amusil@redhat.com","username":"amusil"},"change_message_id":"e63a6e36673a75af4bdd83ed37cd1fec25fa6b70","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                           \u0027segmentation_id\u0027):"},{"line_number":580,"context_line":"                    provider[\u0027provider:\u0027 + key] \u003d kwargs[\u0027provider\u0027][key]"},{"line_number":581,"context_line":"            kwargs.pop(\u0027provider\u0027)"},{"line_number":582,"context_line":"            kwargs.update(provider)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if \u0027external\u0027 in kwargs:"},{"line_number":585,"context_line":"            kwargs[\u0027router:external\u0027] \u003d kwargs.pop(\u0027external\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff2458c1_3b87687f","line":582,"in_reply_to":"5fde21ea_cdbb550a","updated":"2022-01-26 06:44:04.000000000","message":"Done","commit_id":"a5b680d9fae43e2fc18dc88e18f0278a64a89df4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b0f38c60d428df8fc8b9d843709a6fc3ecf18ff","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                           \u0027segmentation_id\u0027):"},{"line_number":580,"context_line":"                    provider[\u0027provider:\u0027 + key] \u003d kwargs[\u0027provider\u0027][key]"},{"line_number":581,"context_line":"            kwargs.pop(\u0027provider\u0027)"},{"line_number":582,"context_line":"            kwargs.update(provider)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if \u0027external\u0027 in kwargs:"},{"line_number":585,"context_line":"            kwargs[\u0027router:external\u0027] \u003d kwargs.pop(\u0027external\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fde21ea_cdbb550a","line":582,"in_reply_to":"bbf67ff9_d475dc50","updated":"2022-01-25 14:47:52.000000000","message":"Somewhere in https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/cloud/test_network.py I guess","commit_id":"a5b680d9fae43e2fc18dc88e18f0278a64a89df4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"593206c1a52348ae67be08b952affc97c2d82c7a","unresolved":false,"context_lines":[{"line_number":572,"context_line":"            for key in (\u0027physical_network\u0027, \u0027network_type\u0027,"},{"line_number":573,"context_line":"                        \u0027segmentation_id\u0027):"},{"line_number":574,"context_line":"                if key in provider:"},{"line_number":575,"context_line":"                    provider[\u0027provider:\u0027 + key] \u003d provider.pop(key)"},{"line_number":576,"context_line":"            kwargs.update(provider)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        if \u0027external\u0027 in kwargs:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dffc1f92_5f235e57","line":575,"updated":"2022-01-24 14:22:23.000000000","message":"nit: you can set kwargs[....] here directly without updating the provider object","commit_id":"ccc8d6e4b0691d8e9c10d3169dfd74ef0f7f96c8"},{"author":{"_account_id":32655,"name":"Ales Musil","email":"amusil@redhat.com","username":"amusil"},"change_message_id":"53d186dcc636a128619102d28957023e13da27c0","unresolved":false,"context_lines":[{"line_number":572,"context_line":"            for key in (\u0027physical_network\u0027, \u0027network_type\u0027,"},{"line_number":573,"context_line":"                        \u0027segmentation_id\u0027):"},{"line_number":574,"context_line":"                if key in provider:"},{"line_number":575,"context_line":"                    provider[\u0027provider:\u0027 + key] \u003d provider.pop(key)"},{"line_number":576,"context_line":"            kwargs.update(provider)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        if \u0027external\u0027 in kwargs:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1d216d0c_71dca995","line":575,"in_reply_to":"dffc1f92_5f235e57","updated":"2022-01-25 06:15:09.000000000","message":"Done, thanks","commit_id":"ccc8d6e4b0691d8e9c10d3169dfd74ef0f7f96c8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"593206c1a52348ae67be08b952affc97c2d82c7a","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                        \u0027segmentation_id\u0027):"},{"line_number":574,"context_line":"                if key in provider:"},{"line_number":575,"context_line":"                    provider[\u0027provider:\u0027 + key] \u003d provider.pop(key)"},{"line_number":576,"context_line":"            kwargs.update(provider)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        if \u0027external\u0027 in kwargs:"},{"line_number":579,"context_line":"            kwargs[\u0027router:external\u0027] \u003d kwargs.pop(\u0027external\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dd82c28c_3d8ffdb6","line":576,"updated":"2022-01-24 14:22:23.000000000","message":"actually, this allow passing unknown keys, which the previous implementation ruled out. I suggest implementing my suggestion above to avoid it.","commit_id":"ccc8d6e4b0691d8e9c10d3169dfd74ef0f7f96c8"},{"author":{"_account_id":32655,"name":"Ales Musil","email":"amusil@redhat.com","username":"amusil"},"change_message_id":"53d186dcc636a128619102d28957023e13da27c0","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                        \u0027segmentation_id\u0027):"},{"line_number":574,"context_line":"                if key in provider:"},{"line_number":575,"context_line":"                    provider[\u0027provider:\u0027 + key] \u003d provider.pop(key)"},{"line_number":576,"context_line":"            kwargs.update(provider)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        if \u0027external\u0027 in kwargs:"},{"line_number":579,"context_line":"            kwargs[\u0027router:external\u0027] \u003d kwargs.pop(\u0027external\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a4774a4_d7abba78","line":576,"in_reply_to":"dd82c28c_3d8ffdb6","updated":"2022-01-25 06:15:09.000000000","message":"Done","commit_id":"ccc8d6e4b0691d8e9c10d3169dfd74ef0f7f96c8"}]}