)]}'
{"openstack/baremetal_introspection/v1/_proxy.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f9ce7dd97c02b58cf0103924d4c07a4d26b8de5c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            a :class:`~openstack.baremetal.v1.node.Node` instance."},{"line_number":64,"context_line":"        :param bool manage_boot: Whether to manage boot parameters for the"},{"line_number":65,"context_line":"            node. Defaults to the server default (which is `True`)."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        :returns: :class:`~.introspection.Introspection` instance."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        node \u003d self._get_resource(_node.Node, node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_47138cb9","line":66,"updated":"2020-11-19 08:47:14.000000000","message":"nit: missing param lookup","commit_id":"e3710ec971c75d1b5528a504d80a28267a936032"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1f34b51d8d7592bbef22e584403c7e890c40599b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            kwargs[\u0027manage_boot\u0027] \u003d manage_boot"},{"line_number":76,"context_line":"        if lookup is not None:"},{"line_number":77,"context_line":"            kwargs[\u0027lookup\u0027] \u003d lookup"},{"line_number":78,"context_line":"        return res.create(self, **kwargs)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def get_introspection(self, introspection):"},{"line_number":81,"context_line":"        \"\"\"Get a specific introspection."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_cb395040","line":78,"updated":"2020-11-18 16:08:01.000000000","message":"We don\u0027t have functional tests for ironic-inspector, but a unit test and a release note wouldn\u0027t hurt.","commit_id":"e3710ec971c75d1b5528a504d80a28267a936032"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8173b24dd3a5c0864ae8d1568df07b2f37019d44","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            kwargs[\u0027manage_boot\u0027] \u003d manage_boot"},{"line_number":76,"context_line":"        if lookup is not None:"},{"line_number":77,"context_line":"            kwargs[\u0027lookup\u0027] \u003d lookup"},{"line_number":78,"context_line":"        return res.create(self, **kwargs)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def get_introspection(self, introspection):"},{"line_number":81,"context_line":"        \"\"\"Get a specific introspection."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_df6aae19","line":78,"range":{"start_line":78,"start_character":40,"end_line":78,"end_character":41},"updated":"2020-11-18 12:42:21.000000000","message":"Worth adding unit test and even a functional test I would say \u003d)","commit_id":"e3710ec971c75d1b5528a504d80a28267a936032"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"50b8217e4025e301d18969f3b23ec7ecfe9c4c73","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        :param  string lookup: contains lookup information which can be"},{"line_number":67,"context_line":"            used by Inspector to identify node. Currently only MAC"},{"line_number":68,"context_line":"            address is supported. Sample format:"},{"line_number":69,"context_line":"            mac:aa:bb:cc:dd:ee:ff,mac:bb:cc:dd:ee:ff:00"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        :returns: :class:`~.introspection.Introspection` instance."},{"line_number":72,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"04a061e9_e1a00ec3","line":69,"updated":"2020-11-30 22:39:43.000000000","message":"I think the lookup argument should allow a string or a list of strings (so no need to comma join it before calling start_introspection). For python requests, when a param value is a list it will duplicate the param, so passing [\u0027mac:aa:bb:cc:dd:ee:ff\u0027, \u0027mac:bb:cc:dd:ee:ff:00\u0027] here will result in a url like\n\n  POST /v1/introspection/\u003cnode\u003e?lookup\u003dmac:aa:bb:cc:dd:ee:ff:gg\u0026lookup\u003dmac:bb:cc:dd:ee:ff:00\n\nThe API endpoint should reconstitute this back into a list, so HTTP already supports params which are lists, lets use that.","commit_id":"9cf251b0fb98875fbe9b0fe42b825bd417d28ed0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8056048c105a0a91c5b77451afb8af6523f0b06b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :param  string lookup: contains lookup information which can be"},{"line_number":67,"context_line":"            used by Inspector to identify node. Currently only MAC"},{"line_number":68,"context_line":"            address is supported. Sample format:"},{"line_number":69,"context_line":"            mac:aa:bb:cc:dd:ee:ff,mac:bb:cc:dd:ee:ff:00"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        :returns: :class:`~.introspection.Introspection` instance."},{"line_number":72,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"c00565ae_98cfd7f9","line":69,"in_reply_to":"04a061e9_e1a00ec3","updated":"2021-01-07 07:57:36.000000000","message":"Done","commit_id":"9cf251b0fb98875fbe9b0fe42b825bd417d28ed0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d7287b6363adf621d748d7f97327409c151e2c9e","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        node \u003d self._get_resource(_node.Node, node)"},{"line_number":74,"context_line":"        res \u003d _introspect.Introspection.new(connection\u003dself._get_connection(),"},{"line_number":75,"context_line":"                                            id\u003dnode.id,"},{"line_number":76,"context_line":"                                            lookup\u003dlookup)"},{"line_number":77,"context_line":"        kwargs \u003d {}"},{"line_number":78,"context_line":"        if manage_boot is not None:"},{"line_number":79,"context_line":"            kwargs[\u0027manage_boot\u0027] \u003d manage_boot"}],"source_content_type":"text/x-python","patch_set":2,"id":"90af4572_8396cc69","line":76,"range":{"start_line":76,"start_character":44,"end_line":76,"end_character":57},"updated":"2021-01-06 13:37:07.000000000","message":"This should not be here (but is unlikely the source of your problems).","commit_id":"9cf251b0fb98875fbe9b0fe42b825bd417d28ed0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8056048c105a0a91c5b77451afb8af6523f0b06b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        node \u003d self._get_resource(_node.Node, node)"},{"line_number":74,"context_line":"        res \u003d _introspect.Introspection.new(connection\u003dself._get_connection(),"},{"line_number":75,"context_line":"                                            id\u003dnode.id,"},{"line_number":76,"context_line":"                                            lookup\u003dlookup)"},{"line_number":77,"context_line":"        kwargs \u003d {}"},{"line_number":78,"context_line":"        if manage_boot is not None:"},{"line_number":79,"context_line":"            kwargs[\u0027manage_boot\u0027] \u003d manage_boot"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba575f5f_8f9033cf","line":76,"range":{"start_line":76,"start_character":44,"end_line":76,"end_character":57},"in_reply_to":"90af4572_8396cc69","updated":"2021-01-07 07:57:36.000000000","message":"Done","commit_id":"9cf251b0fb98875fbe9b0fe42b825bd417d28ed0"}]}