)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38b76685cc66200fc8d4822fcdf6f663ebad135f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for deprecated nova hosts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Somebody might be willing to get some support for hosts even it is"},{"line_number":10,"context_line":"deprecated now. Let\u0027s add at least something."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9006c12e02dfe623ec48e846c9d0bdb530812d2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fffc6b78_fd5b2251","line":10,"updated":"2020-11-20 11:50:12.000000000","message":"Do we have somebody actually requesting it? Is it required for OSC? If both answers are no, I\u0027d rather leave it out.","commit_id":"2516e95a5cbdb33dd9caeb83e540569b0907fc3d"}],"openstack/compute/v2/host.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108bb952e157354a24d47a04485c0ac815c85049","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    # Properties"},{"line_number":40,"context_line":"    #: The name of the host."},{"line_number":41,"context_line":"    host \u003d _resource.Body(\u0027host\u0027)"},{"line_number":42,"context_line":"    #: Mode of maintenance state, either enable or disable."},{"line_number":43,"context_line":"    maintenance_mode \u003d _resource.Body(\u0027maintenance_mode\u0027)"},{"line_number":44,"context_line":"    #: The name of this flavor."},{"line_number":45,"context_line":"    name \u003d _resource.Body(\u0027host_name\u0027, alternate_id\u003dTrue, alias\u003d\u0027host\u0027)"},{"line_number":46,"context_line":"    #: The resource info of the host."}],"source_content_type":"text/x-python","patch_set":2,"id":"4ba851ac_5bd1c314","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":57},"updated":"2021-01-11 11:11:25.000000000","message":"I think I\u0027ve asked this before, but there\u0027s no way to capture that this is an enum, is there? FWIW, it\u0027ll accept any of the following: enable, Enable, ENABLE, disable, Disable, DISABLE\n\nAlso, this and \u0027status\u0027 are the only two fields that you can update via this API. I guess there\u0027s no \u0027updatable\u0027 flag?","commit_id":"2516e95a5cbdb33dd9caeb83e540569b0907fc3d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108bb952e157354a24d47a04485c0ac815c85049","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    #: The name of the service which is running on the host."},{"line_number":49,"context_line":"    service \u003d _resource.Body(\u0027service\u0027)"},{"line_number":50,"context_line":"    #: The status of the host, either enable or disable."},{"line_number":51,"context_line":"    status \u003d _resource.Body(\u0027status\u0027)"},{"line_number":52,"context_line":"    #: The available zone of the host."},{"line_number":53,"context_line":"    zone \u003d _resource.Body(\u0027zone\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8c6edc8e_7eae26da","line":51,"updated":"2021-01-11 11:11:25.000000000","message":"As above, there are six possible values allowed here.","commit_id":"2516e95a5cbdb33dd9caeb83e540569b0907fc3d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108bb952e157354a24d47a04485c0ac815c85049","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                body \u003d response.json()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"                # NOTE(gtema): in the fetch we get single entry \"host\" as a"},{"line_number":66,"context_line":"                # list of resources"},{"line_number":67,"context_line":"                host \u003d body.pop(\u0027host\u0027, [])"},{"line_number":68,"context_line":"                body[\u0027resources\u0027] \u003d []"},{"line_number":69,"context_line":"                for resource in host:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce87f8b0_7d26ab87","line":66,"updated":"2021-01-11 11:11:25.000000000","message":"It isn\u0027t entirely clear to me why we can\u0027t simply set \u0027self.resource_key \u003d \"host\"\u0027. An expanded note would be appreciated.\n\nLater: ah, it seems to be because we\u0027ve got double nested of resource, i.e. normally you\u0027d expect to see something like:\n\n  \"hosts\": [\n      {\n          \"cpu\": 2,\n          ...\n      },\n      ...\n  ]\n\nand instead we\u0027ve got:\n\n  \"host\": [\n      {\n          \"resource\": {\n              \"cpu\": 2,\n              ...\n          }\n      },\n      ...\n  ]\n\nI guess we\u0027ve no other choice here, but it\u0027d be good to document this extensively since it\u0027s very confusing for the layperson.","commit_id":"2516e95a5cbdb33dd9caeb83e540569b0907fc3d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108bb952e157354a24d47a04485c0ac815c85049","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        self.microversion \u003d microversion"},{"line_number":118,"context_line":"        self._translate_fetch_response(response, **kwargs)"},{"line_number":119,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":2,"id":"db9c4f63_4f2c6e8a","line":119,"updated":"2021-01-11 11:11:25.000000000","message":"This looks identical to definition in \u0027openstack.resource.Resource\u0027 except you\u0027re calling \u0027_translate_fetch_response\u0027 instead of \u0027_translate_response\u0027. Why? Can\u0027t we simply rename \u0027_translate_fetch_response\u0027 above to \u0027_translate_response\u0027?","commit_id":"2516e95a5cbdb33dd9caeb83e540569b0907fc3d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108bb952e157354a24d47a04485c0ac815c85049","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53aa982e_60c7b618","line":120,"updated":"2021-01-11 11:11:25.000000000","message":"You haven\u0027t captured the \u0027/os-hosts/{id}/reboot\u0027, \u0027/os-hosts/{id}/shutdown\u0027 or \u0027/os-hosts/{id}/startup\u0027 routes here. I assume you don\u0027t plan to (i.e. they\u0027re not needed for OSC)?","commit_id":"2516e95a5cbdb33dd9caeb83e540569b0907fc3d"}]}