)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"92480dc5e597c9688d14b36dbd8d313c8db2bbd3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     anuradha1904 \u003canuradha750871@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-11 00:17:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Ironic API on OpenStack SDK"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. List Conductors"},{"line_number":10,"context_line":"2. Show Conductors Details"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"085e4d43_700b1eaf","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"updated":"2020-12-18 15:13:21.000000000","message":"I would change to `Conductors API for Ironic on OpenStack SDK `\n\u003d)","commit_id":"9fee4d4602574212b033044f353e23cdc50a6d88"}],"openstack/baremetal/v1/_proxy.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11616e0161984edabd753d358e9270f13d4ee284","unresolved":true,"context_lines":[{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"    def get_conductor(self, conductor):"},{"line_number":1326,"context_line":"        \"\"\"Get a specific conductor."},{"line_number":1327,"context_line":"        :param driver: The value can be the name of a conductor or a"},{"line_number":1328,"context_line":"            :class:`~openstack.baremetal.v1.conductor.Conductor` instance."},{"line_number":1329,"context_line":"        :returns: One :class:`~openstack.baremetal.v1.conductor.Conductor`"},{"line_number":1330,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound` when no"}],"source_content_type":"text/x-python","patch_set":1,"id":"085984ff_9828974d","line":1327,"range":{"start_line":1327,"start_character":15,"end_line":1327,"end_character":21},"updated":"2020-12-10 22:46:56.000000000","message":"wrong name for the param","commit_id":"9fee4d4602574212b033044f353e23cdc50a6d88"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"88b0fdc0657ffec5a2fd0ffd4e2be1ff77703211","unresolved":true,"context_lines":[{"line_number":1418,"context_line":"        return self._get_resource(_deploytemplates.DeployTemplate,"},{"line_number":1419,"context_line":"                                  deploy_template).patch(self, patch)"},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"    def conductors(self, details\u003dFalse):"},{"line_number":1422,"context_line":"        \"\"\"Retrieve a generator of conductors."},{"line_number":1423,"context_line":"        :param bool details: A boolean indicating whether the detailed"},{"line_number":1424,"context_line":"            information for every conductor should be returned."}],"source_content_type":"text/x-python","patch_set":7,"id":"3bb0e878_0c646d65","line":1421,"updated":"2021-02-22 21:26:44.000000000","message":"missing query parameters (like you had in deploy templates), you can remove kwargs dict and update details directly in query.","commit_id":"3dfcbf9ef0f65cb171ba4d3c1f9ea06d91977b7c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"88b0fdc0657ffec5a2fd0ffd4e2be1ff77703211","unresolved":true,"context_lines":[{"line_number":1427,"context_line":"        kwargs \u003d {}"},{"line_number":1428,"context_line":"        if details:"},{"line_number":1429,"context_line":"            kwargs[\u0027details\u0027] \u003d True"},{"line_number":1430,"context_line":"        return self._list(_conductor.Conductor, **kwargs)"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"    def get_conductor(self, conductor):"},{"line_number":1433,"context_line":"        \"\"\"Get a specific conductor."}],"source_content_type":"text/x-python","patch_set":7,"id":"5d03a256_afc25ba9","line":1430,"updated":"2021-02-22 21:26:44.000000000","message":"you should use _conductor.Conductor.list(self, **query)","commit_id":"3dfcbf9ef0f65cb171ba4d3c1f9ea06d91977b7c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"88b0fdc0657ffec5a2fd0ffd4e2be1ff77703211","unresolved":true,"context_lines":[{"line_number":1429,"context_line":"            kwargs[\u0027details\u0027] \u003d True"},{"line_number":1430,"context_line":"        return self._list(_conductor.Conductor, **kwargs)"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"    def get_conductor(self, conductor):"},{"line_number":1433,"context_line":"        \"\"\"Get a specific conductor."},{"line_number":1434,"context_line":"        :param conductor: The value can be the name of a conductor or a"},{"line_number":1435,"context_line":"            :class:`~openstack.baremetal.v1.conductor.Conductor` instance."}],"source_content_type":"text/x-python","patch_set":7,"id":"143aa076_fc558c02","line":1432,"updated":"2021-02-22 21:26:44.000000000","message":"missing fields option.","commit_id":"3dfcbf9ef0f65cb171ba4d3c1f9ea06d91977b7c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"88b0fdc0657ffec5a2fd0ffd4e2be1ff77703211","unresolved":true,"context_lines":[{"line_number":1437,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound` when no"},{"line_number":1438,"context_line":"            conductor matching the name could be found."},{"line_number":1439,"context_line":"        \"\"\""},{"line_number":1440,"context_line":"        return self._get(_conductor.Conductor, conductor)"}],"source_content_type":"text/x-python","patch_set":7,"id":"15be40f0_0cef50c2","line":1440,"range":{"start_line":1440,"start_character":20,"end_line":1440,"end_character":24},"updated":"2021-02-22 21:26:44.000000000","message":"you should use get_with_fields","commit_id":"3dfcbf9ef0f65cb171ba4d3c1f9ea06d91977b7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caa838923ff39061f1843c0ac20230e4b9b5b950","unresolved":true,"context_lines":[{"line_number":1419,"context_line":"                                  deploy_template).patch(self, patch)"},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"    def conductors(self, details\u003dFalse, **query):"},{"line_number":1422,"context_line":"        \"\"\"Retrieve a generator of conductors."},{"line_number":1423,"context_line":"        :param bool details: A boolean indicating whether the detailed"},{"line_number":1424,"context_line":"            information for every conductor should be returned."},{"line_number":1425,"context_line":"        :returns: A generator of conductor instances."}],"source_content_type":"text/x-python","patch_set":9,"id":"0efccb23_681a3374","line":1422,"updated":"2021-02-24 11:46:52.000000000","message":"nit: Missing newline under here. This will render as one giant text string as-is","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caa838923ff39061f1843c0ac20230e4b9b5b950","unresolved":true,"context_lines":[{"line_number":1419,"context_line":"                                  deploy_template).patch(self, patch)"},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"    def conductors(self, details\u003dFalse, **query):"},{"line_number":1422,"context_line":"        \"\"\"Retrieve a generator of conductors."},{"line_number":1423,"context_line":"        :param bool details: A boolean indicating whether the detailed"},{"line_number":1424,"context_line":"            information for every conductor should be returned."},{"line_number":1425,"context_line":"        :returns: A generator of conductor instances."}],"source_content_type":"text/x-python","patch_set":9,"id":"dd36292c_cc2e6cd4","line":1422,"updated":"2021-02-24 11:46:52.000000000","message":"nit: Missing newline under here. This will render as one giant text string as-is, e.g.\n\nhttp://rst.ninjs.org/#Zm9vCjpiYXI6IGJhegoKZm9vCgo6YmFyOiBiYXo\u003d","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"dc0bab88fb5d7bfd1c4fce965522a243d0a32f12","unresolved":true,"context_lines":[{"line_number":1419,"context_line":"                                  deploy_template).patch(self, patch)"},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"    def conductors(self, details\u003dFalse, **query):"},{"line_number":1422,"context_line":"        \"\"\"Retrieve a generator of conductors."},{"line_number":1423,"context_line":"        :param bool details: A boolean indicating whether the detailed"},{"line_number":1424,"context_line":"            information for every conductor should be returned."},{"line_number":1425,"context_line":"        :returns: A generator of conductor instances."}],"source_content_type":"text/x-python","patch_set":9,"id":"fe2c9929_c0855249","line":1422,"in_reply_to":"dd36292c_cc2e6cd4","updated":"2021-02-24 11:53:41.000000000","message":"ack","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caa838923ff39061f1843c0ac20230e4b9b5b950","unresolved":true,"context_lines":[{"line_number":1430,"context_line":"        return _conductor.Conductor.list(self, **query)"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"    def get_conductor(self, conductor, fields\u003dNone):"},{"line_number":1433,"context_line":"        \"\"\"Get a specific conductor."},{"line_number":1434,"context_line":"        :param conductor: The value can be the name of a conductor or a"},{"line_number":1435,"context_line":"            :class:`~openstack.baremetal.v1.conductor.Conductor` instance."},{"line_number":1436,"context_line":"        :returns: One :class:`~openstack.baremetal.v1.conductor.Conductor`"}],"source_content_type":"text/x-python","patch_set":9,"id":"a1bbac84_610b52a0","line":1433,"updated":"2021-02-24 11:46:52.000000000","message":"ditto","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"dc0bab88fb5d7bfd1c4fce965522a243d0a32f12","unresolved":true,"context_lines":[{"line_number":1430,"context_line":"        return _conductor.Conductor.list(self, **query)"},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"    def get_conductor(self, conductor, fields\u003dNone):"},{"line_number":1433,"context_line":"        \"\"\"Get a specific conductor."},{"line_number":1434,"context_line":"        :param conductor: The value can be the name of a conductor or a"},{"line_number":1435,"context_line":"            :class:`~openstack.baremetal.v1.conductor.Conductor` instance."},{"line_number":1436,"context_line":"        :returns: One :class:`~openstack.baremetal.v1.conductor.Conductor`"}],"source_content_type":"text/x-python","patch_set":9,"id":"91cb8ca6_143932ca","line":1433,"in_reply_to":"a1bbac84_610b52a0","updated":"2021-02-24 11:53:41.000000000","message":"ack","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"}],"openstack/baremetal/v1/conductor.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11616e0161984edabd753d358e9270f13d4ee284","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Conductor(_common.ListMixin, resource.Resource):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    resources_key \u003d \u0027/conductors\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/conductors\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":1,"id":"5d728101_89114ea1","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":33},"updated":"2020-12-10 22:46:56.000000000","message":"this still wrong \u003d) check my comment on your old patch","commit_id":"9fee4d4602574212b033044f353e23cdc50a6d88"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ffad2e5df724af25cabc1ec92914b8ff44d976b8","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Conductor(_common.ListMixin, resource.Resource):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    resources_key \u003d \u0027/conductors\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/conductors\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":2,"id":"97491ff0_9b75fb20","line":19,"range":{"start_line":19,"start_character":21,"end_line":19,"end_character":32},"updated":"2021-02-17 19:35:16.000000000","message":"this is wrong see https://docs.openstack.org/api-ref/baremetal/?expanded\u003dlist-conductors-detail#conductors-conductors","commit_id":"289ba2aae9b1435d5b58b91faeecf2a503521e02"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ffad2e5df724af25cabc1ec92914b8ff44d976b8","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    allow_patch \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":31,"context_line":"        \u0027node\u0027, \u0027detail\u0027,"},{"line_number":32,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":33,"context_line":"    )"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1925d2f8_786b5338","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":15},"updated":"2021-02-17 19:35:16.000000000","message":"Node is not available in https://docs.openstack.org/api-ref/baremetal/?expanded\u003dlist-conductors-detail#id165","commit_id":"289ba2aae9b1435d5b58b91faeecf2a503521e02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caa838923ff39061f1843c0ac20230e4b9b5b950","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Conductor(_common.ListMixin, resource.Resource):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    resources_key \u003d \u0027conductors\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/conductors\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":9,"id":"771b1400_55418e91","line":19,"updated":"2021-02-24 11:46:52.000000000","message":"Oh, weird. No \u0027resource_key\u0027 because ironic doesn\u0027t envelope this (any?) detail response","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"dc0bab88fb5d7bfd1c4fce965522a243d0a32f12","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Conductor(_common.ListMixin, resource.Resource):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    resources_key \u003d \u0027conductors\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/conductors\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":9,"id":"343d71bd_81b7861c","line":19,"in_reply_to":"771b1400_55418e91","updated":"2021-02-24 11:53:41.000000000","message":"Stepehn, not sure if I understood what you mean.\n\nWhen listing conductors we do have the resource_key \nhttps://docs.openstack.org/api-ref/baremetal/?expanded\u003dlist-conductors-detail#id166","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"caa838923ff39061f1843c0ac20230e4b9b5b950","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    hostname \u003d resource.Body(\u0027hostname\u0027)"},{"line_number":39,"context_line":"    conductor_group \u003d resource.Body(\u0027conductor_group\u0027)"},{"line_number":40,"context_line":"    alive \u003d resource.Body(\u0027alive\u0027, type\u003dbool)"},{"line_number":41,"context_line":"    links \u003d resource.Body(\u0027links\u0027, type\u003dlist)"},{"line_number":42,"context_line":"    drivers \u003d resource.Body(\u0027drivers\u0027, type\u003dlist)"}],"source_content_type":"text/x-python","patch_set":9,"id":"efa7d7ba_653aec99","line":41,"updated":"2021-02-24 11:46:52.000000000","message":"nit: We surely have a Links resource we could set for the \u0027list_type\u0027?","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"dc0bab88fb5d7bfd1c4fce965522a243d0a32f12","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    hostname \u003d resource.Body(\u0027hostname\u0027)"},{"line_number":39,"context_line":"    conductor_group \u003d resource.Body(\u0027conductor_group\u0027)"},{"line_number":40,"context_line":"    alive \u003d resource.Body(\u0027alive\u0027, type\u003dbool)"},{"line_number":41,"context_line":"    links \u003d resource.Body(\u0027links\u0027, type\u003dlist)"},{"line_number":42,"context_line":"    drivers \u003d resource.Body(\u0027drivers\u0027, type\u003dlist)"}],"source_content_type":"text/x-python","patch_set":9,"id":"cf78536d_638d7405","line":41,"in_reply_to":"efa7d7ba_653aec99","updated":"2021-02-24 11:53:41.000000000","message":"In all ironic code in openstacksdk we have been using like this.","commit_id":"e3d5b40d187af3a3d955843f310c05bfa8189fd8"}],"openstack/tests/functional/baremetal/test_baremetal_conductor.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11616e0161984edabd753d358e9270f13d4ee284","unresolved":true,"context_lines":[{"line_number":18,"context_line":"class TestBareMetalConductor(base.BaseBaremetalTest):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_conductor_list(self):"},{"line_number":21,"context_line":"        conductors \u003d self.conn.baremetal.conductor()"},{"line_number":22,"context_line":"        self.assertNotEqual([], [conductors.hostname for c in conductors])"}],"source_content_type":"text/x-python","patch_set":1,"id":"196027c2_c38c3dd4","line":21,"range":{"start_line":21,"start_character":41,"end_line":21,"end_character":50},"updated":"2020-12-10 22:46:56.000000000","message":"the name of the method is wrong, should be conductors","commit_id":"9fee4d4602574212b033044f353e23cdc50a6d88"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11616e0161984edabd753d358e9270f13d4ee284","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_conductor_list(self):"},{"line_number":21,"context_line":"        conductors \u003d self.conn.baremetal.conductor()"},{"line_number":22,"context_line":"        self.assertNotEqual([], [conductors.hostname for c in conductors])"}],"source_content_type":"text/x-python","patch_set":1,"id":"40039d53_a4158bf6","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":74},"updated":"2020-12-10 22:46:56.000000000","message":"you need to assert that your variable conductors is not empty list, I you can use assertTrue for example of check if the len \u003e 0.\n\nAfter doing this you would iterate over the conductors and request each conductor you found  with get_conductor(c.hostname) and create a few asserts that will make sure the conductors have some information.","commit_id":"9fee4d4602574212b033044f353e23cdc50a6d88"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ffad2e5df724af25cabc1ec92914b8ff44d976b8","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack.baremetal.v1 import _proxy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class TestBareMetalConductor(_proxy.Proxy):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_fake_conductor_get(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"34c8bfc5_4079da4a","line":15,"updated":"2021-02-17 19:35:16.000000000","message":"You need to create a FAKE_CONDUCTOR an do the tests based on that like you did in deploy templates for example","commit_id":"289ba2aae9b1435d5b58b91faeecf2a503521e02"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"24749812c10c4fd385f9fa479a6d057170761e79","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from openstack.baremetal.v1 import _proxy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class TestBareMetalConductor(_proxy.Proxy):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_fake_conductor_get(self):"},{"line_number":19,"context_line":"        conductors \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"8a13a8a2_a9a3503b","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":41},"updated":"2021-02-18 21:54:31.000000000","message":"functional tests doesn\u0027t use _proxy.Proxy, check the functional test you did for deploy template or any other functional tests we have in the directory.","commit_id":"b7cbb0ff4fe4219fa4c9e8c021db4c68d2923f98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"24749812c10c4fd385f9fa479a6d057170761e79","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class TestBareMetalConductor(_proxy.Proxy):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_fake_conductor_get(self):"},{"line_number":19,"context_line":"        conductors \u003d ["},{"line_number":20,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"fb8cbf22_2e54a74d","line":17,"updated":"2021-02-18 21:54:31.000000000","message":"missing min_microversion information","commit_id":"b7cbb0ff4fe4219fa4c9e8c021db4c68d2923f98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"24749812c10c4fd385f9fa479a6d057170761e79","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"af9eeff5_80f90b37","line":110,"updated":"2021-02-18 21:54:31.000000000","message":"You can remove both tests: test_fake_conductor_get and test_fake_conductor_list_details\nYou need to create one functional test (test_conductor), in this test you need to consider the following scenario:\n1- Create a node (you can find examples in many functional tests), the node has the conductor he is part (https://github.com/openstack/openstacksdk/blob/master/openstack/baremetal/v1/node.py#L110)\n2- Request a list of conductors, retrieve their names and store in a list and assert that the list contains the node.conductor.\n3- Request the conductor from the node and assert that it has the different attributes.","commit_id":"b7cbb0ff4fe4219fa4c9e8c021db4c68d2923f98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"88b0fdc0657ffec5a2fd0ffd4e2be1ff77703211","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    min_microversion \u003d \u00271.49\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_fake_conductor_get(self):"},{"line_number":22,"context_line":"        node \u003d self.create_node(name\u003d\u0027node-name\u0027)"},{"line_number":23,"context_line":"        conductors \u003d self.conn.baremetal.conductors()"},{"line_number":24,"context_line":"        hostname_list \u003d [conductor.hostname for conductor in conductors]"}],"source_content_type":"text/x-python","patch_set":7,"id":"81b01ed3_c098ee19","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":31},"updated":"2021-02-22 21:26:44.000000000","message":"you can change the name of the function to something like test_list_get_conductor","commit_id":"3dfcbf9ef0f65cb171ba4d3c1f9ea06d91977b7c"}]}