)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"094550b427f082743771cfe39c2f4a06eb8b062f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-12-29 00:11:16 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Ironic API on OpenStack SDK"},{"line_number":8,"context_line":"1. Create Deploy Template"},{"line_number":9,"context_line":"2. List Deploy Templates"},{"line_number":10,"context_line":"3. Show Deploy Template Details"},{"line_number":11,"context_line":"4. Update a Deploy Template"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6743fb3e_ac6533c2","line":8,"updated":"2021-01-04 10:00:07.000000000","message":"please separate the title from the commit message or it will just all go into one very long line","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f4b5f4079336076320cabfa789e068427a9e59f8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     anuradha1904 \u003canuradha750871@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-06 22:51:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Ironic API on OpenStack SDK"},{"line_number":8,"context_line":"1. Create Deploy Template"},{"line_number":9,"context_line":"2. List Deploy Templates"},{"line_number":10,"context_line":"3. Show Deploy Template Details"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6116a515_3520dbeb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"updated":"2021-01-06 19:32:20.000000000","message":"I would change to something more specific \"Support Deploy Templates for Ironic API\"","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     anuradha1904 \u003canuradha750871@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-06 22:51:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Ironic API on OpenStack SDK"},{"line_number":8,"context_line":"1. Create Deploy Template"},{"line_number":9,"context_line":"2. List Deploy Templates"},{"line_number":10,"context_line":"3. Show Deploy Template Details"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f4affa14_c8ba036c","line":7,"updated":"2021-01-06 18:23:15.000000000","message":"Please insert an empty line after the summary","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"79bb47d23e28a795066520f7fbef84c35e08f8e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     anuradha1904 \u003canuradha750871@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-06 22:51:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Ironic API on OpenStack SDK"},{"line_number":8,"context_line":"1. Create Deploy Template"},{"line_number":9,"context_line":"2. List Deploy Templates"},{"line_number":10,"context_line":"3. Show Deploy Template Details"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6d4d5104_87a2026d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"in_reply_to":"6116a515_3520dbeb","updated":"2021-01-07 18:46:59.000000000","message":"Done","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"}],"doc/source/user/proxies/baremetal.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":81,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":82,"context_line":".. autoclass:: openstack.baremetal.v1._proxy.Proxy"},{"line_number":83,"context_line":"  :noindex:"},{"line_number":84,"context_line":"  :members: deploy_template, find_deploy_template, get_deploy_template,"},{"line_number":85,"context_line":"            create_deploy_template, update_deploy_template,"},{"line_number":86,"context_line":"            patch_deploy_template, delete_deploy_template"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4c395e0c_71cad39f","line":84,"updated":"2021-01-06 18:23:15.000000000","message":"deploy_templates? (plural)","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"}],"doc/source/user/resources/baremetal/index.rst":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":12,"context_line":"   v1/allocation"},{"line_number":13,"context_line":"   v1/volume_connector"},{"line_number":14,"context_line":"   v1/volume_target"},{"line_number":15,"context_line":"   v1/deploy_templates"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7069012f_b1157bab","line":15,"updated":"2020-12-29 01:44:40.000000000","message":"Missing changes on doc/source/user/proxies/baremetal.rst and adding the deploy_templates.rst  under doc/source/user/resources/baremetal/v1/","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"}],"doc/source/user/resources/baremetal/v1/deploy_templates.rst":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"36629d905cccf942c036f759ca761b7a7732bf70","unresolved":true,"context_lines":[{"line_number":1,"context_line":"openstack.baremetal.v1.volume_target"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.baremetal.v1.deploy_templates"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4f75c0e0_d67d1f87","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":36},"updated":"2021-01-06 18:38:57.000000000","message":"volume_target?","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"79bb47d23e28a795066520f7fbef84c35e08f8e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack.baremetal.v1.volume_target"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.baremetal.v1.deploy_templates"}],"source_content_type":"text/x-rst","patch_set":2,"id":"174a2a32_ee32630f","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":36},"in_reply_to":"4f75c0e0_d67d1f87","updated":"2021-01-07 18:46:59.000000000","message":"Done","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"79bb47d23e28a795066520f7fbef84c35e08f8e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"683e1f33_df2a821b","line":14,"updated":"2021-01-07 18:46:59.000000000","message":"This file has something that needs to be fixed, try running the test for docs locally to identify\n\n$ tox -e docs","commit_id":"7cbb6f4972367ff57e11a7375741e9faad1832f8"}],"openstack/baremetal/v1/_proxy.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":1314,"context_line":"    def deploy_templates(self, details\u003dFalse, **query):"},{"line_number":1315,"context_line":"        \"\"\"Retrieve a generator of deploy_templates."},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"        :param details:"},{"line_number":1318,"context_line":"        :param dict query: Optional query parameters to be sent to"},{"line_number":1319,"context_line":"        restrict the deploy_templates to be returned."},{"line_number":1320,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6596f703_2e90632d","line":1317,"range":{"start_line":1317,"start_character":8,"end_line":1317,"end_character":23},"updated":"2020-12-29 01:44:40.000000000","message":"missing description","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":1318,"context_line":"        :param dict query: Optional query parameters to be sent to"},{"line_number":1319,"context_line":"        restrict the deploy_templates to be returned."},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        :returns:"},{"line_number":1322,"context_line":"        \"\"\""},{"line_number":1323,"context_line":"        return _deploytemplates.DeployTemplate.list(self,"},{"line_number":1324,"context_line":"                                                    details\u003ddetails, **query)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ed4bc23_8f9b0412","line":1321,"range":{"start_line":1321,"start_character":8,"end_line":1321,"end_character":17},"updated":"2020-12-29 01:44:40.000000000","message":"missing what returns","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":1318,"context_line":"        :param dict query: Optional query parameters to be sent to"},{"line_number":1319,"context_line":"        restrict the deploy_templates to be returned."},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        :returns:"},{"line_number":1322,"context_line":"        \"\"\""},{"line_number":1323,"context_line":"        return _deploytemplates.DeployTemplate.list(self,"},{"line_number":1324,"context_line":"                                                    details\u003ddetails, **query)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2122203_42d1b4c6","line":1321,"updated":"2020-12-29 01:44:40.000000000","message":"you may need to add a workaround for details like we have in the volume_targets volume_connectors functions in this file.","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":1324,"context_line":"                                                    details\u003ddetails, **query)"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"    def create_deploy_template(self, **attrs):"},{"line_number":1327,"context_line":"        \"\"\"Create a new deploy_template from attributes."},{"line_number":1328,"context_line":"        \"\"\""},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"        return self._create(_deploytemplates.DeployTemplate, **attrs)"},{"line_number":1331,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"59135fff_4e7b5684","line":1328,"range":{"start_line":1327,"start_character":7,"end_line":1328,"end_character":11},"updated":"2020-12-29 01:44:40.000000000","message":"missing description of parameters and the return","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":1330,"context_line":"        return self._create(_deploytemplates.DeployTemplate, **attrs)"},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"    def update_deploy_template(self, deploy_template, **attrs):"},{"line_number":1333,"context_line":"        \"\"\"Update a deployment_template."},{"line_number":1334,"context_line":"        \"\"\""},{"line_number":1335,"context_line":"        return self._update(_deploytemplates.DeployTemplate,"},{"line_number":1336,"context_line":"                            deploy_template, **attrs)"},{"line_number":1337,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"641177f1_a7581d37","line":1334,"range":{"start_line":1333,"start_character":7,"end_line":1334,"end_character":11},"updated":"2020-12-29 01:44:40.000000000","message":"missing description of parameters and the return","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":1334,"context_line":"        \"\"\""},{"line_number":1335,"context_line":"        return self._update(_deploytemplates.DeployTemplate,"},{"line_number":1336,"context_line":"                            deploy_template, **attrs)"},{"line_number":1337,"context_line":""},{"line_number":1338,"context_line":"    def delete_deployment_template(self, volume_target,"},{"line_number":1339,"context_line":"                                   ignore_missing\u003dTrue):"},{"line_number":1340,"context_line":"        \"\"\"Delete an deployment_template."}],"source_content_type":"text/x-python","patch_set":1,"id":"b6a11fb3_124dbcf4","line":1337,"updated":"2020-12-29 01:44:40.000000000","message":"missing patch_deploy_template function","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":1337,"context_line":""},{"line_number":1338,"context_line":"    def delete_deployment_template(self, volume_target,"},{"line_number":1339,"context_line":"                                   ignore_missing\u003dTrue):"},{"line_number":1340,"context_line":"        \"\"\"Delete an deployment_template."},{"line_number":1341,"context_line":"        \"\"\""},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"        return self._delete(_volumetarget.VolumeTarget,"},{"line_number":1344,"context_line":"                            volume_target, ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ed894e7_d6f86177","line":1341,"range":{"start_line":1340,"start_character":6,"end_line":1341,"end_character":11},"updated":"2020-12-29 01:44:40.000000000","message":"missing description of parameters and the return","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"36629d905cccf942c036f759ca761b7a7732bf70","unresolved":true,"context_lines":[{"line_number":1314,"context_line":"    def deploy_templates(self, details\u003dFalse, **query):"},{"line_number":1315,"context_line":"        \"\"\"Retrieve a generator of deploy_templates."},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"        :param details:"},{"line_number":1318,"context_line":"        :param dict query: Optional query parameters to be sent to"},{"line_number":1319,"context_line":"        restrict the deploy_templates to be returned."},{"line_number":1320,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b5acdd18_05299b4d","line":1317,"range":{"start_line":1317,"start_character":8,"end_line":1317,"end_character":23},"updated":"2021-01-06 18:38:57.000000000","message":"missing the description about details","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"79bb47d23e28a795066520f7fbef84c35e08f8e5","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"    def deploy_templates(self, details\u003dFalse, **query):"},{"line_number":1315,"context_line":"        \"\"\"Retrieve a generator of deploy_templates."},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"        :param details:"},{"line_number":1318,"context_line":"        :param dict query: Optional query parameters to be sent to"},{"line_number":1319,"context_line":"        restrict the deploy_templates to be returned."},{"line_number":1320,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cd35d707_13c707b7","line":1317,"range":{"start_line":1317,"start_character":8,"end_line":1317,"end_character":23},"in_reply_to":"b5acdd18_05299b4d","updated":"2021-01-07 18:46:59.000000000","message":"Done","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"        :param dict attrs: Keyword arguments that will be used to create a"},{"line_number":1330,"context_line":"            :class:"},{"line_number":1331,"context_line":"            `~openstack.baremetal.v1._deploytemplates.DeployTemplate`."},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"        :returns: The results of deploy_template creation."},{"line_number":1334,"context_line":"        :rtype::class:"}],"source_content_type":"text/x-python","patch_set":2,"id":"73c46b9d_effee819","line":1331,"updated":"2021-01-06 18:23:15.000000000","message":"This path here and below seems invalid, _deploytemplates is a local alias, you need deploy_templates","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":1331,"context_line":"            `~openstack.baremetal.v1._deploytemplates.DeployTemplate`."},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"        :returns: The results of deploy_template creation."},{"line_number":1334,"context_line":"        :rtype::class:"},{"line_number":1335,"context_line":"            `~openstack.baremetal.v1._deploytemplates.DeployTemplate`."},{"line_number":1336,"context_line":"        \"\"\""},{"line_number":1337,"context_line":"        return self._create(_deploytemplates.DeployTemplate, **attrs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a603dcc5_533b6f0c","line":1334,"updated":"2021-01-06 18:23:15.000000000","message":"I think you need a space before :class:","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"        \"\"\""},{"line_number":1337,"context_line":"        return self._create(_deploytemplates.DeployTemplate, **attrs)"},{"line_number":1338,"context_line":""},{"line_number":1339,"context_line":"    def update_deploy_template(self, deploy_template, **attrs):"},{"line_number":1340,"context_line":"        \"\"\"Update a deploy_template."},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"        :param deploy_template: Either the ID of a node, or an instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"b369088b_2999b7ce","line":1339,"updated":"2021-01-06 18:23:15.000000000","message":"Please add a patch method similar to other resources","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":1343,"context_line":"            of :class:`~openstack."},{"line_number":1344,"context_line":"            baremetal.v1._deploytemplates.DeployTemplate`."},{"line_number":1345,"context_line":"        :param dict attrs: The attributes to update on"},{"line_number":1346,"context_line":"        the deploy_template represented"},{"line_number":1347,"context_line":"            by the ``deploy_template`` parameter."},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"        :returns: The updated deploy_template."}],"source_content_type":"text/x-python","patch_set":2,"id":"e35a8274_d4108d77","line":1346,"updated":"2021-01-06 18:23:15.000000000","message":"wrong indentation","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"        :returns: The updated deploy_template."},{"line_number":1350,"context_line":"        :rtype: :class:`~openstack.baremetal.v1."},{"line_number":1351,"context_line":"        deploytemplates.DeployTemplate`"},{"line_number":1352,"context_line":"        \"\"\""},{"line_number":1353,"context_line":"        return self._update(_deploytemplates.DeployTemplate,"},{"line_number":1354,"context_line":"                            deploy_template, **attrs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"839af92f_578e47c6","line":1351,"updated":"2021-01-06 18:23:15.000000000","message":"missing indentation (also not sure if you can break it like this)","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"            a :class:`~openstack.baremetal.v1._"},{"line_number":1363,"context_line":"            deploytemplates.DeployTemplate` instance."},{"line_number":1364,"context_line":"        :param bool ignore_missing: When set to ``False``,"},{"line_number":1365,"context_line":"        an exception"},{"line_number":1366,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":1367,"context_line":"            will be raised when the deploy_template"},{"line_number":1368,"context_line":"            could not be found."}],"source_content_type":"text/x-python","patch_set":2,"id":"b996c5e6_ec74b0c9","line":1365,"updated":"2021-01-06 18:23:15.000000000","message":"indentation and line wrapping is off here","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"36629d905cccf942c036f759ca761b7a7732bf70","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fa15ff4_78a89aaf","line":1381,"updated":"2021-01-06 18:38:57.000000000","message":"You need to add a get_deploy_tempalte, find_deploy_template and patch_deploy_tempalte","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"79bb47d23e28a795066520f7fbef84c35e08f8e5","unresolved":true,"context_lines":[{"line_number":1332,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`."},{"line_number":1333,"context_line":""},{"line_number":1334,"context_line":"        :returns: The results of deploy_template creation."},{"line_number":1335,"context_line":"        :rtype::class:"},{"line_number":1336,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`."},{"line_number":1337,"context_line":"        \"\"\""},{"line_number":1338,"context_line":"        return self._create(_deploytemplates.DeployTemplate, **attrs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2794ece3_4feb0ec2","line":1335,"range":{"start_line":1335,"start_character":8,"end_line":1335,"end_character":22},"updated":"2021-01-07 18:46:59.000000000","message":"There is a comment from Dmitry you probably missed on patch set #2, you need a space before :class: ✔","commit_id":"7cbb6f4972367ff57e11a7375741e9faad1832f8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1317,"context_line":"        :param details: A boolean indicating whether the detailed information"},{"line_number":1318,"context_line":"                        for every deploy_templates should be returned."},{"line_number":1319,"context_line":"        :param dict query: Optional query parameters to be sent to"},{"line_number":1320,"context_line":"        restrict the deploy_templates to be returned."},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        :returns: A generator of Deploy templates instances"},{"line_number":1323,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bc546422_7b8bd5ef","line":1320,"range":{"start_line":1320,"start_character":8,"end_line":1320,"end_character":53},"updated":"2021-01-11 14:00:56.000000000","message":"You need to fix the indentation of this line.","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1319,"context_line":"        :param dict query: Optional query parameters to be sent to"},{"line_number":1320,"context_line":"        restrict the deploy_templates to be returned."},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        :returns: A generator of Deploy templates instances"},{"line_number":1323,"context_line":"        \"\"\""},{"line_number":1324,"context_line":"        return _deploytemplates.DeployTemplate.list(self,"},{"line_number":1325,"context_line":"                                                    details\u003ddetails, **query)"}],"source_content_type":"text/x-python","patch_set":6,"id":"14cde37a_63f21f6a","line":1322,"range":{"start_line":1322,"start_character":8,"end_line":1322,"end_character":59},"updated":"2021-01-11 14:00:56.000000000","message":"please add a period to the end here.","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1332,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`."},{"line_number":1333,"context_line":""},{"line_number":1334,"context_line":"        :returns: The results of deploy_template creation."},{"line_number":1335,"context_line":"        :rtype: :class:"},{"line_number":1336,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`."},{"line_number":1337,"context_line":"        \"\"\""},{"line_number":1338,"context_line":"        return self._create(_deploytemplates.DeployTemplate, **attrs)"},{"line_number":1339,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8b285910_0f7d1fdb","line":1336,"range":{"start_line":1335,"start_character":0,"end_line":1336,"end_character":70},"updated":"2021-01-11 14:00:56.000000000","message":"The `:class:` needs to be moved to L1336.","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1340,"context_line":"    def update_deploy_template(self, deploy_template, **attrs):"},{"line_number":1341,"context_line":"        \"\"\"Update a deploy_template."},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"        :param deploy_template: Either the ID of a deploy_template,"},{"line_number":1344,"context_line":"                                or an instance"},{"line_number":1345,"context_line":"        of :class:"},{"line_number":1346,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`."},{"line_number":1347,"context_line":"        :param dict attrs: The attributes to update on"},{"line_number":1348,"context_line":"        the deploy_template represented"},{"line_number":1349,"context_line":"            by the ``deploy_template`` parameter."}],"source_content_type":"text/x-python","patch_set":6,"id":"4c99f327_cf3a8520","line":1346,"range":{"start_line":1343,"start_character":0,"end_line":1346,"end_character":70},"updated":"2021-01-11 14:00:56.000000000","message":"The indentation here is wrong and docs will complain.\nIf the description doesn\u0027t fit in 1 line you need to have a correct indentation for all other lines below. The limit of characters on each line is 79 (including spaces and the identation), you can probably move some word from L1344 to L1343, L1344 you would have the other words that you couldn\u0027t fit on L1343 because of the limit of characters and on L1345 you would have :class:`~openstack.baremetal.v1.deploy_templates.DeployTemplate`.","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1344,"context_line":"                                or an instance"},{"line_number":1345,"context_line":"        of :class:"},{"line_number":1346,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`."},{"line_number":1347,"context_line":"        :param dict attrs: The attributes to update on"},{"line_number":1348,"context_line":"        the deploy_template represented"},{"line_number":1349,"context_line":"            by the ``deploy_template`` parameter."},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"        :returns: The updated deploy_template."},{"line_number":1352,"context_line":"        :rtype: :class:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ead87802_206ef5f1","line":1349,"range":{"start_line":1347,"start_character":0,"end_line":1349,"end_character":49},"updated":"2021-01-11 14:00:56.000000000","message":"Also wrong indentation,","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1349,"context_line":"            by the ``deploy_template`` parameter."},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"        :returns: The updated deploy_template."},{"line_number":1352,"context_line":"        :rtype: :class:"},{"line_number":1353,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`"},{"line_number":1354,"context_line":"        \"\"\""},{"line_number":1355,"context_line":"        return self._update(_deploytemplates.DeployTemplate,"},{"line_number":1356,"context_line":"                            deploy_template, **attrs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e425c922_623813a4","line":1353,"range":{"start_line":1352,"start_character":0,"end_line":1353,"end_character":69},"updated":"2021-01-11 14:00:56.000000000","message":"Same problem you have in the `create_deploy_template` function.","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1359,"context_line":"                               ignore_missing\u003dTrue):"},{"line_number":1360,"context_line":"        \"\"\"Delete a deploy_template."},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"        :param deploy_template:The value can be"},{"line_number":1363,"context_line":"        either the ID of a deploy_template or"},{"line_number":1364,"context_line":"            a :class:"},{"line_number":1365,"context_line":"                `~openstack.baremetal.v1.deploy_templates.DeployTemplate`"},{"line_number":1366,"context_line":"                        instance."},{"line_number":1367,"context_line":"        :param bool ignore_missing: When set to ``False``,"},{"line_number":1368,"context_line":"        an exception"},{"line_number":1369,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound`"}],"source_content_type":"text/x-python","patch_set":6,"id":"995338b8_10f4aa89","line":1366,"range":{"start_line":1362,"start_character":0,"end_line":1366,"end_character":32},"updated":"2021-01-11 14:00:56.000000000","message":"indentation problem","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1364,"context_line":"            a :class:"},{"line_number":1365,"context_line":"                `~openstack.baremetal.v1.deploy_templates.DeployTemplate`"},{"line_number":1366,"context_line":"                        instance."},{"line_number":1367,"context_line":"        :param bool ignore_missing: When set to ``False``,"},{"line_number":1368,"context_line":"        an exception"},{"line_number":1369,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":1370,"context_line":"             will be raised when the deploy_template"},{"line_number":1371,"context_line":"             could not be found."},{"line_number":1372,"context_line":"             When set to ``True``, no"},{"line_number":1373,"context_line":"             exception will be raised when attempting"},{"line_number":1374,"context_line":"             to delete a non-existent"},{"line_number":1375,"context_line":"             deploy_template."},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"        :returns: The instance of the deploy_template which was deleted."},{"line_number":1378,"context_line":"        :rtype: :class:"}],"source_content_type":"text/x-python","patch_set":6,"id":"86267e0f_5bc63d6e","line":1375,"range":{"start_line":1367,"start_character":0,"end_line":1375,"end_character":29},"updated":"2021-01-11 14:00:56.000000000","message":"indentation problem","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1375,"context_line":"             deploy_template."},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"        :returns: The instance of the deploy_template which was deleted."},{"line_number":1378,"context_line":"        :rtype: :class:"},{"line_number":1379,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`."},{"line_number":1380,"context_line":"        \"\"\""},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"        return self._delete(_deploytemplates.DeployTemplate,"}],"source_content_type":"text/x-python","patch_set":6,"id":"70a9eb60_4b478da7","line":1379,"range":{"start_line":1378,"start_character":0,"end_line":1379,"end_character":70},"updated":"2021-01-11 14:00:56.000000000","message":"ditto","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1385,"context_line":"    def get_deploy_template(self, deploy_template, fields\u003dNone):"},{"line_number":1386,"context_line":"        \"\"\"Get a specific deployment template."},{"line_number":1387,"context_line":""},{"line_number":1388,"context_line":"        :param deploy_template: The value can be the name or ID"},{"line_number":1389,"context_line":"                                of a deployment template"},{"line_number":1390,"context_line":"            :class:"},{"line_number":1391,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate` instance."},{"line_number":1392,"context_line":"        :param fields: Limit the resource fields to fetch."},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        :returns: One :class:"}],"source_content_type":"text/x-python","patch_set":6,"id":"4cda8d8f_e7838164","line":1391,"range":{"start_line":1388,"start_character":1,"end_line":1391,"end_character":79},"updated":"2021-01-11 14:00:56.000000000","message":"ditto","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1391,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate` instance."},{"line_number":1392,"context_line":"        :param fields: Limit the resource fields to fetch."},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        :returns: One :class:"},{"line_number":1395,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate`"},{"line_number":1396,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound` when no"},{"line_number":1397,"context_line":"            deployment template matching the name or ID could be found."},{"line_number":1398,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"712b909a_1a196d2a","line":1395,"range":{"start_line":1394,"start_character":0,"end_line":1395,"end_character":69},"updated":"2021-01-11 14:00:56.000000000","message":"class should be on L1395.","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1408,"context_line":"            when the deployment template does not exist."},{"line_number":1409,"context_line":"            When set to `True``,None will be returned when attempting to"},{"line_number":1410,"context_line":"            find a nonexistent deployment node."},{"line_number":1411,"context_line":"        :returns: One :class:"},{"line_number":1412,"context_line":"        `~openstack.baremetal.v1.deploy_templates.DeployTemplate` object"},{"line_number":1413,"context_line":"            or None."},{"line_number":1414,"context_line":"        \"\"\""},{"line_number":1415,"context_line":"        return self._find(_deploytemplates.DeployTemplate, name_or_id,"},{"line_number":1416,"context_line":"                          ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":6,"id":"0d2f23cb_ee86bb73","line":1413,"range":{"start_line":1411,"start_character":8,"end_line":1413,"end_character":19},"updated":"2021-01-11 14:00:56.000000000","message":"class should be on L1412 and you will need to organize the rest o the characters on L1413.","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1418,"context_line":"    def patch_deploy_template(self, deploy_template, patch):"},{"line_number":1419,"context_line":"        \"\"\"Apply a JSON patch to the deploy_templates."},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"        :param deploy_templates: The value can be the ID of a"},{"line_number":1422,"context_line":"                                 deploy_template or a"},{"line_number":1423,"context_line":"            :class:"},{"line_number":1424,"context_line":"            `~openstack.baremetal.v1.deploy_templates.DeployTemplate` instance."},{"line_number":1425,"context_line":"        :param patch: JSON patch to apply."},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"        :returns: The updated deploy_template."}],"source_content_type":"text/x-python","patch_set":6,"id":"dbebad64_f9831e72","line":1424,"range":{"start_line":1421,"start_character":0,"end_line":1424,"end_character":79},"updated":"2021-01-11 14:00:56.000000000","message":"wrong identation","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c99c089373243fbc30f9092b6e587130937524af","unresolved":true,"context_lines":[{"line_number":1425,"context_line":"        :param patch: JSON patch to apply."},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"        :returns: The updated deploy_template."},{"line_number":1428,"context_line":"        :rtype: :class:"},{"line_number":1429,"context_line":"        `~openstack.baremetal.v1.deploy_templates.DeployTemplate`"},{"line_number":1430,"context_line":"        \"\"\""},{"line_number":1431,"context_line":"        return self._get_resource(_deploytemplates.DeployTemplate,"},{"line_number":1432,"context_line":"                                  deploy_template).patch(self, patch)"}],"source_content_type":"text/x-python","patch_set":6,"id":"98828b56_edfd41e8","line":1429,"range":{"start_line":1428,"start_character":1,"end_line":1429,"end_character":65},"updated":"2021-01-11 14:00:56.000000000","message":"class should be on L1429 and you need to add identation","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#       http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":7,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"}],"source_content_type":"text/x-python","patch_set":8,"id":"76aa218f_9ff02644","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":50},"updated":"2021-01-21 15:48:46.000000000","message":"This change is not needed","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":1264,"context_line":"                             :class:`~openstack.baremetal.v1.volume_target.VolumeTarget.`"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        :param dict attrs: The attributes to update on the"},{"line_number":1267,"context_line":"         volume_target represented by the ``volume_target`` parameter.`"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"        :returns: The updated volume_target."},{"line_number":1270,"context_line":"        :rtype::class:"}],"source_content_type":"text/x-python","patch_set":8,"id":"f0f40dd5_f3aac1aa","line":1267,"updated":"2021-01-21 15:48:46.000000000","message":"Those changes are not needed.","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":1297,"context_line":"            volume_target.VolumeTarget or a :class:"},{"line_number":1298,"context_line":"            `~openstack.baremetal.v1.volume_target.VolumeTarget`"},{"line_number":1299,"context_line":"            instance."},{"line_number":1300,"context_line":""},{"line_number":1301,"context_line":"        :param bool ignore_missing: When set to ``False``, an exception"},{"line_number":1302,"context_line":"            :class:`~openstack.exceptions.ResourceNotFound` will be raised"},{"line_number":1303,"context_line":"            when the volume_target could not be found."}],"source_content_type":"text/x-python","patch_set":8,"id":"5a592cfa_39e86697","line":1300,"updated":"2021-01-21 15:48:46.000000000","message":"Those changes are not needed.","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":1377,"context_line":"        \"\"\""},{"line_number":1378,"context_line":""},{"line_number":1379,"context_line":"        return self._delete(_deploytemplates.DeployTemplate,"},{"line_number":1380,"context_line":"                            deploy_template, ignore_missing\u003dTrue)"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"    def get_deploy_template(self, deploy_template, fields\u003dNone):"},{"line_number":1383,"context_line":"        \"\"\"Get a specific deployment template."}],"source_content_type":"text/x-python","patch_set":8,"id":"9ff5c85a_6aa0c061","line":1380,"range":{"start_line":1380,"start_character":60,"end_line":1380,"end_character":64},"updated":"2021-01-21 15:48:46.000000000","message":"here should be ignore_missing also, otherwise it will always set to True.","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"059b21f3ee522ea97eeb0aa95c9017f39f543e08","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#       http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":7,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"}],"source_content_type":"text/x-python","patch_set":10,"id":"c6f22418_6c3f23a3","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":50},"updated":"2021-01-27 23:18:32.000000000","message":"Please check the comments from patchset 8, the change in the License is not required.","commit_id":"41ea5841ad480e1ca45e4eab88748c30fb446400"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"059b21f3ee522ea97eeb0aa95c9017f39f543e08","unresolved":true,"context_lines":[{"line_number":1264,"context_line":"                             :class:`~openstack.baremetal.v1.volume_target.VolumeTarget.`"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        :param dict attrs: The attributes to update on the"},{"line_number":1267,"context_line":"         volume_target represented by the ``volume_target`` parameter.`"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"        :returns: The updated volume_target."},{"line_number":1270,"context_line":"        :rtype::class:"}],"source_content_type":"text/x-python","patch_set":10,"id":"2085c4f9_d77a983c","line":1267,"updated":"2021-01-27 23:18:32.000000000","message":"The changes on docs here shouldn\u0027t be part of this patch \u003d)","commit_id":"41ea5841ad480e1ca45e4eab88748c30fb446400"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"059b21f3ee522ea97eeb0aa95c9017f39f543e08","unresolved":true,"context_lines":[{"line_number":1294,"context_line":"        \"\"\"Delete an volume_target."},{"line_number":1295,"context_line":""},{"line_number":1296,"context_line":"        :param volume_target: The value can be either the ID of a"},{"line_number":1297,"context_line":"            volume_target.VolumeTarget or a :class:"},{"line_number":1298,"context_line":"            `~openstack.baremetal.v1.volume_target.VolumeTarget`"},{"line_number":1299,"context_line":"            instance."},{"line_number":1300,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"52bdca3d_265222b6","line":1297,"updated":"2021-01-27 23:18:32.000000000","message":"ditto","commit_id":"41ea5841ad480e1ca45e4eab88748c30fb446400"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"059b21f3ee522ea97eeb0aa95c9017f39f543e08","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"                           restrict the deploy_templates to be returned."},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        :returns: A generator of Deploy templates instances."},{"line_number":1323,"context_line":"        \"\"\""},{"line_number":1324,"context_line":"        return _deploytemplates.DeployTemplate.list(self,"},{"line_number":1325,"context_line":"                                                    details\u003ddetails, **query)"},{"line_number":1326,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a1a97670_124f07b7","line":1323,"updated":"2021-01-27 23:18:32.000000000","message":"You need to check if details is set to True, if that\u0027s the case the query parameter must be updated with the key \u0027detail\u0027 and the value.","commit_id":"41ea5841ad480e1ca45e4eab88748c30fb446400"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"059b21f3ee522ea97eeb0aa95c9017f39f543e08","unresolved":true,"context_lines":[{"line_number":1322,"context_line":"        :returns: A generator of Deploy templates instances."},{"line_number":1323,"context_line":"        \"\"\""},{"line_number":1324,"context_line":"        return _deploytemplates.DeployTemplate.list(self,"},{"line_number":1325,"context_line":"                                                    details\u003ddetails, **query)"},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"    def create_deploy_template(self, **attrs):"},{"line_number":1328,"context_line":"        \"\"\"Create a new deploy_template from attributes."}],"source_content_type":"text/x-python","patch_set":10,"id":"5daa5556_7b9f846e","line":1325,"range":{"start_line":1325,"start_character":52,"end_line":1325,"end_character":68},"updated":"2021-01-27 23:18:32.000000000","message":"This won\u0027t be necessary since the query will contain detail in case it\u0027s True.","commit_id":"41ea5841ad480e1ca45e4eab88748c30fb446400"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"059b21f3ee522ea97eeb0aa95c9017f39f543e08","unresolved":true,"context_lines":[{"line_number":1377,"context_line":"        \"\"\""},{"line_number":1378,"context_line":""},{"line_number":1379,"context_line":"        return self._delete(_deploytemplates.DeployTemplate,"},{"line_number":1380,"context_line":"                            deploy_template, ignore_missing\u003dTrue)"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"    def get_deploy_template(self, deploy_template, fields\u003dNone):"},{"line_number":1383,"context_line":"        \"\"\"Get a specific deployment template."}],"source_content_type":"text/x-python","patch_set":10,"id":"cebed05b_050b5b15","line":1380,"range":{"start_line":1380,"start_character":60,"end_line":1380,"end_character":64},"updated":"2021-01-27 23:18:32.000000000","message":"The non-existent test failed because you hardcoded True in this call \u003d)","commit_id":"41ea5841ad480e1ca45e4eab88748c30fb446400"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"165bda2d6b6bdde7760d3ff13ad47d052af895eb","unresolved":true,"context_lines":[{"line_number":1311,"context_line":"        return self._delete(_volumetarget.VolumeTarget,"},{"line_number":1312,"context_line":"                            volume_target, ignore_missing\u003dignore_missing)"},{"line_number":1313,"context_line":""},{"line_number":1314,"context_line":"    def deploy_templates(self, details\u003dTrue, **query):"},{"line_number":1315,"context_line":"        \"\"\"Retrieve a generator of deploy_templates."},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"        :param details: A boolean indicating whether the detailed information"}],"source_content_type":"text/x-python","patch_set":11,"id":"f06da4a3_3c00bc42","line":1314,"range":{"start_line":1314,"start_character":39,"end_line":1314,"end_character":43},"updated":"2021-01-28 18:39:23.000000000","message":"details should be default to False","commit_id":"564fd12f8101c9c15af461bcd1df16b9b96e6901"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"27c5cb1cb82548a27ea981c4beade618414f0239","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"        return self._get_with_fields(_deploytemplates.DeployTemplate,"},{"line_number":1400,"context_line":"                                     deploy_template, fields\u003dfields)"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"    def find_deploy_template(self, name_or_id, ignore_missing\u003dTrue):"},{"line_number":1403,"context_line":"        \"\"\"Find a single deploy_template."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"        :param str name_or_id: The name or ID of a deploy template."}],"source_content_type":"text/x-python","patch_set":21,"id":"0275493a_55bebf1f","line":1402,"updated":"2021-02-04 11:21:20.000000000","message":"It\u0027s the same as get_deploy_template, let\u0027s not add it until we can search by any fields.","commit_id":"2d0d1c9ebe019ca6b1e0149038445693a43c9871"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b18ff4b3fd3bdcf0ed21aae186b6d65bf7bc9c48","unresolved":true,"context_lines":[{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"        :param bool ignore_missing: When set to ``False``,"},{"line_number":1367,"context_line":"            an exception:class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":1368,"context_line":"            will be raised when the deploy_template"},{"line_number":1369,"context_line":"            could not be found."},{"line_number":1370,"context_line":"            When set to ``True``, no"},{"line_number":1371,"context_line":"            exception will be raised when attempting"}],"source_content_type":"text/x-python","patch_set":24,"id":"68c54de3_3a51c5dd","line":1368,"updated":"2021-02-11 17:42:15.000000000","message":"NIT: can we please format this properly?","commit_id":"10a1ee452b18b8112a5d66219fab1c97a7d2a9bf"}],"openstack/baremetal/v1/deploy_templates.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":17,"context_line":"class DeployTemplate(_common.ListMixin, resource.Resource):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    resources_key \u003d \u0027deploy_templates\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/v1/deploy_templates\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # capabilities"},{"line_number":23,"context_line":"    allow_create \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"a041bf5a_33409337","line":20,"range":{"start_line":20,"start_character":17,"end_line":20,"end_character":37},"updated":"2020-12-29 01:44:40.000000000","message":"base_path doesn\u0027t need the `/v1`","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f2f9dd4b687d273c65e032afdb9bafaf4045a30","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # Volume Targets is available since 1.32"},{"line_number":38,"context_line":"    _max_microversion \u003d \u00271.55\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    #: The boot index of the Volume target. “0” indicates that this volume is"}],"source_content_type":"text/x-python","patch_set":2,"id":"7837b2fb_ece0b333","line":37,"updated":"2021-01-06 18:23:15.000000000","message":"Needs updating","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"90cc7070fd43c497bf433894203e61fbfeb2f2dc","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    commit_jsonpatch \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":33,"context_line":"        \u0027node\u0027, \u0027detail\u0027,"},{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"865e253e_be082181","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":14},"updated":"2021-01-28 22:04:36.000000000","message":"node is not required here","commit_id":"564fd12f8101c9c15af461bcd1df16b9b96e6901"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"675f0951fe8df5e8baea58d070f036e33e602732","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    commit_jsonpatch \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":33,"context_line":"        \u0027detail\u0027,"},{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"d49b4b4a_6900262f","line":33,"updated":"2021-02-02 22:33:30.000000000","message":"can you add \u0027name\u0027 here also? the test now complains about the key used, so we need to have here.","commit_id":"42b2275620d9f4931b8cdcd5994b053750119e57"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"27c5cb1cb82548a27ea981c4beade618414f0239","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    commit_jsonpatch \u003d True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":33,"context_line":"        \u0027detail\u0027, \u0027name\u0027,"},{"line_number":34,"context_line":"        fields\u003d{\u0027type\u0027: _common.fields_type},"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"d1878e95_9ed58d92","line":33,"updated":"2021-02-04 11:21:20.000000000","message":"Name cannot be used in a query, it\u0027s provided instead of UUID as in `/v1/deploy_templates/NAME`.","commit_id":"2d0d1c9ebe019ca6b1e0149038445693a43c9871"}],"openstack/tests/functional/baremetal/base.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        \"\"\"Create a new deploy_template from attributes."},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return self._create(_deploytemplates.DeployTemplate, **attrs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3621414e_d04ffc26","line":93,"range":{"start_line":93,"start_character":9,"end_line":93,"end_character":69},"updated":"2020-12-29 01:44:40.000000000","message":"Take a look on how the other functions in this file works, calling self._create and call directlly the _deploytemplate module doesn\u0027t make sense - considering the structure of the project)","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"36629d905cccf942c036f759ca761b7a7732bf70","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        \"\"\"Create a new deploy_template from attributes."},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        node_id \u003d node_id or self.node_id"},{"line_number":93,"context_line":"        deploy_template \u003d self.conn.baremetal.create_deploy_template("},{"line_number":94,"context_line":"            node_uuid\u003dnode_id, **kwargs)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"994b3ecc_08778232","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":41},"updated":"2021-01-06 18:38:57.000000000","message":"You can create a deploy template without node, so it\u0027s not required.","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4127f603149833a56b5b09b9c1d5a296f3262753","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \"\"\"Create a new deploy_template from attributes."},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        node_id \u003d node_id or self.node_id"},{"line_number":93,"context_line":"        deploy_template \u003d self.conn.baremetal.create_deploy_template("},{"line_number":94,"context_line":"            node_uuid\u003dnode_id, **kwargs)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a7f100c_92d8e64e","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":41},"in_reply_to":"994b3ecc_08778232","updated":"2021-01-07 19:02:36.000000000","message":"Done","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"36629d905cccf942c036f759ca761b7a7732bf70","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        node_id \u003d node_id or self.node_id"},{"line_number":93,"context_line":"        deploy_template \u003d self.conn.baremetal.create_deploy_template("},{"line_number":94,"context_line":"            node_uuid\u003dnode_id, **kwargs)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.addCleanup("},{"line_number":97,"context_line":"            lambda: self.conn.baremetal.delete_deploy_template("}],"source_content_type":"text/x-python","patch_set":2,"id":"4e1f4a29_6d8a21e4","line":94,"range":{"start_line":94,"start_character":12,"end_line":94,"end_character":29},"updated":"2021-01-06 18:38:57.000000000","message":"not required","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4127f603149833a56b5b09b9c1d5a296f3262753","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        node_id \u003d node_id or self.node_id"},{"line_number":93,"context_line":"        deploy_template \u003d self.conn.baremetal.create_deploy_template("},{"line_number":94,"context_line":"            node_uuid\u003dnode_id, **kwargs)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.addCleanup("},{"line_number":97,"context_line":"            lambda: self.conn.baremetal.delete_deploy_template("}],"source_content_type":"text/x-python","patch_set":2,"id":"780f386f_d938e44b","line":94,"range":{"start_line":94,"start_character":12,"end_line":94,"end_character":29},"in_reply_to":"4e1f4a29_6d8a21e4","updated":"2021-01-07 19:02:36.000000000","message":"Done","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"675f0951fe8df5e8baea58d070f036e33e602732","unresolved":true,"context_lines":[{"line_number":85,"context_line":"                                                     ignore_missing\u003dTrue))"},{"line_number":86,"context_line":"        return volume_target"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def create_deploy_template(self, node_id\u003dNone, **kwargs):"},{"line_number":89,"context_line":"        \"\"\"Create a new deploy_template from attributes."},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"56a8ac44_1372121b","line":88,"range":{"start_line":88,"start_character":37,"end_line":88,"end_character":49},"updated":"2021-02-02 22:33:30.000000000","message":"node_id is not necessary for deploy template \u003d)","commit_id":"42b2275620d9f4931b8cdcd5994b053750119e57"}],"openstack/tests/functional/baremetal/test_baremetal_deploy_templates.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    min_microversion \u003d \u00271.55\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def setUp(self):"},{"line_number":22,"context_line":"        super(TestBareMetalVolumetarget, self).setUp()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_baremetal_deploy_create_get_delete(self):"},{"line_number":25,"context_line":"        self.conn.baremetal.create_deploy_template()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a9ee81a_feb3b576","line":22,"updated":"2020-12-29 01:44:40.000000000","message":"I think it would make sense create a common template directly in the setup so you can re-use in the tests bellow. In the test_baremetal_deploy_create_get_delete and est_baremetal_deploy_list (you would ensure you have 2 templates in the test etc) you can create a new template on it.","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de2658338e488a14b3f6272ad10aafe6739afaa0","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    def setUp(self):"},{"line_number":22,"context_line":"        super(TestBareMetalVolumetarget, self).setUp()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_baremetal_deploy_create_get_delete(self):"},{"line_number":25,"context_line":"        self.conn.baremetal.create_deploy_template()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_baremetal_deploy_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c840226_92fe3a62","line":24,"updated":"2020-12-29 01:44:40.000000000","message":"On the tests you are only calling the functions that would do something but they have no parameters or asserts to ensure things will work properly.","commit_id":"77365c05a3486e59f34d8eda831c1d640acf97ea"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f4b5f4079336076320cabfa789e068427a9e59f8","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self.assertIsNotNone(loaded.node_id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_baremetal_deploy_list(self):"},{"line_number":49,"context_line":"        node2 \u003d self.create_node(name\u003d\u0027test-node\u0027)"},{"line_number":50,"context_line":"        steps \u003d ["},{"line_number":51,"context_line":"            {"},{"line_number":52,"context_line":"                \"interface\": \"bios\","}],"source_content_type":"text/x-python","patch_set":2,"id":"b8724f67_5b399825","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":50},"updated":"2021-01-06 19:32:20.000000000","message":"I don\u0027t think a node would be necessary.","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f4b5f4079336076320cabfa789e068427a9e59f8","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                \"priority\": 150"},{"line_number":63,"context_line":"            }"},{"line_number":64,"context_line":"        ]"},{"line_number":65,"context_line":"        vc1 \u003d self.create_deploy_template(name\u003d\u0027test_baremetal_deploy\u0027,"},{"line_number":66,"context_line":"                                          steps\u003dsteps)"},{"line_number":67,"context_line":"        vc2 \u003d self.create_deploy_template(name\u003d\u0027test_baremetal_deploy2\u0027,"},{"line_number":68,"context_line":"                                          steps\u003dsteps)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4eb328ff_04d4e3b0","line":65,"range":{"start_line":65,"start_character":42,"end_line":65,"end_character":70},"updated":"2021-01-06 19:32:20.000000000","message":"deploy templates name need to respect the regex \u0027^CUSTOM_[A-Z0-9_]+$\u0027, test_baremetal_deploy  is not valid (this applies to every test here you used the name for deploy template.","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f4b5f4079336076320cabfa789e068427a9e59f8","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                \"priority\": 150"},{"line_number":63,"context_line":"            }"},{"line_number":64,"context_line":"        ]"},{"line_number":65,"context_line":"        vc1 \u003d self.create_deploy_template(name\u003d\u0027test_baremetal_deploy\u0027,"},{"line_number":66,"context_line":"                                          steps\u003dsteps)"},{"line_number":67,"context_line":"        vc2 \u003d self.create_deploy_template(name\u003d\u0027test_baremetal_deploy2\u0027,"},{"line_number":68,"context_line":"                                          steps\u003dsteps)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5528d2be_ebdef952","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":13},"updated":"2021-01-06 19:32:20.000000000","message":"vc1? vc2? this are from the volume connector tests, please change the variables names to something more meaningful","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f4b5f4079336076320cabfa789e068427a9e59f8","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        self.conn.baremetal.update_volume_connector("},{"line_number":105,"context_line":"            deploy_template,"},{"line_number":106,"context_line":"            deploy_template.steps.priority \u003d\u003d 50)"},{"line_number":107,"context_line":"        self.conn.baremetal.delete_volume_connector(deploy_template,"},{"line_number":108,"context_line":"                                                    ignore_missing\u003dFalse)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_baremetal_deploy_update(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c59bf96c_e0f9cb10","line":107,"range":{"start_line":107,"start_character":52,"end_line":107,"end_character":67},"updated":"2021-01-06 19:32:20.000000000","message":"here you need to pass the deploy_template_id","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4127f603149833a56b5b09b9c1d5a296f3262753","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            }"},{"line_number":39,"context_line":"        ]"},{"line_number":40,"context_line":"        deploy_template \u003d self.create_deploy_template("},{"line_number":41,"context_line":"            name\u003d\u0027^CUSTOM_[A-Z0-9_]+$\u0027,"},{"line_number":42,"context_line":"            steps\u003dsteps)"},{"line_number":43,"context_line":"        loaded \u003d self.conn.baremetal.get_deploy_template("},{"line_number":44,"context_line":"            deploy_template.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"39161b2f_ddc10eba","line":41,"range":{"start_line":41,"start_character":18,"end_line":41,"end_character":38},"updated":"2021-01-07 19:02:36.000000000","message":"This won\u0027t work because this is the regular expression that is used to validate the name of a deploy template. \nThe name of a deploy template starts with `CUSTOM_` and can only be followed by upper case letters, numbers and underscores.\n\nCUSTOM_DEPLOY_TEMPLATE for example","commit_id":"7cbb6f4972367ff57e11a7375741e9faad1832f8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4127f603149833a56b5b09b9c1d5a296f3262753","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            }"},{"line_number":64,"context_line":"        ]"},{"line_number":65,"context_line":"        deploy_template1 \u003d self.create_deploy_template("},{"line_number":66,"context_line":"            name\u003d\u0027^CUSTOM_[A-Z0-9_]+$\u0027,"},{"line_number":67,"context_line":"            steps\u003dsteps)"},{"line_number":68,"context_line":"        deploy_template2 \u003d self.create_deploy_template("},{"line_number":69,"context_line":"            name\u003d\u0027^CUSTOM_[A-Z0-9_]+$\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb138abd_fdf031ec","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":39},"updated":"2021-01-07 19:02:36.000000000","message":"ditto for my first comment","commit_id":"7cbb6f4972367ff57e11a7375741e9faad1832f8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4127f603149833a56b5b09b9c1d5a296f3262753","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            name\u003d\u0027^CUSTOM_[A-Z0-9_]+$\u0027,"},{"line_number":67,"context_line":"            steps\u003dsteps)"},{"line_number":68,"context_line":"        deploy_template2 \u003d self.create_deploy_template("},{"line_number":69,"context_line":"            name\u003d\u0027^CUSTOM_[A-Z0-9_]+$\u0027,"},{"line_number":70,"context_line":"            steps\u003dsteps)"},{"line_number":71,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template("},{"line_number":72,"context_line":"            node\u003dself.node.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3b4ee88c_ef336679","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":39},"updated":"2021-01-07 19:02:36.000000000","message":"ditto for my first comment","commit_id":"7cbb6f4972367ff57e11a7375741e9faad1832f8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4127f603149833a56b5b09b9c1d5a296f3262753","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":78,"context_line":"                         [deploy_template1.id])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template(node\u003d\u0027test-node\u0027)"},{"line_number":81,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":82,"context_line":"                         [deploy_template1.id])"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"0539977c_d53f9667","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":79},"updated":"2021-01-07 19:02:36.000000000","message":"This doesn\u0027t seem correct, the function deploy_template doesn\u0027t need to receive the node name...","commit_id":"7cbb6f4972367ff57e11a7375741e9faad1832f8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4127f603149833a56b5b09b9c1d5a296f3262753","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                \"priority\": 150"},{"line_number":99,"context_line":"            }"},{"line_number":100,"context_line":"        ]"},{"line_number":101,"context_line":"        self.create_deploy_template(name\u003d\u0027^CUSTOM_[A-Z0-9_]+$\u0027,"},{"line_number":102,"context_line":"                                    steps\u003dsteps)"},{"line_number":103,"context_line":"        deploy_template \u003d next(self.conn.baremetal.deploy_template("},{"line_number":104,"context_line":"            details\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2fe08a28_2e5d0b6f","line":101,"range":{"start_line":101,"start_character":36,"end_line":101,"end_character":61},"updated":"2021-01-07 19:02:36.000000000","message":"ditto for my first comment","commit_id":"7cbb6f4972367ff57e11a7375741e9faad1832f8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4127f603149833a56b5b09b9c1d5a296f3262753","unresolved":true,"context_lines":[{"line_number":129,"context_line":"            }"},{"line_number":130,"context_line":"        ]"},{"line_number":131,"context_line":"        deploy_template \u003d self.create_deploy_template("},{"line_number":132,"context_line":"            name\u003d\u0027^CUSTOM_[A-Z0-9_]+$\u0027,"},{"line_number":133,"context_line":"            steps\u003dsteps)"},{"line_number":134,"context_line":"        deploy_template.extra \u003d {\u0027answer\u0027: 42}"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3282666d_ef37b0c6","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":38},"updated":"2021-01-07 19:02:36.000000000","message":"ditto for my first comment","commit_id":"7cbb6f4972367ff57e11a7375741e9faad1832f8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5343ee86e5716d8e080c70bed4966061000d3f56","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        loaded \u003d self.conn.baremetal.get_deploy_template("},{"line_number":44,"context_line":"            deploy_template.id)"},{"line_number":45,"context_line":"        self.assertEqual(loaded.id, deploy_template.id)"},{"line_number":46,"context_line":"        self.assertIsNotNone(loaded.node_id)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_baremetal_deploy_list(self):"},{"line_number":49,"context_line":"        node2 \u003d self.create_node(name\u003d\u0027test-node\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"854b1b61_75e6330f","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":43},"updated":"2021-01-13 16:31:52.000000000","message":"this is not an attribute from deploy template \nhttps://review.opendev.org/c/openstack/openstacksdk/+/768612/6/openstack/baremetal/v1/deploy_templates.py","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5343ee86e5716d8e080c70bed4966061000d3f56","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        deploy_template2 \u003d self.create_deploy_template("},{"line_number":69,"context_line":"            name\u003d\u0027CUSTOM_DEPLOY_TEMPLATE2\u0027,"},{"line_number":70,"context_line":"            steps\u003dsteps)"},{"line_number":71,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template("},{"line_number":72,"context_line":"            node\u003dself.node.id)"},{"line_number":73,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":74,"context_line":"                         [deploy_template2.id])"}],"source_content_type":"text/x-python","patch_set":6,"id":"86143a46_0b59f153","line":71,"range":{"start_line":71,"start_character":46,"end_line":71,"end_character":61},"updated":"2021-01-13 16:31:52.000000000","message":"in Proxy the function is deploy_templates","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f87023c5d24a14356d29aa03230c45cd0a725000","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        deploy_template2 \u003d self.create_deploy_template("},{"line_number":69,"context_line":"            name\u003d\u0027CUSTOM_DEPLOY_TEMPLATE2\u0027,"},{"line_number":70,"context_line":"            steps\u003dsteps)"},{"line_number":71,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template("},{"line_number":72,"context_line":"            node\u003dself.node.id)"},{"line_number":73,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":74,"context_line":"                         [deploy_template2.id])"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c84aa605_e871e8a4","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":30},"updated":"2021-01-11 14:03:46.000000000","message":"deploy_template doesn\u0027t require a node as paramater","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f87023c5d24a14356d29aa03230c45cd0a725000","unresolved":true,"context_lines":[{"line_number":102,"context_line":"                                    steps\u003dsteps)"},{"line_number":103,"context_line":"        deploy_template \u003d next(self.conn.baremetal.deploy_template("},{"line_number":104,"context_line":"            details\u003dTrue,"},{"line_number":105,"context_line":"            node\u003dself.node.id))"},{"line_number":106,"context_line":"        self.assertEqual(deploy_template.steps.priority, 150)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # This test checks that resources returned from listing are usable"}],"source_content_type":"text/x-python","patch_set":6,"id":"0adf48f3_387b52c3","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":30},"updated":"2021-01-11 14:03:46.000000000","message":"ditto","commit_id":"cbd5f8f52bde92b3399dd6cf62dda84186ffc02f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e2a32731212a3f44b366a4286e2877b0fc4cf49a","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            steps\u003dsteps)"},{"line_number":43,"context_line":"        loaded \u003d self.conn.baremetal.get_deploy_template("},{"line_number":44,"context_line":"            deploy_template.id)"},{"line_number":45,"context_line":"        self.assertEqual(loaded.id, deploy_template.id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_baremetal_deploy_list(self):"},{"line_number":48,"context_line":"        node2 \u003d self.create_node(name\u003d\u0027test-node\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"00fe3ba3_c45a79fe","line":45,"updated":"2021-01-19 14:41:02.000000000","message":"You still need to add test for delete.\n- Delete the template\n- assert it will raise an exception if you try to get the template","commit_id":"119496fffe0985f867291a39f95271563b35dc10"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e2a32731212a3f44b366a4286e2877b0fc4cf49a","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            deploy_template.id)"},{"line_number":45,"context_line":"        self.assertEqual(loaded.id, deploy_template.id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_baremetal_deploy_list(self):"},{"line_number":48,"context_line":"        node2 \u003d self.create_node(name\u003d\u0027test-node\u0027)"},{"line_number":49,"context_line":"        steps \u003d ["},{"line_number":50,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":7,"id":"c471b315_3409270c","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":34},"updated":"2021-01-19 14:41:02.000000000","message":"You also need to test here that you can pass details and fields when trying to list deploy templates, take a look at other functional tests to see the examples","commit_id":"119496fffe0985f867291a39f95271563b35dc10"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e2a32731212a3f44b366a4286e2877b0fc4cf49a","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        deploy_template2 \u003d self.create_deploy_template("},{"line_number":68,"context_line":"            name\u003d\u0027CUSTOM_DEPLOY_TEMPLATE2\u0027,"},{"line_number":69,"context_line":"            steps\u003dsteps)"},{"line_number":70,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_templates()"},{"line_number":71,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":72,"context_line":"                         [deploy_template2.id])"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"b55d1c0a_38c657dc","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":23},"updated":"2021-01-19 14:41:02.000000000","message":"here you need pass the id of the deploy_template2 so the assert will work","commit_id":"119496fffe0985f867291a39f95271563b35dc10"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e2a32731212a3f44b366a4286e2877b0fc4cf49a","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            name\u003d\u0027CUSTOM_DEPLOY_TEMPLATE2\u0027,"},{"line_number":69,"context_line":"            steps\u003dsteps)"},{"line_number":70,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_templates()"},{"line_number":71,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":72,"context_line":"                         [deploy_template2.id])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template(node\u003dnode2.id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ca2210a4_6f74d36e","line":71,"range":{"start_line":71,"start_character":35,"end_line":71,"end_character":36},"updated":"2021-01-19 14:41:02.000000000","message":"v doesn\u0027t make more sense, try to use more meaningful names","commit_id":"119496fffe0985f867291a39f95271563b35dc10"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e2a32731212a3f44b366a4286e2877b0fc4cf49a","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":72,"context_line":"                         [deploy_template2.id])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template(node\u003dnode2.id)"},{"line_number":75,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":76,"context_line":"                         [deploy_template1.id])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2919e0c9_d259ba93","line":74,"range":{"start_line":74,"start_character":62,"end_line":74,"end_character":75},"updated":"2021-01-19 14:41:02.000000000","message":"node is not required, the idea here is to filter based on the id of the deploy template1.","commit_id":"119496fffe0985f867291a39f95271563b35dc10"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e2a32731212a3f44b366a4286e2877b0fc4cf49a","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                         [deploy_template2.id])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template(node\u003dnode2.id)"},{"line_number":75,"context_line":"        self.assertEqual([v.id for v in deploy_template],"},{"line_number":76,"context_line":"                         [deploy_template1.id])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template(node\u003d\u0027test-node\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6f8acbb5_1e5bda35","line":75,"range":{"start_line":75,"start_character":26,"end_line":75,"end_character":36},"updated":"2021-01-19 14:41:02.000000000","message":"also change the v since is not meaningful","commit_id":"119496fffe0985f867291a39f95271563b35dc10"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e2a32731212a3f44b366a4286e2877b0fc4cf49a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4f2f7272_955efee7","line":140,"updated":"2021-01-19 14:41:02.000000000","message":"You need to add tests for the following scenarios:\n\n- patch deploy template\n- negative non existing deploy tempalte","commit_id":"119496fffe0985f867291a39f95271563b35dc10"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        deploy_template2 \u003d self.create_deploy_template("},{"line_number":72,"context_line":"            name\u003d\u0027CUSTOM_DEPLOY_TEMPLATE2\u0027,"},{"line_number":73,"context_line":"            steps\u003dsteps)"},{"line_number":74,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_templates()"},{"line_number":75,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":76,"context_line":"                         [deploy_template2.id])"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"33b96764_1b265f5e","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":64},"updated":"2021-01-21 15:48:46.000000000","message":"This won\u0027t work, take a look at my comment on the patch set #7 you forgot to pass a parameter, so it will return a list with two elements.","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":76,"context_line":"                         [deploy_template2.id])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template()"},{"line_number":79,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":80,"context_line":"                         [deploy_template1.id])"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"6a800a98_83110e50","line":78,"range":{"start_line":78,"start_character":7,"end_line":78,"end_character":63},"updated":"2021-01-21 15:48:46.000000000","message":"ditto","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1e7433838d68fb7ec50645a2e8a0198022b47e3d","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":80,"context_line":"                         [deploy_template1.id])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_template()"},{"line_number":83,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":84,"context_line":"                         [deploy_template1.id])"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"02723f8c_1781297d","line":82,"updated":"2021-01-21 15:50:16.000000000","message":"This test you can change to make sure you can use details and fields when trying to list the deploy templates.","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # This test checks that resources returned from listing are usable"},{"line_number":109,"context_line":"        self.conn.baremetal.update_deploy_template("},{"line_number":110,"context_line":"            deploy_template,"},{"line_number":111,"context_line":"            deploy_template.steps.priority \u003d\u003d 50)"},{"line_number":112,"context_line":"        self.conn.baremetal.delete_deploy_template(deploy_template_id,"},{"line_number":113,"context_line":"                                                   ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"c0586a45_170ba442","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":27},"updated":"2021-01-21 15:48:46.000000000","message":"shouldn\u0027t be deploy_tempalte.id ?","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        self.conn.baremetal.update_deploy_template("},{"line_number":110,"context_line":"            deploy_template,"},{"line_number":111,"context_line":"            deploy_template.steps.priority \u003d\u003d 50)"},{"line_number":112,"context_line":"        self.conn.baremetal.delete_deploy_template(deploy_template_id,"},{"line_number":113,"context_line":"                                                   ignore_missing\u003dFalse)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_baremetal_deploy_update(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"95a00bd6_06b52b8b","line":112,"range":{"start_line":112,"start_character":51,"end_line":112,"end_character":69},"updated":"2021-01-21 15:48:46.000000000","message":"shouldn\u0027t be deploy_tempalte.id ?","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"345645d2d6b22e2812f6a0aab9ac226d5327be33","unresolved":true,"context_lines":[{"line_number":171,"context_line":"            deploy_template.id)"},{"line_number":172,"context_line":"        self.assertEqual({\u0027answer\u0027: 42}, deploy_template.extra)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_deploy_template_connector_negative_non_existing(self):"},{"line_number":175,"context_line":"        uuid \u003d \"bbb45f41-d4bc-4307-8d1d-32f95ce1e920\""},{"line_number":176,"context_line":"        self.assertRaises(exceptions.ResourceNotFound,"},{"line_number":177,"context_line":"                          self.conn.baremetal.get_deploy_template, uuid)"}],"source_content_type":"text/x-python","patch_set":8,"id":"2409e4cd_565691b8","line":174,"range":{"start_line":174,"start_character":29,"end_line":174,"end_character":38},"updated":"2021-01-21 15:48:46.000000000","message":"connector??","commit_id":"49eb7c357e7a6e654e0223e8c82dc16bbca8f0c1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"059b21f3ee522ea97eeb0aa95c9017f39f543e08","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        ]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        deploy_tempaltes_with_details \u003d self.conn.baremetal.deploy_templates("},{"line_number":70,"context_line":"            details\u003dTrue)"},{"line_number":71,"context_line":"        for dp in deploy_tempaltes_with_details:"},{"line_number":72,"context_line":"            self.assertIsNotNone(dp.id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"cd38dbe1_a555ee97","line":69,"updated":"2021-01-27 23:18:32.000000000","message":"The logic for this is correct, you will just need to fix the _proxy.py to ensure details is on the query parameter I think.","commit_id":"41ea5841ad480e1ca45e4eab88748c30fb446400"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"90cc7070fd43c497bf433894203e61fbfeb2f2dc","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":97,"context_line":"                         [deploy_template2.id])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_baremetal_deploy_list_update_delete(self, deploy_template_id):"},{"line_number":100,"context_line":"        steps \u003d ["},{"line_number":101,"context_line":"            {"},{"line_number":102,"context_line":"                \"interface\": \"bios\","}],"source_content_type":"text/x-python","patch_set":11,"id":"8bdd0f17_f041cfaa","line":99,"range":{"start_line":99,"start_character":55,"end_line":99,"end_character":73},"updated":"2021-01-28 22:04:36.000000000","message":"You don\u0027t need this parameter \u003d)","commit_id":"564fd12f8101c9c15af461bcd1df16b9b96e6901"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"793660ffea1c9efd4f92e7545e84c24dce670f6d","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            steps\u003dsteps)"},{"line_number":87,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_templates("},{"line_number":88,"context_line":"            deploy_template1.id,"},{"line_number":89,"context_line":"            steps\u003dsteps)"},{"line_number":90,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":91,"context_line":"                         [deploy_template1.id])"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"b1a243ba_3c26c66c","line":89,"range":{"start_line":89,"start_character":12,"end_line":89,"end_character":23},"updated":"2021-01-29 11:32:59.000000000","message":"You don\u0027t need to pass steps here, this would be necessary if you are trying to create a deploy template","commit_id":"eec7ec5d925350654e97591b6b9e5858b47088d7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"793660ffea1c9efd4f92e7545e84c24dce670f6d","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_templates("},{"line_number":94,"context_line":"            deploy_template2.id,"},{"line_number":95,"context_line":"            steps\u003dsteps)"},{"line_number":96,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":97,"context_line":"                         [deploy_template2.id])"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7d26ffbd_bdfe7058","line":95,"range":{"start_line":95,"start_character":12,"end_line":95,"end_character":23},"updated":"2021-01-29 11:32:59.000000000","message":"ditto \u003d)","commit_id":"eec7ec5d925350654e97591b6b9e5858b47088d7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"793660ffea1c9efd4f92e7545e84c24dce670f6d","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        ]"},{"line_number":115,"context_line":"        self.create_deploy_template(name\u003d\u0027CUSTOM_DEPLOY_TEMPLATE3\u0027,"},{"line_number":116,"context_line":"                                    steps\u003dsteps)"},{"line_number":117,"context_line":"        deploy_template \u003d next(self.conn.baremetal.deploy_template("},{"line_number":118,"context_line":"            details\u003dTrue))"},{"line_number":119,"context_line":"        self.assertEqual(deploy_template.steps.priority, 150)"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"db4feb12_3b18eed4","line":117,"range":{"start_line":117,"start_character":51,"end_line":117,"end_character":66},"updated":"2021-01-29 11:32:59.000000000","message":"wrong name of the function","commit_id":"eec7ec5d925350654e97591b6b9e5858b47088d7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"793660ffea1c9efd4f92e7545e84c24dce670f6d","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        # This test checks that resources returned from listing are usable"},{"line_number":122,"context_line":"        self.conn.baremetal.update_deploy_template("},{"line_number":123,"context_line":"            deploy_template.id,"},{"line_number":124,"context_line":"            deploy_template.steps.priority \u003d\u003d 50)"},{"line_number":125,"context_line":"        self.conn.baremetal.delete_deploy_template(deploy_template.id,"},{"line_number":126,"context_line":"                                                   ignore_missing\u003dFalse)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"e21a3ddd_d432f968","line":124,"updated":"2021-01-29 11:32:59.000000000","message":"after doing the update here would be good to have an assert that would ensure that the new priority is correct","commit_id":"eec7ec5d925350654e97591b6b9e5858b47088d7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9e600726d596e35ef6ca4383e50c14f0d3440696","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            name\u003d\u0027CUSTOM_DEPLOY_TEMPLATE2\u0027,"},{"line_number":74,"context_line":"            steps\u003dsteps)"},{"line_number":75,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_templates("},{"line_number":76,"context_line":"            deploy_template1.id)"},{"line_number":77,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":78,"context_line":"                         [deploy_template1.id])"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5a45a00f_fbe6a8a0","line":76,"range":{"start_line":76,"start_character":29,"end_line":76,"end_character":31},"updated":"2021-02-01 17:14:49.000000000","message":"Can you change here to name? I just noticed we can\u0027t filter deploy templates by id.","commit_id":"d6dddd89bbf4ff7d951bc4c3516539de814e6202"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"34c55d81bb2c508679e5426f3ec989805b48ccc3","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                         [deploy_template1.id])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        deploy_template \u003d self.conn.baremetal.deploy_templates("},{"line_number":81,"context_line":"            deploy_template2.name)"},{"line_number":82,"context_line":"        self.assertEqual([value.id for value in deploy_template],"},{"line_number":83,"context_line":"                         [deploy_template2.id])"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"07b7ffcc_1e42d74e","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":33},"updated":"2021-02-01 22:34:06.000000000","message":"weird it didn\u0027t work, maybe we need to explicit\ncan you try name\u003ddeploy_template2.name ( on Line 76 also)","commit_id":"ca08f61db4cf2c4196115ff2429088f1bd421789"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd330508e01ee34ab77e5872d83afa80776a324a","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            name\u003d\u0027CUSTOM_DEPLOY_TEMPLATE2\u0027,"},{"line_number":74,"context_line":"            steps\u003dsteps)"},{"line_number":75,"context_line":"        deploy_templates \u003d self.conn.baremetal.deploy_templates()"},{"line_number":76,"context_line":"        self.assertIn(deploy_template1.id, deploy_templates)"},{"line_number":77,"context_line":"        self.assertIn(deploy_template2.id, deploy_templates)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        deploy_templates_with_details \u003d self.conn.baremetal.deploy_templates("}],"source_content_type":"text/x-python","patch_set":22,"id":"725eaf07_c068d247","line":76,"range":{"start_line":76,"start_character":43,"end_line":76,"end_character":59},"updated":"2021-02-05 00:07:27.000000000","message":"My bad, deploy_templates won\u0027t be a list with the ids, you will need to transform.\nyou can create a variable with the list of available ids\nids \u003d [template.id for template in deploy_templates]\nand you can replace deploy_templates variable in both asserts","commit_id":"352e804898583bd45351da79102d4ef736a0f0cb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd330508e01ee34ab77e5872d83afa80776a324a","unresolved":true,"context_lines":[{"line_number":185,"context_line":"        self.assertRaises(exceptions.ResourceNotFound,"},{"line_number":186,"context_line":"                          self.conn.baremetal.get_deploy_template, uuid)"},{"line_number":187,"context_line":"        self.assertRaises(exceptions.ResourceNotFound,"},{"line_number":188,"context_line":"                          self.conn.baremetal.get_deploy_template, uuid,"},{"line_number":189,"context_line":"                          ignore_missing\u003dFalse)"},{"line_number":190,"context_line":"        self.assertRaises(exceptions.ResourceNotFound,"},{"line_number":191,"context_line":"                          self.conn.baremetal.delete_deploy_template, uuid,"}],"source_content_type":"text/x-python","patch_set":22,"id":"f780eecb_c6a523b2","line":188,"updated":"2021-02-05 00:07:27.000000000","message":"You can Remove this assert also, the one on line 185-186 will cover the scenario.","commit_id":"352e804898583bd45351da79102d4ef736a0f0cb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd330508e01ee34ab77e5872d83afa80776a324a","unresolved":true,"context_lines":[{"line_number":190,"context_line":"        self.assertRaises(exceptions.ResourceNotFound,"},{"line_number":191,"context_line":"                          self.conn.baremetal.delete_deploy_template, uuid,"},{"line_number":192,"context_line":"                          ignore_missing\u003dFalse)"},{"line_number":193,"context_line":"        self.assertIsNone(self.conn.baremetal.get_deploy_template(uuid))"},{"line_number":194,"context_line":"        self.assertIsNone(self.conn.baremetal.delete_deploy_template(uuid))"}],"source_content_type":"text/x-python","patch_set":22,"id":"15f13b50_405c5a3d","line":193,"range":{"start_line":193,"start_character":2,"end_line":193,"end_character":72},"updated":"2021-02-05 00:07:27.000000000","message":"You can remove this assert, get_deploy_template will always Raise an exception in case the uuid doesn\u0027t exist.","commit_id":"352e804898583bd45351da79102d4ef736a0f0cb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8cacf901d90c79027212edad2de6c8ae56334e0d","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            details\u003dTrue)"},{"line_number":82,"context_line":"        for dp in deploy_templates_with_details:"},{"line_number":83,"context_line":"            self.assertIsNotNone(dp.id)"},{"line_number":84,"context_line":"            self.assertIsNotNone(dp.uuid)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        deploy_tempalte_with_fields \u003d self.conn.baremetal.deploy_templates("},{"line_number":87,"context_line":"            fields\u003d[\u0027uuid\u0027, \u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"44882f39_545ee8e1","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":40},"updated":"2021-02-05 16:18:34.000000000","message":"here you can change to name","commit_id":"8a4b01ef686137e65b6718026de8b1a2fb8e8c62"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8cacf901d90c79027212edad2de6c8ae56334e0d","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            self.assertIsNotNone(dp.uuid)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        deploy_tempalte_with_fields \u003d self.conn.baremetal.deploy_templates("},{"line_number":87,"context_line":"            fields\u003d[\u0027uuid\u0027, \u0027name\u0027])"},{"line_number":88,"context_line":"        for dp in deploy_tempalte_with_fields:"},{"line_number":89,"context_line":"            self.assertIsNotNone(dp.id)"},{"line_number":90,"context_line":"            self.assertIsNone(dp.name)"}],"source_content_type":"text/x-python","patch_set":23,"id":"db651a11_536b32a6","line":87,"range":{"start_line":87,"start_character":29,"end_line":87,"end_character":33},"updated":"2021-02-05 16:18:34.000000000","message":"since you want to ensure name will be none you will need to change here to other attribute","commit_id":"8a4b01ef686137e65b6718026de8b1a2fb8e8c62"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8cacf901d90c79027212edad2de6c8ae56334e0d","unresolved":true,"context_lines":[{"line_number":88,"context_line":"        for dp in deploy_tempalte_with_fields:"},{"line_number":89,"context_line":"            self.assertIsNotNone(dp.id)"},{"line_number":90,"context_line":"            self.assertIsNone(dp.name)"},{"line_number":91,"context_line":"            self.assertIsNotNone(dp.uuid)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_baremetal_deploy_list_update_delete(self):"},{"line_number":94,"context_line":"        steps \u003d ["}],"source_content_type":"text/x-python","patch_set":23,"id":"e85562ce_7e45f7fa","line":91,"range":{"start_line":91,"start_character":36,"end_line":91,"end_character":40},"updated":"2021-02-05 16:18:34.000000000","message":"change to other attribute.","commit_id":"8a4b01ef686137e65b6718026de8b1a2fb8e8c62"}],"openstack/tests/unit/baremetal/v1/test_deploy_templates.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f4b5f4079336076320cabfa789e068427a9e59f8","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class DeployTemplates(base.TestCase):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def test_basic(self):"},{"line_number":56,"context_line":"        sot \u003d deploy_templates.DeployTemplate()"},{"line_number":57,"context_line":"        self.assertIsNone(sot.resource_key)"},{"line_number":58,"context_line":"        self.assertEqual(\u0027deploy_templates\u0027, sot.resources_key)"}],"source_content_type":"text/x-python","patch_set":2,"id":"997411a2_d21e3b64","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":18},"updated":"2021-01-06 19:32:20.000000000","message":"This test is failing, try run locally to identify the problem.","commit_id":"64c191dcf505b18c22d807c55e5f8cae79d35b45"}],"releasenotes/notes/ironic-deploy-template-support-fa56005365ed6e4d.yaml":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"059b21f3ee522ea97eeb0aa95c9017f39f543e08","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    Support Deploy Templates for Ironic API"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c9c61606_13fe5caf","line":2,"updated":"2021-01-27 23:18:32.000000000","message":"you don\u0027t need the empty lines Line 2,6,7.","commit_id":"41ea5841ad480e1ca45e4eab88748c30fb446400"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"165bda2d6b6bdde7760d3ff13ad47d052af895eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"58d3c4e1_f03aeb77","line":5,"updated":"2021-01-28 18:39:23.000000000","message":"Line 5 can be removed","commit_id":"564fd12f8101c9c15af461bcd1df16b9b96e6901"}]}