)]}'
{"openstack/cloud/_orchestration.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b05f9c1e11d9002ad1d8cbd116e833e6e9b3431","unresolved":true,"context_lines":[{"line_number":212,"context_line":"    def list_stacks(self, **query):"},{"line_number":213,"context_line":"        \"\"\"List all stacks."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        :returns: a list of ``munch.Munch`` containing the stack description."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        :raises: ``OpenStackCloudException`` if something goes wrong during the"},{"line_number":218,"context_line":"            OpenStack API call."}],"source_content_type":"text/x-python","patch_set":2,"id":"1b69061f_48966c12","line":215,"updated":"2021-01-13 10:01:11.000000000","message":"Need to document the new parameter, right?","commit_id":"3a34da45d4e4eeaddc9b79dd47354a1a2e8926e4"}],"openstack/orchestration/v1/stack.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b05f9c1e11d9002ad1d8cbd116e833e6e9b3431","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from openstack import utils"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Stack(resource.Resource, resource.TagMixin):"},{"line_number":19,"context_line":"    name_attribute \u003d \u0027stack_name\u0027"},{"line_number":20,"context_line":"    resource_key \u003d \u0027stack\u0027"},{"line_number":21,"context_line":"    resources_key \u003d \u0027stacks\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"37fc1239_ad453591","line":18,"range":{"start_line":18,"start_character":31,"end_line":18,"end_character":48},"updated":"2021-01-13 10:01:11.000000000","message":"This configures a \u0027tags\u0027 attribute in the body, and exposes four query parameters: \u0027tags\u0027, \u0027tags-any\u0027, \u0027not-tags\u0027, and \u0027not-tags-any\u0027. All of these are valid, based on the api-ref [1]. However, it also exposes some methods. \u0027fetch_tags\u0027, \u0027set_tags\u0027 and \u0027remove_all_tags\u0027 want to make GET, PUT and DELETE requests to \u0027/stacks/{stack}/tags\u0027 respectively, which does not seem to exist. Likewise, \u0027check_tag\u0027, \u0027add_tag\u0027 and \u0027remove_tag\u0027 want to make GET, PUT and DELETE requests to \u0027/stacks/{stack}/tags/{tag}\u0027 respectively, which again does not seem to exist. Given this, does it really make sense to use this mixin or should we just define these attributes ourselves?\n\n[1] https://docs.openstack.org/api-ref/orchestration/v1/index.html?expanded\u003dlist-stacks-detail#stacks","commit_id":"3a34da45d4e4eeaddc9b79dd47354a1a2e8926e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b05f9c1e11d9002ad1d8cbd116e833e6e9b3431","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        \u0027action\u0027, \u0027name\u0027, \u0027status\u0027,"},{"line_number":33,"context_line":"        \u0027project_id\u0027, \u0027owner_id\u0027, \u0027username\u0027,"},{"line_number":34,"context_line":"        project_id\u003d\u0027tenant_id\u0027,"},{"line_number":35,"context_line":"        **resource.TagMixin._tag_query_parameters"},{"line_number":36,"context_line":"    )"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Properties"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b9df74a_e5588c7d","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":49},"updated":"2021-01-13 10:01:11.000000000","message":"This feels like it should be a public attribute given how we\u0027re using it in another module, but I assume we can\u0027t do that as it would become an attribute of the class. Perhaps we could configure this as an attribute of the \u0027resource\u0027 module, e.g. \u0027resource.TAG_QUERY_PARAMETERS\u0027? We don\u0027t need to fix this now, but it would be a good follow-up.","commit_id":"3a34da45d4e4eeaddc9b79dd47354a1a2e8926e4"}],"openstack/tests/unit/orchestration/v1/test_stack.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b05f9c1e11d9002ad1d8cbd116e833e6e9b3431","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        self.assertTrue(sot.allow_delete)"},{"line_number":136,"context_line":"        self.assertTrue(sot.allow_list)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.assertDictEqual({\u0027action\u0027: \u0027action\u0027,"},{"line_number":139,"context_line":"                              \u0027any_tags\u0027: \u0027tags-any\u0027,"},{"line_number":140,"context_line":"                              \u0027limit\u0027: \u0027limit\u0027,"},{"line_number":141,"context_line":"                              \u0027marker\u0027: \u0027marker\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"87d33de7_5cb26c0d","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":49},"updated":"2021-01-13 10:01:11.000000000","message":"style nit: if you\u0027re reworking this, any chance you could put this on its own line and avoid the massive hanging indent\n\n  self.assertDictEqual(\n      {\n          \u0027action\u0027: \u0027action\u0027,\n          ...\n          \u0027username\u0027: \u0027username\u0027,\n      },\n      sot._query_mapping._mapping)","commit_id":"3a34da45d4e4eeaddc9b79dd47354a1a2e8926e4"}]}