)]}'
{"openstack/proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":560,"context_line":"        :returns: The result of the ``head`` call"},{"line_number":561,"context_line":"        :rtype: :class:`~openstack.resource.Resource`"},{"line_number":562,"context_line":"        \"\"\""},{"line_number":563,"context_line":"        res \u003d self_resource(resource_type, value, **attrs)"},{"line_number":564,"context_line":"        return res.head(self, base_path\u003dbase_path)"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    def _get_cleanup_dependencies(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbd4692a_9dcbf50a","line":563,"range":{"start_line":563,"start_character":0,"end_line":563,"end_character":58},"updated":"2021-02-15 21:58:18.000000000","message":"an unintentional change?","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        :returns: The result of the ``head`` call"},{"line_number":561,"context_line":"        :rtype: :class:`~openstack.resource.Resource`"},{"line_number":562,"context_line":"        \"\"\""},{"line_number":563,"context_line":"        res \u003d self_resource(resource_type, value, **attrs)"},{"line_number":564,"context_line":"        return res.head(self, base_path\u003dbase_path)"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    def _get_cleanup_dependencies(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c7be41f_dee934ec","line":563,"range":{"start_line":563,"start_character":0,"end_line":563,"end_character":58},"in_reply_to":"cbd4692a_9dcbf50a","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack import proxy"},{"line_number":14,"context_line":"from openstack.shared_file_system.v2 import availability_zone"},{"line_number":15,"context_line":"from openstack.shared_file_system.v2 import shares as sh"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Proxy(proxy.Proxy):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b143eda_cbd14577","line":15,"range":{"start_line":15,"start_character":50,"end_line":15,"end_character":56},"updated":"2021-02-15 21:58:18.000000000","message":"no need to shorten..","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack import proxy"},{"line_number":14,"context_line":"from openstack.shared_file_system.v2 import availability_zone"},{"line_number":15,"context_line":"from openstack.shared_file_system.v2 import shares as sh"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Proxy(proxy.Proxy):"}],"source_content_type":"text/x-python","patch_set":1,"id":"abf0c484_1aaf7418","line":15,"range":{"start_line":15,"start_character":50,"end_line":15,"end_character":56},"in_reply_to":"8b143eda_cbd14577","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        return self._update(sh.Shares, share)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create_share(self, **attrs):"},{"line_number":71,"context_line":"        \"\"\"Creates a share from attributes "},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        :param share: The ID of the share to get"},{"line_number":74,"context_line":"        :returns: Details of the new share"}],"source_content_type":"text/x-python","patch_set":1,"id":"b28bb285_78f7b0ca","line":71,"range":{"start_line":71,"start_character":42,"end_line":71,"end_character":43},"updated":"2021-02-15 21:58:18.000000000","message":"trailing whitespace here, and on lines 58, 59 - set your IDE to trim them so you can get rid of them automatically","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return self._update(sh.Shares, share)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create_share(self, **attrs):"},{"line_number":71,"context_line":"        \"\"\"Creates a share from attributes "},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        :param share: The ID of the share to get"},{"line_number":74,"context_line":"        :returns: Details of the new share"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f268ec2_2a95b5fa","line":71,"range":{"start_line":71,"start_character":42,"end_line":71,"end_character":43},"in_reply_to":"b28bb285_78f7b0ca","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :returns: Details of shares resources"},{"line_number":33,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":34,"context_line":"                        share.Share`"},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        return self._list(share.Share, base_path\u003dshare.Share.details_path)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"30d776ef_07c68746","line":34,"updated":"2021-03-04 12:16:59.000000000","message":"this line break looks ugly ;-)","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":34,"context_line":"                        share.Share`"},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        return self._list(share.Share, base_path\u003dshare.Share.details_path)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_share(self, share_id):"},{"line_number":39,"context_line":"        \"\"\"Lists details of a single share"}],"source_content_type":"text/x-python","patch_set":5,"id":"2f47d9ae_e0e487da","line":36,"updated":"2021-03-04 12:16:59.000000000","message":"please have a look at https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/block_storage/v3/_proxy.py#L73 to figure out how details/no_details is used in other cases","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        :param share: The ID of the share to get"},{"line_number":42,"context_line":"        :returns: Details of the identified share"},{"line_number":43,"context_line":"        :rtype: :class: `~openstack.shared_file_system.v2."},{"line_number":44,"context_line":"                        share.Share`"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        return self._get(share.Share, share_id)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b9ea1e2b_2f9977cc","line":44,"updated":"2021-03-04 12:16:59.000000000","message":"would you please fix indentations in the docstrings to be +4 chars (from the docstring indent)  and not under beginning of the text.\nOverall we miss including the service in the doc index (https://opendev.org/openstack/openstacksdk/src/branch/master/doc/source/user/index.rst), thus not really even validating docstrings.","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e64e64d7cdc17aef7d9b600430bbbedc5bc5c60e","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Lists all shares with details"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":33,"context_line":"            the snapshots being returned.  Available parameters include:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"            * status: Filters by a share status"},{"line_number":36,"context_line":"            * share_server_id: The UUID of the share server."}],"source_content_type":"text/x-python","patch_set":8,"id":"8cdfc927_1bbeb5b2","line":33,"range":{"start_line":33,"start_character":16,"end_line":33,"end_character":25},"updated":"2021-03-22 21:36:48.000000000","message":"shares","commit_id":"f664e19ab11ed74aa74708fe7ad3a940ff4cbe91"}],"openstack/shared_file_system/v2/share.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    allow_delete \u003d True"},{"line_number":27,"context_line":"    allow_list \u003d True"},{"line_number":28,"context_line":"    allow_head \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    #: Properties"},{"line_number":31,"context_line":"    # The UUID of the share."},{"line_number":32,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ade8328a_e2b77b70","line":29,"updated":"2021-03-04 12:16:59.000000000","message":"do you support any filters for listing?","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    # The UUID of the share."},{"line_number":32,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":33,"context_line":"    # The share size, in GiBs."},{"line_number":34,"context_line":"    size \u003d resource.Body(\"size\", type\u003dint)"},{"line_number":35,"context_line":"    # The availability zone."},{"line_number":36,"context_line":"    availability_zone \u003d resource.Body(\"availability_zone\", type\u003dstr)"},{"line_number":37,"context_line":"    # The date and time stamp when the resource was created within the"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb1b5b44_17d2dec5","line":34,"updated":"2021-03-04 12:16:59.000000000","message":"would you please sort attributes in the alphabetical order? This will make further maintenance much easier.","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":33,"context_line":"    # The share size, in GiBs."},{"line_number":34,"context_line":"    size \u003d resource.Body(\"size\", type\u003dint)"},{"line_number":35,"context_line":"    # The availability zone."},{"line_number":36,"context_line":"    availability_zone \u003d resource.Body(\"availability_zone\", type\u003dstr)"},{"line_number":37,"context_line":"    # The date and time stamp when the resource was created within the"},{"line_number":38,"context_line":"    # service’s database."}],"source_content_type":"text/x-python","patch_set":5,"id":"0cede2ce_63412143","line":35,"updated":"2021-03-04 12:16:59.000000000","message":"having comments here in the \"#: My funny attribute\" would cause better rendering of the documentation (once included in index)","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    share_network_id \u003d resource.Body(\"share_network_id\", type\u003dstr)"},{"line_number":53,"context_line":"    # The Shared File Systems protocol. A valid value is NFS,"},{"line_number":54,"context_line":"    # CIFS, GlusterFS, HDFS, CephFS, MAPRFS"},{"line_number":55,"context_line":"    share_proto \u003d resource.Body(\"share_proto\", type\u003dstr)"},{"line_number":56,"context_line":"    # One or more metadata key and value pairs as a dictionary of strings."},{"line_number":57,"context_line":"    metadata \u003d resource.Body(\"metadata\", type\u003dobject)"},{"line_number":58,"context_line":"    # The UUID of the share type. In minor versions, this parameter is a share"}],"source_content_type":"text/x-python","patch_set":5,"id":"c552efa4_07e872bc","line":55,"updated":"2021-03-04 12:16:59.000000000","message":"I feel using \"protocol\" would be better matching naming convention with other services","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    # CIFS, GlusterFS, HDFS, CephFS, MAPRFS"},{"line_number":55,"context_line":"    share_proto \u003d resource.Body(\"share_proto\", type\u003dstr)"},{"line_number":56,"context_line":"    # One or more metadata key and value pairs as a dictionary of strings."},{"line_number":57,"context_line":"    metadata \u003d resource.Body(\"metadata\", type\u003dobject)"},{"line_number":58,"context_line":"    # The UUID of the share type. In minor versions, this parameter is a share"},{"line_number":59,"context_line":"    # type name, as a string."},{"line_number":60,"context_line":"    share_type \u003d resource.Body(\"share_type\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f718d24_295de6cb","line":57,"updated":"2021-03-04 12:16:59.000000000","message":"type\u003ddict","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    # type name, as a string."},{"line_number":60,"context_line":"    share_type \u003d resource.Body(\"share_type\", type\u003dstr)"},{"line_number":61,"context_line":"    # The share links"},{"line_number":62,"context_line":"    links \u003d resource.Body(\"links\", type\u003dlist)"},{"line_number":63,"context_line":"    # The level of visibility for the share."},{"line_number":64,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":65,"context_line":"    # For the share migration, the migration task state."}],"source_content_type":"text/x-python","patch_set":5,"id":"5b5b73f4_089ec954","line":62,"updated":"2021-03-04 12:16:59.000000000","message":"you don\u0027t need to specify links. Those are not really intended to be used by user. SDK takes care of pagination","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    # or syncing."},{"line_number":71,"context_line":"    access_rules_status \u003d resource.Body(\"access_rules_status\", type\u003dstr)"},{"line_number":72,"context_line":"    # Indicates whether the share has replicas or not."},{"line_number":73,"context_line":"    has_replicas \u003d resource.Body(\"has_replicas\", type\u003dbool)"},{"line_number":74,"context_line":"    # ID of the user that the share was created by."},{"line_number":75,"context_line":"    user_id \u003d resource.Body(\"user_id\", type\u003dstr)"},{"line_number":76,"context_line":"    # The UUID of the share group that this shares belongs to."}],"source_content_type":"text/x-python","patch_set":5,"id":"35a7660c_a5c53304","line":73,"updated":"2021-03-04 12:16:59.000000000","message":"similar to the others \u003d\u003e bool attrs are prefixed with \"is_\" in SDK","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    replication_type \u003d resource.Body(\"replication_type\", type\u003dstr)"},{"line_number":92,"context_line":"    # An extra specification that filters back ends by whether the share"},{"line_number":93,"context_line":"    # supports snapshots or not."},{"line_number":94,"context_line":"    snapshot_support \u003d resource.Body(\"snapshot_support\", type\u003dbool)"},{"line_number":95,"context_line":"    # Whether the share can be clones into new shares or not."},{"line_number":96,"context_line":"    create_share_from_snapshot_support \u003d resource.Body("},{"line_number":97,"context_line":"        \"create_share_from_snapshot_support\", type\u003dbool)"}],"source_content_type":"text/x-python","patch_set":5,"id":"124ee4cb_e20f87a6","line":94,"updated":"2021-03-04 12:16:59.000000000","message":"flag/bool type of attrs in sdk are having \"is_\" prefix \u003d\u003e is_snaphot_support (or perhaps is_supporting_snapshot), is_supporting_mount_snapshot, etc","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e64e64d7cdc17aef7d9b600430bbbedc5bc5c60e","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    #: The level of visibility for the share."},{"line_number":45,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":46,"context_line":"    #: Whether the share can be clones into new shares or not."},{"line_number":47,"context_line":"    is_supporting_create_share_from_snapshot \u003d resource.Body("},{"line_number":48,"context_line":"        \"is_supporting_create_share_from_snapshot\", type\u003dbool)"},{"line_number":49,"context_line":"    #: Whether the share\u0027s snapshots can be mounted directly and access"},{"line_number":50,"context_line":"    #: controlled independently or not."},{"line_number":51,"context_line":"    is_supporting_mount_snapshot \u003d resource.Body("},{"line_number":52,"context_line":"        \"is_supporting_mount_snapshot\", type\u003dbool)"},{"line_number":53,"context_line":"    #: Whether the share can be reverted to its latest snapshot or not."},{"line_number":54,"context_line":"    is_supporting_revert_to_snapshot \u003d resource.Body("},{"line_number":55,"context_line":"        \"is_supporting_revert_to_snapshot\", type\u003dbool)"},{"line_number":56,"context_line":"    #: An extra specification that filters back ends by whether the share"},{"line_number":57,"context_line":"    #: supports snapshots or not."},{"line_number":58,"context_line":"    is_supporting_snapshot \u003d resource.Body("},{"line_number":59,"context_line":"        \"is_supporting_snapshot\", type\u003dbool)"},{"line_number":60,"context_line":"    #: Indicates whether the share has replicas or not."},{"line_number":61,"context_line":"    is_replicas \u003d resource.Body(\"is_replicas\", type\u003dbool)"},{"line_number":62,"context_line":"    #: One or more metadata key and value pairs as a dictionary of strings."},{"line_number":63,"context_line":"    metadata \u003d resource.Body(\"metadata\", type\u003ddict)"},{"line_number":64,"context_line":"    #: The user defined name of the resource."},{"line_number":65,"context_line":"    name \u003d resource.Body(\"name\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":8,"id":"078a62dc_71ee0ff2","line":62,"range":{"start_line":47,"start_character":1,"end_line":62,"end_character":75},"updated":"2021-03-22 21:36:48.000000000","message":"these sound weird, and I personally don\u0027t see the point of renaming these, but I see that Artem suggested this based on a convention in this project. I suggest using better names to convey these:\n\n is_supporting_create_share_from_snapshot \u003d is_creating_new_share_from_snapshot_supported\n is_supporting_mount_snapshot \u003d is_mounting_snapshot_supported\n is_supporting_revert_to_snapshot \u003d is_reverting_to_snapshot_supported\n is_supporting_snapshot \u003d is_snapshot_supported\n is_replicas \u003d is_replicated","commit_id":"f664e19ab11ed74aa74708fe7ad3a940ff4cbe91"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4316fd22e2f8c338243a72500420865c1db0819b","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    #: The share host name."},{"line_number":41,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":42,"context_line":"    #: The UUID of the share."},{"line_number":43,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":44,"context_line":"    #: The level of visibility for the share."},{"line_number":45,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":46,"context_line":"    #: Whether the share can be clones into new shares or not."}],"source_content_type":"text/x-python","patch_set":10,"id":"1c39ea7b_379cdf87","line":43,"updated":"2021-04-22 15:07:14.000000000","message":"ID and NAME are base attributes and you do not need to define them at all (https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L426)","commit_id":"a49ecba2fc85712f6dd271b882a0a71a4d190de8"}],"openstack/shared_file_system/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d0e225cc_5316b0ae","updated":"2021-02-15 21:58:18.000000000","message":"call this file: \"share.py\"\n\nsingular..","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eb35d17b_573e777e","in_reply_to":"d0e225cc_5316b0ae","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from openstack import resource"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class Shares(resource.Resource):"},{"line_number":17,"context_line":"    resource_key \u003d \"share\""},{"line_number":18,"context_line":"    resources_key \u003d \"shares\""},{"line_number":19,"context_line":"    base_path \u003d \"/shares/detail\""}],"source_content_type":"text/x-python","patch_set":1,"id":"43984a9b_c00be815","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":12},"updated":"2021-02-15 21:58:18.000000000","message":"Share\n\nthis resource represents a single share","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from openstack import resource"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class Shares(resource.Resource):"},{"line_number":17,"context_line":"    resource_key \u003d \"share\""},{"line_number":18,"context_line":"    resources_key \u003d \"shares\""},{"line_number":19,"context_line":"    base_path \u003d \"/shares/detail\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fc0e8632_2fe0080a","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":12},"in_reply_to":"43984a9b_c00be815","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # capabilities"},{"line_number":22,"context_line":"    allow_create \u003d True"},{"line_number":23,"context_line":"    allow_fetch \u003d True"},{"line_number":24,"context_line":"    allow_commit \u003d True "},{"line_number":25,"context_line":"    allow_delete \u003d True"},{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":"    allow_head \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"340616da_4e50e4fa","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":24},"updated":"2021-02-15 21:58:18.000000000","message":"trailing whitespace","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    # capabilities"},{"line_number":22,"context_line":"    allow_create \u003d True"},{"line_number":23,"context_line":"    allow_fetch \u003d True"},{"line_number":24,"context_line":"    allow_commit \u003d True "},{"line_number":25,"context_line":"    allow_delete \u003d True"},{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":"    allow_head \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ddac142_ddce90f3","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":24},"in_reply_to":"340616da_4e50e4fa","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    # The UUID of the share."},{"line_number":31,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":32,"context_line":"    # The share size, in GBs."},{"line_number":33,"context_line":"    size \u003d resource.Body(\"size\", type\u003dint)"},{"line_number":34,"context_line":"    # The availability zone."},{"line_number":35,"context_line":"    availability_zone \u003d resource.Body(\"availability_zone\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"032aab86_259fe59d","line":32,"range":{"start_line":32,"start_character":25,"end_line":32,"end_character":28},"updated":"2021-02-15 21:58:18.000000000","message":"GiBs","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    # The UUID of the share."},{"line_number":31,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":32,"context_line":"    # The share size, in GBs."},{"line_number":33,"context_line":"    size \u003d resource.Body(\"size\", type\u003dint)"},{"line_number":34,"context_line":"    # The availability zone."},{"line_number":35,"context_line":"    availability_zone \u003d resource.Body(\"availability_zone\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df90ddea_f372f081","line":32,"range":{"start_line":32,"start_character":25,"end_line":32,"end_character":28},"in_reply_to":"032aab86_259fe59d","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    links \u003d resource.Body(\"links\", type\u003dlist)"},{"line_number":62,"context_line":"    # The level of visibility for the share."},{"line_number":63,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":64,"context_line":"    # An extra specification that filters back ends by whether they do or do"},{"line_number":65,"context_line":"    # not support share snapshots."},{"line_number":66,"context_line":"    snapshot_support \u003d resource.Body(\"snapshot_support\", type\u003dbool)"},{"line_number":67,"context_line":"    # For the share migration, the migration task state."},{"line_number":68,"context_line":"    task_state \u003d resource.Body(\"task_state\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d9fc56a_0787bad4","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":34},"updated":"2021-02-15 21:58:18.000000000","message":"Whether the share supports snapshots or not\n\n\nCan you move the following options to be in one group:\n\n# share capabilities\nreplication_type\nsnapshot_support\ncreate_share_from_snapshot_support\nrevert_to_snapshot_support\nmount_snapshot_support","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    links \u003d resource.Body(\"links\", type\u003dlist)"},{"line_number":62,"context_line":"    # The level of visibility for the share."},{"line_number":63,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":64,"context_line":"    # An extra specification that filters back ends by whether they do or do"},{"line_number":65,"context_line":"    # not support share snapshots."},{"line_number":66,"context_line":"    snapshot_support \u003d resource.Body(\"snapshot_support\", type\u003dbool)"},{"line_number":67,"context_line":"    # For the share migration, the migration task state."},{"line_number":68,"context_line":"    task_state \u003d resource.Body(\"task_state\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a63c5b67_72ac16ab","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":34},"in_reply_to":"1d9fc56a_0787bad4","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    # The share instance access rules status. A valid value is active, error,"},{"line_number":72,"context_line":"    # or syncing."},{"line_number":73,"context_line":"    access_rules_status \u003d resource.Body(\"access_rules_status\", type\u003dstr)"},{"line_number":74,"context_line":"    # The share replication type."},{"line_number":75,"context_line":"    replication_type \u003d resource.Body(\"replication_type\", type\u003dstr)"},{"line_number":76,"context_line":"    # Indicates whether a share has replicas or not."},{"line_number":77,"context_line":"    has_replicas \u003d resource.Body(\"has_replicas\", type\u003dbool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"79cf91bc_5b6033c9","line":74,"range":{"start_line":74,"start_character":32,"end_line":74,"end_character":33},"updated":"2021-02-15 21:58:18.000000000","message":"Valid values are None, readable, writable and dr","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    # The share instance access rules status. A valid value is active, error,"},{"line_number":72,"context_line":"    # or syncing."},{"line_number":73,"context_line":"    access_rules_status \u003d resource.Body(\"access_rules_status\", type\u003dstr)"},{"line_number":74,"context_line":"    # The share replication type."},{"line_number":75,"context_line":"    replication_type \u003d resource.Body(\"replication_type\", type\u003dstr)"},{"line_number":76,"context_line":"    # Indicates whether a share has replicas or not."},{"line_number":77,"context_line":"    has_replicas \u003d resource.Body(\"has_replicas\", type\u003dbool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"80d8fc6b_b31e5f30","line":74,"range":{"start_line":74,"start_character":32,"end_line":74,"end_character":33},"in_reply_to":"79cf91bc_5b6033c9","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    access_rules_status \u003d resource.Body(\"access_rules_status\", type\u003dstr)"},{"line_number":74,"context_line":"    # The share replication type."},{"line_number":75,"context_line":"    replication_type \u003d resource.Body(\"replication_type\", type\u003dstr)"},{"line_number":76,"context_line":"    # Indicates whether a share has replicas or not."},{"line_number":77,"context_line":"    has_replicas \u003d resource.Body(\"has_replicas\", type\u003dbool)"},{"line_number":78,"context_line":"    # ID of the user that the share was created by."},{"line_number":79,"context_line":"    user_id \u003d resource.Body(\"user_id\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4994a9a2_5c55a9bf","line":76,"range":{"start_line":76,"start_character":24,"end_line":76,"end_character":25},"updated":"2021-02-15 21:58:18.000000000","message":"nit: the","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    access_rules_status \u003d resource.Body(\"access_rules_status\", type\u003dstr)"},{"line_number":74,"context_line":"    # The share replication type."},{"line_number":75,"context_line":"    replication_type \u003d resource.Body(\"replication_type\", type\u003dstr)"},{"line_number":76,"context_line":"    # Indicates whether a share has replicas or not."},{"line_number":77,"context_line":"    has_replicas \u003d resource.Body(\"has_replicas\", type\u003dbool)"},{"line_number":78,"context_line":"    # ID of the user that the share was created by."},{"line_number":79,"context_line":"    user_id \u003d resource.Body(\"user_id\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3e005bce_ddb4a25d","line":76,"range":{"start_line":76,"start_character":24,"end_line":76,"end_character":25},"in_reply_to":"4994a9a2_5c55a9bf","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    has_replicas \u003d resource.Body(\"has_replicas\", type\u003dbool)"},{"line_number":78,"context_line":"    # ID of the user that the share was created by."},{"line_number":79,"context_line":"    user_id \u003d resource.Body(\"user_id\", type\u003dstr)"},{"line_number":80,"context_line":"    # Create a share from a snapshot"},{"line_number":81,"context_line":"    create_share_from_snapshot_support \u003d resource.Body("},{"line_number":82,"context_line":"        \"create_share_from_snapshot_support\", type\u003dbool)"},{"line_number":83,"context_line":"    # Revert share to snapshot"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bc8af81_ae3c514a","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":36},"updated":"2021-02-15 21:58:18.000000000","message":"Whether the share\u0027s snapshots can be cloned into new shares or not","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    has_replicas \u003d resource.Body(\"has_replicas\", type\u003dbool)"},{"line_number":78,"context_line":"    # ID of the user that the share was created by."},{"line_number":79,"context_line":"    user_id \u003d resource.Body(\"user_id\", type\u003dstr)"},{"line_number":80,"context_line":"    # Create a share from a snapshot"},{"line_number":81,"context_line":"    create_share_from_snapshot_support \u003d resource.Body("},{"line_number":82,"context_line":"        \"create_share_from_snapshot_support\", type\u003dbool)"},{"line_number":83,"context_line":"    # Revert share to snapshot"}],"source_content_type":"text/x-python","patch_set":1,"id":"092ad051_c066a2da","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":36},"in_reply_to":"0bc8af81_ae3c514a","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    # Create a share from a snapshot"},{"line_number":81,"context_line":"    create_share_from_snapshot_support \u003d resource.Body("},{"line_number":82,"context_line":"        \"create_share_from_snapshot_support\", type\u003dbool)"},{"line_number":83,"context_line":"    # Revert share to snapshot"},{"line_number":84,"context_line":"    revert_to_snapshot_support \u003d resource.Body("},{"line_number":85,"context_line":"        \"revert_to_snapshot_support\", type\u003dbool)"},{"line_number":86,"context_line":"    # The UUID of the share group."}],"source_content_type":"text/x-python","patch_set":1,"id":"94509449_c7b41c64","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":30},"updated":"2021-02-15 21:58:18.000000000","message":"Whether the share can be reverted to its latest snapshot or not","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    # Create a share from a snapshot"},{"line_number":81,"context_line":"    create_share_from_snapshot_support \u003d resource.Body("},{"line_number":82,"context_line":"        \"create_share_from_snapshot_support\", type\u003dbool)"},{"line_number":83,"context_line":"    # Revert share to snapshot"},{"line_number":84,"context_line":"    revert_to_snapshot_support \u003d resource.Body("},{"line_number":85,"context_line":"        \"revert_to_snapshot_support\", type\u003dbool)"},{"line_number":86,"context_line":"    # The UUID of the share group."}],"source_content_type":"text/x-python","patch_set":1,"id":"e587f583_5ae16096","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":30},"in_reply_to":"94509449_c7b41c64","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    # Revert share to snapshot"},{"line_number":84,"context_line":"    revert_to_snapshot_support \u003d resource.Body("},{"line_number":85,"context_line":"        \"revert_to_snapshot_support\", type\u003dbool)"},{"line_number":86,"context_line":"    # The UUID of the share group."},{"line_number":87,"context_line":"    share_group_id \u003d resource.Body(\"share_group_id\", type\u003dstr)"},{"line_number":88,"context_line":"    # The ID of the group snapshot instance that was used to create this share."},{"line_number":89,"context_line":"    source_share_group_snapshot_member_id \u003d resource.Body("}],"source_content_type":"text/x-python","patch_set":1,"id":"3ed02860_4daa7089","line":86,"range":{"start_line":86,"start_character":33,"end_line":86,"end_character":34},"updated":"2021-02-15 21:58:18.000000000","message":"that this share belongs to","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # Revert share to snapshot"},{"line_number":84,"context_line":"    revert_to_snapshot_support \u003d resource.Body("},{"line_number":85,"context_line":"        \"revert_to_snapshot_support\", type\u003dbool)"},{"line_number":86,"context_line":"    # The UUID of the share group."},{"line_number":87,"context_line":"    share_group_id \u003d resource.Body(\"share_group_id\", type\u003dstr)"},{"line_number":88,"context_line":"    # The ID of the group snapshot instance that was used to create this share."},{"line_number":89,"context_line":"    source_share_group_snapshot_member_id \u003d resource.Body("}],"source_content_type":"text/x-python","patch_set":1,"id":"b1f5ff7d_abaa652b","line":86,"range":{"start_line":86,"start_character":33,"end_line":86,"end_character":34},"in_reply_to":"3ed02860_4daa7089","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    # The ID of the group snapshot instance that was used to create this share."},{"line_number":89,"context_line":"    source_share_group_snapshot_member_id \u003d resource.Body("},{"line_number":90,"context_line":"        \"source_share_group_snapshot_member_id\", type\u003dstr)"},{"line_number":91,"context_line":"    # Mount a snapshot."},{"line_number":92,"context_line":"    mount_snapshot_support \u003d resource.Body("},{"line_number":93,"context_line":"        \"mount_snapshot_support\", type\u003dbool)"},{"line_number":94,"context_line":"    # The progress of the share creation."}],"source_content_type":"text/x-python","patch_set":1,"id":"bb26f3d9_b64a5dc9","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":23},"updated":"2021-02-15 21:58:18.000000000","message":"Whether the share\u0027s snapshots can be mounted directly and access controlled independently or not","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # The ID of the group snapshot instance that was used to create this share."},{"line_number":89,"context_line":"    source_share_group_snapshot_member_id \u003d resource.Body("},{"line_number":90,"context_line":"        \"source_share_group_snapshot_member_id\", type\u003dstr)"},{"line_number":91,"context_line":"    # Mount a snapshot."},{"line_number":92,"context_line":"    mount_snapshot_support \u003d resource.Body("},{"line_number":93,"context_line":"        \"mount_snapshot_support\", type\u003dbool)"},{"line_number":94,"context_line":"    # The progress of the share creation."}],"source_content_type":"text/x-python","patch_set":1,"id":"fd9f17f7_c090b510","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":23},"in_reply_to":"bb26f3d9_b64a5dc9","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"}],"openstack/tests/functional/shared_file_system/test_share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e64e64d7cdc17aef7d9b600430bbbedc5bc5c60e","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    min_microversion \u003d \u00272.7\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_shares(self):"},{"line_number":21,"context_line":"        shs \u003d self.conn.shared_file_system.shares()"},{"line_number":22,"context_line":"        for sh in shs:"},{"line_number":23,"context_line":"            for attribute in (\u0027id\u0027, \u0027name\u0027, \u0027availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e706d8ff_3cc23434","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":4},"updated":"2021-03-22 21:36:48.000000000","message":"Good looking test!\nCan you also add tests to create, get, update and delete a share? those tests can come in a follow up change and it would be nice to have complete test coverage.","commit_id":"f664e19ab11ed74aa74708fe7ad3a940ff4cbe91"}],"openstack/tests/unit/cloud/test_shared_file_system.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"fd589ddca1295be4a6a3be3f3793385a2de66550","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(MANILA_AZ_DICT[\u0027updated_at\u0027], az_list[0].updated_at)"},{"line_number":92,"context_line":"        self.assert_calls()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_list_shares(self):"},{"line_number":95,"context_line":"        self.register_uris(["},{"line_number":96,"context_line":"            dict(method\u003d\u0027GET\u0027,"},{"line_number":97,"context_line":"                 uri\u003dself.get_mock_url("}],"source_content_type":"text/x-python","patch_set":5,"id":"ed3cd338_5795764d","line":94,"updated":"2021-03-04 12:16:59.000000000","message":"good that you started with cloud layer, but I suggest you do this separately. It costs too much additional effort without immediate use. You can implement this in the followups and focus on important things first","commit_id":"a7a32d835bf118ccc3d7b9c0f42db69794c427d8"}],"openstack/tests/unit/shared_file_system/v2/test_proxy.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"9cc3f8fb1ed8743c67f72e448a0fdf4fff61c92e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                 json\u003d{\u0027share\u0027: MANILA_SHARE_DICT}),"},{"line_number":215,"context_line":"        ])"},{"line_number":216,"context_line":"        update_share \u003d self.share_proxy.update_share(SH_ID, name\u003dnew_name,"},{"line_number":217,"context_line":"                                               description\u003dnew_description,"},{"line_number":218,"context_line":"                                               is_public\u003dnew_is_public)"},{"line_number":219,"context_line":"        self.assertEqual(MANILA_SHARE_DICT[\u0027name\u0027], update_share.name)"},{"line_number":220,"context_line":"        self.assertEqual(MANILA_SHARE_DICT[\u0027description\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"18bc50ea_8d177e8c","line":217,"updated":"2021-03-21 08:28:00.000000000","message":"In case you didn\u0027t understand what Zuul is saying, the \"description\u003d ...\" should align with the SH_ID on the line above.","commit_id":"6b6b3a1863141c2d8fceceeafa684c3fcc7f14f0"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"9cc3f8fb1ed8743c67f72e448a0fdf4fff61c92e","unresolved":true,"context_lines":[{"line_number":215,"context_line":"        ])"},{"line_number":216,"context_line":"        update_share \u003d self.share_proxy.update_share(SH_ID, name\u003dnew_name,"},{"line_number":217,"context_line":"                                               description\u003dnew_description,"},{"line_number":218,"context_line":"                                               is_public\u003dnew_is_public)"},{"line_number":219,"context_line":"        self.assertEqual(MANILA_SHARE_DICT[\u0027name\u0027], update_share.name)"},{"line_number":220,"context_line":"        self.assertEqual(MANILA_SHARE_DICT[\u0027description\u0027],"},{"line_number":221,"context_line":"                         update_share.description)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb474c6_da3633d1","line":218,"range":{"start_line":218,"start_character":47,"end_line":218,"end_character":56},"updated":"2021-03-21 08:28:00.000000000","message":"and \"is_public\u003d ...\" should align under the \"description\u003d\" and \"SH_ID\"","commit_id":"6b6b3a1863141c2d8fceceeafa684c3fcc7f14f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e64e64d7cdc17aef7d9b600430bbbedc5bc5c60e","unresolved":true,"context_lines":[{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"SH_ID \u003d str(uuid.uuid4())"},{"line_number":18,"context_line":"MANILA_SHARE_DICT \u003d {"},{"line_number":19,"context_line":"    \"id\": SH_ID,"},{"line_number":20,"context_line":"    \"size\": 1,"}],"source_content_type":"text/x-python","patch_set":8,"id":"35eb173c_6eddb3dd","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":5},"updated":"2021-03-22 21:36:48.000000000","message":"nit: SHARE_ID\nSH_ID isn\u0027t very readable. We generally don\u0027t abbreviate single words like \u0027share\u0027...","commit_id":"f664e19ab11ed74aa74708fe7ad3a940ff4cbe91"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4316fd22e2f8c338243a72500420865c1db0819b","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        self.share_proxy \u003d self.cloud.share"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_list_shares(self):"},{"line_number":61,"context_line":"        self.register_uris(["},{"line_number":62,"context_line":"            dict(method\u003d\u0027GET\u0027,"},{"line_number":63,"context_line":"                 uri\u003dself.get_mock_url("},{"line_number":64,"context_line":"                     \u0027shared-file-system\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"98a4b736_0ccfa5c9","line":61,"updated":"2021-04-22 15:07:14.000000000","message":"unittest for proxy is not the place where we check properties or mock urls (usually). Please have a look on https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/dns/v2/test_proxy.py to get better view on how it should look like","commit_id":"a49ecba2fc85712f6dd271b882a0a71a4d190de8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9a0658a1cb921ba5985dbb1fc772307758330b2f","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        self.share_proxy \u003d self.cloud.share"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_list_shares(self):"},{"line_number":61,"context_line":"        self.register_uris(["},{"line_number":62,"context_line":"            dict(method\u003d\u0027GET\u0027,"},{"line_number":63,"context_line":"                 uri\u003dself.get_mock_url("},{"line_number":64,"context_line":"                     \u0027shared-file-system\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"71800f90_d75a1ebf","line":61,"in_reply_to":"98a4b736_0ccfa5c9","updated":"2021-05-06 17:19:34.000000000","message":"Hmm, these unit tests did help us catch issues with the functional code - so I believe they\u0027re helpful. My main concern was the verifications associated with the \"verify_XYZ\" (e.g.: verify_get, verify_create) methods not including the result verification. However, it appears we could check results if we wanted with the \"expected_result\" parameter in each of those methods, however, that\u0027s being ignored in verify_list and verify_get: \n\nhttps://opendev.org/openstack/openstacksdk/src/commit/6f9cd3f7a7b7823195c4b6fa564e094618afbdff/openstack/tests/unit/test_proxy_base.py#L215\n\nHow do we be consistent while still preserving this test coverage?","commit_id":"a49ecba2fc85712f6dd271b882a0a71a4d190de8"}],"openstack/tests/unit/shared_file_system/v2/test_share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e64e64d7cdc17aef7d9b600430bbbedc5bc5c60e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from openstack.shared_file_system.v2 import share"},{"line_number":14,"context_line":"from openstack.tests.unit import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"IDENTIFIER \u003d \u002708a87d37-5ca2-4308-86c5-cba06d8d796c\u0027"},{"line_number":17,"context_line":"EXAMPLE \u003d {"},{"line_number":18,"context_line":"    \"id\": IDENTIFIER,"},{"line_number":19,"context_line":"    \"size\": 1,"},{"line_number":20,"context_line":"    \"availability_zone\": \"manila-zone-1\","},{"line_number":21,"context_line":"    \"created_at\": \"2021-02-11T17:38:00.000000\","},{"line_number":22,"context_line":"    \"status\": \"available\","},{"line_number":23,"context_line":"    \"name\": None,"},{"line_number":24,"context_line":"    \"description\": None,"},{"line_number":25,"context_line":"    \"project_id\": \"d19444eb73af4b37bc0794532ef6fc50\","},{"line_number":26,"context_line":"    \"snapshot_id\": None,"},{"line_number":27,"context_line":"    \"share_network_id\": None,"},{"line_number":28,"context_line":"    \"share_protocol\": \"NFS\","},{"line_number":29,"context_line":"    \"metadata\": {},"},{"line_number":30,"context_line":"    \"share_type\": \"cbb18bb7-cc97-477a-b64b-ed7c7f2a1c67\","},{"line_number":31,"context_line":"    \"volume_type\": \"default\","},{"line_number":32,"context_line":"    \"is_public\": False,"},{"line_number":33,"context_line":"    \"is_supporting_snapshot\": True,"},{"line_number":34,"context_line":"    \"task_state\": None,"},{"line_number":35,"context_line":"    \"share_type_name\": \"default\","},{"line_number":36,"context_line":"    \"access_rules_status\": \"active\","},{"line_number":37,"context_line":"    \"replication_type\": None,"},{"line_number":38,"context_line":"    \"is_replicas\": False,"},{"line_number":39,"context_line":"    \"user_id\": \"6c262cab98de42c2afc4cfccbefc50c7\","},{"line_number":40,"context_line":"    \"is_supporting_create_share_from_snapshot\": True,"},{"line_number":41,"context_line":"    \"is_supporting_revert_to_snapshot\": True,"},{"line_number":42,"context_line":"    \"share_group_id\": None,"},{"line_number":43,"context_line":"    \"source_share_group_snapshot_member_id\": None,"},{"line_number":44,"context_line":"    \"is_supporting_mount_snapshot\": True,"},{"line_number":45,"context_line":"    \"progress\": \"100%\","},{"line_number":46,"context_line":"    \"share_server_id\": None,"},{"line_number":47,"context_line":"    \"host\": \"new@denver#lvm-single-pool\""},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class TestShares(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3b383155_799bf913","line":48,"range":{"start_line":16,"start_character":0,"end_line":48,"end_character":1},"updated":"2021-03-22 21:36:48.000000000","message":"you could create a fakes.py file and put these fakes there and reuse them across different test files","commit_id":"f664e19ab11ed74aa74708fe7ad3a940ff4cbe91"}],"openstack/tests/unit/shared_filesystem_storage/v2/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack.shared_file_system.v2 import shares as shares"},{"line_number":14,"context_line":"from openstack.tests.unit import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"IDENTIFIER \u003d \u002708a87d37-5ca2-4308-86c5-cba06d8d796c\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"034a9f45_dc172527","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":60},"updated":"2021-02-15 21:58:18.000000000","message":"no need to rename import if that\u0027s the name you wish to use","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack.shared_file_system.v2 import shares as shares"},{"line_number":14,"context_line":"from openstack.tests.unit import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"IDENTIFIER \u003d \u002708a87d37-5ca2-4308-86c5-cba06d8d796c\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"6260e654_e41cbea1","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":60},"in_reply_to":"034a9f45_dc172527","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    \"links\": ["},{"line_number":33,"context_line":"        {"},{"line_number":34,"context_line":"            \"rel\": \"self\","},{"line_number":35,"context_line":"            \"href\": \"http://199.19.213.65/share/v2/d194\\"},{"line_number":36,"context_line":"                44eb73af4b37bc0794532ef6fc50/shares/ea1a5bd4-a8aa-\\"},{"line_number":37,"context_line":"                    48a4-b0b7-d850cb164a5c\""},{"line_number":38,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed3a2d31_4c563737","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":41},"updated":"2021-02-15 21:58:18.000000000","message":"comment below:","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"links\": ["},{"line_number":33,"context_line":"        {"},{"line_number":34,"context_line":"            \"rel\": \"self\","},{"line_number":35,"context_line":"            \"href\": \"http://199.19.213.65/share/v2/d194\\"},{"line_number":36,"context_line":"                44eb73af4b37bc0794532ef6fc50/shares/ea1a5bd4-a8aa-\\"},{"line_number":37,"context_line":"                    48a4-b0b7-d850cb164a5c\""},{"line_number":38,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6a1d784_dc8124fd","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":41},"in_reply_to":"ed3a2d31_4c563737","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a2fb250a72e21bc46f9b7acbc2a1038058835d9","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        },"},{"line_number":39,"context_line":"        {"},{"line_number":40,"context_line":"            \"rel\": \"bookmark\","},{"line_number":41,"context_line":"            \"href\": \"http://199.19.213.65/share/d19444eb\\"},{"line_number":42,"context_line":"                73af4b37bc0794532ef6fc50/shares/ea1a5bd4-a8aa-48a4-b\\"},{"line_number":43,"context_line":"                    0b7-d850cb164a5c\""},{"line_number":44,"context_line":"        }],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ea2ff59d_16c46577","line":41,"range":{"start_line":41,"start_character":28,"end_line":41,"end_character":41},"updated":"2021-02-15 21:58:18.000000000","message":"obfuscate this IP address, use a documentation IP address from these:\n\n   The blocks 192.0.2.0/24 (TEST-NET-1), 198.51.100.0/24 (TEST-NET-2),\n   and 203.0.113.0/24 (TEST-NET-3) are provided for use in\n   documentation. [1]\n\n[1] https://tools.ietf.org/html/rfc5737","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"df80c14d078875ddfa857b80f8c030baf42a9482","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        },"},{"line_number":39,"context_line":"        {"},{"line_number":40,"context_line":"            \"rel\": \"bookmark\","},{"line_number":41,"context_line":"            \"href\": \"http://199.19.213.65/share/d19444eb\\"},{"line_number":42,"context_line":"                73af4b37bc0794532ef6fc50/shares/ea1a5bd4-a8aa-48a4-b\\"},{"line_number":43,"context_line":"                    0b7-d850cb164a5c\""},{"line_number":44,"context_line":"        }],"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4e064db_f64c14b6","line":41,"range":{"start_line":41,"start_character":28,"end_line":41,"end_character":41},"in_reply_to":"ea2ff59d_16c46577","updated":"2021-02-25 02:37:44.000000000","message":"Done","commit_id":"5d7983ab285e7bf88aebd85f248555f3ca63858f"}],"releasenotes/notes/add-shared-file-system-shares-e9f356a318045607.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c934a36cc6120f8ef85e9526cfaf1e730022757c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to create, update, list, get, and delete shares "},{"line_number":5,"context_line":"    (from shared file system service)."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"25477997_f60ea446","line":4,"range":{"start_line":4,"start_character":65,"end_line":4,"end_character":66},"updated":"2021-03-25 23:42:04.000000000","message":"nit: trailing white space","commit_id":"1d4ab0c511980e74687186cf0479c0c6be1486c3"}]}