)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2a4654ccf44f7e4ca70a02ea22da21dd4e400531","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add masakari enabled to segment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027enabled\u0027 to Masakari segment in microversion 1.2."},{"line_number":10,"context_line":"It returns \"enabled\" flag in segments API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I445774a8af60a75c6b936d25fbab858233c632e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c94ffa2a_ccc3f81b","line":9,"updated":"2021-03-01 14:29:17.000000000","message":"I don\u0027t see anything about this microversion in the code. Will the patch still work with an old version of the API?","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6eca436e37e3eedb57f04cce17ae0020060828f1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add masakari enabled to segment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027enabled\u0027 to Masakari segment in microversion 1.2."},{"line_number":10,"context_line":"It returns \"enabled\" flag in segments API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I445774a8af60a75c6b936d25fbab858233c632e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"eeb456d2_11e8bb25","line":9,"in_reply_to":"208380d7_bc181ad3","updated":"2021-03-01 15:14:37.000000000","message":"Should we depend on that? Any reason the server code hasn\u0027t merged yet? Clients usually follow servers.","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"70e4b2944582bdac252c00239e309c79b6936934","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add masakari enabled to segment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027enabled\u0027 to Masakari segment in microversion 1.2."},{"line_number":10,"context_line":"It returns \"enabled\" flag in segments API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I445774a8af60a75c6b936d25fbab858233c632e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"208380d7_bc181ad3","line":9,"in_reply_to":"c94ffa2a_ccc3f81b","updated":"2021-03-01 14:32:44.000000000","message":"Yes, it works. The new field ends up being None, as usual. And 1.2 is coming in with https://review.opendev.org/c/openstack/masakari/+/700879","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"12df2c24bafc35ac7b2e6a53ee8d9174f62966b5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add masakari enabled to segment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027enabled\u0027 to Masakari segment in microversion 1.2."},{"line_number":10,"context_line":"It returns \"enabled\" flag in segments API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I445774a8af60a75c6b936d25fbab858233c632e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4e423561_3da8839a","line":9,"in_reply_to":"eeb456d2_11e8bb25","updated":"2021-03-01 15:40:34.000000000","message":"Hah, the reason is precisely because I wanted to be shown a working client. The only reason we don\u0027t have to depend-on that other patch is that, afaiu, osdk tests for Masakari are only unit tests, not really functional (i.e., against a real API). Correct me if that is wrong.","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"}],"openstack/instance_ha/v1/segment.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6eca436e37e3eedb57f04cce17ae0020060828f1","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    service_type \u003d resource.Body(\"service_type\")"},{"line_number":51,"context_line":"    #: The enabled flag of this segment."},{"line_number":52,"context_line":"    enabled \u003d resource.Body(\"enabled\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":55,"context_line":"        \"sort_key\", \"sort_dir\", recovery_method\u003d\"recovery_method\","},{"line_number":56,"context_line":"        service_type\u003d\"service_type\", enabled\u003d\"enabled\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"8e019148_7417def0","line":53,"updated":"2021-03-01 15:14:37.000000000","message":"Should we configure \u0027_max_microversion\u0027 to indicate that we support 1.2?","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"12df2c24bafc35ac7b2e6a53ee8d9174f62966b5","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    service_type \u003d resource.Body(\"service_type\")"},{"line_number":51,"context_line":"    #: The enabled flag of this segment."},{"line_number":52,"context_line":"    enabled \u003d resource.Body(\"enabled\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":55,"context_line":"        \"sort_key\", \"sort_dir\", recovery_method\u003d\"recovery_method\","},{"line_number":56,"context_line":"        service_type\u003d\"service_type\", enabled\u003d\"enabled\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"2437d4d8_a0476093","line":53,"in_reply_to":"8e019148_7417def0","updated":"2021-03-01 15:40:34.000000000","message":"Yeah, I think it makes sense after I have learnt how it works.","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6eca436e37e3eedb57f04cce17ae0020060828f1","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":55,"context_line":"        \"sort_key\", \"sort_dir\", recovery_method\u003d\"recovery_method\","},{"line_number":56,"context_line":"        service_type\u003d\"service_type\", enabled\u003d\"enabled\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ccc5134a_cf587488","line":56,"updated":"2021-03-01 15:14:37.000000000","message":"Hmm, pretty sure you don\u0027t need to keyword-style arguments unless you\u0027re using a different value to what is used in the API (i.e. \u0027project_id\u0027 when the API uses \u0027tenant_id\u0027), but this is already the case for the other two so maybe I\u0027m missing something.\n\nIn any case, it\u0027s already wrong so what\u0027s a bit more \"wrongness\"","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"12df2c24bafc35ac7b2e6a53ee8d9174f62966b5","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":55,"context_line":"        \"sort_key\", \"sort_dir\", recovery_method\u003d\"recovery_method\","},{"line_number":56,"context_line":"        service_type\u003d\"service_type\", enabled\u003d\"enabled\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff34dc41_0caaeef3","line":56,"in_reply_to":"ccc5134a_cf587488","updated":"2021-03-01 15:40:34.000000000","message":"We can eliminate the \"wrongness\" if it\u0027s unnecessary. ;-)","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"bfe18cb8e34192772a44039f8cb7a9f884c7b78f","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    #: The service type of this segment."},{"line_number":53,"context_line":"    service_type \u003d resource.Body(\"service_type\")"},{"line_number":54,"context_line":"    #: The enabled flag of this segment."},{"line_number":55,"context_line":"    enabled \u003d resource.Body(\"enabled\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":58,"context_line":"        \"sort_key\", \"sort_dir\", recovery_method\u003d\"recovery_method\","}],"source_content_type":"text/x-python","patch_set":3,"id":"336f01a2_8ff6df40","line":55,"updated":"2021-03-03 10:09:50.000000000","message":"sorry, I completely missed this in previous review. In SDK the standard is to prefix flag attributes with \"is_\" prefix, so this attr should be called \"is_enabled\".","commit_id":"0f6909176012d322e68769001badb3e23ee5010c"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"f3872e4f1c6b0a368797b5ea13ca1d1368fbb012","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    #: The service type of this segment."},{"line_number":53,"context_line":"    service_type \u003d resource.Body(\"service_type\")"},{"line_number":54,"context_line":"    #: The enabled flag of this segment."},{"line_number":55,"context_line":"    enabled \u003d resource.Body(\"enabled\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":58,"context_line":"        \"sort_key\", \"sort_dir\", recovery_method\u003d\"recovery_method\","}],"source_content_type":"text/x-python","patch_set":3,"id":"c7bc13ba_8bed2932","line":55,"in_reply_to":"336f01a2_8ff6df40","updated":"2021-03-03 12:04:27.000000000","message":"There are many prefix flag attributes without \"is_\" in nova/cinder/keystone and other service.\nI thinks we should comply with the Masakari design.","commit_id":"0f6909176012d322e68769001badb3e23ee5010c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d9ce6af48c294100646499a896b4b512c0e0c41a","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    #: The service type of this segment."},{"line_number":53,"context_line":"    service_type \u003d resource.Body(\"service_type\")"},{"line_number":54,"context_line":"    #: The enabled flag of this segment."},{"line_number":55,"context_line":"    enabled \u003d resource.Body(\"enabled\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":58,"context_line":"        \"sort_key\", \"sort_dir\", recovery_method\u003d\"recovery_method\","}],"source_content_type":"text/x-python","patch_set":3,"id":"e567094a_b6fb8bf2","line":55,"in_reply_to":"c7bc13ba_8bed2932","updated":"2021-03-03 16:47:15.000000000","message":"A quick search [1] finds only one example with of \u0027enabled\u0027, but loads of \u0027is_enabled\u0027. This should be \u0027is_enabled\u0027, for sure. You should also specify \u0027type\u003dbool\u0027\n\n[1] ag \u0027enabled \u003d\u0027 --ignore tests","commit_id":"0f6909176012d322e68769001badb3e23ee5010c"}],"openstack/tests/unit/instance_ha/v1/test_segment.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6eca436e37e3eedb57f04cce17ae0020060828f1","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    \"description\": \"something\","},{"line_number":27,"context_line":"    \"recovery_method\": \"auto\","},{"line_number":28,"context_line":"    \"service_type\": \"COMPUTE_HOST\","},{"line_number":29,"context_line":"    \"enabled\": True"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e495c916_07e56de4","line":29,"updated":"2021-03-01 15:14:37.000000000","message":"nit: trailing commas are nice for if/when this is expanded further in the future","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"}],"releasenotes/notes/add-masakari-enabled-to-segment-0e83da869d2ab03f.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6eca436e37e3eedb57f04cce17ae0020060828f1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add \u0027enabled\u0027 to Masakari segment in microversion 1.2."},{"line_number":4,"context_line":"    It returns ``enabled`` flag in segments API."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2376b5de_60050fe6","line":3,"updated":"2021-03-01 15:14:37.000000000","message":"How about:\n\n  Add support for the ``enabled`` field of the ``Segment`` resource for the\n  instance HA service (Masakari).","commit_id":"d8b8204693c66c736c5fdd0f2fa47fb66cc7bfde"}]}