)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ad95738a_54c2825a","updated":"2023-04-03 11:37:36.000000000","message":"So close. One TODO left","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4a35ff778a0b6bfd152ec497905a40832487997","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cb306448_1c010b18","updated":"2023-04-03 11:42:53.000000000","message":"Spotted a few more things, actually","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f4f5643c1595354b3d43963e06a6789fe2365cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c8e935ee_be351485","updated":"2023-04-03 20:44:12.000000000","message":"Thanks for the update Sam; could you also please respond/resolve comments when you post your patch?\n\n+1 on Stephen\u0027s docs comments; and a few more notes inline.. ","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3226a7ff04f62e87667512a2418546f939d9b113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0e3b34d8_41016f30","updated":"2023-04-03 11:43:57.000000000","message":"You also need to add this stuff to docs, as you\u0027ve done in e.g. [1]\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/873109","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e39e535f442cc7a797446c87d15ffddb05c80884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bafc9f49_681ee3ef","updated":"2023-04-08 00:40:57.000000000","message":"Hi Sam, \n\nThanks for pushing up a new patchset. Please \"resolve\" prior comments from Stephen; my -1 is for the unrelated change in openstack/tests/unit/cloud/test_shared_file_system.py that needs to be reverted. Please see new comments inline.","commit_id":"c9c4e7c2a5cce5ede7f566285faa59f75e12812f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6e3b3ba1dbe5ea0519a583faba28707b84d20b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2895ddf6_41a3575e","updated":"2023-04-11 18:13:39.000000000","message":"Thanks, LGTM Sam!","commit_id":"ecde40285380beaeeced7f32c17f8dce027f68ca"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cf26fc93db205164b6ec8069fb6290ce0151722","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    def export_locations(self, share_id):"},{"line_number":31,"context_line":"        r\"\"\"List all export locations with details"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :returns: Details of export location"},{"line_number":34,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":35,"context_line":"                                    \\share_export_locations.ShareExportLocations`"},{"line_number":36,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"f9471048_f8215b2d","line":33,"updated":"2021-05-12 14:41:36.000000000","message":"You\u0027re missing docs for the \u0027share_id\u0027 parameter","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def export_locations(self, share_id):"},{"line_number":31,"context_line":"        r\"\"\"List all export locations with details"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :returns: Details of export location"},{"line_number":34,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":35,"context_line":"                                    \\share_export_locations.ShareExportLocations`"},{"line_number":36,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"48713717_be57fdf7","line":33,"in_reply_to":"f9471048_f8215b2d","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def export_locations(self, share_id):"},{"line_number":31,"context_line":"        r\"\"\"List all export locations with details"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :returns: Details of export location"},{"line_number":34,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":35,"context_line":"                                    \\share_export_locations.ShareExportLocations`"},{"line_number":36,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"79e39ba7_89cecbae","line":33,"in_reply_to":"f9471048_f8215b2d","updated":"2023-04-03 11:37:36.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cf26fc93db205164b6ec8069fb6290ce0151722","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    def get_export_location(self, export_location, share_id):"},{"line_number":40,"context_line":"        r\"\"\"List details of export location"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :returns: Details of identified export location"},{"line_number":43,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":44,"context_line":"                                    \\share_export_locations.ShareExportLocations`"},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"c398bae8_f4a5e054","line":42,"updated":"2021-05-12 14:41:36.000000000","message":"Need docs for export_location and share_id","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def get_export_location(self, export_location, share_id):"},{"line_number":40,"context_line":"        r\"\"\"List details of export location"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :returns: Details of identified export location"},{"line_number":43,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":44,"context_line":"                                    \\share_export_locations.ShareExportLocations`"},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"868d2841_2b202710","line":42,"in_reply_to":"c398bae8_f4a5e054","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def get_export_location(self, export_location, share_id):"},{"line_number":40,"context_line":"        r\"\"\"List details of export location"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :returns: Details of identified export location"},{"line_number":43,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":44,"context_line":"                                    \\share_export_locations.ShareExportLocations`"},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"25b5141c_4f228931","line":42,"in_reply_to":"c398bae8_f4a5e054","updated":"2023-04-03 11:37:36.000000000","message":"Done (partially - comments left on PS10)","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4a35ff778a0b6bfd152ec497905a40832487997","unresolved":true,"context_lines":[{"line_number":31,"context_line":")"},{"line_number":32,"context_line":"from openstack.shared_file_system.v2 import limit as _limit"},{"line_number":33,"context_line":"from openstack.shared_file_system.v2 import share as _share"},{"line_number":34,"context_line":"from openstack.shared_file_system.v2 import share_export_locations as el"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class Proxy(proxy.Proxy):"}],"source_content_type":"text/x-python","patch_set":10,"id":"86824c06_5aab9884","line":34,"range":{"start_line":34,"start_character":70,"end_line":34,"end_character":72},"updated":"2023-04-03 11:42:53.000000000","message":"nit: Could we call this \u0027_share_export_locations\u0027 to be consistent?","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":31,"context_line":")"},{"line_number":32,"context_line":"from openstack.shared_file_system.v2 import limit as _limit"},{"line_number":33,"context_line":"from openstack.shared_file_system.v2 import share as _share"},{"line_number":34,"context_line":"from openstack.shared_file_system.v2 import share_export_locations as el"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class Proxy(proxy.Proxy):"}],"source_content_type":"text/x-python","patch_set":10,"id":"e6ceb3e8_5e6816f0","line":34,"range":{"start_line":34,"start_character":70,"end_line":34,"end_character":72},"in_reply_to":"86824c06_5aab9884","updated":"2023-04-11 18:12:31.000000000","message":"Made the change.","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4a35ff778a0b6bfd152ec497905a40832487997","unresolved":true,"context_lines":[{"line_number":441,"context_line":"        \"\"\"List all export locations with details"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        :param share_id: The ID of the share to list export locations from"},{"line_number":444,"context_line":"        :returns: Details of export location"},{"line_number":445,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":446,"context_line":"            share_export_locations.ShareExportLocations`"},{"line_number":447,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"ec63d7b2_ba3f3061","line":444,"updated":"2023-04-03 11:42:53.000000000","message":"This returns a list:\n\n  :returns: List of export locations\n  :rtype: List of :class:`~openstack...`","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        \"\"\"List all export locations with details"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        :param share_id: The ID of the share to list export locations from"},{"line_number":444,"context_line":"        :returns: Details of export location"},{"line_number":445,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":446,"context_line":"            share_export_locations.ShareExportLocations`"},{"line_number":447,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"ac538698_a4d69b09","line":444,"in_reply_to":"ec63d7b2_ba3f3061","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":true,"context_lines":[{"line_number":450,"context_line":"    def get_export_location(self, export_location, share_id):"},{"line_number":451,"context_line":"        \"\"\"List details of export location"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        :param share_id: The ID of the share to get export locations from"},{"line_number":454,"context_line":"        :returns: Details of identified export location"},{"line_number":455,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":456,"context_line":"            share_export_locations.ShareExportLocations`"}],"source_content_type":"text/x-python","patch_set":10,"id":"62041b7b_db1eb28a","line":453,"updated":"2023-04-03 11:37:36.000000000","message":"Still missing docs for export_location","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    def get_export_location(self, export_location, share_id):"},{"line_number":451,"context_line":"        \"\"\"List details of export location"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        :param share_id: The ID of the share to get export locations from"},{"line_number":454,"context_line":"        :returns: Details of identified export location"},{"line_number":455,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":456,"context_line":"            share_export_locations.ShareExportLocations`"}],"source_content_type":"text/x-python","patch_set":10,"id":"a0d40c52_3e6c710c","line":453,"in_reply_to":"62041b7b_db1eb28a","updated":"2023-04-11 18:12:31.000000000","message":"Got it added.","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e39e535f442cc7a797446c87d15ffddb05c80884","unresolved":true,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        :param share_id: The ID of the share to list export locations from"},{"line_number":502,"context_line":"        :returns: List of export locations"},{"line_number":503,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":504,"context_line":"            share_export_locations.ShareExportLocations`"},{"line_number":505,"context_line":"        \"\"\""},{"line_number":506,"context_line":"        return self._list(_share_export_locations.ShareExportLocation,"}],"source_content_type":"text/x-python","patch_set":11,"id":"8cbc7066_15cd3e3b","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":16},"updated":"2023-04-08 00:40:57.000000000","message":"List of :class:","commit_id":"c9c4e7c2a5cce5ede7f566285faa59f75e12812f"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        :param share_id: The ID of the share to list export locations from"},{"line_number":502,"context_line":"        :returns: List of export locations"},{"line_number":503,"context_line":"        :rtype: :class:`~openstack.shared_filesystem_storage.v2."},{"line_number":504,"context_line":"            share_export_locations.ShareExportLocations`"},{"line_number":505,"context_line":"        \"\"\""},{"line_number":506,"context_line":"        return self._list(_share_export_locations.ShareExportLocation,"}],"source_content_type":"text/x-python","patch_set":11,"id":"6e41dd72_e8408fb6","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":16},"in_reply_to":"8cbc7066_15cd3e3b","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"c9c4e7c2a5cce5ede7f566285faa59f75e12812f"}],"openstack/shared_file_system/v2/share_export_locations.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cf26fc93db205164b6ec8069fb6290ce0151722","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    share_id \u003d resource.URI(\"share_id\", type\u003d\u0027str\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    #: The ID of the export location."},{"line_number":35,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":36,"context_line":"    #: The path of the export location."},{"line_number":37,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":38,"context_line":"    #: Indicate if export location is preferred."}],"source_content_type":"text/x-python","patch_set":5,"id":"cc2924ff_5bfa2684","line":35,"updated":"2021-05-12 14:41:36.000000000","message":"You don\u0027t need to provide these. They\u0027re provided as standard on the base resource","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    share_id \u003d resource.URI(\"share_id\", type\u003d\u0027str\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    #: The ID of the export location."},{"line_number":35,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":36,"context_line":"    #: The path of the export location."},{"line_number":37,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":38,"context_line":"    #: Indicate if export location is preferred."}],"source_content_type":"text/x-python","patch_set":5,"id":"588f57a8_de2a1392","line":35,"in_reply_to":"cc2924ff_5bfa2684","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    share_id \u003d resource.URI(\"share_id\", type\u003d\u0027str\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    #: The ID of the export location."},{"line_number":35,"context_line":"    id \u003d resource.Body(\"id\", type\u003dstr)"},{"line_number":36,"context_line":"    #: The path of the export location."},{"line_number":37,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":38,"context_line":"    #: Indicate if export location is preferred."}],"source_content_type":"text/x-python","patch_set":5,"id":"62978683_f27a87e5","line":35,"in_reply_to":"cc2924ff_5bfa2684","updated":"2023-04-03 11:37:36.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fa2abe7fda5038cd8d3d9e602f18e34e53f1f507","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    #: The path of the export location."},{"line_number":37,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":38,"context_line":"    #: Indicate if export location is preferred."},{"line_number":39,"context_line":"    preferred \u003d resource.Body(\"preferred\", type\u003dbool)"},{"line_number":40,"context_line":"    #: The share instance ID of the export location."},{"line_number":41,"context_line":"    share_instance_id \u003d resource.Body(\"share_instance_id\", type\u003dstr)"},{"line_number":42,"context_line":"    #: Indicate if export location is admin only."}],"source_content_type":"text/x-python","patch_set":5,"id":"54c93812_3d4ac849","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":13},"updated":"2021-03-25 23:44:06.000000000","message":"the convention in the sdk is to use \"is_\" for boolean parameters like this one. \n\n\"is_preferred\"","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    #: The path of the export location."},{"line_number":37,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":38,"context_line":"    #: Indicate if export location is preferred."},{"line_number":39,"context_line":"    preferred \u003d resource.Body(\"preferred\", type\u003dbool)"},{"line_number":40,"context_line":"    #: The share instance ID of the export location."},{"line_number":41,"context_line":"    share_instance_id \u003d resource.Body(\"share_instance_id\", type\u003dstr)"},{"line_number":42,"context_line":"    #: Indicate if export location is admin only."}],"source_content_type":"text/x-python","patch_set":5,"id":"ae9c2afe_1f21dd0a","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":13},"in_reply_to":"54c93812_3d4ac849","updated":"2023-04-03 11:37:36.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    #: The path of the export location."},{"line_number":37,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":38,"context_line":"    #: Indicate if export location is preferred."},{"line_number":39,"context_line":"    preferred \u003d resource.Body(\"preferred\", type\u003dbool)"},{"line_number":40,"context_line":"    #: The share instance ID of the export location."},{"line_number":41,"context_line":"    share_instance_id \u003d resource.Body(\"share_instance_id\", type\u003dstr)"},{"line_number":42,"context_line":"    #: Indicate if export location is admin only."}],"source_content_type":"text/x-python","patch_set":5,"id":"95b59d99_31da4535","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":13},"in_reply_to":"54c93812_3d4ac849","updated":"2023-04-11 18:12:31.000000000","message":"Got that changed. Thanks for the info.","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4a35ff778a0b6bfd152ec497905a40832487997","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    #: The path of the export location."},{"line_number":34,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":35,"context_line":"    #: Indicate if export location is preferred."},{"line_number":36,"context_line":"    is_preferred \u003d resource.Body(\"is_preferred\", type\u003dbool)"},{"line_number":37,"context_line":"    #: The share instance ID of the export location."},{"line_number":38,"context_line":"    share_instance_id \u003d resource.Body(\"share_instance_id\", type\u003dstr)"},{"line_number":39,"context_line":"    #: Indicate if export location is admin only."}],"source_content_type":"text/x-python","patch_set":10,"id":"d135e87c_b1c775d5","line":36,"range":{"start_line":36,"start_character":34,"end_line":36,"end_character":46},"updated":"2023-04-03 11:42:53.000000000","message":"The actual field in the body is called \u0027preferred\u0027, right? So this should read:\n\n  is_preferred \u003d resource.Body(\"preferred\", type\u003dbool)\n\nJust so you know, in this example:\n\n  foo \u003d resource.Body(\"bar\", type\u003dbool)\n\n\u0027foo\u0027 is the value that openstacksdk will use. \u0027bar\u0027 is the value openstacksdk will use to build a request and/or pull a value from responses (i.e. the value Manila will use)","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    #: The path of the export location."},{"line_number":34,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":35,"context_line":"    #: Indicate if export location is preferred."},{"line_number":36,"context_line":"    is_preferred \u003d resource.Body(\"is_preferred\", type\u003dbool)"},{"line_number":37,"context_line":"    #: The share instance ID of the export location."},{"line_number":38,"context_line":"    share_instance_id \u003d resource.Body(\"share_instance_id\", type\u003dstr)"},{"line_number":39,"context_line":"    #: Indicate if export location is admin only."}],"source_content_type":"text/x-python","patch_set":10,"id":"ec57ecf1_8fd4998a","line":36,"range":{"start_line":36,"start_character":34,"end_line":36,"end_character":46},"in_reply_to":"0c64a518_f79ab2b2","updated":"2023-04-11 18:12:31.000000000","message":"Thanks, this confused me at first.","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f4f5643c1595354b3d43963e06a6789fe2365cc","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    #: The path of the export location."},{"line_number":34,"context_line":"    path \u003d resource.Body(\"path\", type\u003dstr)"},{"line_number":35,"context_line":"    #: Indicate if export location is preferred."},{"line_number":36,"context_line":"    is_preferred \u003d resource.Body(\"is_preferred\", type\u003dbool)"},{"line_number":37,"context_line":"    #: The share instance ID of the export location."},{"line_number":38,"context_line":"    share_instance_id \u003d resource.Body(\"share_instance_id\", type\u003dstr)"},{"line_number":39,"context_line":"    #: Indicate if export location is admin only."}],"source_content_type":"text/x-python","patch_set":10,"id":"0c64a518_f79ab2b2","line":36,"range":{"start_line":36,"start_character":34,"end_line":36,"end_character":46},"in_reply_to":"d135e87c_b1c775d5","updated":"2023-04-03 20:44:12.000000000","message":"++ Good catch and thanks Stephen!","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"}],"openstack/tests/functional/shared_file_system/test_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fa2abe7fda5038cd8d3d9e602f18e34e53f1f507","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class TestExportLocation(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    min_microversion \u003d \u00272.58\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_export_locations(self):"},{"line_number":21,"context_line":"        exs \u003d self.conn.shared_file_system.export_locations()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1e668e54_fc8cdbc1","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":28},"updated":"2021-03-25 23:44:06.000000000","message":"2.14 perhaps?\n\nper the SFS API Ref you could set this to 2.9: https://docs.openstack.org/api-ref/shared-file-system/?expanded\u003dlist-export-locations-detail#share-export-locations-since-api-v2-9\n\nbut the \"preferred\" key is only present in 2.14+","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class TestExportLocation(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    min_microversion \u003d \u00272.58\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_export_locations(self):"},{"line_number":21,"context_line":"        exs \u003d self.conn.shared_file_system.export_locations()"}],"source_content_type":"text/x-python","patch_set":5,"id":"c70cd21a_af0379df","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":28},"in_reply_to":"1e668e54_fc8cdbc1","updated":"2023-04-03 11:37:36.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class TestExportLocation(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    min_microversion \u003d \u00272.58\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_export_locations(self):"},{"line_number":21,"context_line":"        exs \u003d self.conn.shared_file_system.export_locations()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea917235_8ed56ebf","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":28},"in_reply_to":"1e668e54_fc8cdbc1","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fa2abe7fda5038cd8d3d9e602f18e34e53f1f507","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    min_microversion \u003d \u00272.58\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_export_locations(self):"},{"line_number":21,"context_line":"        exs \u003d self.conn.shared_file_system.export_locations()"},{"line_number":22,"context_line":"        self.assertGreater(len(list(exs)), 0)"},{"line_number":23,"context_line":"        for ex in exs:"},{"line_number":24,"context_line":"            for attribute in ("}],"source_content_type":"text/x-python","patch_set":5,"id":"f2619740_5c1aa8d8","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":61},"updated":"2021-03-25 23:44:06.000000000","message":"this method call requires a share_id, so you\u0027ll need to create a share prior to this call. \n\nThis code can depend on Ashley\u0027s \"share\" resource change and reuse the create_share method: https://review.opendev.org/c/openstack/openstacksdk/+/775707/9/openstack/tests/functional/shared_file_system/base.py","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    min_microversion \u003d \u00272.58\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_export_locations(self):"},{"line_number":21,"context_line":"        exs \u003d self.conn.shared_file_system.export_locations()"},{"line_number":22,"context_line":"        self.assertGreater(len(list(exs)), 0)"},{"line_number":23,"context_line":"        for ex in exs:"},{"line_number":24,"context_line":"            for attribute in ("}],"source_content_type":"text/x-python","patch_set":5,"id":"404d021e_82231dbc","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":61},"in_reply_to":"f2619740_5c1aa8d8","updated":"2023-04-03 11:37:36.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    min_microversion \u003d \u00272.58\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_export_locations(self):"},{"line_number":21,"context_line":"        exs \u003d self.conn.shared_file_system.export_locations()"},{"line_number":22,"context_line":"        self.assertGreater(len(list(exs)), 0)"},{"line_number":23,"context_line":"        for ex in exs:"},{"line_number":24,"context_line":"            for attribute in ("}],"source_content_type":"text/x-python","patch_set":5,"id":"6bdab4fc_b1ded0b2","line":21,"range":{"start_line":21,"start_character":14,"end_line":21,"end_character":61},"in_reply_to":"f2619740_5c1aa8d8","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4a35ff778a0b6bfd152ec497905a40832487997","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    min_microversion \u003d \u00272.9\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def setUp(self):"},{"line_number":21,"context_line":"        super(TestExportLocation, self).setUp()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        self.SHARE_NAME \u003d self.getUniqueString()"},{"line_number":24,"context_line":"        my_share \u003d self.create_share("}],"source_content_type":"text/x-python","patch_set":10,"id":"3a6d0df9_c47ec73a","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":38},"updated":"2023-04-03 11:42:53.000000000","message":"nit: don\u0027t need these in Python 3. You can simply do\n\n  super().setUp()","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    min_microversion \u003d \u00272.9\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def setUp(self):"},{"line_number":21,"context_line":"        super(TestExportLocation, self).setUp()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        self.SHARE_NAME \u003d self.getUniqueString()"},{"line_number":24,"context_line":"        my_share \u003d self.create_share("}],"source_content_type":"text/x-python","patch_set":10,"id":"4d1bfbfb_44deb14c","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":38},"in_reply_to":"3a6d0df9_c47ec73a","updated":"2023-04-11 18:12:31.000000000","message":"Cool, did not know that.","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f4f5643c1595354b3d43963e06a6789fe2365cc","unresolved":true,"context_lines":[{"line_number":37,"context_line":"                    \u0027updated_at\u0027, \u0027created_at\u0027):"},{"line_number":38,"context_line":"                self.assertTrue(hasattr(ex, attribute))"},{"line_number":39,"context_line":"                self.assertIsInstance(getattr(ex, attribute), \u0027str\u0027)"},{"line_number":40,"context_line":"            for attribute in (\u0027preferred\u0027, \u0027is_admin_only\u0027):"},{"line_number":41,"context_line":"                self.assertTrue(hasattr(ex, attribute))"},{"line_number":42,"context_line":"                self.assertIsInstance(getattr(ex, attribute), \u0027bool\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f884540_af1b7a43","line":40,"range":{"start_line":40,"start_character":44,"end_line":40,"end_character":57},"updated":"2023-04-03 20:44:12.000000000","message":"is_admin\n\nWe\u0027re transforming the names the API is giving us in the SDK resource for consistency; so we should assert with the transformed names..","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f4f5643c1595354b3d43963e06a6789fe2365cc","unresolved":true,"context_lines":[{"line_number":37,"context_line":"                    \u0027updated_at\u0027, \u0027created_at\u0027):"},{"line_number":38,"context_line":"                self.assertTrue(hasattr(ex, attribute))"},{"line_number":39,"context_line":"                self.assertIsInstance(getattr(ex, attribute), \u0027str\u0027)"},{"line_number":40,"context_line":"            for attribute in (\u0027preferred\u0027, \u0027is_admin_only\u0027):"},{"line_number":41,"context_line":"                self.assertTrue(hasattr(ex, attribute))"},{"line_number":42,"context_line":"                self.assertIsInstance(getattr(ex, attribute), \u0027bool\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b5330682_2215d04c","line":40,"range":{"start_line":40,"start_character":31,"end_line":40,"end_character":40},"updated":"2023-04-03 20:44:12.000000000","message":"is_preferred","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                    \u0027updated_at\u0027, \u0027created_at\u0027):"},{"line_number":38,"context_line":"                self.assertTrue(hasattr(ex, attribute))"},{"line_number":39,"context_line":"                self.assertIsInstance(getattr(ex, attribute), \u0027str\u0027)"},{"line_number":40,"context_line":"            for attribute in (\u0027preferred\u0027, \u0027is_admin_only\u0027):"},{"line_number":41,"context_line":"                self.assertTrue(hasattr(ex, attribute))"},{"line_number":42,"context_line":"                self.assertIsInstance(getattr(ex, attribute), \u0027bool\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"131783d5_3e954aaf","line":40,"range":{"start_line":40,"start_character":44,"end_line":40,"end_character":57},"in_reply_to":"9f884540_af1b7a43","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                    \u0027updated_at\u0027, \u0027created_at\u0027):"},{"line_number":38,"context_line":"                self.assertTrue(hasattr(ex, attribute))"},{"line_number":39,"context_line":"                self.assertIsInstance(getattr(ex, attribute), \u0027str\u0027)"},{"line_number":40,"context_line":"            for attribute in (\u0027preferred\u0027, \u0027is_admin_only\u0027):"},{"line_number":41,"context_line":"                self.assertTrue(hasattr(ex, attribute))"},{"line_number":42,"context_line":"                self.assertIsInstance(getattr(ex, attribute), \u0027bool\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"6eb4a450_f24b7fb3","line":40,"range":{"start_line":40,"start_character":31,"end_line":40,"end_character":40},"in_reply_to":"b5330682_2215d04c","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"}],"openstack/tests/unit/cloud/test_shared_file_system.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cf26fc93db205164b6ec8069fb6290ce0151722","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    \"id\": IDENTIFIER,"},{"line_number":19,"context_line":"    \"name\": \"manila-zone-0\","},{"line_number":20,"context_line":"    \"created_at\": \"2021-01-21T20:13:55.000000\","},{"line_number":21,"context_line":"    \"updated_at\": None"},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"6c97c136_f8e6a8da","line":21,"updated":"2021-05-12 14:41:36.000000000","message":"nit: this is unrelated and unnecessary","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4a35ff778a0b6bfd152ec497905a40832487997","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    \"id\": IDENTIFIER,"},{"line_number":19,"context_line":"    \"name\": \"manila-zone-0\","},{"line_number":20,"context_line":"    \"created_at\": \"2021-01-21T20:13:55.000000\","},{"line_number":21,"context_line":"    \"updated_at\": None"},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"503f2d85_fb4d86d5","line":21,"in_reply_to":"6c97c136_f8e6a8da","updated":"2023-04-03 11:42:53.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    \"id\": IDENTIFIER,"},{"line_number":19,"context_line":"    \"name\": \"manila-zone-0\","},{"line_number":20,"context_line":"    \"created_at\": \"2021-01-21T20:13:55.000000\","},{"line_number":21,"context_line":"    \"updated_at\": None"},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e5868ef7_481b7f8a","line":21,"in_reply_to":"6c97c136_f8e6a8da","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f4f5643c1595354b3d43963e06a6789fe2365cc","unresolved":true,"context_lines":[{"line_number":19,"context_line":"MANILA_AZ_DICT \u003d {"},{"line_number":20,"context_line":"    \"id\": IDENTIFIER,"},{"line_number":21,"context_line":"    \"name\": \"manila-zone-0\","},{"line_number":22,"context_line":"    \"created_at\": \"2021-01-21T20:13:55.000000\""},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"4a54e702_d20ec013","line":22,"updated":"2023-04-03 20:44:12.000000000","message":"This change is unrelated/unnecessary as pointed out in prior reviews (https://review.opendev.org/c/openstack/openstacksdk/+/780990/comments/6c97c136_f8e6a8da)","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"MANILA_AZ_DICT \u003d {"},{"line_number":20,"context_line":"    \"id\": IDENTIFIER,"},{"line_number":21,"context_line":"    \"name\": \"manila-zone-0\","},{"line_number":22,"context_line":"    \"created_at\": \"2021-01-21T20:13:55.000000\""},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5c4cd9e2_0c993c45","line":22,"in_reply_to":"4a54e702_d20ec013","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e39e535f442cc7a797446c87d15ffddb05c80884","unresolved":true,"context_lines":[{"line_number":19,"context_line":"MANILA_AZ_DICT \u003d {"},{"line_number":20,"context_line":"    \"id\": IDENTIFIER,"},{"line_number":21,"context_line":"    \"name\": \"manila-zone-0\","},{"line_number":22,"context_line":"    \"created_at\": \"2021-01-21T20:13:55.000000\","},{"line_number":23,"context_line":"    \"updated_at\": None,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestSharedFileSystem(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"8c24d388_9df8a1cb","side":"PARENT","line":24,"range":{"start_line":22,"start_character":47,"end_line":24,"end_character":1},"updated":"2023-04-08 00:40:57.000000000","message":"these changes are irrelavent to your patch... Here\u0027s how you can undo all changes and reset this file to its state in the master branch:\n\n  git checkout origin/master openstack/tests/unit/cloud/test_shared_file_system.","commit_id":"81f86089527ef43020a425d5f535ddd5564cdb34"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"MANILA_AZ_DICT \u003d {"},{"line_number":20,"context_line":"    \"id\": IDENTIFIER,"},{"line_number":21,"context_line":"    \"name\": \"manila-zone-0\","},{"line_number":22,"context_line":"    \"created_at\": \"2021-01-21T20:13:55.000000\","},{"line_number":23,"context_line":"    \"updated_at\": None,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestSharedFileSystem(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"6cc3b40a_8e5c516b","side":"PARENT","line":24,"range":{"start_line":22,"start_character":47,"end_line":24,"end_character":1},"in_reply_to":"8c24d388_9df8a1cb","updated":"2023-04-11 18:12:31.000000000","message":"Thanks, got it changed","commit_id":"81f86089527ef43020a425d5f535ddd5564cdb34"}],"openstack/tests/unit/shared_file_system/v2/test_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cf26fc93db205164b6ec8069fb6290ce0151722","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                     append\u003d[\u0027v2\u0027, \"shares\", SHARE_ID, \u0027export_locations\u0027]),"},{"line_number":45,"context_line":"                 json\u003d{\u0027export_locations\u0027: [EXID_DICT]}),"},{"line_number":46,"context_line":"        ])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        exports \u003d list(self.share_proxy.export_locations(SHARE_ID))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertEqual(len(exports), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ddb9d98_807f0672","line":47,"updated":"2021-05-12 14:41:36.000000000","message":"Per [1], you shouldn\u0027t need to do this kind of testing here. Do it in the tests for the individual resource if anywhere\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/775707/10/openstack/tests/unit/shared_file_system/v2/test_proxy.py#61","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     append\u003d[\u0027v2\u0027, \"shares\", SHARE_ID, \u0027export_locations\u0027]),"},{"line_number":45,"context_line":"                 json\u003d{\u0027export_locations\u0027: [EXID_DICT]}),"},{"line_number":46,"context_line":"        ])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        exports \u003d list(self.share_proxy.export_locations(SHARE_ID))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertEqual(len(exports), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"73dca816_ae5549b7","line":47,"in_reply_to":"7ddb9d98_807f0672","updated":"2023-04-03 11:37:36.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     append\u003d[\u0027v2\u0027, \"shares\", SHARE_ID, \u0027export_locations\u0027]),"},{"line_number":45,"context_line":"                 json\u003d{\u0027export_locations\u0027: [EXID_DICT]}),"},{"line_number":46,"context_line":"        ])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        exports \u003d list(self.share_proxy.export_locations(SHARE_ID))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertEqual(len(exports), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bbd28402_b534afae","line":47,"in_reply_to":"7ddb9d98_807f0672","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"}],"openstack/tests/unit/shared_file_system/v2/test_share_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f4f5643c1595354b3d43963e06a6789fe2365cc","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    \"id\": \"f87589cb-f4bc-4a9b-b481-ab701206eb85\","},{"line_number":20,"context_line":"    \"path\": (\"199.19.213.225:/opt/stack/data/manila/mnt/\""},{"line_number":21,"context_line":"             \"share-6ba490c5-5225-4c3b-9982-14b8f475c6d9\"),"},{"line_number":22,"context_line":"    \"is_preferred\": False,"},{"line_number":23,"context_line":"    \"share_instance_id\": \"6ba490c5-5225-4c3b-9982-14b8f475c6d9\","},{"line_number":24,"context_line":"    \"is_admin_only\": False"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":10,"id":"90c2a61a_0b344bda","line":22,"range":{"start_line":22,"start_character":5,"end_line":22,"end_character":17},"updated":"2023-04-03 20:44:12.000000000","message":"\"preferred\"","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \"id\": \"f87589cb-f4bc-4a9b-b481-ab701206eb85\","},{"line_number":20,"context_line":"    \"path\": (\"199.19.213.225:/opt/stack/data/manila/mnt/\""},{"line_number":21,"context_line":"             \"share-6ba490c5-5225-4c3b-9982-14b8f475c6d9\"),"},{"line_number":22,"context_line":"    \"is_preferred\": False,"},{"line_number":23,"context_line":"    \"share_instance_id\": \"6ba490c5-5225-4c3b-9982-14b8f475c6d9\","},{"line_number":24,"context_line":"    \"is_admin_only\": False"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":10,"id":"e420f45c_10eedbca","line":22,"range":{"start_line":22,"start_character":5,"end_line":22,"end_character":17},"in_reply_to":"90c2a61a_0b344bda","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f4f5643c1595354b3d43963e06a6789fe2365cc","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        export \u003d el.ShareExportLocation(**EXAMPLE)"},{"line_number":39,"context_line":"        self.assertEqual(EXAMPLE[\u0027id\u0027], export.id)"},{"line_number":40,"context_line":"        self.assertEqual(EXAMPLE[\u0027path\u0027], export.path)"},{"line_number":41,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_preferred\u0027], export.is_preferred)"},{"line_number":42,"context_line":"        self.assertEqual("},{"line_number":43,"context_line":"            EXAMPLE[\u0027share_instance_id\u0027], export.share_instance_id)"},{"line_number":44,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_admin_only\u0027], export.is_admin)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b3527438_c2087c01","line":41,"range":{"start_line":41,"start_character":34,"end_line":41,"end_character":46},"updated":"2023-04-03 20:44:12.000000000","message":"preferred","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        export \u003d el.ShareExportLocation(**EXAMPLE)"},{"line_number":39,"context_line":"        self.assertEqual(EXAMPLE[\u0027id\u0027], export.id)"},{"line_number":40,"context_line":"        self.assertEqual(EXAMPLE[\u0027path\u0027], export.path)"},{"line_number":41,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_preferred\u0027], export.is_preferred)"},{"line_number":42,"context_line":"        self.assertEqual("},{"line_number":43,"context_line":"            EXAMPLE[\u0027share_instance_id\u0027], export.share_instance_id)"},{"line_number":44,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_admin_only\u0027], export.is_admin)"}],"source_content_type":"text/x-python","patch_set":10,"id":"16592afc_bf97e11b","line":41,"range":{"start_line":41,"start_character":34,"end_line":41,"end_character":46},"in_reply_to":"b3527438_c2087c01","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"481ba9990f7963a3096a5bed0f15ea99526d5c44"}],"releasenotes/notes/add-shared-file-systems-export-location-a27c1741880c384b.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fa2abe7fda5038cd8d3d9e602f18e34e53f1f507","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to list and show Export Locations"},{"line_number":5,"context_line":"    for Shared File System Service APIs"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d6de3228_0ca9146d","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":39},"updated":"2021-03-25 23:44:06.000000000","message":"shares from the Shared File Systems service.","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to list and show Export Locations"},{"line_number":5,"context_line":"    for Shared File System Service APIs"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d9f44f19_06bd9b0f","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":39},"in_reply_to":"d6de3228_0ca9146d","updated":"2023-04-11 18:12:31.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to list and show Export Locations"},{"line_number":5,"context_line":"    for Shared File System Service APIs"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f08af644_aa802cf8","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":39},"in_reply_to":"d6de3228_0ca9146d","updated":"2023-04-03 11:37:36.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9cf26fc93db205164b6ec8069fb6290ce0151722","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to list and show Export Locations"},{"line_number":5,"context_line":"    for Shared File System Service APIs"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a0bf49c9_3b0fd988","line":6,"updated":"2021-05-12 14:41:36.000000000","message":"nit: unnecessary extra newline","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2df6b3b1cda4e18dee46ceaa71eeed8ab485678","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to list and show Export Locations"},{"line_number":5,"context_line":"    for Shared File System Service APIs"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fd9e86cd_37b16aa7","line":6,"in_reply_to":"a0bf49c9_3b0fd988","updated":"2023-04-03 11:37:36.000000000","message":"Done","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"c7b34be3e3cb341b4f904230a93f208428edbd8a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to list and show Export Locations"},{"line_number":5,"context_line":"    for Shared File System Service APIs"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"67252b6d_23dba396","line":6,"in_reply_to":"a0bf49c9_3b0fd988","updated":"2023-04-11 18:12:31.000000000","message":"Good catch","commit_id":"8e24ed579820b2d361f2314866f6bf91a7b16399"}]}