)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4e00439fda49ed3cb0f3bf604d63f0d95cf76b6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e7a3d3e4_30361619","updated":"2022-07-15 16:00:22.000000000","message":"introduces unstable tests","commit_id":"bdbda6eb4c3ea2003dc214e779c014dbc2eecd73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d4754c2d62f2a012e93bc71fa2edae7a6c70e78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7255a93d_273ec528","updated":"2022-07-15 16:33:08.000000000","message":"Good spot","commit_id":"71a8466f0ff1042367967336665a9d276679bb66"}],"openstack/block_storage/v3/_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"274cf3ac767bbe6f0b69c49ae62926e2b8ae917f","unresolved":true,"context_lines":[{"line_number":1009,"context_line":"    def groups(self, details\u003dTrue, **query):"},{"line_number":1010,"context_line":"        \"\"\"Retrieve a generator of groups"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"        :param bool details: When set to ``\u0027False``, no additional details will"},{"line_number":1013,"context_line":"            be returned. The default, ``True``, will cause additional details"},{"line_number":1014,"context_line":"            to be returned."},{"line_number":1015,"context_line":"        :param dict query: Optional query parameters to be sent to limit the"}],"source_content_type":"text/x-python","patch_set":6,"id":"b88785f5_ad2d43cd","line":1012,"updated":"2022-07-01 14:38:36.000000000","message":"too many quotes around `False`","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f31f92989555d4e48843f51645193769ae4b3cb","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"    def groups(self, details\u003dTrue, **query):"},{"line_number":1010,"context_line":"        \"\"\"Retrieve a generator of groups"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"        :param bool details: When set to ``\u0027False``, no additional details will"},{"line_number":1013,"context_line":"            be returned. The default, ``True``, will cause additional details"},{"line_number":1014,"context_line":"            to be returned."},{"line_number":1015,"context_line":"        :param dict query: Optional query parameters to be sent to limit the"}],"source_content_type":"text/x-python","patch_set":6,"id":"879fb9a1_a590a5c5","line":1012,"in_reply_to":"b88785f5_ad2d43cd","updated":"2022-07-07 17:25:58.000000000","message":"Done","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"274cf3ac767bbe6f0b69c49ae62926e2b8ae917f","unresolved":true,"context_lines":[{"line_number":1053,"context_line":"        :returns: The results of group creation."},{"line_number":1054,"context_line":"        :rtype: :class:`~openstack.block_storage.v3.group.Group`."},{"line_number":1055,"context_line":"        \"\"\""},{"line_number":1056,"context_line":"        return _group.Group.create_group_grom_source(self, **attrs)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    def reset_group_state(self, group, status):"},{"line_number":1059,"context_line":"        \"\"\"Reset group status"}],"source_content_type":"text/x-python","patch_set":6,"id":"1c18ed31_3d084229","line":1056,"updated":"2022-07-01 14:38:36.000000000","message":"typo in the called function name. Fact that tests did not failed reveals that there are no tests for the new functions.","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f31f92989555d4e48843f51645193769ae4b3cb","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"        :returns: The results of group creation."},{"line_number":1054,"context_line":"        :rtype: :class:`~openstack.block_storage.v3.group.Group`."},{"line_number":1055,"context_line":"        \"\"\""},{"line_number":1056,"context_line":"        return _group.Group.create_group_grom_source(self, **attrs)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    def reset_group_state(self, group, status):"},{"line_number":1059,"context_line":"        \"\"\"Reset group status"}],"source_content_type":"text/x-python","patch_set":6,"id":"e1aa23a7_4702d5fd","line":1056,"in_reply_to":"1c18ed31_3d084229","updated":"2022-07-07 17:25:58.000000000","message":"Done","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"}],"openstack/block_storage/v3/group.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"274cf3ac767bbe6f0b69c49ae62926e2b8ae917f","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def create_group_from_source("},{"line_number":64,"context_line":"            self, session, name, group_snapshot_id, source_group_id,"},{"line_number":65,"context_line":"            description):"},{"line_number":66,"context_line":"        \"\"\"Creates a new group from source.\"\"\""},{"line_number":67,"context_line":"        body \u003d {"},{"line_number":68,"context_line":"            \u0027create-from-src\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"9d904ccd_694d7bf2","line":65,"updated":"2022-07-01 14:38:36.000000000","message":"can you please place closing bracket to the new line, it breaks visual reading of the code.","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f31f92989555d4e48843f51645193769ae4b3cb","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def create_group_from_source("},{"line_number":64,"context_line":"            self, session, name, group_snapshot_id, source_group_id,"},{"line_number":65,"context_line":"            description):"},{"line_number":66,"context_line":"        \"\"\"Creates a new group from source.\"\"\""},{"line_number":67,"context_line":"        body \u003d {"},{"line_number":68,"context_line":"            \u0027create-from-src\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"6be6c085_609b1b78","line":65,"in_reply_to":"9d904ccd_694d7bf2","updated":"2022-07-07 17:25:58.000000000","message":"Done","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"274cf3ac767bbe6f0b69c49ae62926e2b8ae917f","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            }"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"        url \u003d utils.urljoin(self.base_path, \u0027action\u0027)"},{"line_number":75,"context_line":"        response \u003d session.post(url, json\u003dbody, microversion\u003d\u00273.38\u0027)"},{"line_number":76,"context_line":"        exceptions.raise_from_respone(response)"},{"line_number":77,"context_line":"        group \u003d Group()"},{"line_number":78,"context_line":"        group._translate_response(response\u003dresponse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"be38dffc_593034c0","line":75,"updated":"2022-07-01 14:38:36.000000000","message":"you should not hardcode also here the microversion. Use whichever is set as class attribute","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f31f92989555d4e48843f51645193769ae4b3cb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            }"},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"        url \u003d utils.urljoin(self.base_path, \u0027action\u0027)"},{"line_number":75,"context_line":"        response \u003d session.post(url, json\u003dbody, microversion\u003d\u00273.38\u0027)"},{"line_number":76,"context_line":"        exceptions.raise_from_respone(response)"},{"line_number":77,"context_line":"        group \u003d Group()"},{"line_number":78,"context_line":"        group._translate_response(response\u003dresponse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7451ec25_259d3fe6","line":75,"in_reply_to":"be38dffc_593034c0","updated":"2022-07-07 17:25:58.000000000","message":"Done","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"274cf3ac767bbe6f0b69c49ae62926e2b8ae917f","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        url \u003d utils.urljoin(self.base_path, \u0027action\u0027)"},{"line_number":75,"context_line":"        response \u003d session.post(url, json\u003dbody, microversion\u003d\u00273.38\u0027)"},{"line_number":76,"context_line":"        exceptions.raise_from_respone(response)"},{"line_number":77,"context_line":"        group \u003d Group()"},{"line_number":78,"context_line":"        group._translate_response(response\u003dresponse)"},{"line_number":79,"context_line":"        return group"}],"source_content_type":"text/x-python","patch_set":6,"id":"7afecb27_37bfa6e9","line":77,"updated":"2022-07-01 14:38:36.000000000","message":"object creation function may be actually created as classmethod. Anyway such invocation looks really weird. Once you have already object instance that you invoke you should rather update self with results instead of returning brand new object","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f31f92989555d4e48843f51645193769ae4b3cb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        url \u003d utils.urljoin(self.base_path, \u0027action\u0027)"},{"line_number":75,"context_line":"        response \u003d session.post(url, json\u003dbody, microversion\u003d\u00273.38\u0027)"},{"line_number":76,"context_line":"        exceptions.raise_from_respone(response)"},{"line_number":77,"context_line":"        group \u003d Group()"},{"line_number":78,"context_line":"        group._translate_response(response\u003dresponse)"},{"line_number":79,"context_line":"        return group"}],"source_content_type":"text/x-python","patch_set":6,"id":"c5d1aa5c_e96025ce","line":77,"in_reply_to":"7afecb27_37bfa6e9","updated":"2022-07-07 17:25:58.000000000","message":"Done. I made this a classmethod.","commit_id":"56231eb48aa4f54806fe0b75e3cae78a8ea5058f"}]}