)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74fd2cade809f5b8912e6ae6024b714f52e0fa96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f82d592c_511faa90","updated":"2023-02-28 20:12:55.000000000","message":"recheck","commit_id":"e49e377c491182d94e93f828cdb20be2c28c8404"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"80e402240529a8b30de067b6aefd2ca93d1b90ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8dcb7e48_55d26af5","updated":"2023-03-01 05:40:50.000000000","message":"Hi, \n\nWe\u0027ve merged this in feature/r1 and am cherry-picking it to master. Made a minor modification in the proxy to include the resource in the proxy\u0027s _resource_registry\n\nCould you please review/help merge this?\n\nThanks!","commit_id":"1e2042a299ac5086b2e99a3ec80706ef89407a2e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6cb486fbd9f7772565bdccbc88aa7c7b687cd20d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3176403_952afed4","updated":"2023-03-03 21:42:04.000000000","message":"recheck\n\nopenstacksdk-functional-devstack-networking timed out","commit_id":"1e2042a299ac5086b2e99a3ec80706ef89407a2e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5e1e532b4cd50a6600f3a589624c04c077829d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7dc04336_36a7653d","updated":"2023-03-07 20:21:47.000000000","message":"recheck\n\nOctavia SDK fix has now merged","commit_id":"fcd2315d3a1d63f771ff6ed927ec25b82493f90b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6ef573e9_ae323d5a","updated":"2023-03-22 04:31:27.000000000","message":"Hi Sam, \n\nI\u0027ve added a few more comments inline, please take a look. Thanks!","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"20417b8b4b196c29964c2a710654642c16eb5e82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"01bc4d42_02983377","updated":"2023-03-22 03:23:46.000000000","message":"Sam, could you please rebase this change on master?","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eeb23fd6fcb22e545d2ad089f530544e5e21250f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6e0b7669_7f722f42","updated":"2023-04-10 21:28:07.000000000","message":"Thanks Sam; please see a comment/question inline..","commit_id":"5c9ff645d1ae4013f82584bb49b3128c3bfaf8ee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"384f76f6666d1ceb8144b756f06e516e6cb7f3aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8093c0a1_b997df41","updated":"2023-04-17 22:20:21.000000000","message":"Perfect, thank you for the updates Sam!","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e4497bb3_54a861b0","updated":"2023-04-18 17:19:55.000000000","message":"Thanks for the comments.","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9709da2c3dd0e79e377b4fa4d5c8de25da35ff23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0bcf65ed_2cf6d531","updated":"2023-04-23 03:45:17.000000000","message":"Thanks for cleaning things up after the rebase; LGTM!","commit_id":"f9b15342fb579457154066742290387f09fa1322"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"8d7719096db55a4861a323cf3bf6e2a326710ceb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1291f9f3_337d2478","updated":"2023-04-24 02:43:41.000000000","message":"We also ran into an issue with the access rule returned from calling the get/list methods not having a share_id, so potentially add a `share_id` argument to the ShareAccessRule.delete method, instead of using `self.share_id`.\n\nA potentially good way of doing this is using None as a default value to the share_id argument in both the delete proxy and resource methods, whiel defaulting to using self.share_id.","commit_id":"f9b15342fb579457154066742290387f09fa1322"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"26d0c54788e92c5ac96c7ce40495a548c2f08424","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"74ec39fa_54574ec8","in_reply_to":"1291f9f3_337d2478","updated":"2023-04-25 17:49:00.000000000","message":"Done","commit_id":"f9b15342fb579457154066742290387f09fa1322"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"43df3266561ab2ca4d624fc4c7978ef44512b368","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e6fd8b9d_a96d4dae","updated":"2023-04-25 18:14:52.000000000","message":"Thanks for the update, Sam!","commit_id":"56e36607365ac9fd325e92f1a41eeafc2dd7b03d"}],"doc/source/user/proxies/shared_file_system.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":95,"context_line":"Shared File System Share Access Rules"},{"line_number":96,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"View access rules for shares from the Shared File Systems service."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":101,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"06046dff_4c3aace2","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":4},"updated":"2023-03-22 04:31:27.000000000","message":"Create, View and Delete","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Shared File System Share Access Rules"},{"line_number":96,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"View access rules for shares from the Shared File Systems service."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":101,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3af859d6_02dbf60a","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":4},"in_reply_to":"06046dff_4c3aace2","updated":"2023-04-18 17:19:55.000000000","message":"Thanks for finding all these","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":101,"context_line":"  :noindex:"},{"line_number":102,"context_line":"  :members: access_rules, get_access_rule"}],"source_content_type":"text/x-rst","patch_set":8,"id":"f8bccc42_597fa58a","line":102,"updated":"2023-03-22 04:31:27.000000000","message":"you\u0027ve introduced create and delete methods as well","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. autoclass:: openstack.shared_file_system.v2._proxy.Proxy"},{"line_number":101,"context_line":"  :noindex:"},{"line_number":102,"context_line":"  :members: access_rules, get_access_rule"}],"source_content_type":"text/x-rst","patch_set":8,"id":"70723fa5_0adbe877","line":102,"in_reply_to":"f8bccc42_597fa58a","updated":"2023-04-18 17:19:55.000000000","message":"Done","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"}],"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":403,"context_line":"        return self._create(_share_network.ShareNetwork, **attrs)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def access_rules(self, share, **query):"},{"line_number":406,"context_line":"        \"\"\"Lists the share access rules on a share."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        :returns: A generator of the share access rules."},{"line_number":409,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4d42e9_93045738","line":406,"range":{"start_line":406,"start_character":21,"end_line":406,"end_character":26},"updated":"2023-03-22 04:31:27.000000000","message":"nit: just \"Lists the access rules on a share\" would do","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        return self._create(_share_network.ShareNetwork, **attrs)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def access_rules(self, share, **query):"},{"line_number":406,"context_line":"        \"\"\"Lists the share access rules on a share."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        :returns: A generator of the share access rules."},{"line_number":409,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."}],"source_content_type":"text/x-python","patch_set":8,"id":"7d5cb712_a1005c49","line":406,"range":{"start_line":406,"start_character":21,"end_line":406,"end_character":26},"in_reply_to":"1a4d42e9_93045738","updated":"2023-04-18 17:19:55.000000000","message":"I like that better too.","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eeb23fd6fcb22e545d2ad089f530544e5e21250f","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        :param dict attrs: Attributes which will be used to create"},{"line_number":524,"context_line":"            a :class:`~openstack.shared_file_system.v2."},{"line_number":525,"context_line":"            share_access_rules.ShareAccessRules`, comprised of the"},{"line_number":526,"context_line":"            properties on the ShareAccessRules class. \u0027size\u0027 and \u0027share\u0027"},{"line_number":527,"context_line":"            are required to create a share."},{"line_number":528,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":529,"context_line":"            share_access_rules.ShareAccessRules`"},{"line_number":530,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"7e750e1b_06bd05b6","line":527,"range":{"start_line":526,"start_character":54,"end_line":527,"end_character":43},"updated":"2023-04-10 21:28:07.000000000","message":"This comment doesn\u0027t belong here.. The API requires setting \"access_type\" and \"access_to\" fields","commit_id":"5c9ff645d1ae4013f82584bb49b3128c3bfaf8ee"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        :param dict attrs: Attributes which will be used to create"},{"line_number":524,"context_line":"            a :class:`~openstack.shared_file_system.v2."},{"line_number":525,"context_line":"            share_access_rules.ShareAccessRules`, comprised of the"},{"line_number":526,"context_line":"            properties on the ShareAccessRules class. \u0027size\u0027 and \u0027share\u0027"},{"line_number":527,"context_line":"            are required to create a share."},{"line_number":528,"context_line":"        :rtype: :class:`~openstack.shared_file_system.v2."},{"line_number":529,"context_line":"            share_access_rules.ShareAccessRules`"},{"line_number":530,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"efd0ff35_26b4a87d","line":527,"range":{"start_line":526,"start_character":54,"end_line":527,"end_character":43},"in_reply_to":"7e750e1b_06bd05b6","updated":"2023-04-18 17:19:55.000000000","message":"Done","commit_id":"5c9ff645d1ae4013f82584bb49b3128c3bfaf8ee"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"6a79fea3cc9cc89ed7aec1d5e7f91d8b7e905ec6","unresolved":true,"context_lines":[{"line_number":670,"context_line":"        return self._create("},{"line_number":671,"context_line":"            _share_access_rule.ShareAccessRule, base_path\u003dbase_path, **attrs)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    def delete_access_rule(self, share_id, ignore_missing\u003dTrue):"},{"line_number":674,"context_line":"        \"\"\"Deletes an access rule"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        :param share_id: The ID of the share"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fb64c71_5f454791","line":673,"range":{"start_line":673,"start_character":8,"end_line":673,"end_character":64},"updated":"2023-04-23 23:01:39.000000000","message":"Add access_id argument.","commit_id":"f9b15342fb579457154066742290387f09fa1322"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"72ef5ca18918eefdac28e652e1893c063beaae77","unresolved":true,"context_lines":[{"line_number":670,"context_line":"        return self._create("},{"line_number":671,"context_line":"            _share_access_rule.ShareAccessRule, base_path\u003dbase_path, **attrs)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    def delete_access_rule(self, share_id, ignore_missing\u003dTrue):"},{"line_number":674,"context_line":"        \"\"\"Deletes an access rule"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        :param share_id: The ID of the share"}],"source_content_type":"text/x-python","patch_set":16,"id":"5726cb02_45fdd493","line":673,"range":{"start_line":673,"start_character":8,"end_line":673,"end_character":64},"in_reply_to":"1fb64c71_5f454791","updated":"2023-04-24 15:04:57.000000000","message":"++ Good catch!","commit_id":"f9b15342fb579457154066742290387f09fa1322"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"26d0c54788e92c5ac96c7ce40495a548c2f08424","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        return self._create("},{"line_number":671,"context_line":"            _share_access_rule.ShareAccessRule, base_path\u003dbase_path, **attrs)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    def delete_access_rule(self, share_id, ignore_missing\u003dTrue):"},{"line_number":674,"context_line":"        \"\"\"Deletes an access rule"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        :param share_id: The ID of the share"}],"source_content_type":"text/x-python","patch_set":16,"id":"69ef4c3b_8fc30a3f","line":673,"range":{"start_line":673,"start_character":8,"end_line":673,"end_character":64},"in_reply_to":"5726cb02_45fdd493","updated":"2023-04-25 17:49:00.000000000","message":"Done","commit_id":"f9b15342fb579457154066742290387f09fa1322"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"6a79fea3cc9cc89ed7aec1d5e7f91d8b7e905ec6","unresolved":true,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        :rtype: ``None``"},{"line_number":679,"context_line":"        \"\"\""},{"line_number":680,"context_line":"        res \u003d self._get_resource(_share_access_rule.ShareAccessRule,"},{"line_number":681,"context_line":"                                 share_id)"},{"line_number":682,"context_line":"        res.delete(self, ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":16,"id":"4b6c4864_f65560bc","line":681,"range":{"start_line":680,"start_character":14,"end_line":681,"end_character":42},"updated":"2023-04-23 23:01:39.000000000","message":"res \u003d self._get(\n            _share_access_rule.ShareAccessRule, access_id)","commit_id":"f9b15342fb579457154066742290387f09fa1322"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"26d0c54788e92c5ac96c7ce40495a548c2f08424","unresolved":false,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        :rtype: ``None``"},{"line_number":679,"context_line":"        \"\"\""},{"line_number":680,"context_line":"        res \u003d self._get_resource(_share_access_rule.ShareAccessRule,"},{"line_number":681,"context_line":"                                 share_id)"},{"line_number":682,"context_line":"        res.delete(self, ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fe27fb2f_3a991204","line":681,"range":{"start_line":680,"start_character":14,"end_line":681,"end_character":42},"in_reply_to":"4b6c4864_f65560bc","updated":"2023-04-25 17:49:00.000000000","message":"Thanks for catching these Rey.","commit_id":"f9b15342fb579457154066742290387f09fa1322"}],"openstack/shared_file_system/v2/share_access_rule.py":[{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"c7d552088e2951dd56e6673133cc00304520dedf","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    #: the service’s database."},{"line_number":56,"context_line":"    updated_at \u003d resource.Body(\"updated_at\", type\u003dstr)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _action(self, session, body):"},{"line_number":59,"context_line":"        url \u003d utils.urljoin(\u0027/shares\u0027, self.share_id, \u0027action\u0027)"},{"line_number":60,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027\u0027}"},{"line_number":61,"context_line":"        session.post("},{"line_number":62,"context_line":"            url, json\u003dbody, headers\u003dheaders,"},{"line_number":63,"context_line":"            microversion\u003dself._max_microversion"},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _prepare_request_body(self, patch, prepend_key):"},{"line_number":67,"context_line":"        # A hack to prevent creates from creating the wrong"}],"source_content_type":"text/x-python","patch_set":15,"id":"16cc65c3_8df5947d","line":64,"range":{"start_line":58,"start_character":4,"end_line":64,"end_character":9},"updated":"2023-04-21 22:15:02.000000000","message":"Potentially use this instead:\n\n``` python\ndef _action(\n    self,\n    session,\n    body,\n    base_path\u003dNone,\n    action\u003d\u0027patch\u0027, \n    microversion\u003dNone\n):\n        \"\"\"Perform ShareAccessRule actions given the message body\"\"\"\n        \n        base_path \u003d self.base_path if not base_path else base_path\n        \n        url \u003d utils.urljoin(base_path, self.id, \u0027action\u0027)\n        headers \u003d {\u0027Accept\u0027: \u0027\u0027}\n\n        if microversion is None:\n            microversion \u003d \\\n                self._get_microversion(session, action\u003daction)\n\n        response \u003d session.post(\n            url,\n            json\u003dbody,\n            headers\u003dheaders,\n            microversion\u003dmicroversion)\n\n        exceptions.raise_from_response(response)\n        return response\n```","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"4e9028212c226562862beb1165a6a2e32a2a4b39","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    #: the service’s database."},{"line_number":56,"context_line":"    updated_at \u003d resource.Body(\"updated_at\", type\u003dstr)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _action(self, session, body):"},{"line_number":59,"context_line":"        url \u003d utils.urljoin(\u0027/shares\u0027, self.share_id, \u0027action\u0027)"},{"line_number":60,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027\u0027}"},{"line_number":61,"context_line":"        session.post("},{"line_number":62,"context_line":"            url, json\u003dbody, headers\u003dheaders,"},{"line_number":63,"context_line":"            microversion\u003dself._max_microversion"},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _prepare_request_body(self, patch, prepend_key):"},{"line_number":67,"context_line":"        # A hack to prevent creates from creating the wrong"}],"source_content_type":"text/x-python","patch_set":15,"id":"0a9a97e0_2c3bd842","line":64,"range":{"start_line":58,"start_character":4,"end_line":64,"end_character":9},"in_reply_to":"16cc65c3_8df5947d","updated":"2023-04-22 23:09:55.000000000","message":"Done","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"c7d552088e2951dd56e6673133cc00304520dedf","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            microversion\u003dself._max_microversion"},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _prepare_request_body(self, patch, prepend_key):"},{"line_number":67,"context_line":"        # A hack to prevent creates from creating the wrong"},{"line_number":68,"context_line":"        # body."},{"line_number":69,"context_line":"        if prepend_key is not True and prepend_key is not False:"},{"line_number":70,"context_line":"            request \u003d super(ShareAccessRule, self).\\"},{"line_number":71,"context_line":"                _prepare_request_body(patch, False)"},{"line_number":72,"context_line":"            return {prepend_key: request}"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            return super(ShareAccessRule, self).\\"},{"line_number":75,"context_line":"                _prepare_request_body(patch, prepend_key)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create(self, session, prepend_key\u003d\u0027allow_access\u0027, **kwargs):"},{"line_number":78,"context_line":"        prepend_key \u003d \u0027allow_access\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"0d4f2d8c_8d5b9b4e","line":75,"range":{"start_line":66,"start_character":4,"end_line":75,"end_character":57},"updated":"2023-04-21 22:15:02.000000000","message":"Remove this. There\u0027s no need for this hack anymore.","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"4e9028212c226562862beb1165a6a2e32a2a4b39","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            microversion\u003dself._max_microversion"},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _prepare_request_body(self, patch, prepend_key):"},{"line_number":67,"context_line":"        # A hack to prevent creates from creating the wrong"},{"line_number":68,"context_line":"        # body."},{"line_number":69,"context_line":"        if prepend_key is not True and prepend_key is not False:"},{"line_number":70,"context_line":"            request \u003d super(ShareAccessRule, self).\\"},{"line_number":71,"context_line":"                _prepare_request_body(patch, False)"},{"line_number":72,"context_line":"            return {prepend_key: request}"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            return super(ShareAccessRule, self).\\"},{"line_number":75,"context_line":"                _prepare_request_body(patch, prepend_key)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create(self, session, prepend_key\u003d\u0027allow_access\u0027, **kwargs):"},{"line_number":78,"context_line":"        prepend_key \u003d \u0027allow_access\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"da423952_60bc410b","line":75,"range":{"start_line":66,"start_character":4,"end_line":75,"end_character":57},"in_reply_to":"0d4f2d8c_8d5b9b4e","updated":"2023-04-22 23:09:55.000000000","message":"Done","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"c7d552088e2951dd56e6673133cc00304520dedf","unresolved":true,"context_lines":[{"line_number":74,"context_line":"            return super(ShareAccessRule, self).\\"},{"line_number":75,"context_line":"                _prepare_request_body(patch, prepend_key)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create(self, session, prepend_key\u003d\u0027allow_access\u0027, **kwargs):"},{"line_number":78,"context_line":"        prepend_key \u003d \u0027allow_access\u0027"},{"line_number":79,"context_line":"        save_resource_key \u003d self.resource_key"},{"line_number":80,"context_line":"        self.resource_key \u003d \u0027access\u0027"},{"line_number":81,"context_line":"        resource \u003d super(ShareAccessRule, self).\\"},{"line_number":82,"context_line":"            create(session, prepend_key\u003dprepend_key, **kwargs)"},{"line_number":83,"context_line":"        self.resource_key \u003d save_resource_key"},{"line_number":84,"context_line":"        return resource"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def delete(self, session, ignore_missing\u003dTrue):"},{"line_number":87,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"960c52a6_5874f516","line":84,"range":{"start_line":77,"start_character":4,"end_line":84,"end_character":23},"updated":"2023-04-21 22:15:02.000000000","message":"Now that we don\u0027t need a hack to change the resource key, we can do something like this:\n\n```\ndef create(self, session, **kwargs):\n        return super().\\\n            create(session,\n                   resource_request_key\u003d\u0027allow_access\u0027,\n                   resource_response_key\u003d\u0027access\u0027\n                   **kwargs)\n```","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"4e9028212c226562862beb1165a6a2e32a2a4b39","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            return super(ShareAccessRule, self).\\"},{"line_number":75,"context_line":"                _prepare_request_body(patch, prepend_key)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create(self, session, prepend_key\u003d\u0027allow_access\u0027, **kwargs):"},{"line_number":78,"context_line":"        prepend_key \u003d \u0027allow_access\u0027"},{"line_number":79,"context_line":"        save_resource_key \u003d self.resource_key"},{"line_number":80,"context_line":"        self.resource_key \u003d \u0027access\u0027"},{"line_number":81,"context_line":"        resource \u003d super(ShareAccessRule, self).\\"},{"line_number":82,"context_line":"            create(session, prepend_key\u003dprepend_key, **kwargs)"},{"line_number":83,"context_line":"        self.resource_key \u003d save_resource_key"},{"line_number":84,"context_line":"        return resource"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def delete(self, session, ignore_missing\u003dTrue):"},{"line_number":87,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"b0dedfd2_62ea0f89","line":84,"range":{"start_line":77,"start_character":4,"end_line":84,"end_character":23},"in_reply_to":"960c52a6_5874f516","updated":"2023-04-22 23:09:55.000000000","message":"Done","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":35745,"name":"Reynaldo","display_name":"Reynaldo","email":"rey.bontje80@gmail.com","username":"plugd-in"},"change_message_id":"c7d552088e2951dd56e6673133cc00304520dedf","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        self.resource_key \u003d save_resource_key"},{"line_number":84,"context_line":"        return resource"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def delete(self, session, ignore_missing\u003dTrue):"},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            body \u003d {\u0027deny_access\u0027: {\u0027access_id\u0027 : self.id}}"},{"line_number":89,"context_line":"        except exceptions.ResourceNotFound:"},{"line_number":90,"context_line":"            if not ignore_missing:"},{"line_number":91,"context_line":"                raise"},{"line_number":92,"context_line":"        return self._action(session, body)"}],"source_content_type":"text/x-python","patch_set":15,"id":"4f59b678_a0806aeb","line":92,"range":{"start_line":86,"start_character":4,"end_line":92,"end_character":42},"updated":"2023-04-21 22:15:02.000000000","message":"I think the `try` block is in the wrong place. The assignment to the `body` dict should not raise that exception, but the request made in `self._action` might.\n\nWith the change to `self._action` I proposed, this would become something like: \n\n``` python\ndef delete(self, session, ignore_missing\u003dTrue):\n     body \u003d {\u0027deny_access\u0027: {\u0027access_id\u0027 : self.id}}\n     url \u003d utils.urljoin(\u0027/shares\u0027, self.share_id, \u0027action\u0027)\n     try:\n         response \u003d self._action(session, body, url)\n     except exceptions.ResourceNotFound:\n         if not ignore_missing:\n             raise\n     return response\n```","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"4e9028212c226562862beb1165a6a2e32a2a4b39","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.resource_key \u003d save_resource_key"},{"line_number":84,"context_line":"        return resource"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def delete(self, session, ignore_missing\u003dTrue):"},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            body \u003d {\u0027deny_access\u0027: {\u0027access_id\u0027 : self.id}}"},{"line_number":89,"context_line":"        except exceptions.ResourceNotFound:"},{"line_number":90,"context_line":"            if not ignore_missing:"},{"line_number":91,"context_line":"                raise"},{"line_number":92,"context_line":"        return self._action(session, body)"}],"source_content_type":"text/x-python","patch_set":15,"id":"61660407_b83a6289","line":92,"range":{"start_line":86,"start_character":4,"end_line":92,"end_character":42},"in_reply_to":"4f59b678_a0806aeb","updated":"2023-04-22 23:09:55.000000000","message":"Thanks for catching these.","commit_id":"5adecb4feb7cc616e51e4a30a97ccd25c61a4992"}],"openstack/tests/functional/shared_file_system/test_share_access_rule.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        mys \u003d self.create_share("},{"line_number":23,"context_line":"            name\u003dself.SHARE_NAME, size\u003d2, share_type\u003d\"dhss_false\","},{"line_number":24,"context_line":"            share_protocol\u003d\u0027NFS\u0027, description\u003dNone)"},{"line_number":25,"context_line":"        self.operator_cloud.shared_file_system.wait_for_status("},{"line_number":26,"context_line":"            mys,"},{"line_number":27,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":28,"context_line":"            failures\u003d[\u0027error\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"f46912e3_e2a6988f","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":27},"updated":"2023-03-22 04:31:27.000000000","message":"user_cloud\n\nplease use user_cloud when making API calls that don\u0027t need privileged access... In the Manila API ref that you\u0027re referring to, you\u0027ll see a note on certain APIs needing privileged access; for example:\n\n\"As administrator, you can also reset the state of a snapshot and force-delete a share snapshot in any state. Use the policy.yaml file to grant permissions for these actions to other roles.\"\n\nSo unless this note\u0027s there, you can assume an API can be executed by a regular user of the cloud.","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        mys \u003d self.create_share("},{"line_number":23,"context_line":"            name\u003dself.SHARE_NAME, size\u003d2, share_type\u003d\"dhss_false\","},{"line_number":24,"context_line":"            share_protocol\u003d\u0027NFS\u0027, description\u003dNone)"},{"line_number":25,"context_line":"        self.operator_cloud.shared_file_system.wait_for_status("},{"line_number":26,"context_line":"            mys,"},{"line_number":27,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":28,"context_line":"            failures\u003d[\u0027error\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"800e81a6_818685d6","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":27},"in_reply_to":"f46912e3_e2a6988f","updated":"2023-04-18 17:19:55.000000000","message":"Ahh, I see. Thanks for this information.","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        self.assertIsNotNone(mys.id)"},{"line_number":33,"context_line":"        self.SHARE_ID \u003d mys.id"},{"line_number":34,"context_line":"        self.SHARE \u003d mys"},{"line_number":35,"context_line":"        access_rule \u003d self.operator_cloud.share.create_access_rule("},{"line_number":36,"context_line":"            self.SHARE_ID,"},{"line_number":37,"context_line":"            access_level\u003d\"rw\","},{"line_number":38,"context_line":"            access_type\u003d\"ip\","}],"source_content_type":"text/x-python","patch_set":8,"id":"32975715_5b23d398","line":35,"updated":"2023-03-22 04:31:27.000000000","message":"user_cloud","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.assertIsNotNone(mys.id)"},{"line_number":33,"context_line":"        self.SHARE_ID \u003d mys.id"},{"line_number":34,"context_line":"        self.SHARE \u003d mys"},{"line_number":35,"context_line":"        access_rule \u003d self.operator_cloud.share.create_access_rule("},{"line_number":36,"context_line":"            self.SHARE_ID,"},{"line_number":37,"context_line":"            access_level\u003d\"rw\","},{"line_number":38,"context_line":"            access_type\u003d\"ip\","}],"source_content_type":"text/x-python","patch_set":8,"id":"f5b07f58_1dab35d0","line":35,"in_reply_to":"32975715_5b23d398","updated":"2023-04-18 17:19:55.000000000","message":"Done","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        self.RESOURCE_KEY \u003d access_rule.resource_key"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def tearDown(self):"},{"line_number":45,"context_line":"        acr \u003d self.operator_cloud.share.delete_access_rule("},{"line_number":46,"context_line":"            self.SHARE_ID,"},{"line_number":47,"context_line":"            self.ACCESS_ID"},{"line_number":48,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"787da244_1599ba04","line":45,"updated":"2023-03-22 04:31:27.000000000","message":"user_cloud","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.RESOURCE_KEY \u003d access_rule.resource_key"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def tearDown(self):"},{"line_number":45,"context_line":"        acr \u003d self.operator_cloud.share.delete_access_rule("},{"line_number":46,"context_line":"            self.SHARE_ID,"},{"line_number":47,"context_line":"            self.ACCESS_ID"},{"line_number":48,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"29ac1b1d_a3b873cb","line":45,"in_reply_to":"787da244_1599ba04","updated":"2023-04-18 17:19:55.000000000","message":"Done","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        super(ShareAccessRuleTest, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_get_access_rule(self):"},{"line_number":54,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.get_access_rule("},{"line_number":55,"context_line":"            self.ACCESS_ID"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":"        self.assertEqual(self.ACCESS_ID, sot.id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f52ba168_65566aa0","line":54,"updated":"2023-03-22 04:31:27.000000000","message":"user_cloud","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(ShareAccessRuleTest, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_get_access_rule(self):"},{"line_number":54,"context_line":"        sot \u003d self.operator_cloud.shared_file_system.get_access_rule("},{"line_number":55,"context_line":"            self.ACCESS_ID"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":"        self.assertEqual(self.ACCESS_ID, sot.id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"914eb3b8_e427ea43","line":54,"in_reply_to":"f52ba168_65566aa0","updated":"2023-04-18 17:19:55.000000000","message":"Done","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual(self.ACCESS_ID, sot.id)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_list_access_rules(self):"},{"line_number":60,"context_line":"        rules \u003d self.operator_cloud.shared_file_system.access_rules("},{"line_number":61,"context_line":"            self.SHARE,"},{"line_number":62,"context_line":"            details\u003dTrue"},{"line_number":63,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"b5060f38_d634f14b","line":60,"updated":"2023-03-22 04:31:27.000000000","message":"user_cloud","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual(self.ACCESS_ID, sot.id)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_list_access_rules(self):"},{"line_number":60,"context_line":"        rules \u003d self.operator_cloud.shared_file_system.access_rules("},{"line_number":61,"context_line":"            self.SHARE,"},{"line_number":62,"context_line":"            details\u003dTrue"},{"line_number":63,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"6d76b460_21ae2a6b","line":60,"in_reply_to":"b5060f38_d634f14b","updated":"2023-04-18 17:19:55.000000000","message":"Done","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"}],"openstack/tests/unit/shared_file_system/v2/test_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"626e8307_1a11b8c7","line":238,"updated":"2023-03-22 04:31:27.000000000","message":"we\u0027ll need tests for the create/delete methods as well here..","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"080870e1_acbe181c","line":238,"in_reply_to":"626e8307_1a11b8c7","updated":"2023-04-18 17:19:55.000000000","message":"Got those added. Let me know if anything looks off.","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eeb23fd6fcb22e545d2ad089f530544e5e21250f","unresolved":true,"context_lines":[{"line_number":306,"context_line":"            expected_args\u003d[])"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def test_access_rules_delete(self):"},{"line_number":309,"context_line":"        self._verify("},{"line_number":310,"context_line":"            \"openstack.shared_file_system.v2.share_access_rule.\""},{"line_number":311,"context_line":"            + \"ShareAccessRule.delete\","},{"line_number":312,"context_line":"            self.proxy.delete_access_rule,"}],"source_content_type":"text/x-python","patch_set":13,"id":"f767c476_06c535b2","line":309,"range":{"start_line":309,"start_character":8,"end_line":309,"end_character":21},"updated":"2023-04-10 21:28:07.000000000","message":"Was verify_delete presenting any issue here? with \"ignore_missing\" perhaps? I wonder if we need to implement ignore_missing in the delete method: https://opendev.org/openstack/openstacksdk/src/commit/81f86089527ef43020a425d5f535ddd5564cdb34/openstack/baremetal_introspection/v1/_proxy.py#L106-L127","commit_id":"5c9ff645d1ae4013f82584bb49b3128c3bfaf8ee"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            expected_args\u003d[])"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def test_access_rules_delete(self):"},{"line_number":309,"context_line":"        self._verify("},{"line_number":310,"context_line":"            \"openstack.shared_file_system.v2.share_access_rule.\""},{"line_number":311,"context_line":"            + \"ShareAccessRule.delete\","},{"line_number":312,"context_line":"            self.proxy.delete_access_rule,"}],"source_content_type":"text/x-python","patch_set":13,"id":"cbf4fa8a_0c52219d","line":309,"range":{"start_line":309,"start_character":8,"end_line":309,"end_character":21},"in_reply_to":"f767c476_06c535b2","updated":"2023-04-18 17:19:55.000000000","message":"Yes, ignore missing was causing issues saying \"multiple values of ignore_missing\" were found.","commit_id":"5c9ff645d1ae4013f82584bb49b3128c3bfaf8ee"}],"releasenotes/notes/add-share-access-rules-to-shared-file-362bee34f7331186.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44dda6369e11966b871889832cb7b982cf91a25c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to list and get share access rules with the"},{"line_number":5,"context_line":"    shared file system service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"33136216_d34b6afe","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":33},"updated":"2023-03-22 04:31:27.000000000","message":"create, list, get and delete","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"},{"author":{"_account_id":35763,"name":"Samuel Loegering","email":"samuel.loegering@ndsu.edu","username":"samloegy"},"change_message_id":"03abb1b8611ee2a22b80ec2e2a351ce25a7bba36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support to list and get share access rules with the"},{"line_number":5,"context_line":"    shared file system service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"54b5327b_d0bac144","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":33},"in_reply_to":"33136216_d34b6afe","updated":"2023-04-18 17:19:55.000000000","message":"Done","commit_id":"8656bda820b200f3e38f53f7c3385a6e5c6e0ef8"}]}