)]}'
{"openstack/block_storage/v3/group_type.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9978c6b21979c2b9cd583a197ec258bbc1ed0274","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    allow_commit \u003d True"},{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _max_microversion \u003d \"3.11\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    #: Properties"},{"line_number":31,"context_line":"    #: The group type description."}],"source_content_type":"text/x-python","patch_set":3,"id":"8024fa3b_c02ceffe","line":28,"updated":"2021-04-20 17:33:14.000000000","message":"Where\u0027s this coming from? There\u0027s nothing obvious about this in the docs [1]\n\nLater: Ah, it\u0027s not in the docs but it is in the code [2]. Good spot.\n\n[1] https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dcreate-group-type-detail#group-types-group-types\n[3] https://github.com/openstack/cinder/blob/e010f43c1c380d91c0bbb066061f570a047d6c1b/cinder/api/v3/group_types.py#L54","commit_id":"11557ccccd8aeb3810eb0cb4578cac166ccf32d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9978c6b21979c2b9cd583a197ec258bbc1ed0274","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    #: The group type description."},{"line_number":32,"context_line":"    description \u003d resource.Body(\"description\")"},{"line_number":33,"context_line":"    #: Contains the specifications for a group type."},{"line_number":34,"context_line":"    group_specs \u003d resource.Body(\"group_specs\", type\u003ddict)"},{"line_number":35,"context_line":"    #: The group type ID."},{"line_number":36,"context_line":"    id \u003d resource.Body(\"id\")"},{"line_number":37,"context_line":"    #: Whether the group type is publicly visible."}],"source_content_type":"text/x-python","patch_set":3,"id":"78e6bdc7_5d46fb56","line":34,"updated":"2021-04-20 17:33:14.000000000","message":"Yup, this is a generic collection of \"stuff\" so there\u0027s no need to go into more detail on this","commit_id":"11557ccccd8aeb3810eb0cb4578cac166ccf32d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9978c6b21979c2b9cd583a197ec258bbc1ed0274","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    #: Contains the specifications for a group type."},{"line_number":34,"context_line":"    group_specs \u003d resource.Body(\"group_specs\", type\u003ddict)"},{"line_number":35,"context_line":"    #: The group type ID."},{"line_number":36,"context_line":"    id \u003d resource.Body(\"id\")"},{"line_number":37,"context_line":"    #: Whether the group type is publicly visible."},{"line_number":38,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":39,"context_line":"    # The group type name."}],"source_content_type":"text/x-python","patch_set":3,"id":"791325ef_1543e462","line":36,"updated":"2021-04-20 17:33:14.000000000","message":"You don\u0027t actually need this. It\u0027s added automatically by the parent \u0027Resource\u0027 class [1] \n\n[1] https://github.com/openstack/openstacksdk/blob/e13b59c7/openstack/resource.py#L425-L428","commit_id":"11557ccccd8aeb3810eb0cb4578cac166ccf32d7"},{"author":{"_account_id":33032,"name":"Dylan Zapzalka","email":"dylanjameszapzalka@hotmail.com","username":"dylanzapzalka"},"change_message_id":"7359bc78b7b40bcc7aa2050230f351de31c492ef","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    #: Contains the specifications for a group type."},{"line_number":34,"context_line":"    group_specs \u003d resource.Body(\"group_specs\", type\u003ddict)"},{"line_number":35,"context_line":"    #: The group type ID."},{"line_number":36,"context_line":"    id \u003d resource.Body(\"id\")"},{"line_number":37,"context_line":"    #: Whether the group type is publicly visible."},{"line_number":38,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":39,"context_line":"    # The group type name."}],"source_content_type":"text/x-python","patch_set":3,"id":"29e6efd9_bcdcc902","line":36,"in_reply_to":"791325ef_1543e462","updated":"2021-04-24 17:41:02.000000000","message":"I agree, that is unnecessary.","commit_id":"11557ccccd8aeb3810eb0cb4578cac166ccf32d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9978c6b21979c2b9cd583a197ec258bbc1ed0274","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    #: Whether the group type is publicly visible."},{"line_number":38,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":39,"context_line":"    # The group type name."},{"line_number":40,"context_line":"    name \u003d resource.Body(\"name\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"55bc6288_7b97f776","line":40,"updated":"2021-04-20 17:33:14.000000000","message":"Ditto","commit_id":"11557ccccd8aeb3810eb0cb4578cac166ccf32d7"},{"author":{"_account_id":33032,"name":"Dylan Zapzalka","email":"dylanjameszapzalka@hotmail.com","username":"dylanzapzalka"},"change_message_id":"7359bc78b7b40bcc7aa2050230f351de31c492ef","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    #: Whether the group type is publicly visible."},{"line_number":38,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":39,"context_line":"    # The group type name."},{"line_number":40,"context_line":"    name \u003d resource.Body(\"name\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0e6a2_e5b1cdb1","line":40,"in_reply_to":"55bc6288_7b97f776","updated":"2021-04-24 17:41:02.000000000","message":"Fixed.","commit_id":"11557ccccd8aeb3810eb0cb4578cac166ccf32d7"}],"openstack/tests/functional/block_storage/v3/test_group_type.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9978c6b21979c2b9cd583a197ec258bbc1ed0274","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        group_type \u003d self.conn.block_storage.create_group_type("},{"line_number":26,"context_line":"            name\u003dself.GROUP_TYPE_NAME)"},{"line_number":27,"context_line":"        assert isinstance(group_type, _group_type.GroupType)"},{"line_number":28,"context_line":"        self.assertEqual(self.GROUP_TYPE_NAME, group_type.name)"},{"line_number":29,"context_line":"        self.GROUP_TYPE_ID \u003d group_type.id"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b00fb1aa_e438f34b","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":25},"updated":"2021-04-20 17:33:14.000000000","message":"I know there are lots of other examples of this in the code base so I can understand why you did it this way, but it would be more typical to use unittest\u0027s helper for this:\n\n  self.assertIsInstance(foo, Foo)","commit_id":"11557ccccd8aeb3810eb0cb4578cac166ccf32d7"},{"author":{"_account_id":33032,"name":"Dylan Zapzalka","email":"dylanjameszapzalka@hotmail.com","username":"dylanzapzalka"},"change_message_id":"7359bc78b7b40bcc7aa2050230f351de31c492ef","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        group_type \u003d self.conn.block_storage.create_group_type("},{"line_number":26,"context_line":"            name\u003dself.GROUP_TYPE_NAME)"},{"line_number":27,"context_line":"        assert isinstance(group_type, _group_type.GroupType)"},{"line_number":28,"context_line":"        self.assertEqual(self.GROUP_TYPE_NAME, group_type.name)"},{"line_number":29,"context_line":"        self.GROUP_TYPE_ID \u003d group_type.id"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"660ce649_92bfa332","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":25},"in_reply_to":"b00fb1aa_e438f34b","updated":"2021-04-24 17:41:02.000000000","message":"Fixed.","commit_id":"11557ccccd8aeb3810eb0cb4578cac166ccf32d7"}]}