)]}'
{"id":"openstack%2Fopenstacksdk~787838","triplet_id":"openstack%2Fopenstacksdk~stable%2Fwallaby~I25dabfde27b843df1c91c7fc37a1fe8d207b8010","project":"openstack/openstacksdk","branch":"stable/wallaby","topic":"remote-address-group-id-stable/wallaby","hashtags":[],"change_id":"I25dabfde27b843df1c91c7fc37a1fe8d207b8010","subject":"Don\u0027t send empty remote_address_group_id for security groups","status":"MERGED","created":"2021-04-24 09:56:12.000000000","updated":"2021-05-10 17:08:06.000000000","submitted":"2021-05-10 17:06:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"787838-remote-address-group-id-stable/wallaby","cherry_pick_of_change":786148,"cherry_pick_of_patch_set":3,"meta_rev_id":"a51b7d3f27a45c41ba996981f110865206b9b22a","_number":787838,"virtual_id_number":787838,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-10 17:06:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"recommended":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":1,"date":"2021-04-26 15:50:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2021-05-10 15:45:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-04-26 00:01:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2021-05-04 08:02:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":1,"date":"2021-05-10 15:45:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-24 09:56:12.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2021-04-24 12:03:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-26 15:50:30.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2021-05-04 08:02:37.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2021-05-10 15:45:32.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"936e3e4701926a3dfe114ebfdd86b6cb649299b7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2021-04-24 09:56:12.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"906b8d57a0fd33a098636542732f77272f6ea217","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-24 12:03:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f57211d502cb4f0f9cd6e9e94c82354c : SUCCESS in 4m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77ec3d4b7dec47c4892f57736e3d1d47 : SUCCESS in 3m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/82d5ceeadda44fb0b5b79afd77118a30 : SUCCESS in 5m 17s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/65cbcae4ab474dfe9c75eeb6538eaf67 : SUCCESS in 4m 34s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/536db09e24ec4db19b7c9095cc2e95fd : SUCCESS in 47m 50s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/61bf3c6209014891a5358123a4b20d99 : SUCCESS in 6m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81bf07d256994c38bedc8b294b3c025d : SUCCESS in 7m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9bbc9e109891411196823639918410db : SUCCESS in 5m 36s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/08aa208813184bf9a8f6936aa745816f : SUCCESS in 23m 11s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/644aef35499d4abab1da234bd49534ca : SUCCESS in 18m 42s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3a4285f5c1c144bab7eb7cd4729d351c : SUCCESS in 55m 07s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/68293a78d9334f9f86a8b71db7794c99 : SUCCESS in 1h 24m 51s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/72032584950d46f5aaaebf58227bf442 : SUCCESS in 49m 31s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/575a50e0f4104f2cade8a5b421ab8124 : SUCCESS in 56m 54s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/d721583472f6493cb842559f73adeb05 : SUCCESS in 23m 30s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/717240c5d0c7409ab1d9bef1f007dba3 : POST_FAILURE in 1h 27m 27s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/a878398c162a4e00a3c205f13d3f33e5 : SUCCESS in 52m 47s (non-voting)\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/ec42c5d4e03948cdac72a44c3511b454 : SUCCESS in 53m 51s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b78deee0395745f586c20568dfe32772 : SUCCESS in 28m 16s (non-voting)\n- metalsmith-integration-openstacksdk-src https://zuul.opendev.org/t/openstack/build/4dd6b4be6aa54fe688c0c285e79a0363 : SUCCESS in 55m 31s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/c701f51cd3ca4a28a45af2857a3abde5 : SUCCESS in 38m 01s (non-voting)\n- openstacksdk-ansible-stable-2.8-functional-devstack https://zuul.opendev.org/t/openstack/build/fbda94a56c2e4f68a17bf9bbb63c7245 : FAILURE in 29m 10s (non-voting)\n- openstacksdk-ansible-stable-2.9-functional-devstack https://zuul.opendev.org/t/openstack/build/21f3bc27b14b45df9df16af0b174404f : FAILURE in 33m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9f686ab03996a7fc391629b43ead2c4f758b5b86","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2021-04-26 00:01:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0287fe90e80584d3e6161e9545328f270a1f9629","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2021-04-26 15:50:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6c1f66b203db75d9aee97c003cb99708b31b93a7","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-05-04 08:02:37.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8f3c25fd91cce9ec955783ba006c61de770651e5","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-05-10 15:45:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"45c82c157ec6f2fa0573672e5675373f01fdcd5f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-10 15:46:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f70023df27881fe46b913b0974b026d7f1495731","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-10 17:06:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/331ab55f16e449298af7571128d8bd0e : SUCCESS in 5m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/536267946f194f978bc7837ac181d919 : SUCCESS in 4m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9b74c2d66a4f4280b09ec14e7fb5f4a7 : SUCCESS in 5m 04s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6b7455630c8d4a2fadd2ff9dda99a1b4 : SUCCESS in 5m 02s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/4c934393e9304d71934f3475dbf7a3e3 : SUCCESS in 59m 32s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/f1b15e32815742da81afee507f89ef0a : SUCCESS in 6m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/06a4efe5c4bb4034806f472696117473 : SUCCESS in 8m 24s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e51bc536e86d49549deac0aff6b5cd06 : SUCCESS in 4m 47s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/40176c3855f8453683e094f58def72e6 : SUCCESS in 1h 13m 23s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/1b2c5b8ecae849c28221357d249844e0 : SUCCESS in 20m 20s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/3198165e58f54e9ab8a7dd23faa1c9e2 : SUCCESS in 42m 33s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7b36ed2ba33f445f860262c5189e3949 : SUCCESS in 54m 34s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/655893da4b724ead971fb8ccad9ec788 : SUCCESS in 1h 16m 30s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/f1f9ab943b32452c95cc0700bacc2fb9 : SUCCESS in 51m 53s","accounts_in_message":[],"_revision_number":1},{"id":"9a52a57511bc7f9f4009aec77aecc1d8dcabc824","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-10 17:06:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a51b7d3f27a45c41ba996981f110865206b9b22a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-10 17:08:06.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/11b3ddd4cdb645269f21a6a73b1dce2d : SUCCESS in 59s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/14464a117e33453f88e07a75fa817d16 : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f7c55645505027ac16d8e11f05ee5b2768c85a06","revisions":{"f7c55645505027ac16d8e11f05ee5b2768c85a06":{"kind":"REWORK","_number":1,"created":"2021-04-24 09:56:12.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/38/787838/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/38/787838/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/38/787838/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/38/787838/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/38/787838/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/38/787838/1"}}},"commit":{"parents":[{"commit":"8062615c04e641cef21c1da4b1a4a52908841395","subject":"Update TOX_CONSTRAINTS_FILE for stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/8062615c04e641cef21c1da4b1a4a52908841395"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2021-04-13 23:40:17.000000000","tz":600},"committer":{"name":"Dr. Jens Harbott","email":"j.harbott@x-ion.de","date":"2021-04-24 09:56:12.000000000","tz":0},"subject":"Don\u0027t send empty remote_address_group_id for security groups","message":"Don\u0027t send empty remote_address_group_id for security groups\n\nWe are seeing an error raised by older Neutron\u0027s\n\n 400: Client Error for url: \u003ccloud\u003e/v2.0/security-group-rules,\n Unrecognized attribute(s) \u0027remote_address_group_id\u0027\n\nThis field was added unconditionally with\nI50374c339ab7685a6e74f25f9521b8810c532e13 but, per above, appears to\ncause problems for older Neutron instances.\n\nTo work around this, remove the argument from the body when blank by\noverriding the _prepare_request function of SecurityGroupRule.\n\nTwo tests where this are used are updated; one checks the body is not\nsent when None and the other is modified to send a\nremote_address_group_id value to validate the other path.\n\nStory: #2008577\nTask: #41729\nChange-Id: I25dabfde27b843df1c91c7fc37a1fe8d207b8010\n(cherry picked from commit b562d779e60337926c011b147256ba81cc1e6f88)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f7c55645505027ac16d8e11f05ee5b2768c85a06"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/f7c55645505027ac16d8e11f05ee5b2768c85a06"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}