)]}'
{"openstack/shared_file_system/v2/_proxy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d17cc1eac958414360499e873c357825eb5d4482","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    def delete_share(self, share, ignore_missing\u003dTrue):"},{"line_number":91,"context_line":"        \"\"\"Deletes a single share"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param share: The ID of the share to get"},{"line_number":94,"context_line":"        :returns: Result of the ``delete``"},{"line_number":95,"context_line":"        :rtype: ``None``"},{"line_number":96,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7423a12c_fa655c53","line":93,"range":{"start_line":93,"start_character":45,"end_line":93,"end_character":48},"updated":"2021-06-25 20:37:14.000000000","message":"delete","commit_id":"73f6cfe4765944efc1cf9279e63c9051c3a72ca2"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b4db4031325a9b4a3e77be0a42e5cfc62f9b69bd","unresolved":true,"context_lines":[{"line_number":37,"context_line":"            * status: Filters by a share status"},{"line_number":38,"context_line":"            * share_server_id: The UUID of the share server."},{"line_number":39,"context_line":"            * metadata: One or more metadata key and value pairs as a url"},{"line_number":40,"context_line":"                        encoded dictionary of strings."},{"line_number":41,"context_line":"            * extra_specs: The extra specifications as a set of one or more"},{"line_number":42,"context_line":"                           key-value pairs."},{"line_number":43,"context_line":"            * share_type_id: The UUID of a share type to query resources by."}],"source_content_type":"text/x-python","patch_set":7,"id":"59e33e4d_0e9bc588","line":40,"updated":"2021-07-12 15:47:04.000000000","message":"would you please align all the comments (+4 and not under first char)","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"}],"openstack/shared_file_system/v2/share.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b3a09db7930a7c499c2a78264803038abc968909","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":42,"context_line":"    #: The level of visibility for the share."},{"line_number":43,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":44,"context_line":"    #: Whether the share can be clones into new shares or not."},{"line_number":45,"context_line":"    is_creating_new_share_from_snapshot_supported \u003d resource.Body("},{"line_number":46,"context_line":"        \"create_share_from_snapshot_support\", type\u003dbool)"},{"line_number":47,"context_line":"    #: Whether the share\u0027s snapshots can be mounted directly and access"}],"source_content_type":"text/x-python","patch_set":4,"id":"aefa2050_0c0ea537","line":44,"updated":"2021-07-05 15:51:32.000000000","message":"NIT s/clones/cloned/g","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"2c94a0e3bbe49b07120046ef0da8eb1e305143d9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    host \u003d resource.Body(\"host\", type\u003dstr)"},{"line_number":42,"context_line":"    #: The level of visibility for the share."},{"line_number":43,"context_line":"    is_public \u003d resource.Body(\"is_public\", type\u003dbool)"},{"line_number":44,"context_line":"    #: Whether the share can be clones into new shares or not."},{"line_number":45,"context_line":"    is_creating_new_share_from_snapshot_supported \u003d resource.Body("},{"line_number":46,"context_line":"        \"create_share_from_snapshot_support\", type\u003dbool)"},{"line_number":47,"context_line":"    #: Whether the share\u0027s snapshots can be mounted directly and access"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa97cfe7_87fb9b76","line":44,"in_reply_to":"aefa2050_0c0ea537","updated":"2021-07-05 16:48:58.000000000","message":"Ack","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"}],"openstack/tests/functional/shared_file_system/base.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b4db4031325a9b4a3e77be0a42e5cfc62f9b69bd","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        self.require_service(\u0027shared-file-system\u0027,"},{"line_number":23,"context_line":"                             min_microversion\u003dself.min_microversion)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def create_share(self, **kwargs):"},{"line_number":26,"context_line":"        share \u003d self.conn.share.create_share(**kwargs)"},{"line_number":27,"context_line":"        self.addCleanup(self.conn.share.delete_share, share.id,"},{"line_number":28,"context_line":"                        ignore_missing\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a644f80b_3448616d","line":25,"updated":"2021-07-12 15:47:04.000000000","message":"this test should go into the share file and not stay in the base","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd9d5f4a23d719c734737fe56788314c5f5ee384","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        self.require_service(\u0027shared-file-system\u0027,"},{"line_number":23,"context_line":"                             min_microversion\u003dself.min_microversion)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def create_share(self, **kwargs):"},{"line_number":26,"context_line":"        share \u003d self.conn.share.create_share(**kwargs)"},{"line_number":27,"context_line":"        self.addCleanup(self.conn.share.delete_share, share.id,"},{"line_number":28,"context_line":"                        ignore_missing\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a949ae47_b97f5bc3","line":25,"in_reply_to":"2e4ae990_0002a037","updated":"2021-07-14 17:34:09.000000000","message":"Oh! I see what you mean - at some point the invocation in the functional tests changed to using the client directly via setup and teardown.","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"491416096b653b19bed7043a8c41d7b842835e13","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        self.require_service(\u0027shared-file-system\u0027,"},{"line_number":23,"context_line":"                             min_microversion\u003dself.min_microversion)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def create_share(self, **kwargs):"},{"line_number":26,"context_line":"        share \u003d self.conn.share.create_share(**kwargs)"},{"line_number":27,"context_line":"        self.addCleanup(self.conn.share.delete_share, share.id,"},{"line_number":28,"context_line":"                        ignore_missing\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"2e4ae990_0002a037","line":25,"in_reply_to":"8f6d9e96_9385cf4c","updated":"2021-07-14 14:43:01.000000000","message":"ok, agree. But you are not even invoking it now.","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ec7371d712112e534fe4d21f0502c3b4a71999c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        self.require_service(\u0027shared-file-system\u0027,"},{"line_number":23,"context_line":"                             min_microversion\u003dself.min_microversion)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def create_share(self, **kwargs):"},{"line_number":26,"context_line":"        share \u003d self.conn.share.create_share(**kwargs)"},{"line_number":27,"context_line":"        self.addCleanup(self.conn.share.delete_share, share.id,"},{"line_number":28,"context_line":"                        ignore_missing\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"8f6d9e96_9385cf4c","line":25,"in_reply_to":"a644f80b_3448616d","updated":"2021-07-12 16:33:18.000000000","message":"I\u0027d prefer keeping setup methods here so we don\u0027t have to import a test file or duplicate code when we\u0027re working on related resources.. For example, we\u0027d be implementing share snapshots next; and we\u0027d need to create a share prior to creating snapshots","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"}],"openstack/tests/functional/shared_file_system/test_share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ce3faaec47fd27b93d6ecdbed8bc55722b9e697","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from openstack.tests.functional.shared_file_system import base"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class ShareTest(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_create_share(self):"},{"line_number":19,"context_line":"        my_share \u003d self.conn.shared_file_system.create_share("}],"source_content_type":"text/x-python","patch_set":2,"id":"a221a947_a02947f5","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":5},"updated":"2021-06-25 20:15:02.000000000","message":"also missing tests to:\n\n update_share\n get_share","commit_id":"73f6cfe4765944efc1cf9279e63c9051c3a72ca2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ce3faaec47fd27b93d6ecdbed8bc55722b9e697","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    def test_create_share(self):"},{"line_number":19,"context_line":"        my_share \u003d self.conn.shared_file_system.create_share("},{"line_number":20,"context_line":"            name\u003d\u0027random\u0027, size\u003d2, share_type\u003d\"dhss_false\","},{"line_number":21,"context_line":"            share_protocol\u003d\u0027NFS\u0027, is_public\u003dTrue,"},{"line_number":22,"context_line":"            description\u003dNone, is_default\u003dFalse)"},{"line_number":23,"context_line":"        self.assertIsNotNone(my_share)"},{"line_number":24,"context_line":"        self.assertIsNotNone(my_share.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e354976_4937220c","line":21,"range":{"start_line":21,"start_character":34,"end_line":21,"end_character":48},"updated":"2021-06-25 20:15:02.000000000","message":"is not allowed for __member__ role by default; so I suggest dropping this from the test.","commit_id":"73f6cfe4765944efc1cf9279e63c9051c3a72ca2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ce3faaec47fd27b93d6ecdbed8bc55722b9e697","unresolved":true,"context_lines":[{"line_number":19,"context_line":"        my_share \u003d self.conn.shared_file_system.create_share("},{"line_number":20,"context_line":"            name\u003d\u0027random\u0027, size\u003d2, share_type\u003d\"dhss_false\","},{"line_number":21,"context_line":"            share_protocol\u003d\u0027NFS\u0027, is_public\u003dTrue,"},{"line_number":22,"context_line":"            description\u003dNone, is_default\u003dFalse)"},{"line_number":23,"context_line":"        self.assertIsNotNone(my_share)"},{"line_number":24,"context_line":"        self.assertIsNotNone(my_share.id)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b7d1ed16_c84ceffd","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":46},"updated":"2021-06-25 20:15:02.000000000","message":"This isn\u0027t a valid share parameter: https://docs.openstack.org/api-ref/shared-file-system/?expanded\u003dcreate-share-detail#id36","commit_id":"73f6cfe4765944efc1cf9279e63c9051c3a72ca2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ce3faaec47fd27b93d6ecdbed8bc55722b9e697","unresolved":true,"context_lines":[{"line_number":21,"context_line":"            share_protocol\u003d\u0027NFS\u0027, is_public\u003dTrue,"},{"line_number":22,"context_line":"            description\u003dNone, is_default\u003dFalse)"},{"line_number":23,"context_line":"        self.assertIsNotNone(my_share)"},{"line_number":24,"context_line":"        self.assertIsNotNone(my_share.id)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_get_delete_share(self):"},{"line_number":27,"context_line":"        shares \u003d self.conn.shared_file_system.shares()"}],"source_content_type":"text/x-python","patch_set":2,"id":"4446811c_06b152fe","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":41},"updated":"2021-06-25 20:15:02.000000000","message":"You\u0027ll need to wait for the share to become \"available\" here before exiting this test. If you don\u0027t, the cleanup may not succeed since a share that\u0027s in a transitional \"creating\" state cannot be deleted.\n\nHere\u0027s some usage of a \"wait_for_status\" method: https://github.com/openstack/openstacksdk/blob/32d2a5522cf8ae0047c53ff8d10967b181453ef8/openstack/block_storage/v3/_proxy.py#L675-L676","commit_id":"73f6cfe4765944efc1cf9279e63c9051c3a72ca2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ce3faaec47fd27b93d6ecdbed8bc55722b9e697","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_get_delete_share(self):"},{"line_number":27,"context_line":"        shares \u003d self.conn.shared_file_system.shares()"},{"line_number":28,"context_line":"        self.assertGreater(len(list(shares)), 0)"},{"line_number":29,"context_line":"        for share in shares:"},{"line_number":30,"context_line":"            for attribute in (\u0027id\u0027, \u0027name\u0027, \u0027created_at\u0027, \u0027updated_at\u0027):"},{"line_number":31,"context_line":"                self.assertTrue(hasattr(share, attribute))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fee5d94_b19c77ba","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":48},"updated":"2021-06-25 20:15:02.000000000","message":"This could fail because there are no shares..\nthe test execution order is random, and we have to create at least one share in this test for this assert to work","commit_id":"73f6cfe4765944efc1cf9279e63c9051c3a72ca2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ce3faaec47fd27b93d6ecdbed8bc55722b9e697","unresolved":true,"context_lines":[{"line_number":30,"context_line":"            for attribute in (\u0027id\u0027, \u0027name\u0027, \u0027created_at\u0027, \u0027updated_at\u0027):"},{"line_number":31,"context_line":"                self.assertTrue(hasattr(share, attribute))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        sot \u003d self.conn.shared_file_system.delete_share(shares)"},{"line_number":34,"context_line":"        self.assertIsNone(sot)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f537a95_362f7f26","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":63},"updated":"2021-06-25 20:15:02.000000000","message":"move into the for loop and delete one share at a time","commit_id":"73f6cfe4765944efc1cf9279e63c9051c3a72ca2"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b4db4031325a9b4a3e77be0a42e5cfc62f9b69bd","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        super(ShareTest, self).setUp()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        self.SHARE_NAME \u003d self.getUniqueString()"},{"line_number":23,"context_line":"        my_share \u003d self.conn.shared_file_system.create_share("},{"line_number":24,"context_line":"            name\u003dself.SHARE_NAME, size\u003d2, share_type\u003d\"dhss_false\","},{"line_number":25,"context_line":"            share_protocol\u003d\u0027NFS\u0027, description\u003dNone)"},{"line_number":26,"context_line":"        self.conn.shared_file_system.wait_for_status("}],"source_content_type":"text/x-python","patch_set":7,"id":"d110700c_3c62c889","line":23,"updated":"2021-07-12 15:47:04.000000000","message":"nit: if share creation is not a fast process it is worth optimizing and creating it only once per test. Otherwise only now 3 shares would be created and deleted.","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ec7371d712112e534fe4d21f0502c3b4a71999c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        super(ShareTest, self).setUp()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        self.SHARE_NAME \u003d self.getUniqueString()"},{"line_number":23,"context_line":"        my_share \u003d self.conn.shared_file_system.create_share("},{"line_number":24,"context_line":"            name\u003dself.SHARE_NAME, size\u003d2, share_type\u003d\"dhss_false\","},{"line_number":25,"context_line":"            share_protocol\u003d\u0027NFS\u0027, description\u003dNone)"},{"line_number":26,"context_line":"        self.conn.shared_file_system.wait_for_status("}],"source_content_type":"text/x-python","patch_set":7,"id":"a8164856_70856177","line":23,"in_reply_to":"d110700c_3c62c889","updated":"2021-07-12 16:33:18.000000000","message":"It\u0027s expected to be fast;","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b4db4031325a9b4a3e77be0a42e5cfc62f9b69bd","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_list_share(self):"},{"line_number":49,"context_line":"        shares \u003d self.conn.shared_file_system.shares()"},{"line_number":50,"context_line":"        self.assertGreater(len(list(shares)), 0)"},{"line_number":51,"context_line":"        for share in shares:"},{"line_number":52,"context_line":"            for attribute in (\u0027id\u0027, \u0027name\u0027, \u0027created_at\u0027, \u0027updated_at\u0027):"},{"line_number":53,"context_line":"                self.assertTrue(hasattr(share, attribute))"}],"source_content_type":"text/x-python","patch_set":7,"id":"71b16ab7_a40d9192","line":50,"updated":"2021-07-12 15:47:04.000000000","message":"I would suggest to trigger (without deep verification) list with details\u003dFalse","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"}],"openstack/tests/unit/cloud/test_shared_file_system.py":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"fb7b3aab75d09574b950536c72b254a425a5ff4d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from openstack.tests.unit import base"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"AZ_ID \u003d str(uuid.uuid4())"},{"line_number":17,"context_line":"MANILA_AZ_DICT \u003d {"},{"line_number":18,"context_line":"    \"id\": AZ_ID,"},{"line_number":19,"context_line":"    \"name\": \"manila-zone-0\","}],"source_content_type":"text/x-python","patch_set":4,"id":"1b3f6378_385c6acb","line":16,"updated":"2021-07-01 17:07:34.000000000","message":"you can roll back this change for now, and in another patch remove the cloud files, as they\u0027re unnecessary.","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"}],"openstack/tests/unit/shared_file_system/v2/test_proxy.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b3a09db7930a7c499c2a78264803038abc968909","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack.shared_file_system.v2 import _proxy"},{"line_number":14,"context_line":"from openstack.shared_file_system.v2 import share"},{"line_number":15,"context_line":"from openstack.tests.unit import test_proxy_base"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"520ac1d8_33662af2","line":13,"updated":"2021-07-05 15:51:32.000000000","message":"NIT this could be a single line like\n\nfrom openstack.shared_file_system.v2 import _proxy, share\n\nMore on the import syntax https://docs.python.org/3/reference/simple_stmts.html#the-import-statement","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"2c94a0e3bbe49b07120046ef0da8eb1e305143d9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack.shared_file_system.v2 import _proxy"},{"line_number":14,"context_line":"from openstack.shared_file_system.v2 import share"},{"line_number":15,"context_line":"from openstack.tests.unit import test_proxy_base"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b58423a3_60106b78","line":13,"in_reply_to":"520ac1d8_33662af2","updated":"2021-07-05 16:48:58.000000000","message":"I tried to import both on one line, but pep8 complained that I could only do one import per line.","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"374c6c49c2e3833aac2f9efca1aebf6c83b0a576","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack.shared_file_system.v2 import _proxy"},{"line_number":14,"context_line":"from openstack.shared_file_system.v2 import share"},{"line_number":15,"context_line":"from openstack.tests.unit import test_proxy_base"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"956d4dfe_a108f72d","line":13,"in_reply_to":"b58423a3_60106b78","updated":"2021-07-05 16:51:38.000000000","message":"Ah, it might be some hacking rule we have :) thanks for checking","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b4db4031325a9b4a3e77be0a42e5cfc62f9b69bd","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        super(TestSharedFileSystemProxy, self).setUp()"},{"line_number":22,"context_line":"        self.proxy \u003d _proxy.Proxy(self.session)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_shares(self):"},{"line_number":25,"context_line":"        self.verify_list(self.proxy.shares, share.Share)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_share_get(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"e600d462_02d7824f","line":24,"updated":"2021-07-12 15:47:04.000000000","message":"You function has 3 variations: no params, details\u003dTrue/False and query_params. It is definitely worth adding few corresponding tests","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b4db4031325a9b4a3e77be0a42e5cfc62f9b69bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2ed6cbe3_2568d7b4","line":43,"updated":"2021-07-12 15:47:04.000000000","message":"wait_for_status function is without test","commit_id":"ef1eb65315a9dfc1cf6d75b84c64bbfab866d9c8"}],"openstack/tests/unit/shared_file_system/v2/test_share.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b3a09db7930a7c499c2a78264803038abc968909","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        self.assertEqual(EXAMPLE[\u0027share_protocol\u0027],"},{"line_number":79,"context_line":"                         shares_resource.share_protocol)"},{"line_number":80,"context_line":"        self.assertEqual(EXAMPLE[\u0027metadata\u0027], shares_resource.metadata)"},{"line_number":81,"context_line":"        self.assertEqual(EXAMPLE[\u0027share_type\u0027], shares_resource.share_type)"},{"line_number":82,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_public\u0027], shares_resource.is_public)"},{"line_number":83,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_snapshot_supported\u0027],"},{"line_number":84,"context_line":"                         shares_resource.is_snapshot_supported)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5124e784_9f89ab16","line":81,"updated":"2021-07-05 15:51:32.000000000","message":"NIT volume_type is missing","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"2c94a0e3bbe49b07120046ef0da8eb1e305143d9","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        self.assertEqual(EXAMPLE[\u0027share_protocol\u0027],"},{"line_number":79,"context_line":"                         shares_resource.share_protocol)"},{"line_number":80,"context_line":"        self.assertEqual(EXAMPLE[\u0027metadata\u0027], shares_resource.metadata)"},{"line_number":81,"context_line":"        self.assertEqual(EXAMPLE[\u0027share_type\u0027], shares_resource.share_type)"},{"line_number":82,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_public\u0027], shares_resource.is_public)"},{"line_number":83,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_snapshot_supported\u0027],"},{"line_number":84,"context_line":"                         shares_resource.is_snapshot_supported)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f278ffc0_a96ff664","line":81,"in_reply_to":"5124e784_9f89ab16","updated":"2021-07-05 16:48:58.000000000","message":"Thanks Victoria, we decided to remove volume_type because it may be removed in future API revision.\nhttps://docs.openstack.org/api-ref/shared-file-system/?expanded\u003dcreate-share-detail#:~:text\u003din%20version%202.42-,volume_type,-body","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"374c6c49c2e3833aac2f9efca1aebf6c83b0a576","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        self.assertEqual(EXAMPLE[\u0027share_protocol\u0027],"},{"line_number":79,"context_line":"                         shares_resource.share_protocol)"},{"line_number":80,"context_line":"        self.assertEqual(EXAMPLE[\u0027metadata\u0027], shares_resource.metadata)"},{"line_number":81,"context_line":"        self.assertEqual(EXAMPLE[\u0027share_type\u0027], shares_resource.share_type)"},{"line_number":82,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_public\u0027], shares_resource.is_public)"},{"line_number":83,"context_line":"        self.assertEqual(EXAMPLE[\u0027is_snapshot_supported\u0027],"},{"line_number":84,"context_line":"                         shares_resource.is_snapshot_supported)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f607c47d_0b1d9dcc","line":81,"in_reply_to":"f278ffc0_a96ff664","updated":"2021-07-05 16:51:38.000000000","message":"Great, thanks for clarifying!","commit_id":"bca732092939b006e9194e78bb853a48dd7fc11c"}]}