)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46641f691a81163c9217f97e5c007b8261fe90d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"097f18a6_bba59c17","updated":"2021-12-14 21:59:48.000000000","message":"Hi Kafilat, could you please rebase this change?","commit_id":"35dbc75a12d781fdd18e308a477220b79d008d13"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"953e86dc10acac84e2bdbe008ba7650cb9a67c19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"91ae9db9_84de7ef4","updated":"2021-12-15 09:51:25.000000000","message":"Thanks Goutham!","commit_id":"9b909aca53cb01c811f6d03ef4b17407ec60d8bb"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"506c7e91ee4d23006aa0c743f2c7beca1c9551d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e6738a34_2465f437","updated":"2022-03-04 20:00:21.000000000","message":"recheck","commit_id":"9b909aca53cb01c811f6d03ef4b17407ec60d8bb"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"1a09172639f0576fd302477037884402e3c49b22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d7a81fa3_99008e24","updated":"2022-04-29 13:52:01.000000000","message":"recheck functional test fail","commit_id":"9b909aca53cb01c811f6d03ef4b17407ec60d8bb"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"b7c2c54607b258fa6f34fd0cf527e899d7f8a515","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f3a4ac54_cfb90b41","updated":"2022-04-28 15:37:32.000000000","message":"recheck old logs","commit_id":"9b909aca53cb01c811f6d03ef4b17407ec60d8bb"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"c7a598bd01e2509cf4bf017c1de35c9397861d30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7f802fe9_9cdfe791","updated":"2022-05-02 17:32:48.000000000","message":"failing functional test for manila","commit_id":"c1e6a2d79b549f4881b8c712a881dc04434e6b4b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5c1d7703f8b45e917be815813c48f23c40cc1015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"34d89f33_81bd901c","updated":"2023-02-13 20:14:06.000000000","message":"proposed new patch on master,\nhttps://review.opendev.org/c/openstack/openstacksdk/+/798464","commit_id":"a63d2b9e68a0a618c72550a71c3a0dff40fe2851"}],"openstack/shared_file_system/v2/share_snapshot_instance.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4e5d72ec9899fbb8720498c07ade79146dd0bd8f","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    allow_delete \u003d False"},{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":"    allow_head \u003d False"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    #: The date and time stamp when the resource was created within the"},{"line_number":31,"context_line":"    #: service’s database."}],"source_content_type":"text/x-python","patch_set":2,"id":"73b2c4bf_12dc4731","line":28,"updated":"2021-09-01 07:50:50.000000000","message":"you need to set _max_microversion\u003d2.19, otherwise this will not work at all, since resource added with 2.19","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"b2ac7ee5bf6959d4286a603d7f9a3d37d485855c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    allow_delete \u003d False"},{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":"    allow_head \u003d False"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    #: The date and time stamp when the resource was created within the"},{"line_number":31,"context_line":"    #: service’s database."}],"source_content_type":"text/x-python","patch_set":2,"id":"de46dc42_4288d49f","line":28,"in_reply_to":"73b2c4bf_12dc4731","updated":"2021-09-01 11:50:48.000000000","message":"Done","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4e5d72ec9899fbb8720498c07ade79146dd0bd8f","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":"    allow_head \u003d False"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    #: The date and time stamp when the resource was created within the"},{"line_number":31,"context_line":"    #: service’s database."},{"line_number":32,"context_line":"    created_at \u003d resource.Body(\"created_at\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ec614eba_a61c1db3","line":29,"updated":"2021-09-01 07:50:50.000000000","message":"also snapshot_id as query parameter is missing","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"b2ac7ee5bf6959d4286a603d7f9a3d37d485855c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_list \u003d True"},{"line_number":27,"context_line":"    allow_head \u003d False"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    #: The date and time stamp when the resource was created within the"},{"line_number":31,"context_line":"    #: service’s database."},{"line_number":32,"context_line":"    created_at \u003d resource.Body(\"created_at\", type\u003dstr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"87486bb4_146d3e12","line":29,"in_reply_to":"ec614eba_a61c1db3","updated":"2021-09-01 11:50:48.000000000","message":"Done","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4e5d72ec9899fbb8720498c07ade79146dd0bd8f","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    #: The date and time stamp when the resource was created within the"},{"line_number":31,"context_line":"    #: service’s database."},{"line_number":32,"context_line":"    created_at \u003d resource.Body(\"created_at\", type\u003dstr)"},{"line_number":33,"context_line":"    #: The progress of the snapshot creation."},{"line_number":34,"context_line":"    progress \u003d resource.Body(\"progress\", type\u003dstr)"},{"line_number":35,"context_line":"    #: Provider location of the snapshot on the backend."}],"source_content_type":"text/x-python","patch_set":2,"id":"07c2914c_6b517e29","line":32,"updated":"2021-09-01 07:50:50.000000000","message":"you do not need to explicitly define `type\u003dstr` - this is default","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"b2ac7ee5bf6959d4286a603d7f9a3d37d485855c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    #: The date and time stamp when the resource was created within the"},{"line_number":31,"context_line":"    #: service’s database."},{"line_number":32,"context_line":"    created_at \u003d resource.Body(\"created_at\", type\u003dstr)"},{"line_number":33,"context_line":"    #: The progress of the snapshot creation."},{"line_number":34,"context_line":"    progress \u003d resource.Body(\"progress\", type\u003dstr)"},{"line_number":35,"context_line":"    #: Provider location of the snapshot on the backend."}],"source_content_type":"text/x-python","patch_set":2,"id":"1c86b89b_0961b2ba","line":32,"in_reply_to":"07c2914c_6b517e29","updated":"2021-09-01 11:50:48.000000000","message":"Ack","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"}],"openstack/tests/functional/shared_file_system/test_share_snapshot_instance.py":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"7b9a3da02687d216e0f43373acece74b6acb8bca","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class ShareSnapshotInstanceTest(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_share_snapshot_instances(self):"},{"line_number":19,"context_line":"        sots \u003d self.conn.shared_file_system.share_snapshot_instances()"},{"line_number":20,"context_line":"        self.assertGreater(len(list(sots)), 0)"},{"line_number":21,"context_line":"        for sot in sots:"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa1d81f7_f1001391","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":37},"updated":"2021-07-20 16:21:47.000000000","message":"test list and get methods","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"b2ac7ee5bf6959d4286a603d7f9a3d37d485855c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class ShareSnapshotInstanceTest(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_share_snapshot_instances(self):"},{"line_number":19,"context_line":"        sots \u003d self.conn.shared_file_system.share_snapshot_instances()"},{"line_number":20,"context_line":"        self.assertGreater(len(list(sots)), 0)"},{"line_number":21,"context_line":"        for sot in sots:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a8f0dabd_abba0656","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":37},"in_reply_to":"6a275553_3810a51f","updated":"2021-09-01 11:50:48.000000000","message":"Done","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4e5d72ec9899fbb8720498c07ade79146dd0bd8f","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class ShareSnapshotInstanceTest(base.BaseSharedFileSystemTest):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def test_share_snapshot_instances(self):"},{"line_number":19,"context_line":"        sots \u003d self.conn.shared_file_system.share_snapshot_instances()"},{"line_number":20,"context_line":"        self.assertGreater(len(list(sots)), 0)"},{"line_number":21,"context_line":"        for sot in sots:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a275553_3810a51f","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":37},"in_reply_to":"aa1d81f7_f1001391","updated":"2021-09-01 07:50:50.000000000","message":"if there are no ways to enforce presence of the snapshot_instance (create missing) - there is no way to verify get. What you can do is following:\n- loop through the `list` of entities\n- for every entity execute `get`","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7c13827bc36f5819b548ada6eceda11cd2312121","unresolved":true,"context_lines":[{"line_number":19,"context_line":"class ShareSnapshotInstanceTest(base.BaseSharedFileSystemTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_share_snapshot_instances(self):"},{"line_number":22,"context_line":"        sis \u003d self.operator_cloud.shared_file_system.share_snapshot_instances()"},{"line_number":23,"context_line":"        self.assertGreater(len(list(sis)), 0)"},{"line_number":24,"context_line":"        for si in sis:"},{"line_number":25,"context_line":"            for attribute in (\u0027id\u0027, \u0027name\u0027, \u0027created_at\u0027, \u0027updated_at\u0027):"},{"line_number":26,"context_line":"                self.assertTrue(hasattr(si, attribute))"}],"source_content_type":"text/x-python","patch_set":3,"id":"53ecfd2c_9ed49ffd","line":23,"range":{"start_line":22,"start_character":8,"end_line":23,"end_character":45},"updated":"2021-09-01 16:45:52.000000000","message":"You need to create a snapshot for snapshot instances to exist.","commit_id":"27f3bd0c78213deeb525245773fbf158b3c89d1e"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"1c647b16eadc84c4601787adf7d1323b34da33cf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class ShareSnapshotInstanceTest(base.BaseSharedFileSystemTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_share_snapshot_instances(self):"},{"line_number":22,"context_line":"        sis \u003d self.operator_cloud.shared_file_system.share_snapshot_instances()"},{"line_number":23,"context_line":"        self.assertGreater(len(list(sis)), 0)"},{"line_number":24,"context_line":"        for si in sis:"},{"line_number":25,"context_line":"            for attribute in (\u0027id\u0027, \u0027name\u0027, \u0027created_at\u0027, \u0027updated_at\u0027):"},{"line_number":26,"context_line":"                self.assertTrue(hasattr(si, attribute))"}],"source_content_type":"text/x-python","patch_set":3,"id":"6efcb49b_cdb97452","line":23,"range":{"start_line":22,"start_character":8,"end_line":23,"end_character":45},"in_reply_to":"53ecfd2c_9ed49ffd","updated":"2022-05-12 20:21:06.000000000","message":"Done","commit_id":"27f3bd0c78213deeb525245773fbf158b3c89d1e"}],"openstack/tests/unit/shared_file_system/v2/test_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4e5d72ec9899fbb8720498c07ade79146dd0bd8f","unresolved":true,"context_lines":[{"line_number":70,"context_line":"            share_snapshot_instance.ShareSnapshotInstance)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_share_snapshot_instance_detailed(self):"},{"line_number":73,"context_line":"        self.verify_list(self.proxy.share_snapshot_instances,"},{"line_number":74,"context_line":"                         share_snapshot_instance.ShareSnapshotInstance,"},{"line_number":75,"context_line":"                         method_kwargs\u003d{\"details\": True, \"query\": 1},"},{"line_number":76,"context_line":"                         expected_kwargs\u003d{\"query\": 1})"}],"source_content_type":"text/x-python","patch_set":2,"id":"a862f8db_26d8a3c7","line":73,"updated":"2021-09-01 07:50:50.000000000","message":"can you please break the line here to have smaller identation?","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"b2ac7ee5bf6959d4286a603d7f9a3d37d485855c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            share_snapshot_instance.ShareSnapshotInstance)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_share_snapshot_instance_detailed(self):"},{"line_number":73,"context_line":"        self.verify_list(self.proxy.share_snapshot_instances,"},{"line_number":74,"context_line":"                         share_snapshot_instance.ShareSnapshotInstance,"},{"line_number":75,"context_line":"                         method_kwargs\u003d{\"details\": True, \"query\": 1},"},{"line_number":76,"context_line":"                         expected_kwargs\u003d{\"query\": 1})"}],"source_content_type":"text/x-python","patch_set":2,"id":"11b2e1b6_52168dce","line":73,"in_reply_to":"a862f8db_26d8a3c7","updated":"2021-09-01 11:50:48.000000000","message":"Done","commit_id":"98cdc086e67cf3edc20c8fce4db6b534a1b03d3c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"46641f691a81163c9217f97e5c007b8261fe90d3","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        self.verify_list("},{"line_number":169,"context_line":"            self.proxy.share_snapshot_instances,"},{"line_number":170,"context_line":"            share_snapshot_instance.ShareSnapshotInstance,"},{"line_number":171,"context_line":"            method_kwargs\u003d{\"details\": True, \"query\": 1},"},{"line_number":172,"context_line":"            expected_kwargs\u003d{\"query\": 1})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_share_snapshot_instance_not_detailed(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb19ee68_27c8afcf","line":171,"range":{"start_line":171,"start_character":53,"end_line":171,"end_character":54},"updated":"2021-12-14 21:59:48.000000000","message":"use a real query","commit_id":"35dbc75a12d781fdd18e308a477220b79d008d13"},{"author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"change_message_id":"953e86dc10acac84e2bdbe008ba7650cb9a67c19","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        self.verify_list("},{"line_number":169,"context_line":"            self.proxy.share_snapshot_instances,"},{"line_number":170,"context_line":"            share_snapshot_instance.ShareSnapshotInstance,"},{"line_number":171,"context_line":"            method_kwargs\u003d{\"details\": True, \"query\": 1},"},{"line_number":172,"context_line":"            expected_kwargs\u003d{\"query\": 1})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_share_snapshot_instance_not_detailed(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"28f148ab_e43c0275","line":171,"range":{"start_line":171,"start_character":53,"end_line":171,"end_character":54},"in_reply_to":"bb19ee68_27c8afcf","updated":"2021-12-15 09:51:25.000000000","message":"Done","commit_id":"35dbc75a12d781fdd18e308a477220b79d008d13"}]}
