)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c48ea8ec8b75a62ae8a8912c012f36a897433ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91b67818_718c42af","updated":"2021-12-10 09:04:24.000000000","message":"The changes in code seem all wrong or some at least questionable, maybe restrict to only changing comments for now?","commit_id":"b74f6f3ccdeace7b5a86a9177633ad68dfcb8a71"}],"openstack/network/v2/_proxy.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c48ea8ec8b75a62ae8a8912c012f36a897433ec","unresolved":true,"context_lines":[{"line_number":435,"context_line":"        # If project option is not given, grab project id from session"},{"line_number":436,"context_line":"        if project is None:"},{"line_number":437,"context_line":"            project \u003d self.get_project_id()"},{"line_number":438,"context_line":"            self._delete(_auto_allocated_topology.AutoAllocatedTopology,"},{"line_number":439,"context_line":"                         project, ignore_missing\u003dignore_missing)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def validate_auto_allocated_topology(self, project\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"65b09725_7dd89582","line":438,"updated":"2021-12-10 09:04:24.000000000","message":"This looks wrong to me. The _delete needs to be executed unconditionally.","commit_id":"b74f6f3ccdeace7b5a86a9177633ad68dfcb8a71"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c48ea8ec8b75a62ae8a8912c012f36a897433ec","unresolved":true,"context_lines":[{"line_number":3127,"context_line":"            body \u003d {\u0027port_id\u0027: port_id}"},{"line_number":3128,"context_line":"        else:"},{"line_number":3129,"context_line":"            body \u003d {\u0027subnet_id\u0027: subnet_id}"},{"line_number":3130,"context_line":"            router \u003d self._get_resource(_router.Router, router)"},{"line_number":3131,"context_line":"        return router.add_interface(self, **body)"},{"line_number":3132,"context_line":""},{"line_number":3133,"context_line":"    def remove_interface_from_router(self, router, subnet_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8eea99e3_486ee58e","line":3130,"updated":"2021-12-10 09:04:24.000000000","message":"Also wrong","commit_id":"b74f6f3ccdeace7b5a86a9177633ad68dfcb8a71"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c48ea8ec8b75a62ae8a8912c012f36a897433ec","unresolved":true,"context_lines":[{"line_number":3147,"context_line":"            body \u003d {\u0027port_id\u0027: port_id}"},{"line_number":3148,"context_line":"        else:"},{"line_number":3149,"context_line":"            body \u003d {\u0027subnet_id\u0027: subnet_id}"},{"line_number":3150,"context_line":"            router \u003d self._get_resource(_router.Router, router)"},{"line_number":3151,"context_line":"        return router.remove_interface(self, **body)"},{"line_number":3152,"context_line":""},{"line_number":3153,"context_line":"    def add_extra_routes_to_router(self, router, body):"}],"source_content_type":"text/x-python","patch_set":2,"id":"8679ed1c_fbce5e5e","line":3150,"updated":"2021-12-10 09:04:24.000000000","message":"dito","commit_id":"b74f6f3ccdeace7b5a86a9177633ad68dfcb8a71"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c48ea8ec8b75a62ae8a8912c012f36a897433ec","unresolved":true,"context_lines":[{"line_number":4665,"context_line":"            for port in self.ports("},{"line_number":4666,"context_line":"                    project_id\u003dproject_id,"},{"line_number":4667,"context_line":"                    network_id\u003dnet.id"},{"line_number":4668,"context_line":"            ):"},{"line_number":4669,"context_line":"                self.log.debug(\u0027Looking at port %s\u0027 % port)"},{"line_number":4670,"context_line":"                if port.device_owner in ["},{"line_number":4671,"context_line":"                        \u0027network:router_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb7910d3_4c402dc4","line":4668,"updated":"2021-12-10 09:04:24.000000000","message":"While this doesn\u0027t break the code, I think the convention still is to do 4 spaces of indent in this situation, why is that changed?","commit_id":"b74f6f3ccdeace7b5a86a9177633ad68dfcb8a71"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c48ea8ec8b75a62ae8a8912c012f36a897433ec","unresolved":true,"context_lines":[{"line_number":4710,"context_line":"                            port_id\u003dport.id)"},{"line_number":4711,"context_line":"                    except exceptions.SDKException:"},{"line_number":4712,"context_line":"                        self.log.error(\u0027Cannot delete object %s\u0027 % obj)"},{"line_number":4713,"context_line":"                        # router disconnected, drop it"},{"line_number":4714,"context_line":"                self._service_cleanup_del_res("},{"line_number":4715,"context_line":"                    self.delete_router,"},{"line_number":4716,"context_line":"                    self.get_router(port.device_id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"6676ec9f_718903fc","line":4713,"updated":"2021-12-10 09:04:24.000000000","message":"Also wrong/misleading. I your autoformatting does this, try inserting an empty line above","commit_id":"b74f6f3ccdeace7b5a86a9177633ad68dfcb8a71"}]}