)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7567493c0173faf76d77f5dbece7ce3224934f60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52091844_b6dd538f","updated":"2021-12-15 05:49:38.000000000","message":"In addition to getting a releasenote, I think we would also need to have some functional test added on the new volume-swap functionality.","commit_id":"53e802fb3f2da5ce3f0ec1c8f71bd56d637ae9b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ccbf4cbf118c58112e21a2e3072a5d08b8d65b2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3e188a69_e57073a5","updated":"2022-09-28 13:06:08.000000000","message":"@frickler I think I\u0027ve address your concerns.","commit_id":"e792f249e1480d82546516d6f7e833d7545b2c5f"}],"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7567493c0173faf76d77f5dbece7ce3224934f60","unresolved":true,"context_lines":[{"line_number":1592,"context_line":"    ):"},{"line_number":1593,"context_line":"        \"\"\"update a volume attachment"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"        :param volume_attachment:"},{"line_number":1596,"context_line":"            The value can be either the ID of a volume attachment or a"},{"line_number":1597,"context_line":"            :class:`~openstack.compute.v2.volume_attachment.VolumeAttachment`"},{"line_number":1598,"context_line":"            instance."},{"line_number":1599,"context_line":"        :param server: This parameter need to be specified when"},{"line_number":1600,"context_line":"            VolumeAttachment ID is given as value. It can be either the ID of a"},{"line_number":1601,"context_line":"            server or a :class:`~openstack.compute.v2.server.Server` instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"164de373_6302bf21","line":1598,"range":{"start_line":1595,"start_character":8,"end_line":1598,"end_character":21},"updated":"2021-12-15 05:49:38.000000000","message":"IIUC this is wrong. The parameter actually needs to be a volume ID, because that is what the Nova API expects.","commit_id":"53e802fb3f2da5ce3f0ec1c8f71bd56d637ae9b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2f68aa6c91bda45200143270b80c7b93eccfc17","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"    ):"},{"line_number":1593,"context_line":"        \"\"\"update a volume attachment"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"        :param volume_attachment:"},{"line_number":1596,"context_line":"            The value can be either the ID of a volume attachment or a"},{"line_number":1597,"context_line":"            :class:`~openstack.compute.v2.volume_attachment.VolumeAttachment`"},{"line_number":1598,"context_line":"            instance."},{"line_number":1599,"context_line":"        :param server: This parameter need to be specified when"},{"line_number":1600,"context_line":"            VolumeAttachment ID is given as value. It can be either the ID of a"},{"line_number":1601,"context_line":"            server or a :class:`~openstack.compute.v2.server.Server` instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"f4e28797_c1533556","line":1598,"range":{"start_line":1595,"start_character":8,"end_line":1598,"end_character":21},"in_reply_to":"164de373_6302bf21","updated":"2021-12-20 13:00:12.000000000","message":"Done","commit_id":"53e802fb3f2da5ce3f0ec1c8f71bd56d637ae9b9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7567493c0173faf76d77f5dbece7ce3224934f60","unresolved":true,"context_lines":[{"line_number":1597,"context_line":"            :class:`~openstack.compute.v2.volume_attachment.VolumeAttachment`"},{"line_number":1598,"context_line":"            instance."},{"line_number":1599,"context_line":"        :param server: This parameter need to be specified when"},{"line_number":1600,"context_line":"            VolumeAttachment ID is given as value. It can be either the ID of a"},{"line_number":1601,"context_line":"            server or a :class:`~openstack.compute.v2.server.Server` instance"},{"line_number":1602,"context_line":"            that the attachment belongs to."},{"line_number":1603,"context_line":"        :param volume_id: The ID of a volume to swap to. If this is not"}],"source_content_type":"text/x-python","patch_set":1,"id":"a05eca75_0ffd4176","line":1600,"updated":"2021-12-15 05:49:38.000000000","message":"The first sentence is still wrong, the parameter is mandatory under all circumstances.","commit_id":"53e802fb3f2da5ce3f0ec1c8f71bd56d637ae9b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2f68aa6c91bda45200143270b80c7b93eccfc17","unresolved":false,"context_lines":[{"line_number":1597,"context_line":"            :class:`~openstack.compute.v2.volume_attachment.VolumeAttachment`"},{"line_number":1598,"context_line":"            instance."},{"line_number":1599,"context_line":"        :param server: This parameter need to be specified when"},{"line_number":1600,"context_line":"            VolumeAttachment ID is given as value. It can be either the ID of a"},{"line_number":1601,"context_line":"            server or a :class:`~openstack.compute.v2.server.Server` instance"},{"line_number":1602,"context_line":"            that the attachment belongs to."},{"line_number":1603,"context_line":"        :param volume_id: The ID of a volume to swap to. If this is not"}],"source_content_type":"text/x-python","patch_set":1,"id":"86fa78a8_a7b8d66b","line":1600,"in_reply_to":"a05eca75_0ffd4176","updated":"2021-12-20 13:00:12.000000000","message":"Done","commit_id":"53e802fb3f2da5ce3f0ec1c8f71bd56d637ae9b9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89fe1d976bb6110302df927a3026602ddb9a9f17","unresolved":true,"context_lines":[{"line_number":1596,"context_line":"        )"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    def update_volume_attachment("},{"line_number":1599,"context_line":"        self, server, volume, volume_id\u003dNone, **attrs,"},{"line_number":1600,"context_line":"    ):"},{"line_number":1601,"context_line":"        \"\"\"Update a volume attachment"},{"line_number":1602,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8bd6428f_5ecf977c","line":1599,"updated":"2021-12-21 17:54:48.000000000","message":"I like the idea of making this consistent with the create call and also with the way the Nova API is built, but I wonder if this is too breaking a change. A less intrusive option might be to add a new function and keep the old one forwarding to it, and just deprecate it.","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ccbf4cbf118c58112e21a2e3072a5d08b8d65b2b","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        )"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    def update_volume_attachment("},{"line_number":1599,"context_line":"        self, server, volume, volume_id\u003dNone, **attrs,"},{"line_number":1600,"context_line":"    ):"},{"line_number":1601,"context_line":"        \"\"\"Update a volume attachment"},{"line_number":1602,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ed7671ae_1f0f2936","line":1599,"in_reply_to":"4741a76b_e589c4e0","updated":"2022-09-28 13:06:08.000000000","message":"Renoed away. As noted in the commit message, this wasn\u0027t actually usable until now.","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8411fe40bf81869fee358c6714b9fd29ec988022","unresolved":true,"context_lines":[{"line_number":1596,"context_line":"        )"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    def update_volume_attachment("},{"line_number":1599,"context_line":"        self, server, volume, volume_id\u003dNone, **attrs,"},{"line_number":1600,"context_line":"    ):"},{"line_number":1601,"context_line":"        \"\"\"Update a volume attachment"},{"line_number":1602,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4741a76b_e589c4e0","line":1599,"in_reply_to":"8bd6428f_5ecf977c","updated":"2022-09-07 15:57:52.000000000","message":"Thankfully no one is using this (probably because it\u0027s so badly broken in its current guise). Can we reno this issue away?","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89fe1d976bb6110302df927a3026602ddb9a9f17","unresolved":true,"context_lines":[{"line_number":1609,"context_line":"            volume is attached to."},{"line_number":1610,"context_line":"        :param volume: The value can be either the ID of a volume or a"},{"line_number":1611,"context_line":"            :class:`~openstack.block_storage.v3.volume.Volume` instance."},{"line_number":1612,"context_line":"        :param volume_id: The ID of a volume to swap to. If this is not"},{"line_number":1613,"context_line":"            specified, we will default to not swapping the volume."},{"line_number":1614,"context_line":"        :param attrs: The attributes to update on the volume attachment"},{"line_number":1615,"context_line":"            represented by ``volume_attachment``."}],"source_content_type":"text/x-python","patch_set":4,"id":"078e4f16_8203f136","line":1612,"updated":"2021-12-21 17:54:48.000000000","message":"If we are doing such a breaking change already, maybe name this parameter new_volume_id here, too? Or maybe even just new_volume with the option to pass either an ID or a volume object like for the other volume parameters? Would seem more consistent.","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8411fe40bf81869fee358c6714b9fd29ec988022","unresolved":true,"context_lines":[{"line_number":1609,"context_line":"            volume is attached to."},{"line_number":1610,"context_line":"        :param volume: The value can be either the ID of a volume or a"},{"line_number":1611,"context_line":"            :class:`~openstack.block_storage.v3.volume.Volume` instance."},{"line_number":1612,"context_line":"        :param volume_id: The ID of a volume to swap to. If this is not"},{"line_number":1613,"context_line":"            specified, we will default to not swapping the volume."},{"line_number":1614,"context_line":"        :param attrs: The attributes to update on the volume attachment"},{"line_number":1615,"context_line":"            represented by ``volume_attachment``."}],"source_content_type":"text/x-python","patch_set":4,"id":"418a65d7_6d699986","line":1612,"in_reply_to":"078e4f16_8203f136","updated":"2022-09-07 15:57:52.000000000","message":"I\u0027m not even sure if we should expose this. From the nova API ref [1]:\n\n  When updating volumeId, this API is typically meant to only be used as part of\n  a larger orchestrated volume migration operation initiated in the block storage\n  service via the os-retype or os-migrate_volume volume actions. Direct usage of\n  this API to update volumeId is not recommended and may result in needing to\n  hard reboot the server to update details within the guest such as block storage\n  serial IDs. Furthermore, updating volumeId via this API is only implemented by\n  certain compute drivers.\n\nI made a conscious effort *not* to support this when adding support for volume attachment to OSC. Perhaps we should do the same here or at least expose it as a separate method with a big fat warning that you don\u0027t want to use this. Thoughts?\n\n[1] https://docs.openstack.org/api-ref/compute/?expanded\u003dupdate-a-volume-attachment-detail#update-a-volume-attachment","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ccbf4cbf118c58112e21a2e3072a5d08b8d65b2b","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"            volume is attached to."},{"line_number":1610,"context_line":"        :param volume: The value can be either the ID of a volume or a"},{"line_number":1611,"context_line":"            :class:`~openstack.block_storage.v3.volume.Volume` instance."},{"line_number":1612,"context_line":"        :param volume_id: The ID of a volume to swap to. If this is not"},{"line_number":1613,"context_line":"            specified, we will default to not swapping the volume."},{"line_number":1614,"context_line":"        :param attrs: The attributes to update on the volume attachment"},{"line_number":1615,"context_line":"            represented by ``volume_attachment``."}],"source_content_type":"text/x-python","patch_set":4,"id":"dad76933_ae41d891","line":1612,"in_reply_to":"418a65d7_6d699986","updated":"2022-09-28 13:06:08.000000000","message":"I decided to keep this since there\u0027s a chance cinder or others might want to use openstacksdk instead of novaclient down the line. Also, as noted above, nothing could use this before now so we don\u0027t need to worry about breaking people.","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89fe1d976bb6110302df927a3026602ddb9a9f17","unresolved":true,"context_lines":[{"line_number":1632,"context_line":"            **attrs,"},{"line_number":1633,"context_line":"        )"},{"line_number":1634,"context_line":""},{"line_number":1635,"context_line":"    def delete_volume_attachment(self, server, volume, ignore_missing\u003dTrue):"},{"line_number":1636,"context_line":"        \"\"\"Delete a volume attachment"},{"line_number":1637,"context_line":""},{"line_number":1638,"context_line":"        Note that the underlying API expects a volume ID, not a volume"}],"source_content_type":"text/x-python","patch_set":4,"id":"e45ebb5a_0586007d","line":1635,"updated":"2021-12-21 17:54:48.000000000","message":"Same argument about changing the signature here","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ccbf4cbf118c58112e21a2e3072a5d08b8d65b2b","unresolved":false,"context_lines":[{"line_number":1632,"context_line":"            **attrs,"},{"line_number":1633,"context_line":"        )"},{"line_number":1634,"context_line":""},{"line_number":1635,"context_line":"    def delete_volume_attachment(self, server, volume, ignore_missing\u003dTrue):"},{"line_number":1636,"context_line":"        \"\"\"Delete a volume attachment"},{"line_number":1637,"context_line":""},{"line_number":1638,"context_line":"        Note that the underlying API expects a volume ID, not a volume"}],"source_content_type":"text/x-python","patch_set":4,"id":"0079b8d2_6d808bac","line":1635,"in_reply_to":"e1ad4234_e9a44f47","updated":"2022-09-28 13:06:08.000000000","message":"I added this logic along with tests for same.","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8411fe40bf81869fee358c6714b9fd29ec988022","unresolved":true,"context_lines":[{"line_number":1632,"context_line":"            **attrs,"},{"line_number":1633,"context_line":"        )"},{"line_number":1634,"context_line":""},{"line_number":1635,"context_line":"    def delete_volume_attachment(self, server, volume, ignore_missing\u003dTrue):"},{"line_number":1636,"context_line":"        \"\"\"Delete a volume attachment"},{"line_number":1637,"context_line":""},{"line_number":1638,"context_line":"        Note that the underlying API expects a volume ID, not a volume"}],"source_content_type":"text/x-python","patch_set":4,"id":"e1ad4234_e9a44f47","line":1635,"in_reply_to":"e45ebb5a_0586007d","updated":"2022-09-07 15:57:52.000000000","message":"This one matters more since I stupidly decided to use it in OSC [1] even though it\u0027s pretty broken as-is. How about I try to retrieve a server corresponding to \u0027server\u0027 and switch the volume and server arguments if it\u0027s not a valid server? It\u0027s a bit of hack, but it would avoid a second method and give us a short while to switch OSC across.\n\n[1] https://opendev.org/openstack/python-openstackclient/src/commit/7df94c9f821aa7fabef09cad9e6ab16ed66d46b6/openstackclient/compute/v2/server.py#L3558","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89fe1d976bb6110302df927a3026602ddb9a9f17","unresolved":true,"context_lines":[{"line_number":1702,"context_line":"        \"\"\""},{"line_number":1703,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":1704,"context_line":"        return self._list("},{"line_number":1705,"context_line":"            _volume_attachment.VolumeAttachment,"},{"line_number":1706,"context_line":"            server_id\u003dserver_id,"},{"line_number":1707,"context_line":"        )"},{"line_number":1708,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"60a51099_19330d9e","line":1705,"updated":"2021-12-21 17:54:48.000000000","message":"Wouldn\u0027t you need to pass **query here, too?","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8411fe40bf81869fee358c6714b9fd29ec988022","unresolved":false,"context_lines":[{"line_number":1702,"context_line":"        \"\"\""},{"line_number":1703,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":1704,"context_line":"        return self._list("},{"line_number":1705,"context_line":"            _volume_attachment.VolumeAttachment,"},{"line_number":1706,"context_line":"            server_id\u003dserver_id,"},{"line_number":1707,"context_line":"        )"},{"line_number":1708,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2b29c2c3_8c1b7ec3","line":1705,"in_reply_to":"60a51099_19330d9e","updated":"2022-09-07 15:57:52.000000000","message":"Good point. Done.","commit_id":"bc127fb8aeae937ec5680dd741a1cfe47d39be0a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"77950358246afa75239750ac2eec2ceef7201f2f","unresolved":true,"context_lines":[{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Volume Attachments \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"    # TODO(stephenfin): Make the volume argument required in 1.0"},{"line_number":1564,"context_line":"    def create_volume_attachment(self, server, volume\u003dNone, **attrs):"},{"line_number":1565,"context_line":"        \"\"\"Create a new volume attachment from attributes"},{"line_number":1566,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"f1820006_d389ac5f","line":1563,"range":{"start_line":1563,"start_character":61,"end_line":1563,"end_character":64},"updated":"2022-10-08 11:36:30.000000000","message":"In 2.0?","commit_id":"b6d889c68bac6b16ab991ad3a2cae8bed8bb4dc6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f21e523a3a45577afcec01950fc3fa1cf90e53e2","unresolved":false,"context_lines":[{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Volume Attachments \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"    # TODO(stephenfin): Make the volume argument required in 1.0"},{"line_number":1564,"context_line":"    def create_volume_attachment(self, server, volume\u003dNone, **attrs):"},{"line_number":1565,"context_line":"        \"\"\"Create a new volume attachment from attributes"},{"line_number":1566,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"74d7a0d6_e8084a16","line":1563,"range":{"start_line":1563,"start_character":61,"end_line":1563,"end_character":64},"in_reply_to":"f1820006_d389ac5f","updated":"2022-10-11 15:23:13.000000000","message":"Whoops, yeah","commit_id":"b6d889c68bac6b16ab991ad3a2cae8bed8bb4dc6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"77950358246afa75239750ac2eec2ceef7201f2f","unresolved":true,"context_lines":[{"line_number":1588,"context_line":"            elif \u0027volumeId\u0027 in attrs:"},{"line_number":1589,"context_line":"                volume_id \u003d attrs.pop(\u0027volumeId\u0027)"},{"line_number":1590,"context_line":"            else:"},{"line_number":1591,"context_line":"                # the user hasn\u0027t use the new way *or* the old way so they"},{"line_number":1592,"context_line":"                # should start using the new way"},{"line_number":1593,"context_line":"                # NOTE(stephenfin): we intentionally mimic the behavior of a"},{"line_number":1594,"context_line":"                # missing positional parameter in stdlib"}],"source_content_type":"text/x-python","patch_set":8,"id":"30edf1fb_49f1d7f4","line":1591,"updated":"2022-10-08 11:36:30.000000000","message":"I\u0027m not a native speaker, but I\u0027d suggest:\n\nthe user has used neither the new way nor the old way ...","commit_id":"b6d889c68bac6b16ab991ad3a2cae8bed8bb4dc6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f21e523a3a45577afcec01950fc3fa1cf90e53e2","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"            elif \u0027volumeId\u0027 in attrs:"},{"line_number":1589,"context_line":"                volume_id \u003d attrs.pop(\u0027volumeId\u0027)"},{"line_number":1590,"context_line":"            else:"},{"line_number":1591,"context_line":"                # the user hasn\u0027t use the new way *or* the old way so they"},{"line_number":1592,"context_line":"                # should start using the new way"},{"line_number":1593,"context_line":"                # NOTE(stephenfin): we intentionally mimic the behavior of a"},{"line_number":1594,"context_line":"                # missing positional parameter in stdlib"}],"source_content_type":"text/x-python","patch_set":8,"id":"f136ce57_0ffc5e65","line":1591,"in_reply_to":"30edf1fb_49f1d7f4","updated":"2022-10-11 15:23:13.000000000","message":"Done","commit_id":"b6d889c68bac6b16ab991ad3a2cae8bed8bb4dc6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"77950358246afa75239750ac2eec2ceef7201f2f","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"        :returns: ``None``"},{"line_number":1640,"context_line":"        \"\"\""},{"line_number":1641,"context_line":"        new_volume_id \u003d volume_id"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":1644,"context_line":"        volume_id \u003d resource.Resource._get_id(volume)"},{"line_number":1645,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"389792d1_08e93eaa","line":1642,"updated":"2022-10-08 11:36:30.000000000","message":"Even if there is no current user, it shouldn\u0027t hurt to also use _verify_server_volume_args() here, too? Would make this change more consistent.","commit_id":"b6d889c68bac6b16ab991ad3a2cae8bed8bb4dc6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f21e523a3a45577afcec01950fc3fa1cf90e53e2","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"        :returns: ``None``"},{"line_number":1640,"context_line":"        \"\"\""},{"line_number":1641,"context_line":"        new_volume_id \u003d volume_id"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":1644,"context_line":"        volume_id \u003d resource.Resource._get_id(volume)"},{"line_number":1645,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c092a43a_0fe0e9f7","line":1642,"in_reply_to":"389792d1_08e93eaa","updated":"2022-10-11 15:23:13.000000000","message":"The check to determine whether we switch these isn\u0027t free as it requires an additional API call. Given this proxy method never actually worked before now (due to \u0027allow_commit\u0027 being set to \u0027False\u0027 on the resource - see commit message), I\u0027d rather be inconsistent as faster 😄","commit_id":"b6d889c68bac6b16ab991ad3a2cae8bed8bb4dc6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"77950358246afa75239750ac2eec2ceef7201f2f","unresolved":true,"context_lines":[{"line_number":1738,"context_line":"            when no resource can be found."},{"line_number":1739,"context_line":"        \"\"\""},{"line_number":1740,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":1741,"context_line":"        volume_id \u003d resource.Resource._get_id(volume)"},{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        return self._get("},{"line_number":1744,"context_line":"            _volume_attachment.VolumeAttachment,"}],"source_content_type":"text/x-python","patch_set":8,"id":"42dbb862_9218908e","line":1741,"updated":"2022-10-08 11:36:30.000000000","message":"same here?","commit_id":"b6d889c68bac6b16ab991ad3a2cae8bed8bb4dc6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f21e523a3a45577afcec01950fc3fa1cf90e53e2","unresolved":false,"context_lines":[{"line_number":1738,"context_line":"            when no resource can be found."},{"line_number":1739,"context_line":"        \"\"\""},{"line_number":1740,"context_line":"        server_id \u003d resource.Resource._get_id(server)"},{"line_number":1741,"context_line":"        volume_id \u003d resource.Resource._get_id(volume)"},{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"        return self._get("},{"line_number":1744,"context_line":"            _volume_attachment.VolumeAttachment,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ea330fb1_8ef752cd","line":1741,"in_reply_to":"42dbb862_9218908e","updated":"2022-10-11 15:23:13.000000000","message":"This one did \"work\" but as above, I\u0027d rather be inconsistent as faster here.","commit_id":"b6d889c68bac6b16ab991ad3a2cae8bed8bb4dc6"}]}