)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"0954b41026bf5ac7c9b6e02d46c3ca15a6744782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92c85c5d_e106b0b8","updated":"2022-01-25 14:30:05.000000000","message":"Please also add new proxy functions into the doc (https://opendev.org/openstack/openstacksdk/src/branch/master/doc/source/user/proxies/network.rst)\n\nOtherwise (with other minor comments) is good to go.\n\nWould be of course very helpful to add a functional test for that","commit_id":"2503c7eb2902d0e61b2fb2a56b5a0a8f1966f8c2"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"c58d556a68e1fb93577e9996119c01050c8353fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc8dabe3_945b8cbe","updated":"2022-01-24 18:02:08.000000000","message":"recheck","commit_id":"2503c7eb2902d0e61b2fb2a56b5a0a8f1966f8c2"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"484b252bf28b0e898e6ae2b5e6a2311d5c7ea576","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"80fbd05a_20dfd620","in_reply_to":"92c85c5d_e106b0b8","updated":"2022-01-26 07:48:17.000000000","message":"Thank you for review! \n\nProxy functions [1] and functional tests [2] were added with main patch,\nor you mean additional tests?\n\n\n1) https://opendev.org/openstack/openstacksdk/src/branch/master/doc/source/user/proxies/network.rst#local-ip-operations\n2) https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/functional/network/v2/test_local_ip.py","commit_id":"2503c7eb2902d0e61b2fb2a56b5a0a8f1966f8c2"}],"openstack/network/v2/_proxy.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"0954b41026bf5ac7c9b6e02d46c3ca15a6744782","unresolved":true,"context_lines":[{"line_number":821,"context_line":"            the resources being returned."},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"            * ``fixed_port_id``: The ID of the port to which a local IP"},{"line_number":824,"context_line":"                                 is associated"},{"line_number":825,"context_line":"            * ``fixed_ip``: The fixed ip address associated with a"},{"line_number":826,"context_line":"                            a Local IP"},{"line_number":827,"context_line":"            * ``host``: Host where local ip is associated"}],"source_content_type":"text/x-python","patch_set":3,"id":"a9f1b2ae_f557f078","line":824,"updated":"2022-01-25 14:30:05.000000000","message":"can you please indent this and similar other lines better (+4 compared to prev line and not under the first symbol)","commit_id":"2503c7eb2902d0e61b2fb2a56b5a0a8f1966f8c2"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"484b252bf28b0e898e6ae2b5e6a2311d5c7ea576","unresolved":false,"context_lines":[{"line_number":821,"context_line":"            the resources being returned."},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"            * ``fixed_port_id``: The ID of the port to which a local IP"},{"line_number":824,"context_line":"                                 is associated"},{"line_number":825,"context_line":"            * ``fixed_ip``: The fixed ip address associated with a"},{"line_number":826,"context_line":"                            a Local IP"},{"line_number":827,"context_line":"            * ``host``: Host where local ip is associated"}],"source_content_type":"text/x-python","patch_set":3,"id":"05e4e664_0abad836","line":824,"in_reply_to":"a9f1b2ae_f557f078","updated":"2022-01-26 07:48:17.000000000","message":"Done","commit_id":"2503c7eb2902d0e61b2fb2a56b5a0a8f1966f8c2"}],"openstack/network/v2/local_ip.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"0954b41026bf5ac7c9b6e02d46c3ca15a6744782","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        \u0027name\u0027, \u0027description\u0027,"},{"line_number":38,"context_line":"        \u0027project_id\u0027, \u0027network_id\u0027,"},{"line_number":39,"context_line":"        \u0027local_port_id\u0027, \u0027local_ip_address\u0027,"},{"line_number":40,"context_line":"        \u0027ip_mode\u0027,"},{"line_number":41,"context_line":"    )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # Properties"}],"source_content_type":"text/x-python","patch_set":3,"id":"cba0d555_12b0b302","line":40,"updated":"2022-01-25 14:30:05.000000000","message":"I see neutron also supports \"revision_number\" as query param","commit_id":"2503c7eb2902d0e61b2fb2a56b5a0a8f1966f8c2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1f72c9dcbcd234caebe843acf8909ab27e5bd036","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        \u0027name\u0027, \u0027description\u0027,"},{"line_number":38,"context_line":"        \u0027project_id\u0027, \u0027network_id\u0027,"},{"line_number":39,"context_line":"        \u0027local_port_id\u0027, \u0027local_ip_address\u0027,"},{"line_number":40,"context_line":"        \u0027ip_mode\u0027,"},{"line_number":41,"context_line":"    )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # Properties"}],"source_content_type":"text/x-python","patch_set":3,"id":"03e9c2ac_7c87ef10","line":40,"in_reply_to":"03ec0a4e_c8d88edf","updated":"2022-02-01 14:17:20.000000000","message":"revision_number is an internal counter, this is not used in queries","commit_id":"2503c7eb2902d0e61b2fb2a56b5a0a8f1966f8c2"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"484b252bf28b0e898e6ae2b5e6a2311d5c7ea576","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        \u0027name\u0027, \u0027description\u0027,"},{"line_number":38,"context_line":"        \u0027project_id\u0027, \u0027network_id\u0027,"},{"line_number":39,"context_line":"        \u0027local_port_id\u0027, \u0027local_ip_address\u0027,"},{"line_number":40,"context_line":"        \u0027ip_mode\u0027,"},{"line_number":41,"context_line":"    )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # Properties"}],"source_content_type":"text/x-python","patch_set":3,"id":"03ec0a4e_c8d88edf","line":40,"in_reply_to":"cba0d555_12b0b302","updated":"2022-01-26 07:48:17.000000000","message":"I think this better be consistent with other resources, like floating_ip","commit_id":"2503c7eb2902d0e61b2fb2a56b5a0a8f1966f8c2"}]}
