)]}'
{"openstack/cloud/_network.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d74199dd96d58fbae08c034d2a3759396d81336f","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        :param name_or_id: Name or ID of the desired network."},{"line_number":47,"context_line":"        :param filters: A dict containing additional filters to use. e.g."},{"line_number":48,"context_line":"            {\u0027router:external\u0027: True}"},{"line_number":49,"context_line":"        :returns: A list of network ``Network`` objects matching the search"},{"line_number":50,"context_line":"            criteria."},{"line_number":51,"context_line":"        :raises: ``OpenStackCloudException`` if something goes wrong during the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ebab6c69_219457cb","line":48,"updated":"2022-06-10 09:53:51.000000000","message":"nit: you could use :ptype filters: (or how it\u0027s called) to provide the argument type","commit_id":"88b35ef50f8f747d26bfce623ae06dba230e7be2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d74199dd96d58fbae08c034d2a3759396d81336f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        :param name_or_id: Name or ID of the desired router."},{"line_number":66,"context_line":"        :param filters: A dict containing additional filters to use. e.g."},{"line_number":67,"context_line":"            {\u0027admin_state_up\u0027: True}"},{"line_number":68,"context_line":"        :returns: A list of network ``Router`` objects matching the search"},{"line_number":69,"context_line":"            criteria."},{"line_number":70,"context_line":"        :raises: ``OpenStackCloudException`` if something goes wrong during the"},{"line_number":71,"context_line":"            OpenStack API call."}],"source_content_type":"text/x-python","patch_set":1,"id":"a45a305a_f3b56ae9","line":68,"updated":"2022-06-10 09:53:51.000000000","message":"nit: it could be even better to refer to Router docs","commit_id":"88b35ef50f8f747d26bfce623ae06dba230e7be2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d74199dd96d58fbae08c034d2a3759396d81336f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \"\"\"List all available networks."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        :param filters: (optional) A dict of filter conditions to push down."},{"line_number":125,"context_line":"        :returns: A list of network ``Network`` objects."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        # If the cloud is running nova-network, just return an empty list."},{"line_number":128,"context_line":"        if not self.has_service(\u0027network\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fb9a497_5b4c14a8","line":125,"updated":"2022-06-10 09:53:51.000000000","message":"I\u0027m not overly fond of network Network. Unlike Port, it\u0027s not ambiguous?","commit_id":"88b35ef50f8f747d26bfce623ae06dba230e7be2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d74199dd96d58fbae08c034d2a3759396d81336f","unresolved":false,"context_lines":[{"line_number":894,"context_line":"            Defaults to False."},{"line_number":895,"context_line":"        :raises: BadRequestException if parameters are malformed"},{"line_number":896,"context_line":"        :raises: ResourceNotFound if a resource from firewall_list not found"},{"line_number":897,"context_line":"        :returns: The created network ``FirewallPolicy`` object."},{"line_number":898,"context_line":"        \"\"\""},{"line_number":899,"context_line":"        if \u0027firewall_rules\u0027 in kwargs:"},{"line_number":900,"context_line":"            kwargs[\u0027firewall_rules\u0027] \u003d self._get_firewall_rule_ids("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aeb1588_9ded5309","line":897,"updated":"2022-06-10 09:53:51.000000000","message":"I\u0027d keep rtype and make it a proper link","commit_id":"88b35ef50f8f747d26bfce623ae06dba230e7be2"}]}
