)]}'
{"id":"openstack%2Fopenstacksdk~843435","triplet_id":"openstack%2Fopenstacksdk~master~I8cc7c5d83781698465c44d9a8137b76954de7f1d","project":"openstack/openstacksdk","branch":"master","topic":"remove-munch","attention_set":{},"removed_from_attention_set":{"27900":{"account":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"last_update":"2022-06-13 09:55:41.000000000","reason":"Artem Goncharov replied on the change"},"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2022-06-13 13:06:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8cc7c5d83781698465c44d9a8137b76954de7f1d","subject":"cloud: Update docstrings for network functions","status":"MERGED","created":"2022-05-26 12:00:04.000000000","updated":"2022-06-13 13:06:15.000000000","submitted":"2022-06-13 13:06:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"843435-remove-munch","meta_rev_id":"66b6b93fa291d38729c4ccee1c9b1700e03c4c98","_number":843435,"virtual_id_number":843435,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-06-13 13:06:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":2,"date":"2022-06-13 09:55:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-06-10 09:53:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":1,"date":"2022-06-13 09:55:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-05-26 13:23:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-08 10:11:05.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2022-06-10 09:53:51.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"f3d17ba9df31ab3f3a9a628c1f0e5f927c9d99f9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-05-26 12:00:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ee170b6a941d89250c5079ae4c21cd92353c605","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-05-26 13:23:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4639b2c3647b45139639846d81076e27 : SUCCESS in 3m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e3effba8cab94804937bfcf0f8b1a3c8 : SUCCESS in 4m 55s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d6caaeb275a34538a0c7b2a0334291bc : SUCCESS in 4m 02s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/9d662e1e3a214ee7a3c68ee5f15019db : SUCCESS in 4m 42s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/1a1c66ae0a3849b38359a47121b56117 : SUCCESS in 45m 38s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/1824a9c8f46b471eb9887080f935b58a : SUCCESS in 5m 47s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/14bf84f0392646c994b34353ae683caa : SUCCESS in 4m 16s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/b5e09ff5bab642edb33a350947743450 : SUCCESS in 5m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3d0c248c2ccb4a489068ffb543720ffc : SUCCESS in 8m 51s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/288cec7f944b49cc9752396b852adced : SUCCESS in 57m 48s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/23f8a4df8e724e5a80518353da94423a : SUCCESS in 19m 01s\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/1988c71cfe8c48f99ed20a3524b33a71 : SUCCESS in 32m 06s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/1b4e5b4bddc24225bb37ab55e95da7ed : SUCCESS in 47m 38s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/5b16cf37099e4d158f2b04c4b2bf37d8 : SUCCESS in 1h 19m 18s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/29fbfcb773384d48b787b840e3d4b700 : SUCCESS in 46m 21s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/23f54f6e1d824dd38968bdf7ea2ee9a3 : SUCCESS in 48m 14s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/2f1af5fb0609469a98781d9af924510c : SUCCESS in 21m 43s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/4e16626ca9cc4645917bdc87bead075e : SUCCESS in 26m 09s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/ba859d45a1ca43b7b9209177e80edd53 : SUCCESS in 38m 28s (non-voting)\n- openstacksdk-functional-devstack-legacy https://zuul.opendev.org/t/openstack/build/928731e9eb694293a5dc4541f0dcac86 : SUCCESS in 45m 29s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/012a92743db94e0bbbb345e2a0b26bb6 : SUCCESS in 1h 01m 52s (non-voting)\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/fe63dc81ad2d4c9895984b0de8e49813 : SUCCESS in 56m 16s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/33ec962534c247cd949c95f16f8fe8e0 : SUCCESS in 25m 58s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/6d1723191ddc4fecb29563d56faf96ca : SUCCESS in 42m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d74199dd96d58fbae08c034d2a3759396d81336f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-06-10 09:53:51.000000000","message":"Patch Set 1: Code-Review+2\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"dff87d927b530e25eda806081bc15d935d7e8297","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2022-06-13 09:55:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"26a46433d437da70d86ecf5cfaa55c6db80b4a0b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-13 09:56:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"62e1b9fed08ac8ad840aec79bb94f54975c03750","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-13 13:06:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf5d27c31a604bd8a7d817780eaf28c0 : SUCCESS in 3m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3482fde923f24ef2b931bd3b930bdc74 : SUCCESS in 3m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/56710120616b4a1a91b1ca8b752850d2 : SUCCESS in 4m 24s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/93acbb34053c4a419b0795b93cf3c7c5 : SUCCESS in 45m 05s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/ea45ee0e025c4b3698575a710f27d513 : SUCCESS in 5m 13s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/f5add6418a5e46c280c01e675a01548f : SUCCESS in 3m 55s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/e26cd7066ff247fc87949c41e7013476 : SUCCESS in 4m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/62e63939682348b8ab5f6383ba3854ca : SUCCESS in 8m 05s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/102336938464427c8e50721886ac1033 : SUCCESS in 54m 12s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/feb8599a66614218be720620ebd983a8 : SUCCESS in 14m 45s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/f59fd7d4459c4a79a640654fe99d9f5e : SUCCESS in 34m 55s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0f07c937ecc44abf850aec5a2cbba2df : SUCCESS in 50m 39s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/ad8432c00a4b40ab8a1431e389e11955 : SUCCESS in 1h 18m 26s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/5de4a943a92441aeb17ead0e06ca67e2 : SUCCESS in 45m 47s","accounts_in_message":[],"_revision_number":1},{"id":"66b6b93fa291d38729c4ccee1c9b1700e03c4c98","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-13 13:06:15.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"88b35ef50f8f747d26bfce623ae06dba230e7be2","revisions":{"88b35ef50f8f747d26bfce623ae06dba230e7be2":{"kind":"REWORK","_number":1,"created":"2022-05-26 12:00:04.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/35/843435/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/35/843435/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/35/843435/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/35/843435/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/35/843435/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/35/843435/1"}}},"commit":{"parents":[{"commit":"041a66a2e775d6a28b0e88ca1345b79f5bdde863","subject":"Remove unused normalization helpers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/041a66a2e775d6a28b0e88ca1345b79f5bdde863"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2022-05-18 17:28:19.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2022-05-26 11:29:48.000000000","tz":60},"subject":"cloud: Update docstrings for network functions","message":"cloud: Update docstrings for network functions\n\nWe don\u0027t use munch objects here any more.\n\nWhile we\u0027re here, we also fix a bug in the \u0027get_internal_networks\u0027 and\n\u0027get_external_networks\u0027 helpers: subclasses of \u0027Resource\u0027 including the\n\u0027Network\u0027 resource are not hashable so you can\u0027t put them in sets. We\nmust use lists and assume there are no duplicates.\n\nChange-Id: I8cc7c5d83781698465c44d9a8137b76954de7f1d\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/88b35ef50f8f747d26bfce623ae06dba230e7be2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/88b35ef50f8f747d26bfce623ae06dba230e7be2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}