)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"418d39b82dfb88b9996495f55a8c05dd5e213f5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f42b72a_6bd49a15","updated":"2022-07-11 16:08:32.000000000","message":"-1 is so you spot my comment, no necessarily because we should definitely do this (though I think we should)","commit_id":"e268d0007c528cfbfcce3dfda22cd5fb8e92e2a2"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"a662d2e202eb6907e6312b62d223e0cf2085ed38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0bc50af1_1eb80e8d","updated":"2022-07-15 15:31:55.000000000","message":"+2, but it has conflicts with https://review.opendev.org/c/openstack/openstacksdk/+/846214","commit_id":"2575f5c077ba0cf4980d2efd5b6e12348c91f60a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbdcc17242803b4ca9165f5050abeea37005ca2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"74b1488f_701217aa","updated":"2022-07-12 09:17:50.000000000","message":"Thanks 🙏","commit_id":"2575f5c077ba0cf4980d2efd5b6e12348c91f60a"}],"openstack/resource.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"418d39b82dfb88b9996495f55a8c05dd5e213f5d","unresolved":true,"context_lines":[{"line_number":1388,"context_line":"        return actual"},{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"    def create(self, session, prepend_key\u003dTrue, base_path\u003dNone,"},{"line_number":1391,"context_line":"               microversion\u003dNone, **params):"},{"line_number":1392,"context_line":"        \"\"\"Create a remote resource based on this instance."},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        :param session: The session to use for making this request."}],"source_content_type":"text/x-python","patch_set":1,"id":"162836d9_aaa5291c","line":1391,"updated":"2022-07-11 16:08:32.000000000","message":"Can we make this (and all the others) kw-only arguments?\n\n  def create(\n      self,\n      session,\n      prepend_key\u003dTrue,\n      base_path\u003dNone,\n      *,\n      microversion\u003dNone,\n      **params,\n  ):\n\nIn fact, maybe we could make all the arguments kw-only? None of them are things I\u0027d expect people to pass positionally and we\u0027ve got a 1.0 release with breaking changes allowed ahead of us.","commit_id":"e268d0007c528cfbfcce3dfda22cd5fb8e92e2a2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1db4153d21d15eb0b28fc08fb1b561c70e174f75","unresolved":true,"context_lines":[{"line_number":1388,"context_line":"        return actual"},{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"    def create(self, session, prepend_key\u003dTrue, base_path\u003dNone,"},{"line_number":1391,"context_line":"               microversion\u003dNone, **params):"},{"line_number":1392,"context_line":"        \"\"\"Create a remote resource based on this instance."},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        :param session: The session to use for making this request."}],"source_content_type":"text/x-python","patch_set":1,"id":"39f73fa0_08855900","line":1391,"in_reply_to":"162836d9_aaa5291c","updated":"2022-07-12 09:03:39.000000000","message":"This is a good call. I\u0027ll update this patch to make microversion keyword-only, we can follow up with the other arguments.","commit_id":"e268d0007c528cfbfcce3dfda22cd5fb8e92e2a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbdcc17242803b4ca9165f5050abeea37005ca2a","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"        return actual"},{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"    def create(self, session, prepend_key\u003dTrue, base_path\u003dNone,"},{"line_number":1391,"context_line":"               microversion\u003dNone, **params):"},{"line_number":1392,"context_line":"        \"\"\"Create a remote resource based on this instance."},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        :param session: The session to use for making this request."}],"source_content_type":"text/x-python","patch_set":1,"id":"148ddde2_ba596da6","line":1391,"in_reply_to":"39f73fa0_08855900","updated":"2022-07-12 09:17:50.000000000","message":"Ack","commit_id":"e268d0007c528cfbfcce3dfda22cd5fb8e92e2a2"}],"openstack/tests/unit/test_resource.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9a70969f428a6fb046a866efab7bd74ff080ca25","unresolved":false,"context_lines":[{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    def test_commit_put_explicit_microversion(self):"},{"line_number":1857,"context_line":"        self._test_commit(commit_method\u003d\u0027PUT\u0027, prepend_key\u003dTrue, has_body\u003dTrue,"},{"line_number":1858,"context_line":"                          explicit_microversion\u003d\u00271.42\u0027)"},{"line_number":1859,"context_line":""},{"line_number":1860,"context_line":"    def test_commit_not_dirty(self):"},{"line_number":1861,"context_line":"        self.sot._body \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"54044f11_056bf977","line":1858,"updated":"2022-07-11 16:10:08.000000000","message":"Aside: I really don\u0027t like tests like this. It adds a load of (fallible and often complex) logic to tests. IMO the tests should be dead simple, even if that results in duplication. You didn\u0027t start this trend though so I certainly won\u0027t block on this.","commit_id":"e268d0007c528cfbfcce3dfda22cd5fb8e92e2a2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1db4153d21d15eb0b28fc08fb1b561c70e174f75","unresolved":false,"context_lines":[{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    def test_commit_put_explicit_microversion(self):"},{"line_number":1857,"context_line":"        self._test_commit(commit_method\u003d\u0027PUT\u0027, prepend_key\u003dTrue, has_body\u003dTrue,"},{"line_number":1858,"context_line":"                          explicit_microversion\u003d\u00271.42\u0027)"},{"line_number":1859,"context_line":""},{"line_number":1860,"context_line":"    def test_commit_not_dirty(self):"},{"line_number":1861,"context_line":"        self.sot._body \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff95f5c4_bb3d5923","line":1858,"in_reply_to":"54044f11_056bf977","updated":"2022-07-12 09:03:39.000000000","message":"I agree.. Even de-duplication could be done better. But yeah, I\u0027d prefer not to do it as part of this work.","commit_id":"e268d0007c528cfbfcce3dfda22cd5fb8e92e2a2"}]}