)]}'
{"id":"openstack%2Fopenstacksdk~851976","triplet_id":"openstack%2Fopenstacksdk~master~I064ed922be440d911fbc492dab8465e8f75236df","project":"openstack/openstacksdk","branch":"master","topic":"needs-floating-ip","attention_set":{},"removed_from_attention_set":{"32962":{"account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"last_update":"2022-08-10 08:48:02.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I064ed922be440d911fbc492dab8465e8f75236df","subject":"Enable add_ips_to_server() and _needs_floating_ip() for pristine server resources","status":"MERGED","created":"2022-08-03 09:53:20.000000000","updated":"2022-08-10 08:49:24.000000000","submitted":"2022-08-10 08:48:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"851976-needs-floating-ip","meta_rev_id":"c6fc632050e2a1b7feda29977ef3a467d436d70b","_number":851976,"virtual_id_number":851976,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-08-10 08:48:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-08-10 07:24:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-08-10 07:24:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-03 11:27:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-10 07:24:54.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"283ffc1027a23a6016308cbef2b3e43cc074a34c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-08-03 09:53:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"192801b7e2f7381a74ab352562bc7d4091ad1261","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-03 11:27:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f0f8f82415db4284b6e17fc6ef54dd8b\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/51991febde724027ab2882dff7ce0acc : SUCCESS in 3m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e2fd3c09a1d74259aa8ff8d16aaa0ba6 : SUCCESS in 4m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/222130cd0d1f47ca84d56218515ac1ef : SUCCESS in 4m 09s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/0e334d49ef6e4f52a2b7434f6766f1b7 : SUCCESS in 4m 07s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/9b228eb16831497ab07097e3e6b52376 : SUCCESS in 1h 02m 38s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/7cbd99b123c346558ae49ade31ac9c7e : SUCCESS in 4m 26s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/501d9716aae44e13aeca67fd6ce9d0a3 : SUCCESS in 5m 01s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/206863d3fed344a09fb946d8475527f9 : SUCCESS in 5m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/260fc57ec8f74bbaa001d1cb0ec21811 : SUCCESS in 7m 54s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/9789bbfc286042abb4eb24da737a296a : SUCCESS in 58m 35s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/ddc60fd86be24d5b83d11f9de43bac42 : SUCCESS in 16m 03s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/71acc7e6dd584431a5780fcaf7d5a499 : SUCCESS in 34m 39s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3f247812ade2407eaa80d1a6933d473d : SUCCESS in 53m 07s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/eb8ccbd1cb484e4e8f26f0e8140df4d8 : SUCCESS in 1h 28m 04s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/c87d6e25bc9d40068591b6c8763fd52e : SUCCESS in 46m 22s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/0bb32323b19d4c90bb00d383e96035eb : SUCCESS in 48m 07s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/3968c62a157f4eca80b47a1f90a897a7 : SUCCESS in 36m 04s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/ed18d9ec36154af5a435d3a6a48505aa : SUCCESS in 29m 30s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/3498523adddb4baca2491fc186332ae4 : SUCCESS in 43m 55s (non-voting)\n- openstacksdk-functional-devstack-legacy https://zuul.opendev.org/t/openstack/build/54a3d42553d44372911cb4cea8af6d2c : FAILURE in 28m 34s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/545f7903712d4596b2e1ecfcb62568af : FAILURE in 53m 18s (non-voting)\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/0d595ae986b64fafa6abb576e3a3c444 : SUCCESS in 51m 19s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3973c9f58f54482984b03264e5c1d3f7 : FAILURE in 13m 03s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/a527eccafbf941e6855a52b31545b826 : SUCCESS in 52m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"024661c5830fd037f94e7588b8f140dcd6a1149d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-08-03 11:52:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c53455204533f0b3406e8dd52e18f097d18e1f03","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-08-03 12:34:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5c39308889b782849a536e20ecee8000b46f60af","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-03 14:00:40.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b2d280f025ce46c98f0fd91eea708bf9\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a3b90106f13b4791a42c71f7bf2ed439 : SUCCESS in 4m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/df83d00b1bcf462bac36c9b09dc8b5ad : SUCCESS in 4m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f8a584fbfa8942ec942dc1ab8f2b2587 : SUCCESS in 4m 42s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/7e5fe18117df432ca87086c911915301 : SUCCESS in 4m 28s (non-voting)\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/2e1703a791464a6282eeb777321b1d33 : SUCCESS in 45m 16s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/4cd8e16d7bc9467db8151153b551f769 : SUCCESS in 4m 20s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/c4638a4b3afa469bb31ada77721aa406 : SUCCESS in 4m 13s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/dbe9f9bd514c4acb93c6b29216a57b2c : SUCCESS in 5m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2d42bf50411e4ba6ae83a5253087c4e5 : SUCCESS in 8m 05s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/b33cfca300414577ab44987a683efbc3 : SUCCESS in 56m 26s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/93d53dea698947898b0eb3d9a1de346e : SUCCESS in 13m 37s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/070963d9d2794506b06c5bc36e1311cd : SUCCESS in 35m 31s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/d1945ac0ceed46c2abaeec755901079c : SUCCESS in 1h 01m 17s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/53e05bd9dd7947ab9db6eca7f4fcd7d8 : SUCCESS in 1h 18m 33s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/fa9568db58054cb192958961622d4f14 : SUCCESS in 48m 46s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/b42e4b7095cc4671b92465fcc9134be9 : SUCCESS in 51m 54s (non-voting)\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/4d58313d94474d798b5853b10234e353 : SUCCESS in 37m 12s (non-voting)\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/f6b8da30ea344552bb060cc286a70b81 : SUCCESS in 28m 12s (non-voting)\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/dd3138f8484743fea643506af06e655c : SUCCESS in 46m 46s (non-voting)\n- openstacksdk-functional-devstack-legacy https://zuul.opendev.org/t/openstack/build/e908b29d21e0428e87a5fb4fafc622d0 : FAILURE in 38m 42s (non-voting)\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/bbc8f46cb87044ce85bf8498e3dd2f7b : SUCCESS in 50m 08s (non-voting)\n- ironic-inspector-tempest-openstacksdk-src https://zuul.opendev.org/t/openstack/build/ae9b4d1df47047528d66029b7ae0ca3c : SUCCESS in 1h 22m 22s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6c943aab90a64e24a35a56f4037a7aa7 : FAILURE in 11m 40s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/8e7f8638d7ed4293bf59a50056c6ddfa : SUCCESS in 1h 01m 25s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6067d01fb79a249bb0d758edeb82ee7ef0a35f5a","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2022-08-10 07:24:54.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"42afb10192adf615c772df03da214fca0c0cbd5e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-10 07:25:43.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"aef3baf243235d4259fb2d16b0d2bbd9d2b3c92a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-10 08:48:01.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c665b3b8664e4cc580e5a02ba3ee242a\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ec6f8842b78a4da98366ed58322f253e : SUCCESS in 4m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/dad7e03c23494f33a36e3db9f369519b : SUCCESS in 4m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6f5f76364e964410bafa71ed59d570b3 : SUCCESS in 4m 48s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/df3254c452ab4c41908a491fccbbe791 : SUCCESS in 58m 25s\n- openstacksdk-tox-py38-tips https://zuul.opendev.org/t/openstack/build/8acb4b367ffc4055ac557a929d879572 : SUCCESS in 4m 55s\n- os-client-config-tox-py38-tips https://zuul.opendev.org/t/openstack/build/45a221566a894cc6aac7b6460cc2a76a : SUCCESS in 4m 35s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/369fa9a5046a4c598556c5de95278674 : SUCCESS in 5m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d75ec0f4db6648c1822220868e019b68 : SUCCESS in 8m 35s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/7cc7be4131c64f6896bc32ef707a2157 : SUCCESS in 1h 04m 36s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/f4ac657f6e674fb78495d43391a853be : SUCCESS in 15m 09s (non-voting)\n- dib-nodepool-functional-openstack-centos-8-stream-src https://zuul.opendev.org/t/openstack/build/92f7add2568d41faafab8b128cfcdd88 : SUCCESS in 36m 27s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/cef387a055ca459896544476b33f8183 : SUCCESS in 1h 02m 50s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/84896600c2d24adcac5f76a7f86a7c16 : SUCCESS in 1h 21m 32s\n- openstacksdk-functional-devstack-senlin https://zuul.opendev.org/t/openstack/build/004ce24cf58b45a4a0d3d388726aafcb : SUCCESS in 47m 54s","accounts_in_message":[],"_revision_number":3},{"id":"d093c15ccdcf009ef9f896cfc5bf70e60c0382ea","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-10 08:48:02.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"c6fc632050e2a1b7feda29977ef3a467d436d70b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-10 08:49:24.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/35c6c95e2ba948fd92b47ea821d4a3cd\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/08a6924c6d4f42ebb6c3388dad7aa73a : SUCCESS in 1m 02s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0ded7ac398843b6b1ce46668eb3b45ce02628428","revisions":{"0a07cce6d4a44a2701d4694d1112f815778bdc6a":{"kind":"REWORK","_number":1,"created":"2022-08-03 09:53:20.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/76/851976/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/76/851976/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/1"}}},"commit":{"parents":[{"commit":"3f81d0001dd994cde990d38f6e2671ee0694d7d5","subject":"Replace deprecated failUnlessEqual with assertEqual","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-08-03 09:42:15.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-08-03 09:51:19.000000000","tz":120},"subject":"Enable add_ips_to_server() and _needs_floating_ip() for pristine server resources","message":"Enable add_ips_to_server() and _needs_floating_ip() for pristine server resources\n\nPreviously, both functions [1] and [2] would have to be called with\nserver objects which have been enhanced by add_server_interfaces()\n[3]. The latter adds \u0027public_v4\u0027 and \u0027private_v4\u0027 attributes to the\nserver objects which the default server resource [4] does not have.\n\nNow, we check server\u0027s \u0027addresses\u0027 attributes for fixed and floating\nip addresses [5] in case the \u0027public_v4\u0027 and \u0027private_v4\u0027 attributes\nare not available. The checks for fixed vs floating ip addresses are\nequal to how find_nova_addresses() [6] distinguishes between both\nip address types.\n\n[1] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/_floating_ip.py#L979\n[2] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/_floating_ip.py#L997\n[3] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/meta.py#L439\n[4] https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/compute/v2/server.py\n[5] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/compute/v2/server.py#L81\n[6] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/meta.py#L69\n\nChange-Id: I064ed922be440d911fbc492dab8465e8f75236df\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/0a07cce6d4a44a2701d4694d1112f815778bdc6a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/0a07cce6d4a44a2701d4694d1112f815778bdc6a"}]},"branch":"refs/heads/master"},"ffe7d36b256a7140c0b4a277b794397385d1fc56":{"kind":"REWORK","_number":2,"created":"2022-08-03 11:52:59.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/76/851976/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/76/851976/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/2"}}},"commit":{"parents":[{"commit":"3f81d0001dd994cde990d38f6e2671ee0694d7d5","subject":"Replace deprecated failUnlessEqual with assertEqual","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-08-03 09:42:15.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-08-03 11:52:53.000000000","tz":120},"subject":"Enable add_ips_to_server() and _needs_floating_ip() for pristine server resources","message":"Enable add_ips_to_server() and _needs_floating_ip() for pristine server resources\n\nPreviously, both functions [1] and [2] would have to be called with\nserver objects which have been enhanced by add_server_interfaces()\n[3]. The latter adds \u0027public_v4\u0027 and \u0027private_v4\u0027 attributes to the\nserver objects which the default server resource [4] does not have.\n\nNow, we check server\u0027s \u0027addresses\u0027 attributes for fixed and floating\nip addresses [5] in case the \u0027public_v4\u0027 and \u0027private_v4\u0027 attributes\nare not available. The checks for fixed vs floating ip addresses are\nequal to how find_nova_addresses() [6] distinguishes between both\nip address types.\n\n[1] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/_floating_ip.py#L979\n[2] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/_floating_ip.py#L997\n[3] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/meta.py#L439\n[4] https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/compute/v2/server.py\n[5] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/compute/v2/server.py#L81\n[6] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/meta.py#L69\n\nChange-Id: I064ed922be440d911fbc492dab8465e8f75236df\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/ffe7d36b256a7140c0b4a277b794397385d1fc56"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/ffe7d36b256a7140c0b4a277b794397385d1fc56"}]},"branch":"refs/heads/master"},"0ded7ac398843b6b1ce46668eb3b45ce02628428":{"kind":"REWORK","_number":3,"created":"2022-08-03 12:34:02.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/76/851976/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/76/851976/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/76/851976/3"}}},"commit":{"parents":[{"commit":"3f81d0001dd994cde990d38f6e2671ee0694d7d5","subject":"Replace deprecated failUnlessEqual with assertEqual","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-08-03 09:42:15.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-08-03 12:33:55.000000000","tz":120},"subject":"Enable add_ips_to_server() and _needs_floating_ip() for pristine server resources","message":"Enable add_ips_to_server() and _needs_floating_ip() for pristine server resources\n\nPreviously, both functions [1] and [2] would have to be called with\nserver objects which have been enhanced by add_server_interfaces()\n[3]. The latter adds \u0027public_v4\u0027 and \u0027private_v4\u0027 attributes to the\nserver objects which the default server resource [4] does not have.\n\nNow, we check server\u0027s \u0027addresses\u0027 attributes for fixed and floating\nip addresses [5] in case the \u0027public_v4\u0027 and \u0027private_v4\u0027 attributes\nare not available. The checks for fixed vs floating ip addresses are\nequal to how find_nova_addresses() [6] distinguishes between both\nip address types.\n\n[1] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/_floating_ip.py#L979\n[2] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/_floating_ip.py#L997\n[3] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/meta.py#L439\n[4] https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/compute/v2/server.py\n[5] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/compute/v2/server.py#L81\n[6] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/cloud/meta.py#L69\n\nChange-Id: I064ed922be440d911fbc492dab8465e8f75236df\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/0ded7ac398843b6b1ce46668eb3b45ce02628428"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/0ded7ac398843b6b1ce46668eb3b45ce02628428"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[]}