)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1843e19a2e7f1fcb802ade648958a604117ac404","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26937cdd_fa49a8bc","updated":"2022-09-13 11:41:42.000000000","message":"Great start. Some small nits in there. As noted in one of the comments, it would be good to rebase this on top of [1]\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/856270/","commit_id":"08cda2c5534e0f076e08e164c26ba1591917b776"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"18bd3340bcaf5afeed6c792744b9825d2f7b98b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7861d969_d1bf90ad","updated":"2022-09-13 14:27:14.000000000","message":"This is much better. Thank you! I have two further requests inside. If you wouldn\u0027t mind addressing them, I\u0027m +2","commit_id":"306d620e432cf150645261476a20d5cad3d29302"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"680ddb37674462584b2b65bb205605b799d37236","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b3bbdf21_05d48010","updated":"2022-09-13 15:45:26.000000000","message":"@Areg Grigoryan I noticed that you implemented \u0027metadef namespace\u0027. This change is also related to \u0027metadef\u0027. Would you mind if I ask you to review? ","commit_id":"b8f31b54b790bc948d8e3529eca9ba9c6391bdee"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"8c497f75ef8b98c02a11b6b4259d54d73fd5078b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"108c1468_e6c1b736","updated":"2022-09-13 16:58:01.000000000","message":"RECHECK","commit_id":"b8f31b54b790bc948d8e3529eca9ba9c6391bdee"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"44a9fefeb98f41bb04074cc948da3a57a742982b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7c087fc5_edebd0dd","updated":"2022-09-14 01:59:17.000000000","message":"RECHECK","commit_id":"b8f31b54b790bc948d8e3529eca9ba9c6391bdee"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"f48e2859d6eeb7d486fafbd279812e4c3a8fdf7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"10897abd_7b686f96","updated":"2022-09-13 15:37:39.000000000","message":"This is the first step to implement image metadata things. \n\nThank you Eunyoung 😊 ","commit_id":"b8f31b54b790bc948d8e3529eca9ba9c6391bdee"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"904f541508281add4bb3f0b49d03869f6df6b597","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c8313bb8_fa543f43","updated":"2022-09-14 06:17:43.000000000","message":"I have some difficulty passing by zuul with docs.\n\nPatch 7 contains docs code \u003d\u003e  zuul \u0027openstack-tox-docs\u0027 failed.\nI can\u0027t reproduce this issue on my local env. (`tox -e docs` always ended successfully) Also I didn\u0027t get some useful clue through the build log below.\nhttps://zuul.openstack.org/build/babeb4852061477aa2415864ae91a75d\n\nPatch 8 (latest) remove docs code \u003d\u003e  zuul success","commit_id":"bfafc7f5bd3d9a81656c1468e2ff8beb4b2d429d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"093a15e907641a9483047bcd907fee63f8cd6e90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f6af8308_442ab81f","in_reply_to":"3219923b_690a1aed","updated":"2022-09-16 15:36:32.000000000","message":"Fixed this in [1]. It wasn\u0027t your issues. Seems we messed up previously and the new docs simply highlighted the issue. Very weird.\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/858085/1","commit_id":"bfafc7f5bd3d9a81656c1468e2ff8beb4b2d429d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c68d78c3232935209ab00d888ef739937bdcf3ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eeee5bdd_91c701a9","in_reply_to":"c8313bb8_fa543f43","updated":"2022-09-14 17:27:38.000000000","message":"I had a look at tox.ini and we don\u0027t delete the old artifacts after each build. This can cause Sphinx to cache information. You can ensure you get a clean build each time by removing the doc/build directory before building docs.","commit_id":"bfafc7f5bd3d9a81656c1468e2ff8beb4b2d429d"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"5c9c092c757c0f8e41931eeda04755bfcd8cd64e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3219923b_690a1aed","in_reply_to":"eeee5bdd_91c701a9","updated":"2022-09-16 03:45:07.000000000","message":"Yes, I think this change (857200) may be cached. I have no clue what causes problems in docs files.\n\nOne solution is removing docs changes in this change (857200), then after this change will be merged, I will be able to add docs files with another change id.\n\nI would like to ask your opinion concerning this problem. @stephenfin @Seongsoo Cho","commit_id":"bfafc7f5bd3d9a81656c1468e2ff8beb4b2d429d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71a41a6a6bc4ef2a448f1f17f2163787742b17c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5158628c_43df4a24","updated":"2022-09-14 17:32:58.000000000","message":"Better again. Unfortunately I missed some steps in my last review. Would you mind addressing them?","commit_id":"01474dd37aebfb2b754c6af620259de3dd302831"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f3497383662a156645df1cbafd4224789f21fd88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3c884f77_07460ac5","updated":"2022-09-16 15:38:46.000000000","message":"Thank you 🙏","commit_id":"f3756bc60e85f866b63a1f73dfa2281526d1df8a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5afa6c2c9795e21806d31ec7f5625a7cdfb52f3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3183a84e_bdba63f8","updated":"2022-09-30 10:01:20.000000000","message":"We need to move those tests now. Otherwise LGTM","commit_id":"977dd85f28a7f45ee11f4746ec458caab9b4e0ec"}],"doc/source/user/proxies/image_v2.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71a41a6a6bc4ef2a448f1f17f2163787742b17c1","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Metadef Schema Operations"},{"line_number":65,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. autoclass:: openstack.image.v2._proxy.Proxy"},{"line_number":68,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3543586e_18311f66","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":29},"updated":"2022-09-14 17:32:58.000000000","message":"The underlines should be as long as the title itself. Can you drop these last few characters.\n\nAlternatively, these are still schemas. I wonder if we should group them with the \u0027Schema Operations\u0027 section above? What do you think?","commit_id":"01474dd37aebfb2b754c6af620259de3dd302831"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"1edff7d4af5b303cbea9bfceedeafc28460bf309","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Metadef Schema Operations"},{"line_number":65,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. autoclass:: openstack.image.v2._proxy.Proxy"},{"line_number":68,"context_line":"  :noindex:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5d830eee_4948b7ee","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":29},"in_reply_to":"3543586e_18311f66","updated":"2022-09-14 18:48:56.000000000","message":"Yes, I did re-grouping sections and trimmed unnecessary underlines.","commit_id":"01474dd37aebfb2b754c6af620259de3dd302831"}],"doc/source/user/resources/image/index.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f3497383662a156645df1cbafd4224789f21fd88","unresolved":true,"context_lines":[{"line_number":17,"context_line":"   v2/metadef_namespace"},{"line_number":18,"context_line":"   v2/metadef_schema"},{"line_number":19,"context_line":"   v2/task"},{"line_number":20,"context_line":"   v2/service_info"}],"source_content_type":"text/x-rst","patch_set":13,"id":"4b2aa206_0864ac17","line":20,"updated":"2022-09-16 15:38:46.000000000","message":"Somewhat unrelated aside: are we missing docs for the \u0027schema\u0027 module? This would be a good follow-up if so.","commit_id":"f3756bc60e85f866b63a1f73dfa2281526d1df8a"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"fd4b33c26dd25bfa2ff423b38d9cdc8c18c3ae31","unresolved":true,"context_lines":[{"line_number":17,"context_line":"   v2/metadef_namespace"},{"line_number":18,"context_line":"   v2/metadef_schema"},{"line_number":19,"context_line":"   v2/task"},{"line_number":20,"context_line":"   v2/service_info"}],"source_content_type":"text/x-rst","patch_set":13,"id":"8db4c825_6654905a","line":20,"in_reply_to":"4b2aa206_0864ac17","updated":"2022-09-16 16:01:46.000000000","message":"Yes, although I do not add this in this change, it should be added.","commit_id":"f3756bc60e85f866b63a1f73dfa2281526d1df8a"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"1abc22eaa51907ac1a5b35f5b0e447f3c6a9efda","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   v2/metadef_namespace"},{"line_number":18,"context_line":"   v2/metadef_schema"},{"line_number":19,"context_line":"   v2/task"},{"line_number":20,"context_line":"   v2/service_info"}],"source_content_type":"text/x-rst","patch_set":13,"id":"b8e283e9_1e798225","line":20,"in_reply_to":"8db4c825_6654905a","updated":"2022-09-16 16:02:27.000000000","message":"Done","commit_id":"f3756bc60e85f866b63a1f73dfa2281526d1df8a"}],"doc/source/user/resources/image/v2/metadef_schema.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f3497383662a156645df1cbafd4224789f21fd88","unresolved":true,"context_lines":[{"line_number":4,"context_line":".. automodule:: openstack.image.v2.metadef_schema"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The MetadefSchema Class"},{"line_number":7,"context_line":"----------------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``MetadefSchema`` class inherits"},{"line_number":10,"context_line":"from :class:`~openstack.resource.Resource`."}],"source_content_type":"text/x-rst","patch_set":13,"id":"d63049c5_2f62ed5d","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":28},"updated":"2022-09-16 15:38:46.000000000","message":"This is too long","commit_id":"f3756bc60e85f866b63a1f73dfa2281526d1df8a"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"fd4b33c26dd25bfa2ff423b38d9cdc8c18c3ae31","unresolved":true,"context_lines":[{"line_number":4,"context_line":".. automodule:: openstack.image.v2.metadef_schema"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The MetadefSchema Class"},{"line_number":7,"context_line":"----------------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``MetadefSchema`` class inherits"},{"line_number":10,"context_line":"from :class:`~openstack.resource.Resource`."}],"source_content_type":"text/x-rst","patch_set":13,"id":"e3334d66_59b10da3","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":28},"in_reply_to":"d63049c5_2f62ed5d","updated":"2022-09-16 16:01:46.000000000","message":"I trimmed unnecessary underline. Thanks.","commit_id":"f3756bc60e85f866b63a1f73dfa2281526d1df8a"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"1abc22eaa51907ac1a5b35f5b0e447f3c6a9efda","unresolved":false,"context_lines":[{"line_number":4,"context_line":".. automodule:: openstack.image.v2.metadef_schema"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The MetadefSchema Class"},{"line_number":7,"context_line":"----------------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ``MetadefSchema`` class inherits"},{"line_number":10,"context_line":"from :class:`~openstack.resource.Resource`."}],"source_content_type":"text/x-rst","patch_set":13,"id":"4de893dd_961ad808","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":28},"in_reply_to":"e3334d66_59b10da3","updated":"2022-09-16 16:02:27.000000000","message":"Done","commit_id":"f3756bc60e85f866b63a1f73dfa2281526d1df8a"}],"openstack/image/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1843e19a2e7f1fcb802ade648958a604117ac404","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"989f1518_2b655f76","updated":"2022-09-13 11:41:42.000000000","message":"FYI, we\u0027re added support for metadef namespace in [1] and reordered this file in [2]. Can you rebase this onto [2]?\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/854612/\n[2] https://review.opendev.org/c/openstack/openstacksdk/+/856270/","commit_id":"08cda2c5534e0f076e08e164c26ba1591917b776"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"b8bab661d17bdc63a8ca9820da7f5b01569ed6bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a38078d2_aa818fd3","in_reply_to":"989f1518_2b655f76","updated":"2022-09-13 14:22:11.000000000","message":"Yes, I did in patch 3.","commit_id":"08cda2c5534e0f076e08e164c26ba1591917b776"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1843e19a2e7f1fcb802ade648958a604117ac404","unresolved":true,"context_lines":[{"line_number":843,"context_line":"        \"\"\""},{"line_number":844,"context_line":"        return self._get(_si.Import, require_id\u003dFalse)"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    def get_md_namespace_schema(self):"},{"line_number":847,"context_line":"        \"\"\"Get metadata definition namespace schema"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        :returns: One :class:`~openstack.image.v2.md_schema.MDSchema"}],"source_content_type":"text/x-python","patch_set":2,"id":"b3c35ac1_48ee9d85","line":846,"range":{"start_line":846,"start_character":12,"end_line":846,"end_character":14},"updated":"2022-09-13 11:41:42.000000000","message":"Let\u0027s not abbreviate this here. Can you expand this out (here and elsewhere)?\n\n  def get_metadef_namespace_scheme(self):","commit_id":"08cda2c5534e0f076e08e164c26ba1591917b776"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"b8bab661d17bdc63a8ca9820da7f5b01569ed6bb","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        \"\"\""},{"line_number":844,"context_line":"        return self._get(_si.Import, require_id\u003dFalse)"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    def get_md_namespace_schema(self):"},{"line_number":847,"context_line":"        \"\"\"Get metadata definition namespace schema"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        :returns: One :class:`~openstack.image.v2.md_schema.MDSchema"}],"source_content_type":"text/x-python","patch_set":2,"id":"36abb196_38d8def0","line":846,"range":{"start_line":846,"start_character":12,"end_line":846,"end_character":14},"in_reply_to":"b3c35ac1_48ee9d85","updated":"2022-09-13 14:22:11.000000000","message":"Yes, I did in patch 3.","commit_id":"08cda2c5534e0f076e08e164c26ba1591917b776"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"18bd3340bcaf5afeed6c792744b9825d2f7b98b1","unresolved":true,"context_lines":[{"line_number":861,"context_line":"        return self._get(_si.Import, require_id\u003dFalse)"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d METADEF SCHEMAS \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":864,"context_line":"    def get_metadef_namespace_schema(self):"},{"line_number":865,"context_line":"        \"\"\"Get metadata definition namespace schema"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        :returns: One :class:`~openstack.image.v2.metadef_schema.MetadefSchema`"}],"source_content_type":"text/x-python","patch_set":4,"id":"89fb3e75_2afec230","line":864,"updated":"2022-09-13 14:27:14.000000000","message":"super nit: Even though these use a different object, they\u0027re very similar to the other schemas? Can we group them underneath the \u0027SCHEMAS\u0027 section instead?","commit_id":"306d620e432cf150645261476a20d5cad3d29302"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"5517cc039c9c9794e27178e5ae5717415456a230","unresolved":false,"context_lines":[{"line_number":861,"context_line":"        return self._get(_si.Import, require_id\u003dFalse)"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d METADEF SCHEMAS \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":864,"context_line":"    def get_metadef_namespace_schema(self):"},{"line_number":865,"context_line":"        \"\"\"Get metadata definition namespace schema"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        :returns: One :class:`~openstack.image.v2.metadef_schema.MetadefSchema`"}],"source_content_type":"text/x-python","patch_set":4,"id":"f5c9bde3_30fb01ab","line":864,"in_reply_to":"89fb3e75_2afec230","updated":"2022-09-13 15:35:17.000000000","message":"Thank you! Feel free to request anything to be better.","commit_id":"306d620e432cf150645261476a20d5cad3d29302"}],"openstack/image/v2/md_schema.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1843e19a2e7f1fcb802ade648958a604117ac404","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from openstack import resource"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class MDSchema(resource.Resource):"},{"line_number":17,"context_line":"    base_path \u003d \u0027/schemas/metadef\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":2,"id":"17b4b1d2_4ab67635","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":14},"updated":"2022-09-13 11:41:42.000000000","message":"I was going to ask why not reuse \u0027Schema\u0027 from openstack.image.v2.schema, but then I noticed there are additional fields here. However, looking through the other schemas, I notice there are others that we\u0027ve already got support for which have additional fields. For example, the image schema [1]. I wonder if we want to assume what\u0027s in \u0027Schema\u0027 is good enough or create separate \u0027Schema\u0027 resource objects for all schemas?\n\nIf we *do* keep this, can you rename this \u0027MetadefSchema\u0027?\n\n[1] https://docs.openstack.org/api-ref/image/v2/index.html?expanded\u003dshow-image-schema-detail#show-image-schema","commit_id":"08cda2c5534e0f076e08e164c26ba1591917b776"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"7da53eb9c7cc0cca8092803ee97f3014e663a8e4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from openstack import resource"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class MDSchema(resource.Resource):"},{"line_number":17,"context_line":"    base_path \u003d \u0027/schemas/metadef\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":2,"id":"0f0655d7_c61f8ce4","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":14},"in_reply_to":"17b4b1d2_4ab67635","updated":"2022-09-13 12:12:23.000000000","message":"Yes, I\u0027d try to reuse the \u0027Schema\u0027 resource first, but I noticed that the type of \"additionalProperties\" is different between image schema (dict) and meta def schema (bool).\n\nI\u0027ll change the name of the module, class, and methods. (such as \u0027metadef-schema.py\u0027, \u0027MetadefSchema\u0027, \u0027get_metadef_namespace_schema\u0027)","commit_id":"08cda2c5534e0f076e08e164c26ba1591917b776"}],"openstack/image/v2/metadef_schema.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71a41a6a6bc4ef2a448f1f17f2163787742b17c1","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    #: Additional properties"},{"line_number":23,"context_line":"    additional_properties \u003d resource.Body(\u0027additionalProperties\u0027, type\u003dbool)"},{"line_number":24,"context_line":"    #: Definitions properties"},{"line_number":25,"context_line":"    definitions_properties \u003d resource.Body(\u0027definitions\u0027, type\u003ddict)"},{"line_number":26,"context_line":"    #: Required properties"},{"line_number":27,"context_line":"    required_properties \u003d resource.Body(\u0027required\u0027, type\u003dlist)"},{"line_number":28,"context_line":"    #: Schema properties"}],"source_content_type":"text/x-python","patch_set":9,"id":"b650efa4_8c6164d3","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":26},"updated":"2022-09-14 17:32:58.000000000","message":"These aren\u0027t really definition properties. They\u0027re just definitions. Can you rename this to \u0027definitions\u0027?","commit_id":"01474dd37aebfb2b754c6af620259de3dd302831"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"1edff7d4af5b303cbea9bfceedeafc28460bf309","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    #: Additional properties"},{"line_number":23,"context_line":"    additional_properties \u003d resource.Body(\u0027additionalProperties\u0027, type\u003dbool)"},{"line_number":24,"context_line":"    #: Definitions properties"},{"line_number":25,"context_line":"    definitions_properties \u003d resource.Body(\u0027definitions\u0027, type\u003ddict)"},{"line_number":26,"context_line":"    #: Required properties"},{"line_number":27,"context_line":"    required_properties \u003d resource.Body(\u0027required\u0027, type\u003dlist)"},{"line_number":28,"context_line":"    #: Schema properties"}],"source_content_type":"text/x-python","patch_set":9,"id":"0ba98836_252db2f1","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":26},"in_reply_to":"b650efa4_8c6164d3","updated":"2022-09-14 18:48:56.000000000","message":"Thank you! This is my mistake. I changed the name and description.","commit_id":"01474dd37aebfb2b754c6af620259de3dd302831"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71a41a6a6bc4ef2a448f1f17f2163787742b17c1","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    #: Definitions properties"},{"line_number":25,"context_line":"    definitions_properties \u003d resource.Body(\u0027definitions\u0027, type\u003ddict)"},{"line_number":26,"context_line":"    #: Required properties"},{"line_number":27,"context_line":"    required_properties \u003d resource.Body(\u0027required\u0027, type\u003dlist)"},{"line_number":28,"context_line":"    #: Schema properties"},{"line_number":29,"context_line":"    properties \u003d resource.Body(\u0027properties\u0027, type\u003ddict)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c8472f4e_794d410a","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":23},"updated":"2022-09-14 17:32:58.000000000","message":"likewise, can we just call this \u0027required\u0027 ?","commit_id":"01474dd37aebfb2b754c6af620259de3dd302831"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"1edff7d4af5b303cbea9bfceedeafc28460bf309","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    #: Definitions properties"},{"line_number":25,"context_line":"    definitions_properties \u003d resource.Body(\u0027definitions\u0027, type\u003ddict)"},{"line_number":26,"context_line":"    #: Required properties"},{"line_number":27,"context_line":"    required_properties \u003d resource.Body(\u0027required\u0027, type\u003dlist)"},{"line_number":28,"context_line":"    #: Schema properties"},{"line_number":29,"context_line":"    properties \u003d resource.Body(\u0027properties\u0027, type\u003ddict)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baec405e_a7bb8006","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":23},"in_reply_to":"c8472f4e_794d410a","updated":"2022-09-14 18:48:56.000000000","message":"Thank you! This is my mistake. I changed the name and description.","commit_id":"01474dd37aebfb2b754c6af620259de3dd302831"}],"openstack/tests/functional/image/v2/test_image.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5afa6c2c9795e21806d31ec7f5625a7cdfb52f3b","unresolved":true,"context_lines":[{"line_number":123,"context_line":"    def test_get_metadef_tags_schema(self):"},{"line_number":124,"context_line":"        metadef_schema \u003d self.conn.image.get_metadef_tags_schema()"},{"line_number":125,"context_line":"        self.assertIsNotNone(metadef_schema)"},{"line_number":126,"context_line":"        self.assertIsInstance(metadef_schema, _metadef_schema.MetadefSchema)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_list_tasks(self):"},{"line_number":129,"context_line":"        tasks \u003d self.conn.image.tasks()"}],"source_content_type":"text/x-python","patch_set":16,"id":"012a417c_c213d8bb","line":126,"updated":"2022-09-30 10:01:20.000000000","message":"These should all go into a separate file now. I\u0027d suggest\n\n  openstack/tests/functional/image/v2/test_metadef_schema.py","commit_id":"977dd85f28a7f45ee11f4746ec458caab9b4e0ec"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"ae8e42b15277c66da434dca65cdf50d9c35919b4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def test_get_metadef_tags_schema(self):"},{"line_number":124,"context_line":"        metadef_schema \u003d self.conn.image.get_metadef_tags_schema()"},{"line_number":125,"context_line":"        self.assertIsNotNone(metadef_schema)"},{"line_number":126,"context_line":"        self.assertIsInstance(metadef_schema, _metadef_schema.MetadefSchema)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_list_tasks(self):"},{"line_number":129,"context_line":"        tasks \u003d self.conn.image.tasks()"}],"source_content_type":"text/x-python","patch_set":16,"id":"a7283fdc_a0b11bb8","line":126,"in_reply_to":"012a417c_c213d8bb","updated":"2022-10-01 03:24:49.000000000","message":"Yes, I\u0027d separate these another file.","commit_id":"977dd85f28a7f45ee11f4746ec458caab9b4e0ec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5afa6c2c9795e21806d31ec7f5625a7cdfb52f3b","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_list_tasks(self):"},{"line_number":129,"context_line":"        tasks \u003d self.conn.image.tasks()"},{"line_number":130,"context_line":"        self.assertIsNotNone(tasks)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_tags(self):"},{"line_number":133,"context_line":"        # add tag"}],"source_content_type":"text/x-python","patch_set":16,"id":"0f79ce00_ce5e3e33","line":130,"updated":"2022-09-30 10:01:20.000000000","message":"Whoops, this looks like a rebase issue?","commit_id":"977dd85f28a7f45ee11f4746ec458caab9b4e0ec"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"ae8e42b15277c66da434dca65cdf50d9c35919b4","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_list_tasks(self):"},{"line_number":129,"context_line":"        tasks \u003d self.conn.image.tasks()"},{"line_number":130,"context_line":"        self.assertIsNotNone(tasks)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_tags(self):"},{"line_number":133,"context_line":"        # add tag"}],"source_content_type":"text/x-python","patch_set":16,"id":"f71bd32d_7ba4fb9d","line":130,"in_reply_to":"0f79ce00_ce5e3e33","updated":"2022-10-01 03:24:49.000000000","message":"It\u0027s my fault during merge. Thanks🙏","commit_id":"977dd85f28a7f45ee11f4746ec458caab9b4e0ec"}],"openstack/tests/unit/image/v2/test_metadef_schema.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"18bd3340bcaf5afeed6c792744b9825d2f7b98b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"461f014d_5e1e7667","updated":"2022-09-13 14:27:14.000000000","message":"This is great. However, would it be possible to get a functional test to complement the unit tests here? Should be very simple since nothing needs to be created or destroyed.","commit_id":"306d620e432cf150645261476a20d5cad3d29302"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"5517cc039c9c9794e27178e5ae5717415456a230","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"00d62208_36af3c51","in_reply_to":"461f014d_5e1e7667","updated":"2022-09-13 15:35:17.000000000","message":"Yes, I did in patch 5.","commit_id":"306d620e432cf150645261476a20d5cad3d29302"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06ffd998668ac733967edd5cacf1395594094a09","unresolved":true,"context_lines":[{"line_number":119,"context_line":"}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class TestSchema(base.TestCase):"},{"line_number":123,"context_line":"    def test_basic(self):"},{"line_number":124,"context_line":"        sot \u003d metadef_schema.MetadefSchema()"},{"line_number":125,"context_line":"        self.assertIsNone(sot.resource_key)"}],"source_content_type":"text/x-python","patch_set":17,"id":"865949b7_41cf8c37","line":122,"range":{"start_line":122,"start_character":6,"end_line":122,"end_character":16},"updated":"2022-10-03 11:00:12.000000000","message":"TestMetadefSchema","commit_id":"b78d9dc911cefbdc6893987b9d6b7989562f6f9f"},{"author":{"_account_id":34427,"name":"Eunyoung Kim","display_name":"eunyoung","email":"lilac94.kim@gmail.com","username":"lilac94"},"change_message_id":"8be775c534e70584431f9b1f4b55c69a939fadfc","unresolved":false,"context_lines":[{"line_number":119,"context_line":"}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class TestSchema(base.TestCase):"},{"line_number":123,"context_line":"    def test_basic(self):"},{"line_number":124,"context_line":"        sot \u003d metadef_schema.MetadefSchema()"},{"line_number":125,"context_line":"        self.assertIsNone(sot.resource_key)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3ac30e31_771db7e3","line":122,"range":{"start_line":122,"start_character":6,"end_line":122,"end_character":16},"in_reply_to":"865949b7_41cf8c37","updated":"2022-10-03 12:38:47.000000000","message":"I renamed in patch set 18. Thanks!","commit_id":"b78d9dc911cefbdc6893987b9d6b7989562f6f9f"}]}