)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3425142eb879abd325111572142e1ff52d74c667","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafael Castillo \u003crcastill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 04:47:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds shelf offload action to server proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I74979ded4ded26382629611b5990229c9936e247"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"72b2d4c1_fc22aba8","line":7,"updated":"2022-09-29 10:24:48.000000000","message":"shelve, not shelf!","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2830a808dc79640f01c41014f9d0b8009b98c770","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafael Castillo \u003crcastill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 04:47:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds shelf offload action to server proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I74979ded4ded26382629611b5990229c9936e247"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85156a_3d4f605c","line":7,"in_reply_to":"72b2d4c1_fc22aba8","updated":"2023-05-16 10:42:00.000000000","message":"Done","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"361d015ed377bb23421ea46bd17db9091a2b98dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f63b40d8_41fb44ab","updated":"2022-09-28 11:09:16.000000000","message":"One question and one comment inline. Not worth a -1 though. The lack of tests and a release note *are* worth that though 😉 Can you add these?","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2830a808dc79640f01c41014f9d0b8009b98c770","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"94241971_6aee616d","updated":"2023-05-16 10:42:00.000000000","message":"Rebased the patch. This otherwise is good. Nice work here and sorry for the delay getting to it.","commit_id":"6d04b0c3ced433f57a6a44158d975b143c03afc1"}],"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3425142eb879abd325111572142e1ff52d74c667","unresolved":true,"context_lines":[{"line_number":1001,"context_line":"        server \u003d self._get_resource(_server.Server, server)"},{"line_number":1002,"context_line":"        server.shelve(self)"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    def shelf_offload_server(self, server):"},{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."}],"source_content_type":"text/x-python","patch_set":4,"id":"6527e92f_18bcc645","line":1004,"updated":"2022-09-29 10:24:48.000000000","message":"shelve, not shelf!","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c6d4c5c326f9ef5e440b70bc91ca555ed0d4ff36","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        server \u003d self._get_resource(_server.Server, server)"},{"line_number":1002,"context_line":"        server.shelve(self)"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    def shelf_offload_server(self, server):"},{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."}],"source_content_type":"text/x-python","patch_set":4,"id":"07769d2a_fc7eaaf6","line":1004,"in_reply_to":"6527e92f_18bcc645","updated":"2022-11-02 13:19:22.000000000","message":"Thank you!","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"361d015ed377bb23421ea46bd17db9091a2b98dc","unresolved":true,"context_lines":[{"line_number":1004,"context_line":"    def shelf_offload_server(self, server):"},{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        :param server: Either the ID of a server or a"},{"line_number":1010,"context_line":"            :class:`~openstack.compute.v2.server.Server` instance."}],"source_content_type":"text/x-python","patch_set":4,"id":"34a0ff47_ebc7eda9","line":1007,"updated":"2022-09-28 11:09:16.000000000","message":"We should note that on some clouds, shelved servers are automatically offloaded after a certain time period.","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3425142eb879abd325111572142e1ff52d74c667","unresolved":true,"context_lines":[{"line_number":1004,"context_line":"    def shelf_offload_server(self, server):"},{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        :param server: Either the ID of a server or a"},{"line_number":1010,"context_line":"            :class:`~openstack.compute.v2.server.Server` instance."}],"source_content_type":"text/x-python","patch_set":4,"id":"a48aaab5_64bc313c","line":1007,"in_reply_to":"34a0ff47_ebc7eda9","updated":"2022-09-29 10:24:48.000000000","message":"shelved_offload_time\u003d0 is actually Nova\u0027s default [1].\n\n[1] https://opendev.org/openstack/nova/src/commit/aad31e6ba489f720f5bdc765c132fd0f059a0329/nova/conf/compute.py#L1156\n\nWe definitely need some tests to see how shelve_offload behaves with shelved_offload_time\u003d0.","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2830a808dc79640f01c41014f9d0b8009b98c770","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"    def shelf_offload_server(self, server):"},{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        :param server: Either the ID of a server or a"},{"line_number":1010,"context_line":"            :class:`~openstack.compute.v2.server.Server` instance."}],"source_content_type":"text/x-python","patch_set":4,"id":"ce4f5cce_3c7e3a7a","line":1007,"in_reply_to":"5a0cae01_6e4e3088","updated":"2023-05-16 10:42:00.000000000","message":"Done","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7f73b9d486ac6e3f973956add850ba8780fef565","unresolved":true,"context_lines":[{"line_number":1004,"context_line":"    def shelf_offload_server(self, server):"},{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        :param server: Either the ID of a server or a"},{"line_number":1010,"context_line":"            :class:`~openstack.compute.v2.server.Server` instance."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a0cae01_6e4e3088","line":1007,"in_reply_to":"a48aaab5_64bc313c","updated":"2022-11-07 16:27:03.000000000","message":"This still needs to be done","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3425142eb879abd325111572142e1ff52d74c667","unresolved":true,"context_lines":[{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        :param server: Either the ID of a server or a"},{"line_number":1010,"context_line":"            :class:`~openstack.compute.v2.server.Server` instance."},{"line_number":1011,"context_line":"        :returns: None"}],"source_content_type":"text/x-python","patch_set":4,"id":"6de657d8_ffac162d","line":1008,"updated":"2022-09-29 10:24:48.000000000","message":"Please add same warning text as for shelve_server:\n\n  Policy defaults enable only users with\n  administrative role or the owner of the server to perform this\n  operation. Cloud provides could change this permission though.\n\nYou probably want to add the required preconditions as well [1].\n\n[1] https://docs.openstack.org/api-ref/compute/#shelf-offload-remove-server-shelveoffload-action","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2830a808dc79640f01c41014f9d0b8009b98c770","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        :param server: Either the ID of a server or a"},{"line_number":1010,"context_line":"            :class:`~openstack.compute.v2.server.Server` instance."},{"line_number":1011,"context_line":"        :returns: None"}],"source_content_type":"text/x-python","patch_set":4,"id":"0f531285_30394ff7","line":1008,"in_reply_to":"5002d4ee_5afe7f01","updated":"2023-05-16 10:42:00.000000000","message":"Done","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"023cbe6c53174d368346cb5ef0ad8c3b8b217790","unresolved":true,"context_lines":[{"line_number":1005,"context_line":"        \"\"\"Shelf-offloads, or removes, a server"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        Data and resource associations are deleted."},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        :param server: Either the ID of a server or a"},{"line_number":1010,"context_line":"            :class:`~openstack.compute.v2.server.Server` instance."},{"line_number":1011,"context_line":"        :returns: None"}],"source_content_type":"text/x-python","patch_set":4,"id":"5002d4ee_5afe7f01","line":1008,"in_reply_to":"6de657d8_ffac162d","updated":"2022-11-07 16:26:44.000000000","message":"Yes, please do this","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c6d4c5c326f9ef5e440b70bc91ca555ed0d4ff36","unresolved":true,"context_lines":[{"line_number":648,"context_line":"        else:"},{"line_number":649,"context_line":"            self._delete(_server.Server, server, ignore_missing\u003dignore_missing)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def find_server(self, name_or_id, ignore_missing\u003dTrue, *,"},{"line_number":652,"context_line":"                    all_projects\u003dFalse):"},{"line_number":653,"context_line":"        \"\"\"Find a single server"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"044e3003_13b9bd46","line":651,"updated":"2022-11-02 13:19:22.000000000","message":"What is this \u0027*,\u0027 for?","commit_id":"396f6d9916e556bf68ea4c48b8801ab0bfee6dc9"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"fcd0b8b7fdf3d6c91cf76677dfcf59fbe7cca43d","unresolved":true,"context_lines":[{"line_number":648,"context_line":"        else:"},{"line_number":649,"context_line":"            self._delete(_server.Server, server, ignore_missing\u003dignore_missing)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def find_server(self, name_or_id, ignore_missing\u003dTrue, *,"},{"line_number":652,"context_line":"                    all_projects\u003dFalse):"},{"line_number":653,"context_line":"        \"\"\"Find a single server"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"683df58d_9847e2e6","line":651,"in_reply_to":"044e3003_13b9bd46","updated":"2022-11-03 13:24:10.000000000","message":"Indicates that all_projects is a kwarg only argument\n\nhttps://peps.python.org/pep-3102/","commit_id":"396f6d9916e556bf68ea4c48b8801ab0bfee6dc9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"0cb74d6a5d072e1a32bcaf01507c0e9e1d413247","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        else:"},{"line_number":649,"context_line":"            self._delete(_server.Server, server, ignore_missing\u003dignore_missing)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def find_server(self, name_or_id, ignore_missing\u003dTrue, *,"},{"line_number":652,"context_line":"                    all_projects\u003dFalse):"},{"line_number":653,"context_line":"        \"\"\"Find a single server"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c2876928_e1306350","line":651,"in_reply_to":"683df58d_9847e2e6","updated":"2022-11-03 20:22:31.000000000","message":"Interesting! Thanks for the link 😊","commit_id":"396f6d9916e556bf68ea4c48b8801ab0bfee6dc9"}],"openstack/compute/v2/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"361d015ed377bb23421ea46bd17db9091a2b98dc","unresolved":true,"context_lines":[{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    def shelf_offload(self, session):"},{"line_number":482,"context_line":"        body \u003d {\"shelveOffload\": None}"},{"line_number":483,"context_line":"        self._action(session, body)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def unshelve(self, session, availability_zone\u003dNone):"},{"line_number":486,"context_line":"        body \u003d {\"unshelve\": None}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a3fbdb0_24db3297","line":483,"updated":"2022-09-28 11:09:16.000000000","message":"[Thinking out loud] Rather than doing this, I wonder if it would make more sense to add an \u0027offload\u0027 boolean parameter to the \u0027shelve\u0027 method (defaults to False)? I guess they are different things and we don\u0027t do this for e.g. migration...","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2830a808dc79640f01c41014f9d0b8009b98c770","unresolved":false,"context_lines":[{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    def shelf_offload(self, session):"},{"line_number":482,"context_line":"        body \u003d {\"shelveOffload\": None}"},{"line_number":483,"context_line":"        self._action(session, body)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def unshelve(self, session, availability_zone\u003dNone):"},{"line_number":486,"context_line":"        body \u003d {\"unshelve\": None}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9e1a17af_2e633408","line":483,"in_reply_to":"1a3fbdb0_24db3297","updated":"2023-05-16 10:42:00.000000000","message":"Decided not to do this","commit_id":"d34375fbb5476920db9b57102525f3d576bebd82"}]}