)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3e9929cad52eb799333b2060fd0be39ed52e0027","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafael Castillo \u003crcastill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-15 21:47:37 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use /servers/detail endpoint in find_server proxy method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If8306f879361f872a1a87d589c756d9ae2435449"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4bc90d8e_e82f51e2","line":7,"updated":"2022-09-28 11:03:04.000000000","message":"This is a pretty *big* change that will likely affect performance in larger deployments. Could you call out the reason _why_ you\u0027re doing this? You should do so here and in a release note.","commit_id":"49783b7adf8753207907059eaa428addb26e76d0"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"663b37b4fee80c70f4c4e9353ba836b0ecd39707","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafael Castillo \u003crcastill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-15 21:47:37 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use /servers/detail endpoint in find_server proxy method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If8306f879361f872a1a87d589c756d9ae2435449"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a2b3c0c6_7898a239","line":7,"in_reply_to":"4bc90d8e_e82f51e2","updated":"2022-09-29 21:10:11.000000000","message":"I\u0027ve added some rationale to the commit message.\n\nFor some additional context, I ran into this when developing an ansible collections patch. I needed to access the `status` field, which came in when I looked up the server by id but not by name.\n\n[0] https://review.opendev.org/c/openstack/ansible-collections-openstack/+/857976","commit_id":"49783b7adf8753207907059eaa428addb26e76d0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3e9929cad52eb799333b2060fd0be39ed52e0027","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"094d23b9_82d10887","updated":"2022-09-28 11:03:04.000000000","message":"Seems reasonably but I\u0027d like to understand the rationale for this change before we commit to it.","commit_id":"49783b7adf8753207907059eaa428addb26e76d0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b422257584f99772e5cb7b6ca14a78a2e8299951","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b86439b_6d2820d7","updated":"2022-09-30 10:14:25.000000000","message":"Thanks for the additional context. Can you add a release note, please? I\u0027m +2 other than that.","commit_id":"6fa752a4c4df4cb1293b37c7932f0c984ab236d9"}],"openstack/tests/unit/compute/v2/test_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3e9929cad52eb799333b2060fd0be39ed52e0027","unresolved":true,"context_lines":[{"line_number":671,"context_line":"        self.verify_find(self.proxy.find_server, server.Server,"},{"line_number":672,"context_line":"                         expected_kwargs\u003ddict("},{"line_number":673,"context_line":"                             list_base_path\u003d\u0027/servers/detail\u0027))"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def test_server_get(self):"},{"line_number":676,"context_line":"        self.verify_get(self.proxy.get_server, server.Server)"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2459d841_4b2ac30d","line":674,"updated":"2022-09-28 11:03:04.000000000","message":"I know we\u0027re not consistent about this but we should be dropping this down a line [1]. Can you do so?\n\n  self.verify_find(\n    self.proxy.find_server,\n    server.Server,\n    expected_kwargs\u003d{\u0027list_base_path\u0027: \u0027/servers/detail\u0027},\n  )\n\n[1] https://github.com/openstack/openstacksdk/blob/master/HACKING.rst#indentation","commit_id":"49783b7adf8753207907059eaa428addb26e76d0"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"663b37b4fee80c70f4c4e9353ba836b0ecd39707","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        self.verify_find(self.proxy.find_server, server.Server,"},{"line_number":672,"context_line":"                         expected_kwargs\u003ddict("},{"line_number":673,"context_line":"                             list_base_path\u003d\u0027/servers/detail\u0027))"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def test_server_get(self):"},{"line_number":676,"context_line":"        self.verify_get(self.proxy.get_server, server.Server)"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6b43b718_f2e511b8","line":674,"in_reply_to":"2459d841_4b2ac30d","updated":"2022-09-29 21:10:11.000000000","message":"Done","commit_id":"49783b7adf8753207907059eaa428addb26e76d0"}]}