)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"bd5d4b78e7f9e73cbbfa736cc915c121a814be38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"21aafc5d_3f2f3e3d","updated":"2022-09-29 14:19:03.000000000","message":"recheck unclear failures","commit_id":"1d40306799e9be10ebf5dcfc831e694a7950a28b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e64d2d8a67104d95a76b2371894bd8cc41eb3913","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"051df276_15071cff","updated":"2022-11-21 17:42:20.000000000","message":"We can probably do this better, but let\u0027s not let the perfect be the enemy of the good","commit_id":"70dbcfcd66d85875447a29a5abab110af38b6c5b"}],"include-acceptance-regular-user.txt":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af67f6f93fff8b00356dd6c489ce2855b3c3278f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"openstack.tests.functional.block_storage.v3.test_volume"},{"line_number":2,"context_line":"# openstack.tests.functional.block_storage.v3.test_backup"}],"source_content_type":"text/plain","patch_set":3,"id":"e7a7cb53_0dfd3283","line":1,"updated":"2022-09-28 10:54:15.000000000","message":"Could we add a comment about what this list contains? Maybe it would make sense to place it into the \u0027openstack/tests/functional\u0027 directory also?","commit_id":"8e6e7044a223270babb645efd85676f3126df227"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c456eca8a7b74715eaf30d0f71e605c2793bce3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack.tests.functional.block_storage.v3.test_volume"},{"line_number":2,"context_line":"# openstack.tests.functional.block_storage.v3.test_backup"}],"source_content_type":"text/plain","patch_set":3,"id":"6e930832_c90b0e82","line":1,"in_reply_to":"e7a7cb53_0dfd3283","updated":"2022-10-13 13:28:54.000000000","message":"Done","commit_id":"8e6e7044a223270babb645efd85676f3126df227"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c456eca8a7b74715eaf30d0f71e605c2793bce3c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# This file contains list of tests that can work with regular user privileges"},{"line_number":2,"context_line":"# Until all tests are modified to properly identify whether they are able to"},{"line_number":3,"context_line":"# run or must skip the ones that are known to work are whitelisted here."},{"line_number":4,"context_line":"openstack.tests.functional.block_storage.v3.test_volume"},{"line_number":5,"context_line":"# Do not enable test_backup for now, since it is not capable to determine"},{"line_number":6,"context_line":"# backup capabilities of the cloud"}],"source_content_type":"text/plain","patch_set":6,"id":"50bb7b73_aa883b40","line":3,"range":{"start_line":3,"start_character":55,"end_line":3,"end_character":66},"updated":"2022-10-13 13:28:54.000000000","message":"white/black-listing terms are deprecated, in this case just \"... are listed here.\" should be fine","commit_id":"2b5a9d485d813cd5fc25e2db450d12fc205fd09b"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"6c268f3d346e0b7ba3e4d657963927e8db3d58ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This file contains list of tests that can work with regular user privileges"},{"line_number":2,"context_line":"# Until all tests are modified to properly identify whether they are able to"},{"line_number":3,"context_line":"# run or must skip the ones that are known to work are whitelisted here."},{"line_number":4,"context_line":"openstack.tests.functional.block_storage.v3.test_volume"},{"line_number":5,"context_line":"# Do not enable test_backup for now, since it is not capable to determine"},{"line_number":6,"context_line":"# backup capabilities of the cloud"}],"source_content_type":"text/plain","patch_set":6,"id":"2cc248b3_45206018","line":3,"range":{"start_line":3,"start_character":55,"end_line":3,"end_character":66},"in_reply_to":"50bb7b73_aa883b40","updated":"2022-10-19 12:24:16.000000000","message":"Done","commit_id":"2b5a9d485d813cd5fc25e2db450d12fc205fd09b"}],"openstack/tests/functional/block_storage/v3/base.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af67f6f93fff8b00356dd6c489ce2855b3c3278f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    def setUp(self):"},{"line_number":21,"context_line":"        super(BaseBlockStorageTest, self).setUp()"},{"line_number":22,"context_line":"        self._set_user_cloud(block_storage_api_version\u003d\u00273\u0027)"},{"line_number":23,"context_line":"        self._set_operator_cloud(block_storage_api_version\u003d\u00273\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        if not self.user_cloud.has_service(\u0027block-storage\u0027, \u00273\u0027):"},{"line_number":26,"context_line":"            self.skipTest(\u0027block-storage service not supported by cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ccb6acb5_74ff25f5","side":"PARENT","line":23,"updated":"2022-09-28 10:54:15.000000000","message":"Why are we removing this? Unnecessary? I note there are a few related changes. Perhaps you could call it out in the commit message?","commit_id":"30081b1b9f4b54a711b10df2cbcbbfea85f33663"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c456eca8a7b74715eaf30d0f71e605c2793bce3c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def setUp(self):"},{"line_number":21,"context_line":"        super(BaseBlockStorageTest, self).setUp()"},{"line_number":22,"context_line":"        self._set_user_cloud(block_storage_api_version\u003d\u00273\u0027)"},{"line_number":23,"context_line":"        self._set_operator_cloud(block_storage_api_version\u003d\u00273\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        if not self.user_cloud.has_service(\u0027block-storage\u0027, \u00273\u0027):"},{"line_number":26,"context_line":"            self.skipTest(\u0027block-storage service not supported by cloud\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7fc3a221_63d0ba25","side":"PARENT","line":23,"in_reply_to":"ccb6acb5_74ff25f5","updated":"2022-10-13 13:28:54.000000000","message":"This is being moved to openstack/tests/functional/block_storage/v3/test_type.py which IIUC is the only location where the operator cloud is being used in block_storage tests.","commit_id":"30081b1b9f4b54a711b10df2cbcbbfea85f33663"}],"openstack/tests/functional/block_storage/v3/test_backup.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af67f6f93fff8b00356dd6c489ce2855b3c3278f","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        if not self.user_cloud.has_service(\u0027object-store\u0027):"},{"line_number":26,"context_line":"            self.skipTest(\u0027Object service is requred, but not available\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        self.VOLUME_NAME \u003d uuid.uuid4().hex"},{"line_number":29,"context_line":"        self.VOLUME_ID \u003d None"},{"line_number":30,"context_line":"        self.BACKUP_NAME \u003d uuid.uuid4().hex"},{"line_number":31,"context_line":"        self.BACKUP_ID \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1e11914c_b9812d75","line":28,"updated":"2022-09-28 10:54:15.000000000","message":"A comment about why we use this would be helpful","commit_id":"8e6e7044a223270babb645efd85676f3126df227"}],"openstack/tests/functional/block_storage/v3/test_volume.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af67f6f93fff8b00356dd6c489ce2855b3c3278f","unresolved":true,"context_lines":[{"line_number":24,"context_line":"        if not self.user_cloud.has_service(\u0027block-storage\u0027):"},{"line_number":25,"context_line":"            self.skipTest(\u0027block-storage service not supported by cloud\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        volume_name \u003d uuid.uuid4().hex"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.volume \u003d self.user_cloud.block_storage.create_volume("},{"line_number":30,"context_line":"            name\u003dvolume_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c3f13e5_df995800","line":27,"updated":"2022-09-28 10:54:15.000000000","message":"I wonder should we just remove all uses of \u0027getUniqueString\u0027 in a separate PR (or subclass and override it) if it\u0027s causing a few issues like this?","commit_id":"8e6e7044a223270babb645efd85676f3126df227"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"af67f6f93fff8b00356dd6c489ce2855b3c3278f","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    OPENSTACKSDK_OPERATOR_CLOUD\u003d"},{"line_number":54,"context_line":"commands \u003d"},{"line_number":55,"context_line":"    stestr --test-path ./openstack/tests/functional/{env:OPENSTACKSDK_TESTS_SUBDIR:} run --serial {posargs} --include-list include-acceptance-regular-user.txt"},{"line_number":56,"context_line":"    stestr slowest"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"[testenv:pep8]"},{"line_number":59,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"c1d7eff1_0333bbc2","line":56,"updated":"2022-09-28 10:54:15.000000000","message":"Rather than doing this, can\u0027t we skip tests where admin privileges are required by not available? Perhaps that\u0027s the eventual plan and this is a stop gap? If so, we should call that out","commit_id":"8e6e7044a223270babb645efd85676f3126df227"}]}
